* RE: [PATCH v2 1/2] powerpc/mpic: Add Open-PIC global timer document
From: Wang Dongsheng-B40534 @ 2012-08-13 4:10 UTC (permalink / raw)
To: Gala Kumar-B11780
Cc: Wood Scott-B07421, devicetree-discuss@lists.ozlabs.org Discuss,
Paul Mackerras, linuxppc-dev@lists.ozlabs.org list
In-Reply-To: <94D8FBCC-7AA8-4F50-90A3-2A11F579AC34@freescale.com>
>=20
> > a/Documentation/devicetree/bindings/powerpc/fsl/mpic-timer.txt
> > b/Documentation/devicetree/bindings/powerpc/fsl/mpic-timer.txt
> > index df41958..5aafca0 100644
> > --- a/Documentation/devicetree/bindings/powerpc/fsl/mpic-timer.txt
> > +++ b/Documentation/devicetree/bindings/powerpc/fsl/mpic-timer.txt
> > @@ -1,13 +1,14 @@
> > * Freescale MPIC timers
> >
> > Required properties:
> > -- compatible: "fsl,mpic-global-timer"
> > +- compatible: "fsl,global-timer"
>=20
> Why are renaming?.. also use of fsl,global-timer is to generic of a name
> for the this.
>=20
[Wang Dongsheng] "fsl,global-timer" is generic of a name.
^ permalink raw reply
* RE: [PATCH v2 1/2] powerpc/mpic: Add Open-PIC global timer document
From: Wang Dongsheng-B40534 @ 2012-08-13 5:40 UTC (permalink / raw)
To: Wood Scott-B07421
Cc: Li Yang-R58472, devicetree-discuss@lists.ozlabs.org,
paulus@samba.org, Gala Kumar-B11780,
linuxppc-dev@lists.ozlabs.org
In-Reply-To: <50255F49.5050500@freescale.com>
PiA+IGRpZmYgLS1naXQgYS9Eb2N1bWVudGF0aW9uL2RldmljZXRyZWUvYmluZGluZ3Mvb3Blbi1w
aWMudHh0DQo+ID4gYi9Eb2N1bWVudGF0aW9uL2RldmljZXRyZWUvYmluZGluZ3Mvb3Blbi1waWMu
dHh0DQo+ID4gaW5kZXggOTA5YTkwMi4uMDQ1YzJlOSAxMDA2NDQNCj4gPiAtLS0gYS9Eb2N1bWVu
dGF0aW9uL2RldmljZXRyZWUvYmluZGluZ3Mvb3Blbi1waWMudHh0DQo+ID4gKysrIGIvRG9jdW1l
bnRhdGlvbi9kZXZpY2V0cmVlL2JpbmRpbmdzL29wZW4tcGljLnR4dA0KPiA+IEBAIC05Miw2ICs5
Miw1MiBAQCBFeGFtcGxlIDI6DQo+ID4NCj4gPiAgKiBSZWZlcmVuY2VzDQo+ID4NCj4gPiArKiBP
cGVuIFBJQyBnbG9iYWwgdGltZXJzDQo+ID4gKw0KPiA+ICtSZXF1aXJlZCBwcm9wZXJ0aWVzOg0K
PiA+ICstIGNvbXBhdGlibGU6ICJvcGVuLXBpYyxnbG9iYWwtdGltZXIiDQo+IA0KPiBvcGVuLXBp
YyBpc24ndCBhIHZlbmRvciAob3Igc29mdHdhcmUgcHJvamVjdCB0aGF0IGFjdHMgbGlrZSBhDQo+
IHBzZXVkby12ZW5kb3IpIC0tIEknZCBnbyB3aXRoICJvcGVuLXBpYy1nbG9iYWwtdGltZXIiLg0K
PiANCltXYW5nIERvbmdzaGVuZ10geWVzLCAib3Blbi1waWMtZ2xvYmFsLXRpbWVyIiBsb29rcyBn
b29kLg0KDQo+ID4gKy0gcmVnIDogQ29udGFpbnMgdHdvIHJlZ2lvbnMuICBUaGUgZmlyc3QgaXMg
dGhlIHRpbWVyIGZyZXF1ZW5jeQ0KPiA+ICtyZXBvcnRpbmcNCj4gPiArICByZWdpc3RlciBmb3Ig
dGhlIGdyb3VwLiAgVGhlIHNlY29uZCBpcyB0aGUgbWFpbiB0aW1lciByZWdpc3RlciBiYW5rDQo+
ID4gKyAgKEdUQ0NSLCBHVEJDUiwgR1RWUFIsIEdURFIpLg0KPiANCj4gV2h5IG5vdCBqdXN0IHB1
dCBjbG9jay1mcmVxdWVuY3kgaW4gdGhlIG5vZGUsIGluc3RlYWQgb2YgZGVzY3JpYmluZyBURlJS
Pw0KPiBJIGRvbid0IHRoaW5rIFUtQm9vdCBjdXJyZW50bHkgc2V0cyBURlJSLg0KPiANCltXYW5n
IERvbmdzaGVuZ10gSWYgZHVyaW5nIHN0YXJ0dXAgVS1Cb290IGRvIG5vdCBzZXQgVEZSUiB0aGF0
IGlzIHVucmVhc29uYWJsZS4NCkluIE9wZW4tUElDIHRoaXMgaXMgbm90IGFsbG93ZWQuIFdlIHVz
ZWQgaXMgdGhlIENDQiBmcmVxdWVuY3kgaW4gRlNMIGNoaXAuDQpXZSBkbyBub3QgbmVlZCB0byBj
YXJlIGFib3V0IHRoZSB2YWx1ZSBvZiB0aGlzIHJlZ2lzdGVyLiBCdXQgd2UgbXVzdCBzdXBwb3J0
IA0KVEZSUi4NCg0KPiA+ICsJCXJlZyA9IDwweDAxMGYwIDQgMHgwMTEwMCAweDEwMD47DQo+ID4g
Kw0KPiA+ICsJCS8qIEFub3RoZXIgQU1QIHBhcnRpdGlvbiBpcyB1c2luZyB0aW1lciAqLw0KPiA+
ICsJCWF2YWlsYWJsZS1yYW5nZXMgPSA8MiAyPjsNCj4gPg0KPiA+ICsNCj4gPiArCQlpbnRlcnJ1
cHRzID0gPDIgMCAzIDANCj4gPiArCQkgICAgICAgICAgICAgIDMgMCAzIDA+Ow0KPiA+ICsJfTsN
Cj4gPiArDQo+ID4gK0V4YW1wbGUgMjoNCj4gPiArDQo+ID4gKwl0aW1lcjogdGltZXJAMDEwZjAg
ew0KPiA+ICsJCWNvbXBhdGlibGUgPSAib3Blbi1waWMsZ2xvYmFsLXRpbWVyIjsNCj4gPiArCQlk
ZXZpY2VfdHlwZSA9ICJvcGVuLXBpYyI7DQo+ID4gKwkJcmVnID0gPDB4MDEwZjAgNCAweDAxMTAw
IDB4MTAwPjsNCj4gPiArCQlpbnRlcnJ1cHRzID0gPDAgMCAzIDANCj4gPiArCQkJICAgICAgMSAw
IDMgMA0KPiA+ICsJCQkgICAgICAyIDAgMyAwDQo+ID4gKwkJICAgICAgICAgICAgICAzIDAgMyAw
PjsNCj4gPiArCX07DQo+IA0KPiA0LWNlbGwgaW50ZXJydXB0IHNwZWNpZmllcnMgYXJlIHNwZWNp
ZmljIHRvIEZyZWVzY2FsZSBNUElDcy4gIFRoaXMgbWVhbnMNCj4gdGhlcmUncyBubyB3YXkgdG8g
ZGVzY3JpYmUgdGhlIHRpbWVyIGludGVycnVwdCBvbiBhIG5vbi1GcmVlc2NhbGUgb3BlbnBpYy4N
Cj4gQWdhaW4sIEkgc3VnZ2VzdCB3ZSBub3QgYm90aGVyIHdpdGggdGhpcyBpbiB0aGUgYWJzZW5j
ZSBvZiBhbiBhY3R1YWwgbmVlZA0KPiB0byBzdXBwb3J0IHRoZSB0aW1lciBvbiBub24tRnJlZXNj
YWxlIG9wZW5waWMgaW4gcGFydGl0aW9uZWQgc2NlbmFyaW9zLg0KPiBUaGUgZXhpc3Rpbmcgb3Bl
bnBpYyBub2RlIGlzIHN1ZmZpY2llbnQgdG8gZGVzY3JpYmUgdGhlDQo+IGhhcmR3YXJlIGluIHRo
ZSBhYnNlbmNlIG9mIHBhcnRpdGlvbmluZy4gICBXZSBjb3VsZCBoYXZlIGFuDQo+ICJvcGVucGlj
LW5vLXRpbWVyIiBwcm9wZXJ0eSB0byBpbmRpY2F0ZSB0aGF0IHdlJ3JlIGRlc2NyaWJpbmcgaXQN
Cj4gc2VwYXJhdGVseSwgc28gdGhhdCB0aGUgYWJzZW5jZSBvZiBhIHRpbWVyIG5vZGUgaXNuJ3Qg
YW1iaWd1b3VzIGFzIHRvDQo+IHdoZXRoZXIgaXQncyBhbiBvbGQgdHJlZSBvciBhIHBhcnRpdGlv
bmVkIHNjZW5hcmlvLiAgQW4gZnNsLG1waWMNCj4gY29tcGF0aWJsZSB3b3VsZCBpbXBseSBvcGVu
cGljLW5vLXRpbWVyLg0KPiANCj4gTm90ZSB0aGF0IEkgYmVsaWV2ZSBtYW55IG9mIHRoZSBub24t
RnJlZXNjYWxlIG9wZW5waWMgbm9kZXMgYXJlIGdvaW5nIHRvDQo+IGJlIGZvdW5kIG9uIHN5c3Rl
bXMgd2l0aCByZWFsIE9wZW4gRmlybXdhcmUsIHNvIHdlIGNhbid0IGdvIGNoYW5naW5nIHRoZQ0K
PiBkZXZpY2UgdHJlZSBmb3IgdGhlbS4NCltXYW5nIERvbmdzaGVuZ10gSW4gdGhlIE9wZW4tUElD
IHNwZWNpZmljYXRpb24sIHRoZXJlIGFyZSBmb3VyIHRpbWVyLg0KCQlpbnRlcnJ1cHRzID0gPDAg
MCAzIDANCgkJCSAgICAgIDEgMCAzIDANCgkJCSAgICAgIDIgMCAzIDANCgkJICAgICAgICAgICAg
ICAzIDAgMyAwPjsNCg0KVGhlICJpbnRlcnJ1cHRzIiBqdXN0IGxldCB1c2VyIGtub3cgdGhlcmUg
YXJlIGZvdXIgdGltZXJzLiBVc2FnZSBiYXNlZCAiaW50ZXJydXB0cyINCmJpbmRpbmcgdG8gY2hh
bmdlIGR0cy4NCg0KPiANCj4gLVNjb3R0DQoNCg==
^ permalink raw reply
* RE: [PATCH v2 2/2] powerpc/mpic: add global timer support
From: Wang Dongsheng-B40534 @ 2012-08-13 5:53 UTC (permalink / raw)
To: Wood Scott-B07421
Cc: Gala Kumar-B11780, paulus@samba.org,
linuxppc-dev@lists.ozlabs.org, Li Yang-R58472
In-Reply-To: <5025639F.4070203@freescale.com>
DQoNCj4gLS0tLS1PcmlnaW5hbCBNZXNzYWdlLS0tLS0NCj4gRnJvbTogV29vZCBTY290dC1CMDc0
MjENCj4gU2VudDogU2F0dXJkYXksIEF1Z3VzdCAxMSwgMjAxMiAzOjQwIEFNDQo+IFRvOiBXYW5n
IERvbmdzaGVuZy1CNDA1MzQNCj4gQ2M6IGJlbmhAa2VybmVsLmNyYXNoaW5nLm9yZzsgcGF1bHVz
QHNhbWJhLm9yZzsgbGludXhwcGMtDQo+IGRldkBsaXN0cy5vemxhYnMub3JnOyBHYWxhIEt1bWFy
LUIxMTc4MDsgTGkgWWFuZy1SNTg0NzINCj4gU3ViamVjdDogUmU6IFtQQVRDSCB2MiAyLzJdIHBv
d2VycGMvbXBpYzogYWRkIGdsb2JhbCB0aW1lciBzdXBwb3J0DQo+IA0KPiBPbiAwOC8xMC8yMDEy
IDEyOjU0IEFNLCBEb25nc2hlbmcud2FuZ0BmcmVlc2NhbGUuY29tIHdyb3RlOg0KPiA+ICtzdGF0
aWMgY29uc3Qgc3RydWN0IG9mX2RldmljZV9pZCBtcGljX3RpbWVyX2lkc1tdID0gew0KPiA+ICsJ
eyAuY29tcGF0aWJsZSA9ICJvcGVuLXBpYyxnbG9iYWwtdGltZXIiLCB9LA0KPiA+ICsJeyAuY29t
cGF0aWJsZSA9ICJmc2wsZ2xvYmFsLXRpbWVyIiwgfSwNCj4gPiArCXt9LA0KPiA+ICt9Ow0KPiA+
ICsNCj4gPiArc3RhdGljIGludCBfX2luaXQgbXBpY190aW1lcl9pbml0KHZvaWQpIHsNCj4gPiAr
CXN0cnVjdCBkZXZpY2Vfbm9kZSAqbnAgPSBOVUxMOw0KPiA+ICsNCj4gPiArCWZvcl9lYWNoX25v
ZGVfYnlfdHlwZShucCwgIm9wZW4tcGljIikNCj4gPiArCQlpZiAob2ZfbWF0Y2hfbm9kZShtcGlj
X3RpbWVyX2lkcywgbnApKQ0KPiA+ICsJCQlncm91cF9pbml0KG5wKTsNCj4gPiArDQo+ID4gKwlp
ZiAobGlzdF9lbXB0eSgmZ3JvdXBfbGlzdCkpDQo+ID4gKwkJcmV0dXJuIC1FTk9ERVY7DQo+ID4g
Kw0KPiA+ICsJcmV0dXJuIDA7DQo+ID4gK30NCj4gPiArYXJjaF9pbml0Y2FsbChtcGljX3RpbWVy
X2luaXQpOw0KPiANCj4gT2gsIGFuZCBkb24ndCBwcm9iZSBieSBkZXZpY2VfdHlwZS4NCj4gDQpb
V2FuZyBEb25nc2hlbmddIGZpbmUuIGZvcl9lYWNoX25vZGVfYnlfbmFtZS4NCg0KPiAtU2NvdHQN
Cg0K
^ permalink raw reply
* RE: [PATCH v2 2/2] powerpc/mpic: add global timer support
From: Li Yang-R58472 @ 2012-08-13 6:17 UTC (permalink / raw)
To: Wang Dongsheng-B40534, Wood Scott-B07421
Cc: devicetree-discuss@lists.ozlabs.org, Gala Kumar-B11780,
paulus@samba.org, linuxppc-dev@lists.ozlabs.org
In-Reply-To: <ABB05CD9C9F68C46A5CEDC7F15439259DB147E@039-SN2MPN1-022.039d.mgd.msft.net>
DQoNCj4gLS0tLS1PcmlnaW5hbCBNZXNzYWdlLS0tLS0NCj4gRnJvbTogV2FuZyBEb25nc2hlbmct
QjQwNTM0DQo+IFNlbnQ6IE1vbmRheSwgQXVndXN0IDEzLCAyMDEyIDE6NTQgUE0NCj4gVG86IFdv
b2QgU2NvdHQtQjA3NDIxDQo+IENjOiBiZW5oQGtlcm5lbC5jcmFzaGluZy5vcmc7IHBhdWx1c0Bz
YW1iYS5vcmc7IGxpbnV4cHBjLQ0KPiBkZXZAbGlzdHMub3psYWJzLm9yZzsgR2FsYSBLdW1hci1C
MTE3ODA7IExpIFlhbmctUjU4NDcyDQo+IFN1YmplY3Q6IFJFOiBbUEFUQ0ggdjIgMi8yXSBwb3dl
cnBjL21waWM6IGFkZCBnbG9iYWwgdGltZXIgc3VwcG9ydA0KPiANCj4gDQo+IA0KPiA+IC0tLS0t
T3JpZ2luYWwgTWVzc2FnZS0tLS0tDQo+ID4gRnJvbTogV29vZCBTY290dC1CMDc0MjENCj4gPiBT
ZW50OiBTYXR1cmRheSwgQXVndXN0IDExLCAyMDEyIDM6NDAgQU0NCj4gPiBUbzogV2FuZyBEb25n
c2hlbmctQjQwNTM0DQo+ID4gQ2M6IGJlbmhAa2VybmVsLmNyYXNoaW5nLm9yZzsgcGF1bHVzQHNh
bWJhLm9yZzsgbGludXhwcGMtDQo+ID4gZGV2QGxpc3RzLm96bGFicy5vcmc7IEdhbGEgS3VtYXIt
QjExNzgwOyBMaSBZYW5nLVI1ODQ3Mg0KPiA+IFN1YmplY3Q6IFJlOiBbUEFUQ0ggdjIgMi8yXSBw
b3dlcnBjL21waWM6IGFkZCBnbG9iYWwgdGltZXIgc3VwcG9ydA0KPiA+DQo+ID4gT24gMDgvMTAv
MjAxMiAxMjo1NCBBTSwgRG9uZ3NoZW5nLndhbmdAZnJlZXNjYWxlLmNvbSB3cm90ZToNCj4gPiA+
ICtzdGF0aWMgY29uc3Qgc3RydWN0IG9mX2RldmljZV9pZCBtcGljX3RpbWVyX2lkc1tdID0gew0K
PiA+ID4gKwl7IC5jb21wYXRpYmxlID0gIm9wZW4tcGljLGdsb2JhbC10aW1lciIsIH0sDQo+ID4g
PiArCXsgLmNvbXBhdGlibGUgPSAiZnNsLGdsb2JhbC10aW1lciIsIH0sDQo+ID4gPiArCXt9LA0K
PiA+ID4gK307DQo+ID4gPiArDQo+ID4gPiArc3RhdGljIGludCBfX2luaXQgbXBpY190aW1lcl9p
bml0KHZvaWQpIHsNCj4gPiA+ICsJc3RydWN0IGRldmljZV9ub2RlICpucCA9IE5VTEw7DQo+ID4g
PiArDQo+ID4gPiArCWZvcl9lYWNoX25vZGVfYnlfdHlwZShucCwgIm9wZW4tcGljIikNCj4gPiA+
ICsJCWlmIChvZl9tYXRjaF9ub2RlKG1waWNfdGltZXJfaWRzLCBucCkpDQo+ID4gPiArCQkJZ3Jv
dXBfaW5pdChucCk7DQo+ID4gPiArDQo+ID4gPiArCWlmIChsaXN0X2VtcHR5KCZncm91cF9saXN0
KSkNCj4gPiA+ICsJCXJldHVybiAtRU5PREVWOw0KPiA+ID4gKw0KPiA+ID4gKwlyZXR1cm4gMDsN
Cj4gPiA+ICt9DQo+ID4gPiArYXJjaF9pbml0Y2FsbChtcGljX3RpbWVyX2luaXQpOw0KPiA+DQo+
ID4gT2gsIGFuZCBkb24ndCBwcm9iZSBieSBkZXZpY2VfdHlwZS4NCg0KQWN0dWFsbHkgaXQgZG9l
cyBtYXRjaCB0aGUgY29tcGF0aWJsZS4gIFRoZSBkZXZpY2VfdHlwZSBpcyBqdXN0IHRvIHNwZWVk
IHVwIHRoZSBzZWFyY2guICBJIGRvbid0IHRoaW5rIGl0J3MgYSBwcm9ibGVtIHVubGVzcyB0aGUg
ZGV2aWNlIHR5cGUgaXMgbm90IG1hbmRhdG9yeSBhbnkgbW9yZSBmb3IgZGVmaW5lZCB0eXBlcy4N
Cg0KLSBMZW8NCg==
^ permalink raw reply
* RE: [PATCH v2 2/2] powerpc/mpic: add global timer support
From: Wang Dongsheng-B40534 @ 2012-08-13 6:18 UTC (permalink / raw)
To: Wood Scott-B07421
Cc: Gala Kumar-B11780, paulus@samba.org,
linuxppc-dev@lists.ozlabs.org, Li Yang-R58472
In-Reply-To: <50257116.3030207@freescale.com>
DQoNCj4gLS0tLS1PcmlnaW5hbCBNZXNzYWdlLS0tLS0NCj4gRnJvbTogV29vZCBTY290dC1CMDc0
MjENCj4gU2VudDogU2F0dXJkYXksIEF1Z3VzdCAxMSwgMjAxMiA0OjM4IEFNDQo+IFRvOiBXYW5n
IERvbmdzaGVuZy1CNDA1MzQNCj4gQ2M6IGJlbmhAa2VybmVsLmNyYXNoaW5nLm9yZzsgcGF1bHVz
QHNhbWJhLm9yZzsgbGludXhwcGMtDQo+IGRldkBsaXN0cy5vemxhYnMub3JnOyBHYWxhIEt1bWFy
LUIxMTc4MDsgTGkgWWFuZy1SNTg0NzINCj4gU3ViamVjdDogUmU6IFtQQVRDSCB2MiAyLzJdIHBv
d2VycGMvbXBpYzogYWRkIGdsb2JhbCB0aW1lciBzdXBwb3J0DQo+IA0KPiBPbiAwOC8xMC8yMDEy
IDEyOjU0IEFNLCBEb25nc2hlbmcud2FuZ0BmcmVlc2NhbGUuY29tIHdyb3RlOg0KPiA+ICtzdGF0
aWMgaW50IGdyb3VwX2dldF9mcmVxKHN0cnVjdCBncm91cF9wcml2ICpwcml2KSB7DQo+ID4gKwlp
ZiAocHJpdi0+ZmxhZ3MgJiBGU0xfR0xPQkFMX1RJTUVSKSB7DQo+ID4gKwkJY2NiZnJlcSA9IGZz
bF9nZXRfc3lzX2ZyZXEoKTsNCj4gPiArCQlwcml2LT50aW1lcmZyZXEgPSBjY2JmcmVxOw0KPiA+
ICsJfSBlbHNlIHsNCj4gPiArCQlwcml2LT50aW1lcmZyZXEgPSBpbl9iZTMyKHByaXYtPmdyb3Vw
X3RmcnIpOw0KPiA+ICsJfQ0KPiANCj4gRlNMIE1QSUNzIGhhdmUgVEZSUiB0b28uICBJJ20gbm90
IHN1cmUgdGhhdCB0aGUgbGFjayBvZiBmc2wsbXBpYyBpcyBhDQo+IGdvb2QgaW5kaWNhdGlvbiB0
aGF0IFRGUlIgaXMgYmVpbmcgc2V0IChlLmcuIHdlIGhhdmUgb2xkIGRldmljZSB0cmVlcyBmb3IN
Cj4gRlNMIGNoaXBzIHdpdGggVS1Cb290IHRoYXQgYXJlIGxhYmVsbGVkIGFzIG9yZGluYXJ5IG9w
ZW5waWNzKS4NCj4gDQpbV2FuZyBEb25nc2hlbmddIHllcywgd2UgaGF2ZS4gQnV0IHdlIGRvIG5v
dCB1c2VkIGl0LiBUaGUgVEZSUiByZWdpc3RlciB2YWx1ZQ0KaXMgemVyby4gDQoNCj4gPiArDQo+
ID4gKwlpZiAocHJpdi0+dGltZXJmcmVxIDw9IDApDQo+ID4gKwkJcmV0dXJuIC1FSU5WQUw7DQo+
ID4gKw0KPiA+ICsJcmV0dXJuIDA7DQo+ID4gK30NCj4gDQo+IHRpbWVyZnJlcSBpcyB1bnNpZ25l
ZC4gIEl0IGNhbiBuZXZlciBiZSA8IDAuDQo+IA0KW1dhbmcgRG9uZ3NoZW5nXSBZZWFoLiBUaGFu
a3MuDQo+ID4gKw0KPiA+ICtzdGF0aWMgaW50IGdyb3VwX2luaXRfcmVnbWFwKHN0cnVjdCBkZXZp
Y2Vfbm9kZSAqbnAsIHN0cnVjdA0KPiA+ICtncm91cF9wcml2ICpwcml2KSB7DQo+ID4gKwlwcml2
LT5ncm91cF90ZnJyID0gb2ZfaW9tYXAobnAsIDApOw0KPiA+ICsJaWYgKCFwcml2LT5ncm91cF90
ZnJyKSB7DQo+ID4gKwkJcHJfZXJyKCIlczogY2Fubm90IGlvcmVtYXAgdGZyciBhZGRyZXNzLlxu
IiwNCj4gPiArCQkJCW5wLT5mdWxsX25hbWUpOw0KPiA+ICsJCXJldHVybiAtRUlOVkFMOw0KPiA+
ICsJfQ0KPiA+ICsNCj4gPiArCXByaXYtPnJlZ3MgPSBvZl9pb21hcChucCwgMSk7DQo+ID4gKwlp
ZiAoIXByaXYtPnJlZ3MpIHsNCj4gPiArCQlwcl9lcnIoIiVzOiBjYW5ub3QgaW9yZW1hcCB0aW1l
ciByZWdpc3RlciBhZGRyZXNzLlxuIiwNCj4gPiArCQkJCW5wLT5mdWxsX25hbWUpOw0KPiA+ICsJ
CXJldHVybiAtRUlOVkFMOw0KPiA+ICsJfQ0KPiA+ICsNCj4gPiArCWlmICghKHByaXYtPmZsYWdz
ICYgRlNMX0dMT0JBTF9USU1FUikpDQo+ID4gKwkJcmV0dXJuIDA7DQo+ID4gKw0KPiA+ICsJcHJp
di0+Z3JvdXBfdGNyID0gb2ZfaW9tYXAobnAsIDIpOw0KPiA+ICsJaWYgKCFwcml2LT5ncm91cF90
Y3IpIHsNCj4gPiArCQlwcl9lcnIoIiVzOiBjYW5ub3QgaW9yZW1hcCB0Y3IgYWRkcmVzcy5cbiIs
IG5wLT5mdWxsX25hbWUpOw0KPiA+ICsJCXJldHVybiAtRUlOVkFMOw0KPiA+ICsJfQ0KPiANCj4g
VGhpcyBpcyBub3QgY29tcGF0aWJsZSB3aXRoIGV4aXN0aW5nIG1waWMgdGltZXIgbm9kZXMuDQo+
IA0KW1dhbmcgRG9uZ3NoZW5nXSBZZWFoLCBuZXh0IHBhdGNoIHRvIHN1cHBvcnQgdGhhdC4NCg0K
PiA+ICsJcCA9IG9mX2dldF9wcm9wZXJ0eShucCwgImF2YWlsYWJsZS1yYW5nZXMiLCAmbGVuKTsN
Cj4gPiArCWlmIChwICYmIGxlbiAlICgyICogc2l6ZW9mKHUzMikpICE9IDApIHsNCj4gPiArCQlw
cl9lcnIoIiVzOiBtYWxmb3JtZWQgZnNsLGF2YWlsYWJsZS1yYW5nZXMgcHJvcGVydHkuXG4iLA0K
PiA+ICsJCQkJbnAtPmZ1bGxfbmFtZSk7DQo+ID4gKwkJcmV0dXJuIC1FSU5WQUw7DQo+ID4gKwl9
DQo+IA0KPiBZb3UgbmVlZCB0byBzdXBwb3J0IGZzbCxhdmFpbGFibGUtcmFuZ2VzIHNpbmNlIHRo
YXQncyBpbiBhbiBhY2NlcHRlZA0KPiBiaW5kaW5nIGFuZCBwZW9wbGUgY291bGQgaGF2ZSBwYXJ0
aXRpb25lZCBzZXR1cHMgYWxyZWFkeSB1c2luZyBpdC4NCj4gDQpbV2FuZyBEb25nc2hlbmddIEZT
TCBjaGlwIG9yIE9QRU4tUElDIHNwZWNpZmljYXRpb24oT25seSBhIGdyb3VwKQ0KaW4gZWFjaCBn
cm91cCBvbmx5IGZvdXIgdGltZXIuIFRoaXMgaXMgdW5pZmllZC4gU28gaSB1c2UgYSBnZW5lcmlj
IG5hbWUuDQpJIHRoaW5rIHRoZXJlIGlzIG5vdCBjb21wYXRpYmxlIHdpdGggZXhpc3RpbmcgbXBp
YyB0aW1lciBub2Rlcy4NCg0KCXAgPSBvZl9nZXRfcHJvcGVydHkobnAsICJhdmFpbGFibGUtcmFu
Z2VzIiwgJmxlbik7DQoJaWYgKCFwKQ0KCQlwID0gb2ZfZ2V0X3Byb3BlcnR5KG5wLCAiZnNsLGF2
YWlsYWJsZS1yYW5nZXMiLCAmbGVuKTsNCg0KCWlmIChwICYmIGxlbiAlICgyICogc2l6ZW9mKHUz
MikpICE9IDApIHsNCgkJcHJfZXJyKCIlczogbWFsZm9ybWVkIGZzbCxhdmFpbGFibGUtcmFuZ2Vz
IHByb3BlcnR5LlxuIiwNCgkJCQlucC0+ZnVsbF9uYW1lKTsNCgkJcmV0dXJuIC1FSU5WQUw7DQoJ
fQ0KDQo+IFlvdSBhbHNvIGhhdmUgYSBtaXNtYXRjaCBiZXR3ZWVuIHRoZSBwcm9wZXJ0eSB5b3Ug
Y2hlY2sgYW5kIHRoZSBlcnJvcg0KPiBzdHJpbmcuDQo+IA0KW1dhbmcgRG9uZ3NoZW5nXSBZZWFo
LiA6LSguDQoNCj4gLVNjb3R0DQoNCg==
^ permalink raw reply
* RE: [PATCH v2 2/2] powerpc/mpic: add global timer support
From: Wang Dongsheng-B40534 @ 2012-08-13 6:20 UTC (permalink / raw)
To: Tabi Timur-B04825
Cc: Gala Kumar-B11780, paulus@samba.org,
linuxppc-dev@lists.ozlabs.org, Wood Scott-B07421
In-Reply-To: <CAOZdJXWmLgRM9t6Cus=5kfOwjmAFSg+hjNXyd1cR7GtJ8k0Qew@mail.gmail.com>
> -----Original Message-----
> From: Tabi Timur-B04825
> Sent: Saturday, August 11, 2012 9:10 PM
> To: Wang Dongsheng-B40534
> Cc: benh@kernel.crashing.org; paulus@samba.org; Wood Scott-B07421; Gala
> Kumar-B11780; linuxppc-dev@lists.ozlabs.org
> Subject: Re: [PATCH v2 2/2] powerpc/mpic: add global timer support
>=20
> On Fri, Aug 10, 2012 at 12:54 AM, <Dongsheng.wang@freescale.com> wrote:
> > From: Wang Dongsheng <Dongsheng.Wang@freescale.com>
>=20
> > +EXPORT_SYMBOL_GPL(mpic_request_timer);
>=20
> Make these EXPORT_SYMBOL. No need for a GPL restriction.
>=20
[Wang Dongsheng] Why?
> --
> Timur Tabi
> Linux kernel developer at Freescale
^ permalink raw reply
* RE: [PATCH v2 2/2] powerpc/mpic: add global timer support
From: Wang Dongsheng-B40534 @ 2012-08-13 6:25 UTC (permalink / raw)
To: Wang Dongsheng-B40534, Tabi Timur-B04825
Cc: linuxppc-dev@lists.ozlabs.org, Gala Kumar-B11780,
paulus@samba.org, Wood Scott-B07421
In-Reply-To: <ABB05CD9C9F68C46A5CEDC7F15439259DB14DD@039-SN2MPN1-022.039d.mgd.msft.net>
> -----Original Message-----
> From: Linuxppc-dev [mailto:linuxppc-dev-
> bounces+b40534=3Dfreescale.com@lists.ozlabs.org] On Behalf Of Wang
> Dongsheng-B40534
> Sent: Monday, August 13, 2012 2:21 PM
> To: Tabi Timur-B04825
> Cc: Gala Kumar-B11780; paulus@samba.org; linuxppc-dev@lists.ozlabs.org;
> Wood Scott-B07421
> Subject: RE: [PATCH v2 2/2] powerpc/mpic: add global timer support
>=20
>=20
>=20
> > -----Original Message-----
> > From: Tabi Timur-B04825
> > Sent: Saturday, August 11, 2012 9:10 PM
> > To: Wang Dongsheng-B40534
> > Cc: benh@kernel.crashing.org; paulus@samba.org; Wood Scott-B07421;
> > Gala Kumar-B11780; linuxppc-dev@lists.ozlabs.org
> > Subject: Re: [PATCH v2 2/2] powerpc/mpic: add global timer support
> >
> > On Fri, Aug 10, 2012 at 12:54 AM, <Dongsheng.wang@freescale.com> wrote=
:
> > > From: Wang Dongsheng <Dongsheng.Wang@freescale.com>
> >
> > > +EXPORT_SYMBOL_GPL(mpic_request_timer);
> >
> > Make these EXPORT_SYMBOL. No need for a GPL restriction.
> >
> [Wang Dongsheng] Why?
[Wang Dongsheng] Sorry, I just see the mail. Thanks.
> > --
> > Timur Tabi
> > Linux kernel developer at Freescale
>=20
> _______________________________________________
> Linuxppc-dev mailing list
> Linuxppc-dev@lists.ozlabs.org
> https://lists.ozlabs.org/listinfo/linuxppc-dev
^ permalink raw reply
* Re: [PATCH v3 0/7] mv643xx.c: Add basic device tree support.
From: Ian Molton @ 2012-08-13 10:00 UTC (permalink / raw)
To: Arnd Bergmann
Cc: thomas.petazzoni, andrew, netdev, devicetree-discuss, ben.dooks,
linuxppc-dev, David Miller, linux-arm-kernel
In-Reply-To: <201208101049.57586.arnd@arndb.de>
On 10/08/12 11:49, Arnd Bergmann wrote:
> On Thursday 09 August 2012, Ian Molton wrote:
>>> The driver
>>> already knows all those offsets and they are always the same
>>> for all variants of mv643xx, right?
>> Yes, but its not clean. And no amount of refactoring is
>> really going to make a nice driver that also fits the ancient
>> (and badly thought out) OF bindings.
> In what way is it badly though out, or not clean? The use of
> underscores in the properties, and the way that the sram
> is configured is problematic, I agree. But The way that
> the three ports are addressed and how the PHY is found
> seems quite clever.
It forces one to load the MDIO driver first, because it maps ALL the
registers for both itself and all the ports, and the MDIO driver has no
way of knowing how many ethernet blocks are present (I have a device
here with two, and another with four). Thats anywhere from 1 to 12
ports, split across 1 to 4 address ranges, and theres a big gap in the
address range between controllers 0,1 and 2,3. *ALL* the devices on the
board are sharing ethernet block 0's MDIO bus. By pure luck it happens
to work, because the blocks 2,3 have an alias of the MDIO registers from
blocks 0,1.
Having the MDIO driver map the ethernet drivers memory is a terrible
solution, IMO. Ethernet drivers should map their own memory, and that
introduces the n-ports-per-block problem, because their address ranges
overlap.
I think the best solution is to make each ethernet block register 3 ports.
the PPC code can simply generate different fixups so that instead of
creating 3 devices, it creates one, with three ports.
>> If we have to break things, we can at least go for a nice
>> clean design, surely?
>>
>> The ports arent really child devices of the MAC. The MAC
>> just has 3 ports.
> I don't see the difference between those two things.
The ports are at best 'pseudodevices'. Real devices have registers of
their own.
>> We're going to have to maintain a legacy
>> platform_device -> DT bindings hack somewhere anyway,
>> at least until the remaining other users of the driver
>> convert to D-T.
> I don't understand why you describe the method used in
> powerpc as a hack. It was the normal way to introduce
> DT support for platform devices back when it was implemented.
Just because its normal doesn't mean its not a hack :)
> It also had the advantage of not requiring any modifications
> to the generic driver, because it was shared between one
> architecture using DT (powerpc) and one that didn't (ARM).
It /did/ spawn a pretty hideous driver, though...
-Ian
^ permalink raw reply
* Re: [PATCH v2 4/6] x86: Add clear_page_nocache
From: Kirill A. Shutemov @ 2012-08-13 11:43 UTC (permalink / raw)
To: Jan Beulich
Cc: Andrea Arcangeli, linux-mips, Andi Kleen, H. Peter Anvin,
Alex Shi, Robert Richter, linuxppc-dev, x86, Hugh Dickins,
linux-kernel, Andy Lutomirski, linux-mm, linux-sh, Ingo Molnar,
Mel Gorman, Johannes Weiner, sparclinux, Thomas Gleixner,
Tim Chen, Andrew Morton, KAMEZAWA Hiroyuki
In-Reply-To: <5023F1BC0200007800093EF0@nat28.tlf.novell.com>
[-- Attachment #1: Type: text/plain, Size: 7861 bytes --]
On Thu, Aug 09, 2012 at 04:22:04PM +0100, Jan Beulich wrote:
> >>> On 09.08.12 at 17:03, "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com> wrote:
...
> > ---
> > arch/x86/include/asm/page.h | 2 ++
> > arch/x86/include/asm/string_32.h | 5 +++++
> > arch/x86/include/asm/string_64.h | 5 +++++
> > arch/x86/lib/Makefile | 1 +
> > arch/x86/lib/clear_page_nocache_32.S | 30 ++++++++++++++++++++++++++++++
> > arch/x86/lib/clear_page_nocache_64.S | 29 +++++++++++++++++++++++++++++
>
> Couldn't this more reasonably go into clear_page_{32,64}.S?
We don't have clear_page_32.S.
> >+ xorl %eax,%eax
> >+ movl $4096/64,%ecx
> >+ .p2align 4
> >+.Lloop:
> >+ decl %ecx
> >+#define PUT(x) movnti %eax,x*8(%edi) ; movnti %eax,x*8+4(%edi)
>
> Is doing twice as much unrolling as on 64-bit really worth it?
Moving 64 bytes per cycle is faster on Sandy Bridge, but slower on
Westmere. Any preference? ;)
Westmere:
Performance counter stats for './test_unroll32' (20 runs):
31498.420608 task-clock # 0.998 CPUs utilized ( +- 0.25% )
40 context-switches # 0.001 K/sec ( +- 1.40% )
0 CPU-migrations # 0.000 K/sec ( +-100.00% )
89 page-faults # 0.003 K/sec ( +- 0.13% )
74,728,231,935 cycles # 2.372 GHz ( +- 0.25% ) [83.34%]
53,789,969,009 stalled-cycles-frontend # 71.98% frontend cycles idle ( +- 0.35% ) [83.33%]
41,681,014,054 stalled-cycles-backend # 55.78% backend cycles idle ( +- 0.43% ) [66.67%]
37,992,733,278 instructions # 0.51 insns per cycle
# 1.42 stalled cycles per insn ( +- 0.05% ) [83.33%]
3,561,376,245 branches # 113.065 M/sec ( +- 0.05% ) [83.33%]
27,182,795 branch-misses # 0.76% of all branches ( +- 0.06% ) [83.33%]
31.558545812 seconds time elapsed ( +- 0.25% )
Performance counter stats for './test_unroll64' (20 runs):
31564.753623 task-clock # 0.998 CPUs utilized ( +- 0.19% )
39 context-switches # 0.001 K/sec ( +- 0.40% )
0 CPU-migrations # 0.000 K/sec
90 page-faults # 0.003 K/sec ( +- 0.12% )
74,886,045,192 cycles # 2.372 GHz ( +- 0.19% ) [83.33%]
57,477,323,995 stalled-cycles-frontend # 76.75% frontend cycles idle ( +- 0.26% ) [83.34%]
44,548,142,150 stalled-cycles-backend # 59.49% backend cycles idle ( +- 0.31% ) [66.67%]
32,940,027,099 instructions # 0.44 insns per cycle
# 1.74 stalled cycles per insn ( +- 0.05% ) [83.34%]
1,884,944,093 branches # 59.717 M/sec ( +- 0.05% ) [83.32%]
1,027,135 branch-misses # 0.05% of all branches ( +- 0.56% ) [83.34%]
31.621001407 seconds time elapsed ( +- 0.19% )
Sandy Bridge:
Performance counter stats for './test_unroll32' (20 runs):
8578.382891 task-clock # 0.997 CPUs utilized ( +- 0.08% )
15 context-switches # 0.000 M/sec ( +- 2.97% )
0 CPU-migrations # 0.000 M/sec
84 page-faults # 0.000 M/sec ( +- 0.13% )
29,154,476,597 cycles # 3.399 GHz ( +- 0.08% ) [83.33%]
11,851,215,147 stalled-cycles-frontend # 40.65% frontend cycles idle ( +- 0.20% ) [83.33%]
1,530,172,593 stalled-cycles-backend # 5.25% backend cycles idle ( +- 1.44% ) [66.67%]
37,915,778,094 instructions # 1.30 insns per cycle
# 0.31 stalled cycles per insn ( +- 0.00% ) [83.34%]
3,590,533,447 branches # 418.556 M/sec ( +- 0.01% ) [83.35%]
26,500,765 branch-misses # 0.74% of all branches ( +- 0.01% ) [83.34%]
8.604638449 seconds time elapsed ( +- 0.08% )
Performance counter stats for './test_unroll64' (20 runs):
8463.789963 task-clock # 0.997 CPUs utilized ( +- 0.07% )
14 context-switches # 0.000 M/sec ( +- 1.70% )
0 CPU-migrations # 0.000 M/sec ( +-100.00% )
85 page-faults # 0.000 M/sec ( +- 0.12% )
28,763,328,688 cycles # 3.398 GHz ( +- 0.07% ) [83.32%]
13,517,462,952 stalled-cycles-frontend # 47.00% frontend cycles idle ( +- 0.14% ) [83.33%]
1,356,208,859 stalled-cycles-backend # 4.72% backend cycles idle ( +- 1.42% ) [66.68%]
32,885,492,141 instructions # 1.14 insns per cycle
# 0.41 stalled cycles per insn ( +- 0.00% ) [83.34%]
1,912,094,072 branches # 225.915 M/sec ( +- 0.02% ) [83.34%]
305,896 branch-misses # 0.02% of all branches ( +- 1.05% ) [83.33%]
8.488304839 seconds time elapsed ( +- 0.07% )
$ cat test.c
#include <stdio.h>
#include <sys/mman.h>
#define SIZE 1024*1024*1024
void clear_page_nocache_sse2(void *page) __attribute__((regparm(1)));
int main(int argc, char** argv)
{
char *p;
unsigned long i, j;
p = mmap(NULL, SIZE, PROT_WRITE|PROT_READ,
MAP_PRIVATE|MAP_ANONYMOUS|MAP_POPULATE, -1, 0);
for(j = 0; j < 100; j++) {
for(i = 0; i < SIZE; i += 4096) {
clear_page_nocache_sse2(p + i);
}
}
return 0;
}
$ cat clear_page_nocache_unroll32.S
.globl clear_page_nocache_sse2
.align 4,0x90
clear_page_nocache_sse2:
.cfi_startproc
mov %eax,%edx
xorl %eax,%eax
movl $4096/32,%ecx
.p2align 4
.Lloop_sse2:
decl %ecx
#define PUT(x) movnti %eax,x*4(%edx)
PUT(0)
PUT(1)
PUT(2)
PUT(3)
PUT(4)
PUT(5)
PUT(6)
PUT(7)
#undef PUT
lea 32(%edx),%edx
jnz .Lloop_sse2
nop
ret
.cfi_endproc
.type clear_page_nocache_sse2, @function
.size clear_page_nocache_sse2, .-clear_page_nocache_sse2
$ cat clear_page_nocache_unroll64.S
.globl clear_page_nocache_sse2
.align 4,0x90
clear_page_nocache_sse2:
.cfi_startproc
mov %eax,%edx
xorl %eax,%eax
movl $4096/64,%ecx
.p2align 4
.Lloop_sse2:
decl %ecx
#define PUT(x) movnti %eax,x*8(%edx) ; movnti %eax,x*8+4(%edx)
PUT(0)
PUT(1)
PUT(2)
PUT(3)
PUT(4)
PUT(5)
PUT(6)
PUT(7)
#undef PUT
lea 64(%edx),%edx
jnz .Lloop_sse2
nop
ret
.cfi_endproc
.type clear_page_nocache_sse2, @function
.size clear_page_nocache_sse2, .-clear_page_nocache_sse2
--
Kirill A. Shutemov
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
^ permalink raw reply
* Re: [PATCH v2 4/6] x86: Add clear_page_nocache
From: Jan Beulich @ 2012-08-13 12:02 UTC (permalink / raw)
To: Kirill A. Shutemov
Cc: Andrea Arcangeli, linux-mips, Andi Kleen, H. Peter Anvin,
Alex Shi, Robert Richter, linuxppc-dev, x86, Hugh Dickins,
linux-kernel, Andy Lutomirski, linux-mm, linux-sh, Ingo Molnar,
Mel Gorman, Johannes Weiner, sparclinux, Thomas Gleixner,
Tim Chen, Andrew Morton, KAMEZAWA Hiroyuki
In-Reply-To: <20120813114334.GA21855@otc-wbsnb-06>
>>> On 13.08.12 at 13:43, "Kirill A. Shutemov" <kirill.shutemov@linux.intel=
.com> wrote:
> On Thu, Aug 09, 2012 at 04:22:04PM +0100, Jan Beulich wrote:
>> >>> On 09.08.12 at 17:03, "Kirill A. Shutemov" <kirill.shutemov@linux.in=
tel.com> wrote:
>=20
> ...
>=20
>> > ---
>> > arch/x86/include/asm/page.h | 2 ++
>> > arch/x86/include/asm/string_32.h | 5 +++++
>> > arch/x86/include/asm/string_64.h | 5 +++++
>> > arch/x86/lib/Makefile | 1 +
>> > arch/x86/lib/clear_page_nocache_32.S | 30 +++++++++++++++++++++++++=
+++++
>> > arch/x86/lib/clear_page_nocache_64.S | 29 +++++++++++++++++++++++++=
++++
>>=20
>> Couldn't this more reasonably go into clear_page_{32,64}.S?
>=20
> We don't have clear_page_32.S.
Sure, but you're introducing a file anyway. Fold the new code into
the existing file for 64-bit, and create a new, similarly named one
for 32-bit.
>> >+ xorl %eax,%eax
>> >+ movl $4096/64,%ecx
>> >+ .p2align 4
>> >+.Lloop:
>> >+ decl %ecx
>> >+#define PUT(x) movnti %eax,x*8(%edi) ; movnti %eax,x*8+4(%edi)
>>=20
>> Is doing twice as much unrolling as on 64-bit really worth it?
>=20
> Moving 64 bytes per cycle is faster on Sandy Bridge, but slower on
> Westmere. Any preference? ;)
If it's not a clear win, I'd favor the 8-stores-per-cycle variant,
matching x86-64.
Jan
^ permalink raw reply
* [PATCH] [RESEND] powerpc: fix personality handling in ppc64_personality()
From: Jiri Kosina @ 2012-08-13 13:18 UTC (permalink / raw)
To: Benjamin Herrenschmidt, Paul Mackerras, linuxppc-dev,
linux-kernel, Andreas Schwab
Directly comparing current->personality against PER_LINUX32 doesn't work
in cases when any of the personality flags stored in the top three bytes
are used.
Directly forcefully setting personality to PER_LINUX32 or PER_LINUX
discards any flags stored in the top three bytes
Use personality() macro to compare only PER_MASK bytes and make sure that
we are setting only the bits that should be set, instead of overwriting
the whole value.
Signed-off-by: Jiri Kosina <jkosina@suse.cz>
---
Resned of patch sent on Thu, 2 Aug 2012 09:10:03 +0200 (CEST)
arch/powerpc/kernel/syscalls.c | 8 ++++----
1 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/arch/powerpc/kernel/syscalls.c b/arch/powerpc/kernel/syscalls.c
index f2496f2..dc1558e 100644
--- a/arch/powerpc/kernel/syscalls.c
+++ b/arch/powerpc/kernel/syscalls.c
@@ -107,11 +107,11 @@ long ppc64_personality(unsigned long personality)
long ret;
if (personality(current->personality) == PER_LINUX32
- && personality == PER_LINUX)
- personality = PER_LINUX32;
+ && personality(personality) == PER_LINUX)
+ personality = (personality & ~PER_MASK) | PER_LINUX32;
ret = sys_personality(personality);
- if (ret == PER_LINUX32)
- ret = PER_LINUX;
+ if (personality(ret) == PER_LINUX32)
+ ret = (ret & ~PER_MASK) | PER_LINUX;
return ret;
}
#endif
--
Jiri Kosina
SUSE Labs
^ permalink raw reply related
* Re: [PATCH V2 3/3] drivers/char/tpm: Add securityfs support for event log
From: Ashley Lai @ 2012-08-13 16:15 UTC (permalink / raw)
To: Michael Ellerman
Cc: key, linux-kernel, linux-security-module, tpmdd-devel, adlai, rcj,
linuxppc-dev
In-Reply-To: <1344583401.27290.15.camel@concordia>
Thank you so much for reviewing the code. Please see my reply below.
On Fri, 2012-08-10 at 17:23 +1000, Michael Ellerman wrote:
> On Thu, 2012-08-09 at 18:13 -0500, Ashley Lai wrote:
> > This patch retrieves the event log data from the device tree
> > during file open. The event log data will then displayed through
> > securityfs.
>
> Hi Ashley,
>
> Comments inline ..
>
> > diff --git a/drivers/char/tpm/Makefile b/drivers/char/tpm/Makefile
> > index 547509d..b53da57 100644
> > --- a/drivers/char/tpm/Makefile
> > +++ b/drivers/char/tpm/Makefile
> > @@ -2,9 +2,15 @@
> > # Makefile for the kernel tpm device drivers.
> > #
> > obj-$(CONFIG_TCG_TPM) += tpm.o
> > +obj-$(CONFIG_TCG_TPM) += tpm_bios.o
> > ifdef CONFIG_ACPI
> > - obj-$(CONFIG_TCG_TPM) += tpm_bios.o
> > tpm_bios-objs += tpm_eventlog.o tpm_acpi.o
> > +else
> > +ifdef CONFIG_TCG_IBMVTPM
> > + tpm_bios-objs += tpm_eventlog.o tpm_of.o
> > +else
> > + tpm_bios-objs += tpm_eventlog.o tpm_noeventlog.o
>
> What does it mean to build tpm_eventlog and tpm_noeventlog ?
This is the case where the event log is not available. I agree it does not
look clean. I'm thinking of moving tpm_noeventlog into header file to
eliminate this file.
>
>
>
> > diff --git a/drivers/char/tpm/tpm_eventlog.h b/drivers/char/tpm/tpm_eventlog.h
> > index 8e23ccd..21ac6af 100644
> > --- a/drivers/char/tpm/tpm_eventlog.h
> > +++ b/drivers/char/tpm/tpm_eventlog.h
> > @@ -68,4 +68,18 @@ enum tcpa_pc_event_ids {
> > };
> >
> > int read_log(struct tpm_bios_log *log);
> > +
> > +extern struct dentry **tpm_bios_log_setup(char *);
> > +extern void tpm_bios_log_teardown(struct dentry **);
> > +
> > +#ifdef CONFIG_PPC64
> > +#define TPM_NO_EVENT_LOG !of_find_node_by_name(NULL, "ibm,vtpm")
> > +#else
> > +#ifdef CONFIG_ACPI
> > +#define TPM_NO_EVENT_LOG 0
> > +#else
> > +#define TPM_NO_EVENT_LOG 1
> > +#endif
> > +#endif
>
> This should be a static inline, with the ifdefs inside.
I just realized that it does not need to call of_find_node_by_name()
here because if ibm,vtpm is not there it does not go to probe. Thanks
for pointing this out.
>
> How often is this called? of_find_node_by_name() is not particularly
> efficient. It might be better to search once and save a flag indicating
> whether you found it.
This is called during load and unload of the driver. I'll remove the call to
of_find_node_by_name() in next version. See above.
>
> Also you must call of_node_put() on the result of
> of_find_node_by_name(), so at the least you must do:
Nice catch!!! I will fix other places in the code in the next
version.
>
> struct device_node *np;
> np = of_find_node_by_name(NULL, "ibm,vtpm");
> of_node_put(np);
> return (np != NULL);
>
> > #endif
> > diff --git a/drivers/char/tpm/tpm_noeventlog.c b/drivers/char/tpm/tpm_noeventlog.c
> > new file mode 100644
> > index 0000000..f30a2bf
> > --- /dev/null
> > +++ b/drivers/char/tpm/tpm_noeventlog.c
> > @@ -0,0 +1,21 @@
> > +/*
> > + * Copyright (C) 2012 IBM Corporation
> ^^
> Don't use (C)
Will remove it.
>
> > + *
> > + * Author: Ashley Lai <adlai@us.ibm.com>
> > + *
> > + * Maintained by: <tpmdd-devel@lists.sourceforge.net>
> > + *
> > + * This program is free software; you can redistribute it and/or
> > + * modify it under the terms of the GNU General Public License
> > + * as published by the Free Software Foundation; either version
> > + * 2 of the License, or (at your option) any later version.
> > + *
> > + */
> > +
> > +#include <linux/slab.h>
> > +#include "tpm_eventlog.h"
> > +
> > +int read_log(struct tpm_bios_log *log)
> > +{
> > + return -EINVAL;
> > +}
>
> Wouldn't it be simpler to put this in a header with the appropriate
> ifdefs, and then you'd need less logic in the Makefile?
Will move this to header file. Thanks.
>
>
> > diff --git a/drivers/char/tpm/tpm_of.c b/drivers/char/tpm/tpm_of.c
> > new file mode 100644
> > index 0000000..6d44adb
> > --- /dev/null
> > +++ b/drivers/char/tpm/tpm_of.c
> > @@ -0,0 +1,68 @@
> > +/*
> > + * Copyright 2012 IBM Corporation
> > + *
> > + * Author: Ashley Lai <adlai@us.ibm.com>
> > + *
> > + * Maintained by: <tpmdd-devel@lists.sourceforge.net>
> > + *
> > + * Read the event log created by the firmware on PPC64
> > + *
> > + * This program is free software; you can redistribute it and/or
> > + * modify it under the terms of the GNU General Public License
> > + * as published by the Free Software Foundation; either version
> > + * 2 of the License, or (at your option) any later version.
> > + *
> > + */
> > +
> > +#include <linux/slab.h>
> > +#include <linux/of.h>
> > +
> > +#include "tpm.h"
> > +#include "tpm_eventlog.h"
> > +
> > +int read_log(struct tpm_bios_log *log)
> > +{
> > + struct device_node *np;
> > + const u32 *sizep;
> > + const __be64 *basep;
> > +
> > + if (log->bios_event_log != NULL) {
> > + pr_err("%s: ERROR - Eventlog already initialized\n", __func__);
> > + return -EFAULT;
> > + }
> > +
> > + np = of_find_node_by_name(NULL, "ibm,vtpm");
> > + if (!np) {
> > + pr_err("%s: ERROR - IBMVTPM not supported\n", __func__);
> > + return -ENODEV;
> > + }
>
> All your return paths below here must call of_node_put(np).
I'll fix it in next version. Thanks.
>
> > + sizep = of_get_property(np, "linux,sml-size", NULL);
> > + if (sizep == NULL) {
> > + pr_err("%s: ERROR - SML size not found\n", __func__);
> > + return -EIO;
> > + }
> > + if (*sizep == 0) {
> > + pr_err("%s: ERROR - event log area empty\n", __func__);
> > + return -EIO;
> > + }
> > +
> > + basep = of_get_property(np, "linux,sml-base", NULL);
> > + if (basep == NULL) {
> > + pr_err(KERN_ERR "%s: ERROR - SML not found\n", __func__);
> > + return -EIO;
> > + }
> > +
> > + log->bios_event_log = kmalloc(*sizep, GFP_KERNEL);
> > + if (!log->bios_event_log) {
> > + pr_err("%s: ERROR - Not enough memory for BIOS measurements\n",
> > + __func__);
> > + return -ENOMEM;
> > + }
> > +
> > + log->bios_event_log_end = log->bios_event_log + *sizep;
> > +
> > + memcpy(log->bios_event_log, __va(be64_to_cpup(basep)), *sizep);
> > +
> > + return 0;
> > +}
>
>
> cheers
>
^ permalink raw reply
* Re: [PATCH v2 4/6] x86: Add clear_page_nocache
From: Andi Kleen @ 2012-08-13 16:27 UTC (permalink / raw)
To: Kirill A. Shutemov
Cc: Andrea Arcangeli, linux-mips, H. Peter Anvin, Alex Shi,
Robert Richter, linuxppc-dev, x86, Hugh Dickins, linux-kernel,
Andy Lutomirski, linux-mm, linux-sh, Ingo Molnar, Mel Gorman,
Jan Beulich, Johannes Weiner, sparclinux, Thomas Gleixner,
Tim Chen, Andrew Morton, KAMEZAWA Hiroyuki
In-Reply-To: <20120813114334.GA21855@otc-wbsnb-06>
> Moving 64 bytes per cycle is faster on Sandy Bridge, but slower on
> Westmere. Any preference? ;)
You have to be careful with these benchmarks.
- You need to make sure the data is cache cold, cache hot is misleading.
- The numbers can change if you have multiple CPUs doing this in parallel.
-Andi
^ permalink raw reply
* Re: [PATCH v2 2/2] powerpc/mpic: add global timer support
From: Scott Wood @ 2012-08-13 16:49 UTC (permalink / raw)
To: Wang Dongsheng-B40534
Cc: Wood Scott-B07421, Li Yang-R58472, paulus@samba.org,
Gala Kumar-B11780, linuxppc-dev@lists.ozlabs.org
In-Reply-To: <ABB05CD9C9F68C46A5CEDC7F15439259DB147E@039-SN2MPN1-022.039d.mgd.msft.net>
On 08/13/2012 12:53 AM, Wang Dongsheng-B40534 wrote:
>
>
>> -----Original Message-----
>> From: Wood Scott-B07421
>> Sent: Saturday, August 11, 2012 3:40 AM
>> To: Wang Dongsheng-B40534
>> Cc: benh@kernel.crashing.org; paulus@samba.org; linuxppc-
>> dev@lists.ozlabs.org; Gala Kumar-B11780; Li Yang-R58472
>> Subject: Re: [PATCH v2 2/2] powerpc/mpic: add global timer support
>>
>> On 08/10/2012 12:54 AM, Dongsheng.wang@freescale.com wrote:
>>> +static const struct of_device_id mpic_timer_ids[] = {
>>> + { .compatible = "open-pic,global-timer", },
>>> + { .compatible = "fsl,global-timer", },
>>> + {},
>>> +};
>>> +
>>> +static int __init mpic_timer_init(void) {
>>> + struct device_node *np = NULL;
>>> +
>>> + for_each_node_by_type(np, "open-pic")
>>> + if (of_match_node(mpic_timer_ids, np))
>>> + group_init(np);
>>> +
>>> + if (list_empty(&group_list))
>>> + return -ENODEV;
>>> +
>>> + return 0;
>>> +}
>>> +arch_initcall(mpic_timer_init);
>>
>> Oh, and don't probe by device_type.
>>
> [Wang Dongsheng] fine. for_each_node_by_name.
No. Probe by compatible only.
-Scott
^ permalink raw reply
* Re: [PATCH v2 2/2] powerpc/mpic: add global timer support
From: Scott Wood @ 2012-08-13 16:50 UTC (permalink / raw)
To: Li Yang-R58472
Cc: Wood Scott-B07421, devicetree-discuss@lists.ozlabs.org,
Wang Dongsheng-B40534, paulus@samba.org, Gala Kumar-B11780,
linuxppc-dev@lists.ozlabs.org
In-Reply-To: <94F013E7935FF44C83EBE7784D62AD3F093AEC18@039-SN2MPN1-023.039d.mgd.msft.net>
On 08/13/2012 01:17 AM, Li Yang-R58472 wrote:
>
>
>> -----Original Message-----
>> From: Wang Dongsheng-B40534
>> Sent: Monday, August 13, 2012 1:54 PM
>> To: Wood Scott-B07421
>> Cc: benh@kernel.crashing.org; paulus@samba.org; linuxppc-
>> dev@lists.ozlabs.org; Gala Kumar-B11780; Li Yang-R58472
>> Subject: RE: [PATCH v2 2/2] powerpc/mpic: add global timer support
>>
>>
>>
>>> -----Original Message-----
>>> From: Wood Scott-B07421
>>> Sent: Saturday, August 11, 2012 3:40 AM
>>> To: Wang Dongsheng-B40534
>>> Cc: benh@kernel.crashing.org; paulus@samba.org; linuxppc-
>>> dev@lists.ozlabs.org; Gala Kumar-B11780; Li Yang-R58472
>>> Subject: Re: [PATCH v2 2/2] powerpc/mpic: add global timer support
>>>
>>> On 08/10/2012 12:54 AM, Dongsheng.wang@freescale.com wrote:
>>>> +static const struct of_device_id mpic_timer_ids[] = {
>>>> + { .compatible = "open-pic,global-timer", },
>>>> + { .compatible = "fsl,global-timer", },
>>>> + {},
>>>> +};
>>>> +
>>>> +static int __init mpic_timer_init(void) {
>>>> + struct device_node *np = NULL;
>>>> +
>>>> + for_each_node_by_type(np, "open-pic")
>>>> + if (of_match_node(mpic_timer_ids, np))
>>>> + group_init(np);
>>>> +
>>>> + if (list_empty(&group_list))
>>>> + return -ENODEV;
>>>> +
>>>> + return 0;
>>>> +}
>>>> +arch_initcall(mpic_timer_init);
>>>
>>> Oh, and don't probe by device_type.
>
> Actually it does match the compatible. The device_type is just to
> speed up the search. I don't think it's a problem unless the device
> type is not mandatory any more for defined types.
Doesn't matter (and I doubt it provides any significant speed up
compared to a search by compatible, and in any case this is not
performance critical). device_type is deprecated outside certain
specific legacy uses. Get rid of it.
-Scott
^ permalink raw reply
* Re: [PATCH v2 4/6] x86: Add clear_page_nocache
From: Borislav Petkov @ 2012-08-13 17:04 UTC (permalink / raw)
To: Kirill A. Shutemov
Cc: linux-mips, linux-sh, linux-mm, Jan Beulich, H. Peter Anvin,
sparclinux, Andrea Arcangeli, Andi Kleen, Robert Richter, x86,
Hugh Dickins, Ingo Molnar, Mel Gorman, Alex Shi, Thomas Gleixner,
KAMEZAWA Hiroyuki, Tim Chen, linux-kernel, Andy Lutomirski,
Johannes Weiner, Andrew Morton, linuxppc-dev
In-Reply-To: <20120813114334.GA21855@otc-wbsnb-06>
On Mon, Aug 13, 2012 at 02:43:34PM +0300, Kirill A. Shutemov wrote:
> $ cat test.c
> #include <stdio.h>
> #include <sys/mman.h>
>
> #define SIZE 1024*1024*1024
>
> void clear_page_nocache_sse2(void *page) __attribute__((regparm(1)));
>
> int main(int argc, char** argv)
> {
> char *p;
> unsigned long i, j;
>
> p = mmap(NULL, SIZE, PROT_WRITE|PROT_READ,
> MAP_PRIVATE|MAP_ANONYMOUS|MAP_POPULATE, -1, 0);
> for(j = 0; j < 100; j++) {
> for(i = 0; i < SIZE; i += 4096) {
> clear_page_nocache_sse2(p + i);
> }
> }
>
> return 0;
> }
> $ cat clear_page_nocache_unroll32.S
> .globl clear_page_nocache_sse2
> .align 4,0x90
> clear_page_nocache_sse2:
> .cfi_startproc
> mov %eax,%edx
> xorl %eax,%eax
> movl $4096/32,%ecx
> .p2align 4
> .Lloop_sse2:
> decl %ecx
> #define PUT(x) movnti %eax,x*4(%edx)
> PUT(0)
> PUT(1)
> PUT(2)
> PUT(3)
> PUT(4)
> PUT(5)
> PUT(6)
> PUT(7)
> #undef PUT
> lea 32(%edx),%edx
> jnz .Lloop_sse2
> nop
> ret
> .cfi_endproc
> .type clear_page_nocache_sse2, @function
> .size clear_page_nocache_sse2, .-clear_page_nocache_sse2
> $ cat clear_page_nocache_unroll64.S
> .globl clear_page_nocache_sse2
> .align 4,0x90
> clear_page_nocache_sse2:
> .cfi_startproc
> mov %eax,%edx
This must still be the 32-bit version becaue it segfaults here. Here's
why:
mmap above gives a ptr which, on 64-bit, is larger than 32-bit, i.e. it
looks like 0x7fffxxxxx000, i.e. starting from top of userspace.
Now, the mov above truncates that ptr and the thing segfaults.
Doing s/edx/rdx/g fixes it though.
Thanks.
--
Regards/Gruss,
Boris.
^ permalink raw reply
* Re: [PATCH] powerpc/epapr: export epapr_hypercall_start
From: Scott Wood @ 2012-08-13 17:29 UTC (permalink / raw)
To: Tabi Timur-B04825
Cc: Wood Scott-B07421, kvm@vger.kernel.org, agraf@suse.de,
kvm-ppc@vger.kernel.org, Geert Uytterhoeven,
linuxppc-dev@lists.ozlabs.org
In-Reply-To: <CAOZdJXW+Br2LCxCuMruHJtODqu+8xcdgWrcLPWE2aJ2U23RU3g@mail.gmail.com>
On 08/11/2012 08:07 AM, Tabi Timur-B04825 wrote:
> On Sat, Aug 11, 2012 at 2:01 AM, Geert Uytterhoeven
> <geert@linux-m68k.org> wrote:
>> On Sat, Aug 11, 2012 at 12:21 AM, Scott Wood <scottwood@freescale.com> wrote:
>>> +EXPORT_SYMBOL(epapr_hypercall_start);
>>
>> EXPORT_SYMBOL_GPL?
>
> We prefer EXPORT_SYMBOL. We don't want to restrict our customers from
> having to use GPL code.
>
More specifically in this case, I don't see how use of this symbol in
any way suggests that the code would be GPL-derivative. The API is
documented in the ePAPR standard or other external sources -- not a
kernel internal implementation issue. The contents of
epapr_hypercall_start itself are not copyrightable (by default it's
basically "return -1", and is patched at runtime with a few instructions
provided by the hypervisor). The header file with the inline accessors
is dual licensed (and also unlikely to be copyrightable, in terms of
what actually makes it into the output binary).
-Scott
^ permalink raw reply
* Re: [PATCH v2 2/2] powerpc/mpic: add global timer support
From: Scott Wood @ 2012-08-13 17:36 UTC (permalink / raw)
To: Wang Dongsheng-B40534
Cc: Wood Scott-B07421, Li Yang-R58472, paulus@samba.org,
Gala Kumar-B11780, linuxppc-dev@lists.ozlabs.org
In-Reply-To: <ABB05CD9C9F68C46A5CEDC7F15439259DB14CA@039-SN2MPN1-022.039d.mgd.msft.net>
On 08/13/2012 01:18 AM, Wang Dongsheng-B40534 wrote:
>>> + p = of_get_property(np, "available-ranges", &len);
>>> + if (p && len % (2 * sizeof(u32)) != 0) {
>>> + pr_err("%s: malformed fsl,available-ranges property.\n",
>>> + np->full_name);
>>> + return -EINVAL;
>>> + }
>>
>> You need to support fsl,available-ranges since that's in an accepted
>> binding and people could have partitioned setups already using it.
>>
> [Wang Dongsheng] FSL chip or OPEN-PIC specification(Only a group)
> in each group only four timer. This is unified. So i use a generic name.
> I think there is not compatible with existing mpic timer nodes.
We need to be compatible with existing trees, so you'd need to check for
both -- but I think any further discussion of the details is premature
until we decide whether this is worthwhile to begin with (both the
support of non-FSL timers, and the creation of a new device tree binding
which will not be implemented by many of the machines that have non-FSL
openpic because they run real Open Firmware).
-Scott
^ permalink raw reply
* Re: [PATCH v2 1/2] powerpc/mpic: Add Open-PIC global timer document
From: Scott Wood @ 2012-08-13 17:39 UTC (permalink / raw)
To: Wang Dongsheng-B40534
Cc: Wood Scott-B07421, Li Yang-R58472,
devicetree-discuss@lists.ozlabs.org, paulus@samba.org,
Gala Kumar-B11780, linuxppc-dev@lists.ozlabs.org
In-Reply-To: <ABB05CD9C9F68C46A5CEDC7F15439259DB1450@039-SN2MPN1-022.039d.mgd.msft.net>
On 08/13/2012 12:40 AM, Wang Dongsheng-B40534 wrote:
>>> diff --git a/Documentation/devicetree/bindings/open-pic.txt
>>> b/Documentation/devicetree/bindings/open-pic.txt
>>> index 909a902..045c2e9 100644
>>> --- a/Documentation/devicetree/bindings/open-pic.txt
>>> +++ b/Documentation/devicetree/bindings/open-pic.txt
>>> @@ -92,6 +92,52 @@ Example 2:
>>>
>>> * References
>>>
>>> +* Open PIC global timers
>>> +
>>> +Required properties:
>>> +- compatible: "open-pic,global-timer"
>>
>> open-pic isn't a vendor (or software project that acts like a
>> pseudo-vendor) -- I'd go with "open-pic-global-timer".
>>
> [Wang Dongsheng] yes, "open-pic-global-timer" looks good.
>
>>> +- reg : Contains two regions. The first is the timer frequency
>>> +reporting
>>> + register for the group. The second is the main timer register bank
>>> + (GTCCR, GTBCR, GTVPR, GTDR).
>>
>> Why not just put clock-frequency in the node, instead of describing TFRR?
>> I don't think U-Boot currently sets TFRR.
>>
> [Wang Dongsheng] If during startup U-Boot do not set TFRR that is unreasonable.
Too bad, it's what happens and we're not going to force users to update
U-Boot because of this.
>>> +Example 2:
>>> +
>>> + timer: timer@010f0 {
>>> + compatible = "open-pic,global-timer";
>>> + device_type = "open-pic";
>>> + reg = <0x010f0 4 0x01100 0x100>;
>>> + interrupts = <0 0 3 0
>>> + 1 0 3 0
>>> + 2 0 3 0
>>> + 3 0 3 0>;
>>> + };
>>
>> 4-cell interrupt specifiers are specific to Freescale MPICs. This means
>> there's no way to describe the timer interrupt on a non-Freescale openpic.
>> Again, I suggest we not bother with this in the absence of an actual need
>> to support the timer on non-Freescale openpic in partitioned scenarios.
>> The existing openpic node is sufficient to describe the
>> hardware in the absence of partitioning. We could have an
>> "openpic-no-timer" property to indicate that we're describing it
>> separately, so that the absence of a timer node isn't ambiguous as to
>> whether it's an old tree or a partitioned scenario. An fsl,mpic
>> compatible would imply openpic-no-timer.
>>
>> Note that I believe many of the non-Freescale openpic nodes are going to
>> be found on systems with real Open Firmware, so we can't go changing the
>> device tree for them.
> [Wang Dongsheng] In the Open-PIC specification, there are four timer.
> interrupts = <0 0 3 0
> 1 0 3 0
> 2 0 3 0
> 3 0 3 0>;
>
> The "interrupts" just let user know there are four timers. Usage based "interrupts"
> binding to change dts.
I can't understand the above or how it's a response to what I wrote.
-Scott
^ permalink raw reply
* Re: [PATCH v2 4/6] x86: Add clear_page_nocache
From: Kirill A. Shutemov @ 2012-08-13 19:07 UTC (permalink / raw)
To: Borislav Petkov, Kirill A. Shutemov, Jan Beulich, Andi Kleen,
Andy Lutomirski, Robert Richter, Johannes Weiner, Hugh Dickins,
Alex Shi, KAMEZAWA Hiroyuki, x86, linux-mm, Thomas Gleixner,
Andrew Morton, linux-mips, Tim Chen, linuxppc-dev,
Andrea Arcangeli, Ingo Molnar, Mel Gorman, linux-kernel, linux-sh,
sparclinux, H. Peter Anvin
In-Reply-To: <20120813170402.GB15530@x1.osrc.amd.com>
On Mon, Aug 13, 2012 at 07:04:02PM +0200, Borislav Petkov wrote:
> On Mon, Aug 13, 2012 at 02:43:34PM +0300, Kirill A. Shutemov wrote:
> > $ cat test.c
> > #include <stdio.h>
> > #include <sys/mman.h>
> >
> > #define SIZE 1024*1024*1024
> >
> > void clear_page_nocache_sse2(void *page) __attribute__((regparm(1)));
> >
> > int main(int argc, char** argv)
> > {
> > char *p;
> > unsigned long i, j;
> >
> > p = mmap(NULL, SIZE, PROT_WRITE|PROT_READ,
> > MAP_PRIVATE|MAP_ANONYMOUS|MAP_POPULATE, -1, 0);
> > for(j = 0; j < 100; j++) {
> > for(i = 0; i < SIZE; i += 4096) {
> > clear_page_nocache_sse2(p + i);
> > }
> > }
> >
> > return 0;
> > }
> > $ cat clear_page_nocache_unroll32.S
> > .globl clear_page_nocache_sse2
> > .align 4,0x90
> > clear_page_nocache_sse2:
> > .cfi_startproc
> > mov %eax,%edx
> > xorl %eax,%eax
> > movl $4096/32,%ecx
> > .p2align 4
> > .Lloop_sse2:
> > decl %ecx
> > #define PUT(x) movnti %eax,x*4(%edx)
> > PUT(0)
> > PUT(1)
> > PUT(2)
> > PUT(3)
> > PUT(4)
> > PUT(5)
> > PUT(6)
> > PUT(7)
> > #undef PUT
> > lea 32(%edx),%edx
> > jnz .Lloop_sse2
> > nop
> > ret
> > .cfi_endproc
> > .type clear_page_nocache_sse2, @function
> > .size clear_page_nocache_sse2, .-clear_page_nocache_sse2
> > $ cat clear_page_nocache_unroll64.S
> > .globl clear_page_nocache_sse2
> > .align 4,0x90
> > clear_page_nocache_sse2:
> > .cfi_startproc
> > mov %eax,%edx
>
> This must still be the 32-bit version becaue it segfaults here.
Yes, it's test for 32-bit version.
--
Kirill A. Shutemov
^ permalink raw reply
* RE: [PATCH v2 2/2] powerpc/mpic: add global timer support
From: Wang Dongsheng-B40534 @ 2012-08-14 2:00 UTC (permalink / raw)
To: Wood Scott-B07421
Cc: Gala Kumar-B11780, paulus@samba.org,
linuxppc-dev@lists.ozlabs.org, Li Yang-R58472
In-Reply-To: <50293B36.1000408@freescale.com>
DQoNCj4gLS0tLS1PcmlnaW5hbCBNZXNzYWdlLS0tLS0NCj4gRnJvbTogV29vZCBTY290dC1CMDc0
MjENCj4gU2VudDogVHVlc2RheSwgQXVndXN0IDE0LCAyMDEyIDE6MzcgQU0NCj4gVG86IFdhbmcg
RG9uZ3NoZW5nLUI0MDUzNA0KPiBDYzogV29vZCBTY290dC1CMDc0MjE7IGJlbmhAa2VybmVsLmNy
YXNoaW5nLm9yZzsgcGF1bHVzQHNhbWJhLm9yZzsNCj4gbGludXhwcGMtZGV2QGxpc3RzLm96bGFi
cy5vcmc7IEdhbGEgS3VtYXItQjExNzgwOyBMaSBZYW5nLVI1ODQ3Mg0KPiBTdWJqZWN0OiBSZTog
W1BBVENIIHYyIDIvMl0gcG93ZXJwYy9tcGljOiBhZGQgZ2xvYmFsIHRpbWVyIHN1cHBvcnQNCj4g
DQo+IE9uIDA4LzEzLzIwMTIgMDE6MTggQU0sIFdhbmcgRG9uZ3NoZW5nLUI0MDUzNCB3cm90ZToN
Cj4gPj4+ICsJcCA9IG9mX2dldF9wcm9wZXJ0eShucCwgImF2YWlsYWJsZS1yYW5nZXMiLCAmbGVu
KTsNCj4gPj4+ICsJaWYgKHAgJiYgbGVuICUgKDIgKiBzaXplb2YodTMyKSkgIT0gMCkgew0KPiA+
Pj4gKwkJcHJfZXJyKCIlczogbWFsZm9ybWVkIGZzbCxhdmFpbGFibGUtcmFuZ2VzIHByb3BlcnR5
LlxuIiwNCj4gPj4+ICsJCQkJbnAtPmZ1bGxfbmFtZSk7DQo+ID4+PiArCQlyZXR1cm4gLUVJTlZB
TDsNCj4gPj4+ICsJfQ0KPiA+Pg0KPiA+PiBZb3UgbmVlZCB0byBzdXBwb3J0IGZzbCxhdmFpbGFi
bGUtcmFuZ2VzIHNpbmNlIHRoYXQncyBpbiBhbiBhY2NlcHRlZA0KPiA+PiBiaW5kaW5nIGFuZCBw
ZW9wbGUgY291bGQgaGF2ZSBwYXJ0aXRpb25lZCBzZXR1cHMgYWxyZWFkeSB1c2luZyBpdC4NCj4g
Pj4NCj4gPiBbV2FuZyBEb25nc2hlbmddIEZTTCBjaGlwIG9yIE9QRU4tUElDIHNwZWNpZmljYXRp
b24oT25seSBhIGdyb3VwKSBpbg0KPiA+IGVhY2ggZ3JvdXAgb25seSBmb3VyIHRpbWVyLiBUaGlz
IGlzIHVuaWZpZWQuIFNvIGkgdXNlIGEgZ2VuZXJpYyBuYW1lLg0KPiA+IEkgdGhpbmsgdGhlcmUg
aXMgbm90IGNvbXBhdGlibGUgd2l0aCBleGlzdGluZyBtcGljIHRpbWVyIG5vZGVzLg0KPiANCj4g
V2UgbmVlZCB0byBiZSBjb21wYXRpYmxlIHdpdGggZXhpc3RpbmcgdHJlZXMsIHNvIHlvdSdkIG5l
ZWQgdG8gY2hlY2sgZm9yDQo+IGJvdGggLS0gYnV0IEkgdGhpbmsgYW55IGZ1cnRoZXIgZGlzY3Vz
c2lvbiBvZiB0aGUgZGV0YWlscyBpcyBwcmVtYXR1cmUNCj4gdW50aWwgd2UgZGVjaWRlIHdoZXRo
ZXIgdGhpcyBpcyB3b3J0aHdoaWxlIHRvIGJlZ2luIHdpdGggKGJvdGggdGhlDQo+IHN1cHBvcnQg
b2Ygbm9uLUZTTCB0aW1lcnMsIGFuZCB0aGUgY3JlYXRpb24gb2YgYSBuZXcgZGV2aWNlIHRyZWUg
YmluZGluZw0KPiB3aGljaCB3aWxsIG5vdCBiZSBpbXBsZW1lbnRlZCBieSBtYW55IG9mIHRoZSBt
YWNoaW5lcyB0aGF0IGhhdmUgbm9uLUZTTA0KPiBvcGVucGljIGJlY2F1c2UgdGhleSBydW4gcmVh
bCBPcGVuIEZpcm13YXJlKS4NCj4gDQpbV2FuZyBEb25nc2hlbmddIA0KCXAgPSBvZl9nZXRfcHJv
cGVydHkobnAsICJhdmFpbGFibGUtcmFuZ2VzIiwgJmxlbik7DQoJaWYgKCFwKQ0KCQlwID0gb2Zf
Z2V0X3Byb3BlcnR5KG5wLCAiZnNsLGF2YWlsYWJsZS1yYW5nZXMiLCAmbGVuKTsNCgkNCgl0aGlz
IGNvZGUgYmUgY29tcGF0aWJsZSB3aXRoIGV4aXN0aW5nIHRyZWVzLg0KCQ0KPiAtU2NvdHQNCg0K
^ permalink raw reply
* Re: [PATCH v2 2/2] powerpc/mpic: add global timer support
From: Scott Wood @ 2012-08-14 2:05 UTC (permalink / raw)
To: Wang Dongsheng-B40534
Cc: Wood Scott-B07421, Li Yang-R58472, paulus@samba.org,
Gala Kumar-B11780, linuxppc-dev@lists.ozlabs.org
In-Reply-To: <ABB05CD9C9F68C46A5CEDC7F15439259DB1984@039-SN2MPN1-022.039d.mgd.msft.net>
On 08/13/2012 09:00 PM, Wang Dongsheng-B40534 wrote:
>
>
>> -----Original Message-----
>> From: Wood Scott-B07421
>> Sent: Tuesday, August 14, 2012 1:37 AM
>> To: Wang Dongsheng-B40534
>> Cc: Wood Scott-B07421; benh@kernel.crashing.org; paulus@samba.org;
>> linuxppc-dev@lists.ozlabs.org; Gala Kumar-B11780; Li Yang-R58472
>> Subject: Re: [PATCH v2 2/2] powerpc/mpic: add global timer support
>>
>> On 08/13/2012 01:18 AM, Wang Dongsheng-B40534 wrote:
>>>>> + p = of_get_property(np, "available-ranges", &len);
>>>>> + if (p && len % (2 * sizeof(u32)) != 0) {
>>>>> + pr_err("%s: malformed fsl,available-ranges property.\n",
>>>>> + np->full_name);
>>>>> + return -EINVAL;
>>>>> + }
>>>>
>>>> You need to support fsl,available-ranges since that's in an accepted
>>>> binding and people could have partitioned setups already using it.
>>>>
>>> [Wang Dongsheng] FSL chip or OPEN-PIC specification(Only a group) in
>>> each group only four timer. This is unified. So i use a generic name.
>>> I think there is not compatible with existing mpic timer nodes.
>>
>> We need to be compatible with existing trees, so you'd need to check for
>> both -- but I think any further discussion of the details is premature
>> until we decide whether this is worthwhile to begin with (both the
>> support of non-FSL timers, and the creation of a new device tree binding
>> which will not be implemented by many of the machines that have non-FSL
>> openpic because they run real Open Firmware).
>>
> [Wang Dongsheng]
> p = of_get_property(np, "available-ranges", &len);
> if (!p)
> p = of_get_property(np, "fsl,available-ranges", &len);
>
> this code be compatible with existing trees.
Yes, that's what I meant by checking both.
I still think we need to discuss why we're doing this first. What
specific machines are going to have these new openpic timer nodes?
-Scott
^ permalink raw reply
* RE: [PATCH v2 2/2] powerpc/mpic: add global timer support
From: Wang Dongsheng-B40534 @ 2012-08-14 2:06 UTC (permalink / raw)
To: Wood Scott-B07421
Cc: Gala Kumar-B11780, paulus@samba.org,
linuxppc-dev@lists.ozlabs.org, Li Yang-R58472
In-Reply-To: <5029300F.60600@freescale.com>
DQoNCj4gLS0tLS1PcmlnaW5hbCBNZXNzYWdlLS0tLS0NCj4gRnJvbTogV29vZCBTY290dC1CMDc0
MjENCj4gU2VudDogVHVlc2RheSwgQXVndXN0IDE0LCAyMDEyIDEyOjQ5IEFNDQo+IFRvOiBXYW5n
IERvbmdzaGVuZy1CNDA1MzQNCj4gQ2M6IFdvb2QgU2NvdHQtQjA3NDIxOyBiZW5oQGtlcm5lbC5j
cmFzaGluZy5vcmc7IHBhdWx1c0BzYW1iYS5vcmc7DQo+IGxpbnV4cHBjLWRldkBsaXN0cy5vemxh
YnMub3JnOyBHYWxhIEt1bWFyLUIxMTc4MDsgTGkgWWFuZy1SNTg0NzINCj4gU3ViamVjdDogUmU6
IFtQQVRDSCB2MiAyLzJdIHBvd2VycGMvbXBpYzogYWRkIGdsb2JhbCB0aW1lciBzdXBwb3J0DQo+
IA0KPiBPbiAwOC8xMy8yMDEyIDEyOjUzIEFNLCBXYW5nIERvbmdzaGVuZy1CNDA1MzQgd3JvdGU6
DQo+ID4NCj4gPg0KPiA+PiAtLS0tLU9yaWdpbmFsIE1lc3NhZ2UtLS0tLQ0KPiA+PiBGcm9tOiBX
b29kIFNjb3R0LUIwNzQyMQ0KPiA+PiBTZW50OiBTYXR1cmRheSwgQXVndXN0IDExLCAyMDEyIDM6
NDAgQU0NCj4gPj4gVG86IFdhbmcgRG9uZ3NoZW5nLUI0MDUzNA0KPiA+PiBDYzogYmVuaEBrZXJu
ZWwuY3Jhc2hpbmcub3JnOyBwYXVsdXNAc2FtYmEub3JnOyBsaW51eHBwYy0NCj4gPj4gZGV2QGxp
c3RzLm96bGFicy5vcmc7IEdhbGEgS3VtYXItQjExNzgwOyBMaSBZYW5nLVI1ODQ3Mg0KPiA+PiBT
dWJqZWN0OiBSZTogW1BBVENIIHYyIDIvMl0gcG93ZXJwYy9tcGljOiBhZGQgZ2xvYmFsIHRpbWVy
IHN1cHBvcnQNCj4gPj4NCj4gPj4gT24gMDgvMTAvMjAxMiAxMjo1NCBBTSwgRG9uZ3NoZW5nLndh
bmdAZnJlZXNjYWxlLmNvbSB3cm90ZToNCj4gPj4+ICtzdGF0aWMgY29uc3Qgc3RydWN0IG9mX2Rl
dmljZV9pZCBtcGljX3RpbWVyX2lkc1tdID0gew0KPiA+Pj4gKwl7IC5jb21wYXRpYmxlID0gIm9w
ZW4tcGljLGdsb2JhbC10aW1lciIsIH0sDQo+ID4+PiArCXsgLmNvbXBhdGlibGUgPSAiZnNsLGds
b2JhbC10aW1lciIsIH0sDQo+ID4+PiArCXt9LA0KPiA+Pj4gK307DQo+ID4+PiArDQo+ID4+PiAr
c3RhdGljIGludCBfX2luaXQgbXBpY190aW1lcl9pbml0KHZvaWQpIHsNCj4gPj4+ICsJc3RydWN0
IGRldmljZV9ub2RlICpucCA9IE5VTEw7DQo+ID4+PiArDQo+ID4+PiArCWZvcl9lYWNoX25vZGVf
YnlfdHlwZShucCwgIm9wZW4tcGljIikNCj4gPj4+ICsJCWlmIChvZl9tYXRjaF9ub2RlKG1waWNf
dGltZXJfaWRzLCBucCkpDQo+ID4+PiArCQkJZ3JvdXBfaW5pdChucCk7DQo+ID4+PiArDQo+ID4+
PiArCWlmIChsaXN0X2VtcHR5KCZncm91cF9saXN0KSkNCj4gPj4+ICsJCXJldHVybiAtRU5PREVW
Ow0KPiA+Pj4gKw0KPiA+Pj4gKwlyZXR1cm4gMDsNCj4gPj4+ICt9DQo+ID4+PiArYXJjaF9pbml0
Y2FsbChtcGljX3RpbWVyX2luaXQpOw0KPiA+Pg0KPiA+PiBPaCwgYW5kIGRvbid0IHByb2JlIGJ5
IGRldmljZV90eXBlLg0KPiA+Pg0KPiA+IFtXYW5nIERvbmdzaGVuZ10gZmluZS4gZm9yX2VhY2hf
bm9kZV9ieV9uYW1lLg0KPiANCj4gTm8uICBQcm9iZSBieSBjb21wYXRpYmxlIG9ubHkuDQo+IA0K
W1dhbmcgRG9uZ3NoZW5nXSBJIGxvb2tlZCBkZXZpY2V0cmVlJ3MgQVBJLiANCg0KCWZvcl9lYWNo
X21hdGNoaW5nX25vZGUobnAsIG1waWNfdGltZXJfaWRzKSBsb29rcyBiZXR0ZXIuIFRoYW5rcy4N
CiAgICAgICAgICAgICAgICAgICAgICAgIA0KDQo+IC1TY290dA0KDQo=
^ permalink raw reply
* RE: [PATCH v2 2/2] powerpc/mpic: add global timer support
From: Wang Dongsheng-B40534 @ 2012-08-14 2:15 UTC (permalink / raw)
To: Wood Scott-B07421
Cc: Gala Kumar-B11780, paulus@samba.org,
linuxppc-dev@lists.ozlabs.org, Li Yang-R58472
In-Reply-To: <5029B25E.4010708@freescale.com>
DQoNCj4gLS0tLS1PcmlnaW5hbCBNZXNzYWdlLS0tLS0NCj4gRnJvbTogV29vZCBTY290dC1CMDc0
MjENCj4gU2VudDogVHVlc2RheSwgQXVndXN0IDE0LCAyMDEyIDEwOjA1IEFNDQo+IFRvOiBXYW5n
IERvbmdzaGVuZy1CNDA1MzQNCj4gQ2M6IFdvb2QgU2NvdHQtQjA3NDIxOyBiZW5oQGtlcm5lbC5j
cmFzaGluZy5vcmc7IHBhdWx1c0BzYW1iYS5vcmc7DQo+IGxpbnV4cHBjLWRldkBsaXN0cy5vemxh
YnMub3JnOyBHYWxhIEt1bWFyLUIxMTc4MDsgTGkgWWFuZy1SNTg0NzINCj4gU3ViamVjdDogUmU6
IFtQQVRDSCB2MiAyLzJdIHBvd2VycGMvbXBpYzogYWRkIGdsb2JhbCB0aW1lciBzdXBwb3J0DQo+
IA0KPiBPbiAwOC8xMy8yMDEyIDA5OjAwIFBNLCBXYW5nIERvbmdzaGVuZy1CNDA1MzQgd3JvdGU6
DQo+ID4NCj4gPg0KPiA+PiAtLS0tLU9yaWdpbmFsIE1lc3NhZ2UtLS0tLQ0KPiA+PiBGcm9tOiBX
b29kIFNjb3R0LUIwNzQyMQ0KPiA+PiBTZW50OiBUdWVzZGF5LCBBdWd1c3QgMTQsIDIwMTIgMToz
NyBBTQ0KPiA+PiBUbzogV2FuZyBEb25nc2hlbmctQjQwNTM0DQo+ID4+IENjOiBXb29kIFNjb3R0
LUIwNzQyMTsgYmVuaEBrZXJuZWwuY3Jhc2hpbmcub3JnOyBwYXVsdXNAc2FtYmEub3JnOw0KPiA+
PiBsaW51eHBwYy1kZXZAbGlzdHMub3psYWJzLm9yZzsgR2FsYSBLdW1hci1CMTE3ODA7IExpIFlh
bmctUjU4NDcyDQo+ID4+IFN1YmplY3Q6IFJlOiBbUEFUQ0ggdjIgMi8yXSBwb3dlcnBjL21waWM6
IGFkZCBnbG9iYWwgdGltZXIgc3VwcG9ydA0KPiA+Pg0KPiA+PiBPbiAwOC8xMy8yMDEyIDAxOjE4
IEFNLCBXYW5nIERvbmdzaGVuZy1CNDA1MzQgd3JvdGU6DQo+ID4+Pj4+ICsJcCA9IG9mX2dldF9w
cm9wZXJ0eShucCwgImF2YWlsYWJsZS1yYW5nZXMiLCAmbGVuKTsNCj4gPj4+Pj4gKwlpZiAocCAm
JiBsZW4gJSAoMiAqIHNpemVvZih1MzIpKSAhPSAwKSB7DQo+ID4+Pj4+ICsJCXByX2VycigiJXM6
IG1hbGZvcm1lZCBmc2wsYXZhaWxhYmxlLXJhbmdlcyBwcm9wZXJ0eS5cbiIsDQo+ID4+Pj4+ICsJ
CQkJbnAtPmZ1bGxfbmFtZSk7DQo+ID4+Pj4+ICsJCXJldHVybiAtRUlOVkFMOw0KPiA+Pj4+PiAr
CX0NCj4gPj4+Pg0KPiA+Pj4+IFlvdSBuZWVkIHRvIHN1cHBvcnQgZnNsLGF2YWlsYWJsZS1yYW5n
ZXMgc2luY2UgdGhhdCdzIGluIGFuDQo+ID4+Pj4gYWNjZXB0ZWQgYmluZGluZyBhbmQgcGVvcGxl
IGNvdWxkIGhhdmUgcGFydGl0aW9uZWQgc2V0dXBzIGFscmVhZHkNCj4gdXNpbmcgaXQuDQo+ID4+
Pj4NCj4gPj4+IFtXYW5nIERvbmdzaGVuZ10gRlNMIGNoaXAgb3IgT1BFTi1QSUMgc3BlY2lmaWNh
dGlvbihPbmx5IGEgZ3JvdXApIGluDQo+ID4+PiBlYWNoIGdyb3VwIG9ubHkgZm91ciB0aW1lci4g
VGhpcyBpcyB1bmlmaWVkLiBTbyBpIHVzZSBhIGdlbmVyaWMgbmFtZS4NCj4gPj4+IEkgdGhpbmsg
dGhlcmUgaXMgbm90IGNvbXBhdGlibGUgd2l0aCBleGlzdGluZyBtcGljIHRpbWVyIG5vZGVzLg0K
PiA+Pg0KPiA+PiBXZSBuZWVkIHRvIGJlIGNvbXBhdGlibGUgd2l0aCBleGlzdGluZyB0cmVlcywg
c28geW91J2QgbmVlZCB0byBjaGVjaw0KPiA+PiBmb3IgYm90aCAtLSBidXQgSSB0aGluayBhbnkg
ZnVydGhlciBkaXNjdXNzaW9uIG9mIHRoZSBkZXRhaWxzIGlzDQo+ID4+IHByZW1hdHVyZSB1bnRp
bCB3ZSBkZWNpZGUgd2hldGhlciB0aGlzIGlzIHdvcnRod2hpbGUgdG8gYmVnaW4gd2l0aA0KPiA+
PiAoYm90aCB0aGUgc3VwcG9ydCBvZiBub24tRlNMIHRpbWVycywgYW5kIHRoZSBjcmVhdGlvbiBv
ZiBhIG5ldyBkZXZpY2UNCj4gPj4gdHJlZSBiaW5kaW5nIHdoaWNoIHdpbGwgbm90IGJlIGltcGxl
bWVudGVkIGJ5IG1hbnkgb2YgdGhlIG1hY2hpbmVzDQo+ID4+IHRoYXQgaGF2ZSBub24tRlNMIG9w
ZW5waWMgYmVjYXVzZSB0aGV5IHJ1biByZWFsIE9wZW4gRmlybXdhcmUpLg0KPiA+Pg0KPiA+IFtX
YW5nIERvbmdzaGVuZ10NCj4gPiAJcCA9IG9mX2dldF9wcm9wZXJ0eShucCwgImF2YWlsYWJsZS1y
YW5nZXMiLCAmbGVuKTsNCj4gPiAJaWYgKCFwKQ0KPiA+IAkJcCA9IG9mX2dldF9wcm9wZXJ0eShu
cCwgImZzbCxhdmFpbGFibGUtcmFuZ2VzIiwgJmxlbik7DQo+ID4NCj4gPiAJdGhpcyBjb2RlIGJl
IGNvbXBhdGlibGUgd2l0aCBleGlzdGluZyB0cmVlcy4NCj4gDQo+IFllcywgdGhhdCdzIHdoYXQg
SSBtZWFudCBieSBjaGVja2luZyBib3RoLg0KPiANCj4gSSBzdGlsbCB0aGluayB3ZSBuZWVkIHRv
IGRpc2N1c3Mgd2h5IHdlJ3JlIGRvaW5nIHRoaXMgZmlyc3QuICBXaGF0DQo+IHNwZWNpZmljIG1h
Y2hpbmVzIGFyZSBnb2luZyB0byBoYXZlIHRoZXNlIG5ldyBvcGVucGljIHRpbWVyIG5vZGVzPw0K
PiANCltXYW5nIERvbmdzaGVuZ10gSXQncyBzdXBwb3J0IHRvIHBvd2VyIG1hbmFnZW1lbnQgYXdh
a2VuaW5nLiBBdCBwcmVzZW50LCANCnRoZSBwb3dlciBtYW5hZ2VtZW50IG1vcmUgYW5kIG1vcmUg
aW1wb3J0YW50LiBUaGlzIHdheSBpcyBpbXBvcnRhbnQgdG8gd2FrZQ0KdXAgbWFjaGluZS4gQXQg
bGVhc3QgbmVlZCBzdXBwb3J0IHBvd2VyIG1hbmFnZW1lbnQgb2YgbWFjaGluZSBzdGlsbCBuZWVk
cw0Kc3VjaCBhIGRyaXZlci4NCg0KPiAtU2NvdHQNCg0K
^ permalink raw reply
* Re: [PATCH v2 2/2] powerpc/mpic: add global timer support
From: Scott Wood @ 2012-08-14 2:18 UTC (permalink / raw)
To: Wang Dongsheng-B40534
Cc: Wood Scott-B07421, Li Yang-R58472, paulus@samba.org,
Gala Kumar-B11780, linuxppc-dev@lists.ozlabs.org
In-Reply-To: <ABB05CD9C9F68C46A5CEDC7F15439259DB19CF@039-SN2MPN1-022.039d.mgd.msft.net>
On 08/13/2012 09:15 PM, Wang Dongsheng-B40534 wrote:
>
>
>> -----Original Message-----
>> From: Wood Scott-B07421
>> Sent: Tuesday, August 14, 2012 10:05 AM
>> To: Wang Dongsheng-B40534
>> Cc: Wood Scott-B07421; benh@kernel.crashing.org; paulus@samba.org;
>> linuxppc-dev@lists.ozlabs.org; Gala Kumar-B11780; Li Yang-R58472
>> Subject: Re: [PATCH v2 2/2] powerpc/mpic: add global timer support
>>
>> On 08/13/2012 09:00 PM, Wang Dongsheng-B40534 wrote:
>>>
>>>
>>>> -----Original Message-----
>>>> From: Wood Scott-B07421
>>>> Sent: Tuesday, August 14, 2012 1:37 AM
>>>> To: Wang Dongsheng-B40534
>>>> Cc: Wood Scott-B07421; benh@kernel.crashing.org; paulus@samba.org;
>>>> linuxppc-dev@lists.ozlabs.org; Gala Kumar-B11780; Li Yang-R58472
>>>> Subject: Re: [PATCH v2 2/2] powerpc/mpic: add global timer support
>>>>
>>>> On 08/13/2012 01:18 AM, Wang Dongsheng-B40534 wrote:
>>>>>>> + p = of_get_property(np, "available-ranges", &len);
>>>>>>> + if (p && len % (2 * sizeof(u32)) != 0) {
>>>>>>> + pr_err("%s: malformed fsl,available-ranges property.\n",
>>>>>>> + np->full_name);
>>>>>>> + return -EINVAL;
>>>>>>> + }
>>>>>>
>>>>>> You need to support fsl,available-ranges since that's in an
>>>>>> accepted binding and people could have partitioned setups already
>> using it.
>>>>>>
>>>>> [Wang Dongsheng] FSL chip or OPEN-PIC specification(Only a group) in
>>>>> each group only four timer. This is unified. So i use a generic name.
>>>>> I think there is not compatible with existing mpic timer nodes.
>>>>
>>>> We need to be compatible with existing trees, so you'd need to check
>>>> for both -- but I think any further discussion of the details is
>>>> premature until we decide whether this is worthwhile to begin with
>>>> (both the support of non-FSL timers, and the creation of a new device
>>>> tree binding which will not be implemented by many of the machines
>>>> that have non-FSL openpic because they run real Open Firmware).
>>>>
>>> [Wang Dongsheng]
>>> p = of_get_property(np, "available-ranges", &len);
>>> if (!p)
>>> p = of_get_property(np, "fsl,available-ranges", &len);
>>>
>>> this code be compatible with existing trees.
>>
>> Yes, that's what I meant by checking both.
>>
>> I still think we need to discuss why we're doing this first. What
>> specific machines are going to have these new openpic timer nodes?
>>
> [Wang Dongsheng] It's support to power management awakening. At present,
> the power management more and more important. This way is important to wake
> up machine. At least need support power management of machine still needs
> such a driver.
I mean specifically for the non-Freescale openpic nodes.
-Scott
^ permalink raw reply
page: next (older) | prev (newer) | latest
- recent:[subjects (threaded)|topics (new)|topics (active)]
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox