* Re: 3.9-rc1 powerpc ptrace.c: 'brk.len' is used uninitialized
From: Philippe De Muyter @ 2013-03-07 9:59 UTC (permalink / raw)
To: Michael Neuling; +Cc: linuxppc-dev, linux-kernel
In-Reply-To: <31862.1362611670@ale.ozlabs.ibm.com>
Hello Mikey,
On Thu, Mar 07, 2013 at 10:14:30AM +1100, Michael Neuling wrote:
> Philippe De Muyter <phdm@macqel.be> wrote:
>
> > On Thu, Mar 07, 2013 at 09:09:48AM +1100, Michael Neuling wrote:
> > > > bisect tells me that since your commit 9422de3e953d0e60eb95f5430a9dd803eec1c6d7
> > > > "powerpc: Hardware breakpoints rewrite to handle non DABR breakpoint registers",
> > > > compiling linux fails with :
> > > >
> > > > cc1: warnings being treated as errors
> > > > arch/powerpc/kernel/ptrace.c: In function 'arch_ptrace':
> > > > arch/powerpc/kernel/ptrace.c:1450: warning: 'brk.len' is used uninitialized in this function
> > > > arch/powerpc/kernel/ptrace.c:1352: note: 'brk.len' was declared here
> > > >
> > > > could you look at that ?
> > >
> > > Sure.
> >
> > I use gcc-4.2.2, and my .config follows.
>
> I'm a bit lost.
>
> I don't have 4.2.2 (which is ancient BTW) and I can't hit this on
> 4.3,4.5 or 4.6 with your config. It compiles fine.
>
> Also:
>
> > arch/powerpc/kernel/ptrace.c:1450: warning: 'brk.len' is used uninitialized in this function
> > arch/powerpc/kernel/ptrace.c:1352: note: 'brk.len' was declared here
>
> These line numbers make no sense at all WRT v3.9-rc1. brk.len is neither
> declared or used in those lines:
those were the line numbers just after your commit
In 3.9-rc1 they are :
cc1: warnings being treated as errors
arch/powerpc/kernel/ptrace.c: In function 'arch_ptrace':
arch/powerpc/kernel/ptrace.c:1479: warning: 'brk.len' is used uninitialized in this function
arch/powerpc/kernel/ptrace.c:1381: note: 'brk.len' was declared here
if (child->thread.hw_brk.address)
return -ENOSPC;
1479: child->thread.hw_brk = brk;
return 1;
#endif /* !CONFIG_PPC_ADV_DEBUG_DVCS */
Philippe
^ permalink raw reply
* RE: [PATCH V4] powerpc/85xx: Add machine check handler to fix PCIe erratum on mpc85xx
From: David Laight @ 2013-03-07 10:04 UTC (permalink / raw)
To: Jia Hongtao-B38951, Wood Scott-B07421; +Cc: linuxppc-dev, Stuart Yoder
In-Reply-To: <412C8208B4A0464FA894C5F0C278CD5D01BFA1D0@039-SN1MPN1-002.039d.mgd.msft.net>
> In my understanding filling the register could warn the executing =
process
> an error occurred in some cases. But no way to fix the wrong behavior =
caused
> by the instruction lost. So let's say that filling the register may =
benefit
> a little.
IIRC the only ppc instructions that should be accessing PCIe space
are simple memory reads/writes, locked exchanges probably don't work.
writes will be async - so we are talking about memory reads.
> On the other side, we should not access to the addresses of unknown =
process
> in Linux kernel. We must get the instruction before filling the =
register.
> If the instruction is not in the cache we have to access to the =
unknown
> addresses to get it. For system security I think this is strictly =
forbidden.
Eh???
The kernel fault handler will know whether the fault is from kernel
or userspace (in which case it must be the current process), and will
almost certainly already have code that looks at the faulting =
instruction
sequence.
If the faulting code address is 'user', then the normal functions for
reading user addresses have to be used.
If the faulting address is 'kernel' it might be in an ISR - restricting
what can be done - but the instruction is definitely readable.
> Although I think filling the register have some advantages but it's =
should
> be forbidden for security reason.
I'm sure security would say exactly the opposite.
David
^ permalink raw reply
* Re: [PATCH 2/6] powerpc/fsl_pci: Store the platform device information corresponding to the pci controller.
From: Joerg Roedel @ 2013-03-07 10:37 UTC (permalink / raw)
To: Sethi Varun-B16395
Cc: Wood Scott-B07421, Stuart Yoder, linux-kernel@vger.kernel.org,
Yoder Stuart-B08248, iommu@lists.linux-foundation.org,
linuxppc-dev@lists.ozlabs.org
In-Reply-To: <C5ECD7A89D1DC44195F34B25E172658D3E74C7@039-SN2MPN1-013.039d.mgd.msft.net>
Yes, please base your patches on the latest upstream-tag. I will move my
tree to v3.9-rc1 soon, there are some fixes that need to go upstream.
On Thu, Mar 07, 2013 at 09:14:21AM +0000, Sethi Varun-B16395 wrote:
> Hi Joerg,
> I have to post the next version of my patchset, should I base it on top of 3.9-rc1?
> By when would you move the iommu git tree to 3.9-rc1?
>
> Regards
> Varun
>
> > -----Original Message-----
> > From: Kumar Gala [mailto:galak@kernel.crashing.org]
> > Sent: Thursday, February 28, 2013 9:15 PM
> > To: Sethi Varun-B16395
> > Cc: Joerg Roedel; Stuart Yoder; iommu@lists.linux-foundation.org;
> > linuxppc-dev@lists.ozlabs.org; linux-kernel@vger.kernel.org; Wood Scott-
> > B07421; Yoder Stuart-B08248
> > Subject: Re: [PATCH 2/6] powerpc/fsl_pci: Store the platform device
> > information corresponding to the pci controller.
> >
> >
> > On Feb 27, 2013, at 4:56 AM, Sethi Varun-B16395 wrote:
> >
> > > This patch is present in the "next branch" of linux ppc tree maintained
> > by Kumar Gala.
> > > Following is the commit id:
> > > 52c5affc545053d37c0b05224bbf70f5336caa20
> > >
> > > I am not sure if this would be part of 3.9-rc1.
> > >
> > > Regards
> > > varun
> >
> > This is now in Linus's tree so will be in 3.9-rc1
> >
> > - k
> >
>
>
^ permalink raw reply
* [PATCH 1/4] Device tree entry for Freescale TDM controller
From: Sandeep Singh @ 2013-03-07 11:27 UTC (permalink / raw)
To: linuxppc-dev, linux-arm-kernel; +Cc: Sandeep Singh, Poonam Aggrwal
Added dtsi file for Freescale TDM controller.
This controller is available on many Freescale SOCs like MPC8315, P1020, P1010,
P1022 and P1024
Signed-off-by: Sandeep Singh <Sandeep@freescale.com>
Signed-off-by: Poonam Aggrwal <poonam.aggrwal@freescale.com>
---
arch/powerpc/boot/dts/fsl/pq3-tdm1.0-0.dtsi | 42 +++++++++++++++++++++++++++
1 files changed, 42 insertions(+), 0 deletions(-)
create mode 100644 arch/powerpc/boot/dts/fsl/pq3-tdm1.0-0.dtsi
diff --git a/arch/powerpc/boot/dts/fsl/pq3-tdm1.0-0.dtsi b/arch/powerpc/boot/dts/fsl/pq3-tdm1.0-0.dtsi
new file mode 100644
index 0000000..e89f637
--- /dev/null
+++ b/arch/powerpc/boot/dts/fsl/pq3-tdm1.0-0.dtsi
@@ -0,0 +1,42 @@
+/*
+ * PQ3 TDM device tree stub [ controller @ offset 0x16000 ]
+ *
+ * Copyright 2012 Freescale Semiconductor Inc.
+ *
+ * Redistribution and use in source and binary forms, with or without
+ * modification, are permitted provided that the following conditions are met:
+ * * Redistributions of source code must retain the above copyright
+ * notice, this list of conditions and the following disclaimer.
+ * * Redistributions in binary form must reproduce the above copyright
+ * notice, this list of conditions and the following disclaimer in the
+ * documentation and/or other materials provided with the distribution.
+ * * Neither the name of Freescale Semiconductor nor the
+ * names of its contributors may be used to endorse or promote products
+ * derived from this software without specific prior written permission.
+ *
+ *
+ * ALTERNATIVELY, this software may be distributed under the terms of the
+ * GNU General Public License ("GPL") as published by the Free Software
+ * Foundation, either version 2 of that License or (at your option) any
+ * later version.
+ *
+ * THIS SOFTWARE IS PROVIDED BY Freescale Semiconductor ``AS IS'' AND ANY
+ * EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED
+ * WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE
+ * DISCLAIMED. IN NO EVENT SHALL Freescale Semiconductor BE LIABLE FOR ANY
+ * DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES
+ * (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES;
+ * LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND
+ * ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
+ * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS
+ * SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
+ */
+
+tdm@16000 {
+ compatible = "fsl,tdm1.0";
+ reg = <0x16000 0x200 0x2c000 0x2000>;
+ clock-frequency = <0>;
+ tdm_tx_clk = <2048000>;
+ interrupts = <62 8 0 0>;
+ fsl,max-time-slots = <128>;
+};
--
1.7.6.GIT
^ permalink raw reply related
* [PATCH 2/4] Device Tree bindings for Freescale TDM controller
From: Sandeep Singh @ 2013-03-07 11:27 UTC (permalink / raw)
To: linuxppc-dev, linux-arm-kernel; +Cc: Sandeep Singh, Poonam Aggrwal
In-Reply-To: <1362655668-26721-1-git-send-email-Sandeep@freescale.com>
This controller is available on many Freescale SOCs like MPC8315, P1020, P1010,
P1022 and P1024
Signed-off-by: Sandeep Singh <Sandeep@freescale.com>
Signed-off-by: Poonam Aggrwal <poonam.aggrwal@freescale.com>
---
Documentation/devicetree/bindings/tdm/fsl-tdm.txt | 65 +++++++++++++++++++++
1 files changed, 65 insertions(+), 0 deletions(-)
create mode 100644 Documentation/devicetree/bindings/tdm/fsl-tdm.txt
diff --git a/Documentation/devicetree/bindings/tdm/fsl-tdm.txt b/Documentation/devicetree/bindings/tdm/fsl-tdm.txt
new file mode 100644
index 0000000..1258b89
--- /dev/null
+++ b/Documentation/devicetree/bindings/tdm/fsl-tdm.txt
@@ -0,0 +1,65 @@
+=====================================================================
+TDM Device Tree Binding
+Copyright (C) 2012 Freescale Semiconductor Inc.
+
+NOTE: The bindings described in this document are preliminary
+and subject to change.
+
+=====================================================================
+TDM (Time Division Multiplexing)
+
+DESCRIPTION
+
+The TDM is full duplex serial port designed to allow various devices including
+digital signal processors (DSPs) to communicate with a variety of serial devices
+including industry standard framers, codecs, other DSPs and microprocessors.
+
+The below properties describe the device tree bindings for Freescale TDM
+controller.
+This TDM controller is available on various Freescale Processors like
+MPC8313, P1020, P1022 and P1010.
+
+PROPERTIES
+
+ - compatible
+ Usage: required
+ Value type: <string>
+ Definition: Should contain "fsl,tdm1.0".
+
+ - reg
+ Usage: required
+ Definition: A standard property. The first reg specifier describes the
+ TDM registers, and the second describes the TDM DMAC registers.
+
+ - clock-frequency
+ Usage: optional
+ Value type: <u32 or u64>
+ Definition: The frequency at which the TDM block is operating.
+
+ - interrupts
+ Usage: required
+ Definition: Definition: Two interrupt specifiers. The first is TDM
+ error, and the second is TDM EMAC.
+
+ - phy-handle
+ Usage: optional
+ Value type: <phandle>
+ Definition: Phandle of the line controller node or framer node eg. SLIC,
+ E1/T1 etc.
+
+ - fsl,max-time-slots
+ Usage: required
+ Value type: <u32>
+ Definition: Maximum number of 8-bit time slots in one TDM frame.
+ This is the maximum number which TDM hardware supports.
+
+EXAMPLE
+
+ tdm@16000 {
+ compatible = "fsl,tdm1.0";
+ reg = <0x16000 0x200 0x2c000 0x2000>;
+ clock-frequency = <0>;
+ interrupts = <16 8 62 8>;
+ phy-handle = <&zarlink1>;
+ fsl,max-time-slots = <128>;
+ };
--
1.7.6.GIT
^ permalink raw reply related
* [PATCH 3/4] TDM Device Tree entries for various Freescale Platforms
From: Sandeep Singh @ 2013-03-07 11:27 UTC (permalink / raw)
To: linuxppc-dev, linux-arm-kernel; +Cc: Sandeep Singh, Poonam Aggrwal
In-Reply-To: <1362655668-26721-1-git-send-email-Sandeep@freescale.com>
P1010RDB, P1020RDB, P1020MBG-PC, P1022DS, P1020RDB-PC and P1024RDB
In this Patch:
1. TDM node included in <silicon>.dtsi files.
2. Disabled TDM in 36bit configurations because of limitations
in TDM hardware block, details mentioned below.
Details of 36bit h/w limitaion:
---------------------------------
TDM DMAC IP does not support more than 32b address. To address memory regions
more than 4GB, 4 bits of address were provided in GUTs, which are appended to
txns initiated by TDM DMAC. These 4 bits are appended irrespective of the
region addressed. When TDM works in DMA mode, the DMA need to access DDR as
well as TDM FIFO in CCSR space. So this poses a restriction that if memory
region above 4GB need to be accessed, CCSR space should also be mapped into
that 4GB region.
In this case DDR is at at first 4G (starting from 0) and CCSR is at
different 4G (0xfffe00000), hence the issue.
Signed-off-by: Sandeep Singh <Sandeep@freescale.com>
Signed-off-by: Poonam Aggrwal <poonam.aggrwal@freescale.com>
---
arch/powerpc/boot/dts/fsl/p1010si-post.dtsi | 3 ++-
arch/powerpc/boot/dts/fsl/p1020si-post.dtsi | 1 +
arch/powerpc/boot/dts/fsl/p1022si-post.dtsi | 1 +
arch/powerpc/boot/dts/p1010rdb_36b.dts | 3 +++
arch/powerpc/boot/dts/p1020mbg-pc_36b.dts | 3 +++
arch/powerpc/boot/dts/p1020rdb-pc_36b.dts | 3 +++
arch/powerpc/boot/dts/p1020rdb_36b.dts | 3 +++
arch/powerpc/boot/dts/p1022ds_36b.dts | 3 +++
arch/powerpc/boot/dts/p1024rdb_36b.dts | 3 +++
9 files changed, 22 insertions(+), 1 deletions(-)
diff --git a/arch/powerpc/boot/dts/fsl/p1010si-post.dtsi b/arch/powerpc/boot/dts/fsl/p1010si-post.dtsi
index 0bde9ee..15c74a2 100644
--- a/arch/powerpc/boot/dts/fsl/p1010si-post.dtsi
+++ b/arch/powerpc/boot/dts/fsl/p1010si-post.dtsi
@@ -1,7 +1,7 @@
/*
* P1010/P1014 Silicon/SoC Device Tree Source (post include)
*
- * Copyright 2011 Freescale Semiconductor Inc.
+ * Copyright 2011-2012 Freescale Semiconductor Inc.
*
* Redistribution and use in source and binary forms, with or without
* modification, are permitted provided that the following conditions are met:
@@ -132,6 +132,7 @@
/include/ "pq3-gpio-0.dtsi"
/include/ "pq3-sata2-0.dtsi"
/include/ "pq3-sata2-1.dtsi"
+/include/ "pq3-tdm1.0-0.dtsi"
can0: can@1c000 {
compatible = "fsl,p1010-flexcan";
diff --git a/arch/powerpc/boot/dts/fsl/p1020si-post.dtsi b/arch/powerpc/boot/dts/fsl/p1020si-post.dtsi
index 68cc5e7..684f664 100644
--- a/arch/powerpc/boot/dts/fsl/p1020si-post.dtsi
+++ b/arch/powerpc/boot/dts/fsl/p1020si-post.dtsi
@@ -131,6 +131,7 @@
};
/include/ "pq3-gpio-0.dtsi"
+/include/ "pq3-tdm1.0-0.dtsi"
L2: l2-cache-controller@20000 {
compatible = "fsl,p1020-l2-cache-controller";
diff --git a/arch/powerpc/boot/dts/fsl/p1022si-post.dtsi b/arch/powerpc/boot/dts/fsl/p1022si-post.dtsi
index 06216b8..4016e45 100644
--- a/arch/powerpc/boot/dts/fsl/p1022si-post.dtsi
+++ b/arch/powerpc/boot/dts/fsl/p1022si-post.dtsi
@@ -190,6 +190,7 @@
fsl,fifo-depth = <15>;
};
+/include/ "pq3-tdm1.0-0.dtsi"
/include/ "pq3-sata2-0.dtsi"
/include/ "pq3-sata2-1.dtsi"
diff --git a/arch/powerpc/boot/dts/p1010rdb_36b.dts b/arch/powerpc/boot/dts/p1010rdb_36b.dts
index 64776f4..e159b42 100644
--- a/arch/powerpc/boot/dts/p1010rdb_36b.dts
+++ b/arch/powerpc/boot/dts/p1010rdb_36b.dts
@@ -52,6 +52,9 @@
board_soc: soc: soc@fffe00000 {
ranges = <0x0 0xf 0xffe00000 0x100000>;
+ tdm@16000 {
+ status = "disabled";
+ };
};
pci0: pcie@fffe09000 {
diff --git a/arch/powerpc/boot/dts/p1020mbg-pc_36b.dts b/arch/powerpc/boot/dts/p1020mbg-pc_36b.dts
index 9e9f401..416e1a7 100644
--- a/arch/powerpc/boot/dts/p1020mbg-pc_36b.dts
+++ b/arch/powerpc/boot/dts/p1020mbg-pc_36b.dts
@@ -52,6 +52,9 @@
soc: soc@fffe00000 {
ranges = <0x0 0xf 0xffe00000 0x100000>;
+ tdm@16000 {
+ status = "disabled";
+ };
};
pci0: pcie@fffe09000 {
diff --git a/arch/powerpc/boot/dts/p1020rdb-pc_36b.dts b/arch/powerpc/boot/dts/p1020rdb-pc_36b.dts
index 5237da7..a1861d6 100644
--- a/arch/powerpc/boot/dts/p1020rdb-pc_36b.dts
+++ b/arch/powerpc/boot/dts/p1020rdb-pc_36b.dts
@@ -53,6 +53,9 @@
soc: soc@fffe00000 {
ranges = <0x0 0xf 0xffe00000 0x100000>;
+ tdm@16000 {
+ status = "disabled";
+ };
};
pci0: pcie@fffe09000 {
diff --git a/arch/powerpc/boot/dts/p1020rdb_36b.dts b/arch/powerpc/boot/dts/p1020rdb_36b.dts
index bdbdb60..7bac196 100644
--- a/arch/powerpc/boot/dts/p1020rdb_36b.dts
+++ b/arch/powerpc/boot/dts/p1020rdb_36b.dts
@@ -29,6 +29,9 @@
board_soc: soc: soc@fffe00000 {
ranges = <0x0 0xf 0xffe00000 0x100000>;
+ tdm@16000 {
+ status = "disabled";
+ };
};
pci0: pcie@fffe09000 {
diff --git a/arch/powerpc/boot/dts/p1022ds_36b.dts b/arch/powerpc/boot/dts/p1022ds_36b.dts
index f7aacce..024ea40 100644
--- a/arch/powerpc/boot/dts/p1022ds_36b.dts
+++ b/arch/powerpc/boot/dts/p1022ds_36b.dts
@@ -51,6 +51,9 @@
board_soc: soc: soc@fffe00000 {
ranges = <0x0 0xf 0xffe00000 0x100000>;
+ tdm@16000 {
+ status = "disabled";
+ };
};
pci0: pcie@fffe09000 {
diff --git a/arch/powerpc/boot/dts/p1024rdb_36b.dts b/arch/powerpc/boot/dts/p1024rdb_36b.dts
index 3656825..b113229 100644
--- a/arch/powerpc/boot/dts/p1024rdb_36b.dts
+++ b/arch/powerpc/boot/dts/p1024rdb_36b.dts
@@ -49,6 +49,9 @@
soc: soc@fffe00000 {
ranges = <0x0 0xf 0xffe00000 0x100000>;
+ tdm@16000 {
+ status = "disabled";
+ };
};
pci0: pcie@fffe09000 {
--
1.7.6.GIT
^ permalink raw reply related
* [PATCH 4/4] Added device tree entries for Legerity SLIC node on various Freescale Platforms
From: Sandeep Singh @ 2013-03-07 11:27 UTC (permalink / raw)
To: linuxppc-dev, linux-arm-kernel; +Cc: Sandeep Singh, Poonam Aggrwal
In-Reply-To: <1362655668-26721-1-git-send-email-Sandeep@freescale.com>
SLIC device is connected on SPI bus on these platforms
Signed-off-by: Sandeep Singh <Sandeep@freescale.com>
Signed-off-by: Poonam Aggrwal <poonam.aggrwal@freescale.com>
---
arch/powerpc/boot/dts/p1010rdb.dtsi | 13 ++++++++++++-
arch/powerpc/boot/dts/p1020mbg-pc.dtsi | 19 +++++++++++++++++++
arch/powerpc/boot/dts/p1020rdb-pc.dtsi | 18 ++++++++++++++++++
arch/powerpc/boot/dts/p1020rdb.dtsi | 17 +++++++++++++++++
arch/powerpc/boot/dts/p1022ds.dtsi | 17 +++++++++++++++++
arch/powerpc/boot/dts/p1024rdb.dtsi | 18 ++++++++++++++++++
6 files changed, 101 insertions(+), 1 deletions(-)
diff --git a/arch/powerpc/boot/dts/p1010rdb.dtsi b/arch/powerpc/boot/dts/p1010rdb.dtsi
index ec7c27a..b0a5908 100644
--- a/arch/powerpc/boot/dts/p1010rdb.dtsi
+++ b/arch/powerpc/boot/dts/p1010rdb.dtsi
@@ -1,7 +1,7 @@
/*
* P1010 RDB Device Tree Source stub (no addresses or top-level ranges)
*
- * Copyright 2011 Freescale Semiconductor Inc.
+ * Copyright 2011-2012 Freescale Semiconductor Inc.
*
* Redistribution and use in source and binary forms, with or without
* modification, are permitted provided that the following conditions are met:
@@ -184,8 +184,19 @@
label = "SPI Flash JFFS2 RFS";
};
};
+
+ tdm_phy_0: slic@0 {
+ compatible = "zarlink,le88266", "tdm-phy-slic";
+ reg = <0>;
+ spi-max-frequency = <8000000>;
+ };
};
+ tdm@16000 {
+ num-phy = <1>;
+ phy-handle = <&tdm_phy_0>;
+ };
+
usb@22000 {
phy_type = "utmi";
dr_mode = "host";
diff --git a/arch/powerpc/boot/dts/p1020mbg-pc.dtsi b/arch/powerpc/boot/dts/p1020mbg-pc.dtsi
index a24699c..9119387 100644
--- a/arch/powerpc/boot/dts/p1020mbg-pc.dtsi
+++ b/arch/powerpc/boot/dts/p1020mbg-pc.dtsi
@@ -93,6 +93,25 @@
};
};
+ spi@7000 {
+ tdm_phy_0: slic@0 {
+ compatible = "zarlink,le88266", "tdm-phy-slic";
+ reg = <1>;
+ spi-max-frequency = <8000000>;
+ };
+
+ tdm_phy_1: slic@1 {
+ compatible = "zarlink,le88266", "tdm-phy-slic";
+ reg = <2>;
+ spi-max-frequency = <8000000>;
+ };
+ };
+
+ tdm@16000 {
+ num-phy = <2>;
+ phy-handle = <&tdm_phy_0>, <&tdm_phy_1>;
+ };
+
mdio@24000 {
phy0: ethernet-phy@0 {
interrupts = <3 1 0 0>;
diff --git a/arch/powerpc/boot/dts/p1020rdb-pc.dtsi b/arch/powerpc/boot/dts/p1020rdb-pc.dtsi
index c952cd3..3a7fdd9 100644
--- a/arch/powerpc/boot/dts/p1020rdb-pc.dtsi
+++ b/arch/powerpc/boot/dts/p1020rdb-pc.dtsi
@@ -186,6 +186,24 @@
label = "file system jffs2";
};
};
+
+ tdm_phy_0: slic@0 {
+ compatible = "zarlink,le88266", "tdm-phy-slic";
+ reg = <1>;
+ spi-max-frequency = <8000000>;
+ };
+
+ tdm_phy_1: slic@1 {
+ compatible = "zarlink,le88266", "tdm-phy-slic";
+ reg = <2>;
+ spi-max-frequency = <8000000>;
+ };
+
+ };
+
+ tdm@16000 {
+ num-phy = <2>;
+ phy-handle = <&tdm_phy_0>, <&tdm_phy_1>;
};
usb@22000 {
diff --git a/arch/powerpc/boot/dts/p1020rdb.dtsi b/arch/powerpc/boot/dts/p1020rdb.dtsi
index 1fb7e0e..f1a3431 100644
--- a/arch/powerpc/boot/dts/p1020rdb.dtsi
+++ b/arch/powerpc/boot/dts/p1020rdb.dtsi
@@ -186,6 +186,23 @@
label = "file system jffs2";
};
};
+
+ tdm_phy_0: slic@0 {
+ compatible = "zarlink,le88266", "tdm-phy-slic";
+ reg = <1>;
+ spi-max-frequency = <8000000>;
+ };
+
+ tdm_phy_1: slic@1 {
+ compatible = "zarlink,le88266", "tdm-phy-slic";
+ reg = <2>;
+ spi-max-frequency = <8000000>;
+ };
+ };
+
+ tdm@16000 {
+ num-phy = <2>;
+ phy-handle = <&tdm_phy_0>, <&tdm_phy_1>;
};
usb@22000 {
diff --git a/arch/powerpc/boot/dts/p1022ds.dtsi b/arch/powerpc/boot/dts/p1022ds.dtsi
index 873da35..af2d4e1 100644
--- a/arch/powerpc/boot/dts/p1022ds.dtsi
+++ b/arch/powerpc/boot/dts/p1022ds.dtsi
@@ -183,6 +183,18 @@
reg = <0x00700000 0x00900000>;
};
};
+
+ tdm_phy_0: slic@0 {
+ compatible = "zarlink,le88266", "tdm-phy-slic";
+ reg = <1>;
+ spi-max-frequency = <8000000>;
+ };
+
+ tdm_phy_1: slic@1 {
+ compatible = "zarlink,le88266", "tdm-phy-slic";
+ reg = <2>;
+ spi-max-frequency = <8000000>;
+ };
};
ssi@15000 {
@@ -191,6 +203,11 @@
fsl,ssi-asynchronous;
};
+ tdm@16000 {
+ num-phy = <2>;
+ phy-handle = <&tdm_phy_0>, <&tdm_phy_1>;
+ };
+
usb@22000 {
phy_type = "ulpi";
};
diff --git a/arch/powerpc/boot/dts/p1024rdb.dtsi b/arch/powerpc/boot/dts/p1024rdb.dtsi
index b05dcb4..cec36a3 100644
--- a/arch/powerpc/boot/dts/p1024rdb.dtsi
+++ b/arch/powerpc/boot/dts/p1024rdb.dtsi
@@ -164,6 +164,19 @@
label = "SPI JFFS2 RFS";
};
};
+
+ tdm_phy_0: slic@0 {
+ compatible = "zarlink,le88266", "tdm-phy-slic";
+ reg = <1>;
+ spi-max-frequency = <8000000>;
+ };
+
+ tdm_phy_1: slic@1 {
+ compatible = "zarlink,le88266", "tdm-phy-slic";
+ reg = <2>;
+ spi-max-frequency = <8000000>;
+ };
+
};
i2c@3000 {
@@ -173,6 +186,11 @@
};
};
+ tdm@16000 {
+ num-phy = <2>;
+ phy-handle = <&tdm_phy_0>, <&tdm_phy_1>;
+ };
+
usb@22000 {
phy_type = "ulpi";
};
--
1.7.6.GIT
^ permalink raw reply related
* Re: [PATCH 1/4] Device tree entry for Freescale TDM controller
From: Russell King - ARM Linux @ 2013-03-07 13:34 UTC (permalink / raw)
To: Sandeep Singh; +Cc: Poonam Aggrwal, linuxppc-dev, linux-arm-kernel
In-Reply-To: <1362655668-26721-1-git-send-email-Sandeep@freescale.com>
I know I'm probably missing something... but... why are these patches
copied to the ARM list? They appear to be PowerPC patches.
On Thu, Mar 07, 2013 at 04:57:45PM +0530, Sandeep Singh wrote:
> Added dtsi file for Freescale TDM controller.
> This controller is available on many Freescale SOCs like MPC8315, P1020, P1010,
> P1022 and P1024
> Signed-off-by: Sandeep Singh <Sandeep@freescale.com>
> Signed-off-by: Poonam Aggrwal <poonam.aggrwal@freescale.com>
> ---
> arch/powerpc/boot/dts/fsl/pq3-tdm1.0-0.dtsi | 42 +++++++++++++++++++++++++++
> 1 files changed, 42 insertions(+), 0 deletions(-)
> create mode 100644 arch/powerpc/boot/dts/fsl/pq3-tdm1.0-0.dtsi
>
> diff --git a/arch/powerpc/boot/dts/fsl/pq3-tdm1.0-0.dtsi b/arch/powerpc/boot/dts/fsl/pq3-tdm1.0-0.dtsi
> new file mode 100644
> index 0000000..e89f637
> --- /dev/null
> +++ b/arch/powerpc/boot/dts/fsl/pq3-tdm1.0-0.dtsi
> @@ -0,0 +1,42 @@
> +/*
> + * PQ3 TDM device tree stub [ controller @ offset 0x16000 ]
> + *
> + * Copyright 2012 Freescale Semiconductor Inc.
> + *
> + * Redistribution and use in source and binary forms, with or without
> + * modification, are permitted provided that the following conditions are met:
> + * * Redistributions of source code must retain the above copyright
> + * notice, this list of conditions and the following disclaimer.
> + * * Redistributions in binary form must reproduce the above copyright
> + * notice, this list of conditions and the following disclaimer in the
> + * documentation and/or other materials provided with the distribution.
> + * * Neither the name of Freescale Semiconductor nor the
> + * names of its contributors may be used to endorse or promote products
> + * derived from this software without specific prior written permission.
> + *
> + *
> + * ALTERNATIVELY, this software may be distributed under the terms of the
> + * GNU General Public License ("GPL") as published by the Free Software
> + * Foundation, either version 2 of that License or (at your option) any
> + * later version.
> + *
> + * THIS SOFTWARE IS PROVIDED BY Freescale Semiconductor ``AS IS'' AND ANY
> + * EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED
> + * WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE
> + * DISCLAIMED. IN NO EVENT SHALL Freescale Semiconductor BE LIABLE FOR ANY
> + * DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES
> + * (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES;
> + * LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND
> + * ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
> + * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS
> + * SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
> + */
> +
> +tdm@16000 {
> + compatible = "fsl,tdm1.0";
> + reg = <0x16000 0x200 0x2c000 0x2000>;
> + clock-frequency = <0>;
> + tdm_tx_clk = <2048000>;
> + interrupts = <62 8 0 0>;
> + fsl,max-time-slots = <128>;
> +};
> --
> 1.7.6.GIT
>
>
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply
* Re: [PATCH] mmc: sdhci-pltfm: Fix timeout on t4240's sdhci controller
From: Gala Kumar-B11780 @ 2013-03-07 16:30 UTC (permalink / raw)
To: Lan Chunhe-B25806; +Cc: <linuxppc-dev@lists.ozlabs.org>
In-Reply-To: <1362643535-2377-1-git-send-email-Chunhe.Lan@freescale.com>
On Mar 7, 2013, at 2:05 AM, Chunhe Lan wrote:
> This patch fixes timeout problems on t4240's sdhci controller:
>=20
> mmc0: Too large timeout requested for CMD25!
> mmc0: Too large timeout requested for CMD25!
> mmc0: Too large timeout requested for CMD25!
>=20
> Signed-off-by: Chunhe Lan <Chunhe.Lan@freescale.com>
> ---
> drivers/mmc/host/sdhci-pltfm.c | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>=20
> diff --git a/drivers/mmc/host/sdhci-pltfm.c b/drivers/mmc/host/sdhci-pltf=
m.c
> index 3145a78..9db7b12 100644
> --- a/drivers/mmc/host/sdhci-pltfm.c
> +++ b/drivers/mmc/host/sdhci-pltfm.c
> @@ -94,6 +94,7 @@ void sdhci_get_of_property(struct platform_device *pdev=
)
>=20
> if (of_device_is_compatible(np, "fsl,p2020-esdhc") ||
> of_device_is_compatible(np, "fsl,p1010-esdhc") ||
> + of_device_is_compatible(np, "fsl,t4240-esdhc") ||
> of_device_is_compatible(np, "fsl,mpc8536-esdhc"))
> host->quirks |=3D SDHCI_QUIRK_BROKEN_TIMEOUT_VAL;
>=20
> --=20
> 1.7.6.5
>=20
Why does this occur? Is it a board issue? Is it a silicon issue? Is it d=
ue to some erratum? Why T4 only?
- k=
^ permalink raw reply
* Re: [PATCH][V2] powerpc: remove the PPC_CLOCK dependency
From: Kumar Gala @ 2013-03-07 16:32 UTC (permalink / raw)
To: <Yuantian.Tang@freescale.com>; +Cc: linuxppc-dev
In-Reply-To: <1362561364-16073-1-git-send-email-Yuantian.Tang@freescale.com>
On Mar 6, 2013, at 3:16 AM, <Yuantian.Tang@freescale.com> =
<Yuantian.Tang@freescale.com> wrote:
> From: Tang Yuantian <Yuantian.Tang@freescale.com>
>=20
> config FSL_SOC and CPM do not really depend on PPC_CLOCK. So remove =
it.
> PPC_CLOCK also keeps powerpc archtecture from supporting COMMON_CLK.
>=20
> Signed-off-by: Tang Yuantian <Yuantian.Tang@freescale.com>
> ---
> v2: correct the title
>=20
> arch/powerpc/Kconfig | 1 -
> arch/powerpc/platforms/Kconfig | 1 -
> 2 files changed, 0 insertions(+), 2 deletions(-)
Does the Flexcan driver use this?
- k
>=20
> diff --git a/arch/powerpc/Kconfig b/arch/powerpc/Kconfig
> index 352f416..383485b 100644
> --- a/arch/powerpc/Kconfig
> +++ b/arch/powerpc/Kconfig
> @@ -655,7 +655,6 @@ config SBUS
> config FSL_SOC
> bool
> select HAVE_CAN_FLEXCAN if NET && CAN
> - select PPC_CLOCK
>=20
> config FSL_PCI
> bool
> diff --git a/arch/powerpc/platforms/Kconfig =
b/arch/powerpc/platforms/Kconfig
> index e7a896a..aba81cd 100644
> --- a/arch/powerpc/platforms/Kconfig
> +++ b/arch/powerpc/platforms/Kconfig
> @@ -343,7 +343,6 @@ config FSL_ULI1575
>=20
> config CPM
> bool
> - select PPC_CLOCK
>=20
> config OF_RTC
> bool
> --=20
> 1.7.0.4
>=20
^ permalink raw reply
* Re: [PATCH V4] powerpc/85xx: Add machine check handler to fix PCIe erratum on mpc85xx
From: Scott Wood @ 2013-03-07 16:37 UTC (permalink / raw)
To: Jia Hongtao-B38951
Cc: Wood Scott-B07421, David Laight, linuxppc-dev@lists.ozlabs.org,
Stuart Yoder
In-Reply-To: <412C8208B4A0464FA894C5F0C278CD5D01BFA1D0@039-SN1MPN1-002.039d.mgd.msft.net>
On 03/07/2013 02:06:05 AM, Jia Hongtao-B38951 wrote:
> Here is the ideas from Scott:
> "
> > + if (is_in_pci_mem_space(addr)) {
> > + inst =3D *(unsigned int *)regs->nip;
>=20
> Be careful about taking a fault here. A simple TLB miss should be =20
> safe
> given that we shouldn't be accessing PCIe in the middle of exception
> code, but what if the mapping has gone away (e.g. a userspace driver =20
> had
> its code munmap()ed or swapped out)? What if permissions allow =20
> execute
> but not read (not sure if Linux will allow this, but the hardware =20
> does)?
>=20
> What if it happened in a KVM guest? You can't access guest addresses
> directly.
> "
That means you need to be careful about how you read the instruction, =20
not that you shouldn't do it at all.
-Scott=
^ permalink raw reply
* Re: [PATCH 5/8] powerpc/fsl-booke: Add initial silicon device tree for
From: Kumar Gala @ 2013-03-07 17:09 UTC (permalink / raw)
To: Scott Wood; +Cc: linuxppc-dev
In-Reply-To: <1362528955.25308.12@snotra>
On Mar 5, 2013, at 6:15 PM, Scott Wood wrote:
> On 03/05/2013 05:15:57 PM, Kumar Gala wrote:
>> Enable a baseline T4240 SoC to boot. There are several things =
missing
>> from the device trees for T4240:
>> * Thread support on e6500
>=20
> Why did threads get removed from the device tree? It's supposed to =
describe hardware, not what Linux currently supports.
will fix, was concerned if we'd be able to boot if they exited
>=20
>> * Proper PAMU topology information
>> * DPAA related nodes (Qman, Bman, Fman, Rman, DCE)
>> * Prefetch Manager
>> * Thermal monitor unit
>> * Interlaken
>=20
> The dts should be marked preliminary somehow -- we really should get =
out of the habit of letting device nodes trickle in as drivers get =
added.
agreed but forward progress always gets in the way
>=20
>> +/* controller at 0x240000 */
>> +&pci0 {
>> + compatible =3D "fsl,t4240-pcie", "fsl,qoriq-pcie-v3.0";
>=20
> We have a version register -- do we really need to keep sticking the =
version number in the compatible? Note that we've had device trees that =
specified the version incorrectly in the past.
>=20
>> + device_type =3D "pci";
>> + #size-cells =3D <2>;
>> + #address-cells =3D <3>;
>> + bus-range =3D <0x0 0xff>;
>> + clock-frequency =3D <33333333>;
>=20
> This clock-frequency is not correct (I doubt it's needed at all).
I can zero the field, but its spec'd by pci binding
>=20
>> + PowerPC,e6500@1 {
>> + device_type =3D "cpu";
>> + reg =3D <2>;
>> + next-level-cache =3D <&L2_1>;
>> + };
>> + PowerPC,e6500@2 {
>> + device_type =3D "cpu";
>> + reg =3D <4>;
>> + next-level-cache =3D <&L2_1>;
>> + };
>> + PowerPC,e6500@3 {
>> + device_type =3D "cpu";
>> + reg =3D <6>;
>> + next-level-cache =3D <&L2_1>;
>> + };
>> +
>> + PowerPC,e6500@4 {
>> + device_type =3D "cpu";
>> + reg =3D <8>;
>> + next-level-cache =3D <&L2_2>;
>> + };
>=20
> Inconsistent whitespace.
will kill the whitespace.
> As usual, the pre/post split is unnecessary. Everything in it can go =
in post.
>=20
> -Scott
^ permalink raw reply
* Re: [PATCH 5/8] powerpc/fsl-booke: Add initial silicon device tree for
From: Scott Wood @ 2013-03-07 17:47 UTC (permalink / raw)
To: Kumar Gala; +Cc: linuxppc-dev
In-Reply-To: <FFA4082B-0C61-43F6-BB84-2C5A25476814@kernel.crashing.org>
On 03/07/2013 11:09:50 AM, Kumar Gala wrote:
>=20
> On Mar 5, 2013, at 6:15 PM, Scott Wood wrote:
>=20
> > On 03/05/2013 05:15:57 PM, Kumar Gala wrote:
> >> Enable a baseline T4240 SoC to boot. There are several things =20
> missing
> >> from the device trees for T4240:
> >> * Thread support on e6500
> >
> > Why did threads get removed from the device tree? It's supposed to =20
> describe hardware, not what Linux currently supports.
>=20
> will fix, was concerned if we'd be able to boot if they exited
I don't think it'd be a problem (and if it is, then fix Linux).
> >> + device_type =3D "pci";
> >> + #size-cells =3D <2>;
> >> + #address-cells =3D <3>;
> >> + bus-range =3D <0x0 0xff>;
> >> + clock-frequency =3D <33333333>;
> >
> > This clock-frequency is not correct (I doubt it's needed at all).
>=20
> I can zero the field, but its spec'd by pci binding
If we aren't going to put a correct value in, is zero better than =20
omitting it entirely?
There are other properties in the PCI binding that we don't have, such =20
as slot-names. I don't see any language in the PCI binding that says =20
one is required but the other isn't.
And shouldn't we be using the PCI express binding (device_type =3D =20
"pciex", or just get rid of it since this isn't real OF)?
-Scott=
^ permalink raw reply
* Re: [PATCH 5/8] powerpc/fsl-booke: Add initial silicon device tree for
From: Kumar Gala @ 2013-03-07 19:53 UTC (permalink / raw)
To: Scott Wood; +Cc: linuxppc-dev
In-Reply-To: <1362678470.23227.5@snotra>
On Mar 7, 2013, at 11:47 AM, Scott Wood wrote:
> On 03/07/2013 11:09:50 AM, Kumar Gala wrote:
>> On Mar 5, 2013, at 6:15 PM, Scott Wood wrote:
>> > On 03/05/2013 05:15:57 PM, Kumar Gala wrote:
>> >> Enable a baseline T4240 SoC to boot. There are several things =
missing
>> >> from the device trees for T4240:
>> >> * Thread support on e6500
>> >
>> > Why did threads get removed from the device tree? It's supposed to =
describe hardware, not what Linux currently supports.
>> will fix, was concerned if we'd be able to boot if they exited
>=20
> I don't think it'd be a problem (and if it is, then fix Linux).
looks fine, so I'll add them in v2 patch.
>=20
>> >> + device_type =3D "pci";
>> >> + #size-cells =3D <2>;
>> >> + #address-cells =3D <3>;
>> >> + bus-range =3D <0x0 0xff>;
>> >> + clock-frequency =3D <33333333>;
>> >
>> > This clock-frequency is not correct (I doubt it's needed at all).
>> I can zero the field, but its spec'd by pci binding
>=20
> If we aren't going to put a correct value in, is zero better than =
omitting it entirely?
>=20
> There are other properties in the PCI binding that we don't have, such =
as slot-names. I don't see any language in the PCI binding that says =
one is required but the other isn't.
>=20
> And shouldn't we be using the PCI express binding (device_type =3D =
"pciex", or just get rid of it since this isn't real OF)?
I'll drop clock-frequency since we dont use it.
- k
^ permalink raw reply
* [PATCH 5/8 v2] powerpc/fsl-booke: Add initial silicon device tree for
From: Kumar Gala @ 2013-03-07 19:58 UTC (permalink / raw)
To: linuxppc-dev
Enable a baseline T4240 SoC to boot. There are several things missing
from the device trees for T4240:
* Proper PAMU topology information
* DPAA related nodes (Qman, Bman, Fman, Rman, DCE)
* Prefetch Manager
* Thermal monitor unit
* Interlaken
Signed-off-by: Roy Zang <tie-fei.zang@freescale.com>
Signed-off-by: Minghuan Lian <Minghuan.Lian@freescale.com>
Signed-off-by: Haiying Wang <Haiying.Wang@freescale.com>
Signed-off-by: Andy Fleming <afleming@freescale.com>
Signed-off-by: Prabhakar Kushwaha <prabhakar@freescale.com>
Signed-off-by: York Sun <yorksun@freescale.com>
Signed-off-by: Vakul Garg <vakul@freescale.com>
Signed-off-by: Tang Yuantian <Yuantian.Tang@freescale.com>
Signed-off-by: Zhao Chenhui <chenhui.zhao@freescale.com>
Signed-off-by: Li Yang <leoli@freescale.com>
Signed-off-by: Ramneek Mehresh <ramneek.mehresh@freescale.com>
Signed-off-by: Laurentiu Tudor <Laurentiu.Tudor@freescale.com>
Signed-off-by: Kumar Gala <galak@kernel.crashing.org>
---
* Added thread ids to cpu nodes
* removed clock-frequency from PCI nodes as we dont use it
arch/powerpc/boot/dts/fsl/qoriq-gpio-1.dtsi | 41 ++++
arch/powerpc/boot/dts/fsl/qoriq-gpio-2.dtsi | 41 ++++
arch/powerpc/boot/dts/fsl/qoriq-gpio-3.dtsi | 41 ++++
arch/powerpc/boot/dts/fsl/t4240si-post.dtsi | 307 +++++++++++++++++++++++++++
arch/powerpc/boot/dts/fsl/t4240si-pre.dtsi | 127 +++++++++++
5 files changed, 557 insertions(+)
create mode 100644 arch/powerpc/boot/dts/fsl/qoriq-gpio-1.dtsi
create mode 100644 arch/powerpc/boot/dts/fsl/qoriq-gpio-2.dtsi
create mode 100644 arch/powerpc/boot/dts/fsl/qoriq-gpio-3.dtsi
create mode 100644 arch/powerpc/boot/dts/fsl/t4240si-post.dtsi
create mode 100644 arch/powerpc/boot/dts/fsl/t4240si-pre.dtsi
diff --git a/arch/powerpc/boot/dts/fsl/qoriq-gpio-1.dtsi b/arch/powerpc/boot/dts/fsl/qoriq-gpio-1.dtsi
new file mode 100644
index 0000000..c2f9cda
--- /dev/null
+++ b/arch/powerpc/boot/dts/fsl/qoriq-gpio-1.dtsi
@@ -0,0 +1,41 @@
+/*
+ * QorIQ GPIO device tree stub [ controller @ offset 0x131000 ]
+ *
+ * Copyright 2013 Freescale Semiconductor Inc.
+ *
+ * Redistribution and use in source and binary forms, with or without
+ * modification, are permitted provided that the following conditions are met:
+ * * Redistributions of source code must retain the above copyright
+ * notice, this list of conditions and the following disclaimer.
+ * * Redistributions in binary form must reproduce the above copyright
+ * notice, this list of conditions and the following disclaimer in the
+ * documentation and/or other materials provided with the distribution.
+ * * Neither the name of Freescale Semiconductor nor the
+ * names of its contributors may be used to endorse or promote products
+ * derived from this software without specific prior written permission.
+ *
+ *
+ * ALTERNATIVELY, this software may be distributed under the terms of the
+ * GNU General Public License ("GPL") as published by the Free Software
+ * Foundation, either version 2 of that License or (at your option) any
+ * later version.
+ *
+ * THIS SOFTWARE IS PROVIDED BY Freescale Semiconductor ``AS IS'' AND ANY
+ * EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED
+ * WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE
+ * DISCLAIMED. IN NO EVENT SHALL Freescale Semiconductor BE LIABLE FOR ANY
+ * DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES
+ * (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES;
+ * LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND
+ * ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
+ * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS
+ * SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
+ */
+
+gpio1: gpio@131000 {
+ compatible = "fsl,qoriq-gpio";
+ reg = <0x131000 0x1000>;
+ interrupts = <54 2 0 0>;
+ #gpio-cells = <2>;
+ gpio-controller;
+};
diff --git a/arch/powerpc/boot/dts/fsl/qoriq-gpio-2.dtsi b/arch/powerpc/boot/dts/fsl/qoriq-gpio-2.dtsi
new file mode 100644
index 0000000..33f3ccb
--- /dev/null
+++ b/arch/powerpc/boot/dts/fsl/qoriq-gpio-2.dtsi
@@ -0,0 +1,41 @@
+/*
+ * QorIQ GPIO device tree stub [ controller @ offset 0x132000 ]
+ *
+ * Copyright 2013 Freescale Semiconductor Inc.
+ *
+ * Redistribution and use in source and binary forms, with or without
+ * modification, are permitted provided that the following conditions are met:
+ * * Redistributions of source code must retain the above copyright
+ * notice, this list of conditions and the following disclaimer.
+ * * Redistributions in binary form must reproduce the above copyright
+ * notice, this list of conditions and the following disclaimer in the
+ * documentation and/or other materials provided with the distribution.
+ * * Neither the name of Freescale Semiconductor nor the
+ * names of its contributors may be used to endorse or promote products
+ * derived from this software without specific prior written permission.
+ *
+ *
+ * ALTERNATIVELY, this software may be distributed under the terms of the
+ * GNU General Public License ("GPL") as published by the Free Software
+ * Foundation, either version 2 of that License or (at your option) any
+ * later version.
+ *
+ * THIS SOFTWARE IS PROVIDED BY Freescale Semiconductor ``AS IS'' AND ANY
+ * EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED
+ * WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE
+ * DISCLAIMED. IN NO EVENT SHALL Freescale Semiconductor BE LIABLE FOR ANY
+ * DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES
+ * (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES;
+ * LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND
+ * ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
+ * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS
+ * SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
+ */
+
+gpio2: gpio@132000 {
+ compatible = "fsl,qoriq-gpio";
+ reg = <0x132000 0x1000>;
+ interrupts = <86 2 0 0>;
+ #gpio-cells = <2>;
+ gpio-controller;
+};
diff --git a/arch/powerpc/boot/dts/fsl/qoriq-gpio-3.dtsi b/arch/powerpc/boot/dts/fsl/qoriq-gpio-3.dtsi
new file mode 100644
index 0000000..86954e9
--- /dev/null
+++ b/arch/powerpc/boot/dts/fsl/qoriq-gpio-3.dtsi
@@ -0,0 +1,41 @@
+/*
+ * QorIQ GPIO device tree stub [ controller @ offset 0x133000 ]
+ *
+ * Copyright 2013 Freescale Semiconductor Inc.
+ *
+ * Redistribution and use in source and binary forms, with or without
+ * modification, are permitted provided that the following conditions are met:
+ * * Redistributions of source code must retain the above copyright
+ * notice, this list of conditions and the following disclaimer.
+ * * Redistributions in binary form must reproduce the above copyright
+ * notice, this list of conditions and the following disclaimer in the
+ * documentation and/or other materials provided with the distribution.
+ * * Neither the name of Freescale Semiconductor nor the
+ * names of its contributors may be used to endorse or promote products
+ * derived from this software without specific prior written permission.
+ *
+ *
+ * ALTERNATIVELY, this software may be distributed under the terms of the
+ * GNU General Public License ("GPL") as published by the Free Software
+ * Foundation, either version 2 of that License or (at your option) any
+ * later version.
+ *
+ * THIS SOFTWARE IS PROVIDED BY Freescale Semiconductor ``AS IS'' AND ANY
+ * EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED
+ * WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE
+ * DISCLAIMED. IN NO EVENT SHALL Freescale Semiconductor BE LIABLE FOR ANY
+ * DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES
+ * (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES;
+ * LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND
+ * ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
+ * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS
+ * SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
+ */
+
+gpio3: gpio@133000 {
+ compatible = "fsl,qoriq-gpio";
+ reg = <0x133000 0x1000>;
+ interrupts = <87 2 0 0>;
+ #gpio-cells = <2>;
+ gpio-controller;
+};
diff --git a/arch/powerpc/boot/dts/fsl/t4240si-post.dtsi b/arch/powerpc/boot/dts/fsl/t4240si-post.dtsi
new file mode 100644
index 0000000..376b958
--- /dev/null
+++ b/arch/powerpc/boot/dts/fsl/t4240si-post.dtsi
@@ -0,0 +1,307 @@
+/*
+ * T4240 Silicon/SoC Device Tree Source (post include)
+ *
+ * Copyright 2012 Freescale Semiconductor Inc.
+ *
+ * Redistribution and use in source and binary forms, with or without
+ * modification, are permitted provided that the following conditions are met:
+ * * Redistributions of source code must retain the above copyright
+ * notice, this list of conditions and the following disclaimer.
+ * * Redistributions in binary form must reproduce the above copyright
+ * notice, this list of conditions and the following disclaimer in the
+ * documentation and/or other materials provided with the distribution.
+ * * Neither the name of Freescale Semiconductor nor the
+ * names of its contributors may be used to endorse or promote products
+ * derived from this software without specific prior written permission.
+ *
+ *
+ * ALTERNATIVELY, this software may be distributed under the terms of the
+ * GNU General Public License ("GPL") as published by the Free Software
+ * Foundation, either version 2 of that License or (at your option) any
+ * later version.
+ *
+ * THIS SOFTWARE IS PROVIDED BY Freescale Semiconductor ``AS IS'' AND ANY
+ * EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED
+ * WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE
+ * DISCLAIMED. IN NO EVENT SHALL Freescale Semiconductor BE LIABLE FOR ANY
+ * DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES
+ * (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES;
+ * LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND
+ * ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
+ * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS
+ * SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
+ */
+
+&ifc {
+ #address-cells = <2>;
+ #size-cells = <1>;
+ compatible = "fsl,ifc", "simple-bus";
+ interrupts = <25 2 0 0>;
+};
+
+/* controller at 0x240000 */
+&pci0 {
+ compatible = "fsl,t4240-pcie", "fsl,qoriq-pcie-v3.0";
+ device_type = "pci";
+ #size-cells = <2>;
+ #address-cells = <3>;
+ bus-range = <0x0 0xff>;
+ interrupts = <20 2 0 0>;
+ pcie@0 {
+ #interrupt-cells = <1>;
+ #size-cells = <2>;
+ #address-cells = <3>;
+ device_type = "pci";
+ interrupts = <20 2 0 0>;
+ interrupt-map-mask = <0xf800 0 0 7>;
+ interrupt-map = <
+ /* IDSEL 0x0 */
+ 0000 0 0 1 &mpic 40 1 0 0
+ 0000 0 0 2 &mpic 1 1 0 0
+ 0000 0 0 3 &mpic 2 1 0 0
+ 0000 0 0 4 &mpic 3 1 0 0
+ >;
+ };
+};
+
+/* controller at 0x250000 */
+&pci1 {
+ compatible = "fsl,t4240-pcie", "fsl,qoriq-pcie-v3.0";
+ device_type = "pci";
+ #size-cells = <2>;
+ #address-cells = <3>;
+ bus-range = <0 0xff>;
+ interrupts = <21 2 0 0>;
+ pcie@0 {
+ #interrupt-cells = <1>;
+ #size-cells = <2>;
+ #address-cells = <3>;
+ device_type = "pci";
+ interrupts = <21 2 0 0>;
+ interrupt-map-mask = <0xf800 0 0 7>;
+ interrupt-map = <
+ /* IDSEL 0x0 */
+ 0000 0 0 1 &mpic 41 1 0 0
+ 0000 0 0 2 &mpic 5 1 0 0
+ 0000 0 0 3 &mpic 6 1 0 0
+ 0000 0 0 4 &mpic 7 1 0 0
+ >;
+ };
+};
+
+/* controller at 0x260000 */
+&pci2 {
+ compatible = "fsl,t4240-pcie", "fsl,qoriq-pcie-v3.0";
+ device_type = "pci";
+ #size-cells = <2>;
+ #address-cells = <3>;
+ bus-range = <0x0 0xff>;
+ interrupts = <22 2 0 0>;
+ pcie@0 {
+ #interrupt-cells = <1>;
+ #size-cells = <2>;
+ #address-cells = <3>;
+ device_type = "pci";
+ interrupts = <22 2 0 0>;
+ interrupt-map-mask = <0xf800 0 0 7>;
+ interrupt-map = <
+ /* IDSEL 0x0 */
+ 0000 0 0 1 &mpic 42 1 0 0
+ 0000 0 0 2 &mpic 9 1 0 0
+ 0000 0 0 3 &mpic 10 1 0 0
+ 0000 0 0 4 &mpic 11 1 0 0
+ >;
+ };
+};
+
+/* controller at 0x270000 */
+&pci3 {
+ compatible = "fsl,t4240-pcie", "fsl,qoriq-pcie-v3.0";
+ device_type = "pci";
+ #size-cells = <2>;
+ #address-cells = <3>;
+ bus-range = <0x0 0xff>;
+ interrupts = <23 2 0 0>;
+ pcie@0 {
+ #interrupt-cells = <1>;
+ #size-cells = <2>;
+ #address-cells = <3>;
+ device_type = "pci";
+ interrupts = <23 2 0 0>;
+ interrupt-map-mask = <0xf800 0 0 7>;
+ interrupt-map = <
+ /* IDSEL 0x0 */
+ 0000 0 0 1 &mpic 43 1 0 0
+ 0000 0 0 2 &mpic 0 1 0 0
+ 0000 0 0 3 &mpic 4 1 0 0
+ 0000 0 0 4 &mpic 8 1 0 0
+ >;
+ };
+};
+
+&rio {
+ compatible = "fsl,srio";
+ interrupts = <16 2 1 11>;
+ #address-cells = <2>;
+ #size-cells = <2>;
+ ranges;
+
+ port1 {
+ #address-cells = <2>;
+ #size-cells = <2>;
+ cell-index = <1>;
+ };
+
+ port2 {
+ #address-cells = <2>;
+ #size-cells = <2>;
+ cell-index = <2>;
+ };
+};
+
+&soc {
+ #address-cells = <1>;
+ #size-cells = <1>;
+ device_type = "soc";
+ compatible = "simple-bus";
+
+ soc-sram-error {
+ compatible = "fsl,soc-sram-error";
+ interrupts = <16 2 1 29>;
+ };
+
+ corenet-law@0 {
+ compatible = "fsl,corenet-law";
+ reg = <0x0 0x1000>;
+ fsl,num-laws = <32>;
+ };
+
+ ddr1: memory-controller@8000 {
+ compatible = "fsl,qoriq-memory-controller-v4.7",
+ "fsl,qoriq-memory-controller";
+ reg = <0x8000 0x1000>;
+ interrupts = <16 2 1 23>;
+ };
+
+ ddr2: memory-controller@9000 {
+ compatible = "fsl,qoriq-memory-controller-v4.7",
+ "fsl,qoriq-memory-controller";
+ reg = <0x9000 0x1000>;
+ interrupts = <16 2 1 22>;
+ };
+
+ ddr3: memory-controller@a000 {
+ compatible = "fsl,qoriq-memory-controller-v4.7",
+ "fsl,qoriq-memory-controller";
+ reg = <0xa000 0x1000>;
+ interrupts = <16 2 1 21>;
+ };
+
+ cpc: l3-cache-controller@10000 {
+ compatible = "fsl,t4240-l3-cache-controller", "cache";
+ reg = <0x10000 0x1000
+ 0x11000 0x1000
+ 0x12000 0x1000>;
+ interrupts = <16 2 1 27
+ 16 2 1 26
+ 16 2 1 25>;
+ };
+
+ corenet-cf@18000 {
+ compatible = "fsl,corenet-cf";
+ reg = <0x18000 0x1000>;
+ interrupts = <16 2 1 31>;
+ fsl,ccf-num-csdids = <32>;
+ fsl,ccf-num-snoopids = <32>;
+ };
+
+ iommu@20000 {
+ compatible = "fsl,pamu-v1.0", "fsl,pamu";
+ reg = <0x20000 0x6000>;
+ interrupts = <
+ 24 2 0 0
+ 16 2 1 30>;
+ };
+
+/include/ "qoriq-mpic.dtsi"
+
+ guts: global-utilities@e0000 {
+ compatible = "fsl,t4240-device-config";
+ reg = <0xe0000 0xe00>;
+ fsl,has-rstcr;
+ fsl,liodn-bits = <12>;
+ };
+
+ clockgen: global-utilities@e1000 {
+ compatible = "fsl,t4240-clockgen", "fsl,qoriq-clockgen-2";
+ reg = <0xe1000 0x1000>;
+ };
+
+ rcpm: global-utilities@e2000 {
+ compatible = "fsl,t4240-rcpm", "fsl,qoriq-rcpm-2";
+ reg = <0xe2000 0x1000>;
+ };
+
+ sfp: sfp@e8000 {
+ compatible = "fsl,t4240-sfp";
+ reg = <0xe8000 0x1000>;
+ };
+
+ serdes: serdes@ea000 {
+ compatible = "fsl,t4240-serdes";
+ reg = <0xea000 0x4000>;
+ };
+
+/include/ "qoriq-dma-0.dtsi"
+/include/ "qoriq-dma-1.dtsi"
+
+/include/ "qoriq-espi-0.dtsi"
+ spi@110000 {
+ fsl,espi-num-chipselects = <4>;
+ };
+
+/include/ "qoriq-esdhc-0.dtsi"
+ sdhc@114000 {
+ compatible = "fsl,t4240-esdhc", "fsl,esdhc";
+ sdhci,auto-cmd12;
+ };
+/include/ "qoriq-i2c-0.dtsi"
+/include/ "qoriq-i2c-1.dtsi"
+/include/ "qoriq-duart-0.dtsi"
+/include/ "qoriq-duart-1.dtsi"
+/include/ "qoriq-gpio-0.dtsi"
+/include/ "qoriq-gpio-1.dtsi"
+/include/ "qoriq-gpio-2.dtsi"
+/include/ "qoriq-gpio-3.dtsi"
+/include/ "qoriq-usb2-mph-0.dtsi"
+ usb0: usb@210000 {
+ compatible = "fsl-usb2-mph-v2.4", "fsl-usb2-mph";
+ phy_type = "utmi";
+ port0;
+ };
+/include/ "qoriq-usb2-dr-0.dtsi"
+ usb1: usb@211000 {
+ compatible = "fsl-usb2-dr-v2.4", "fsl-usb2-dr";
+ dr_mode = "host";
+ phy_type = "utmi";
+ };
+/include/ "qoriq-sata2-0.dtsi"
+/include/ "qoriq-sata2-1.dtsi"
+/include/ "qoriq-sec5.0-0.dtsi"
+
+ L2_1: l2-cache-controller@c20000 {
+ compatible = "fsl,t4240-l2-cache-controller";
+ reg = <0xc20000 0x40000>;
+ next-level-cache = <&cpc>;
+ };
+ L2_2: l2-cache-controller@c60000 {
+ compatible = "fsl,t4240-l2-cache-controller";
+ reg = <0xc60000 0x40000>;
+ next-level-cache = <&cpc>;
+ };
+ L2_3: l2-cache-controller@ca0000 {
+ compatible = "fsl,t4240-l2-cache-controller";
+ reg = <0xca0000 0x40000>;
+ next-level-cache = <&cpc>;
+ };
+};
diff --git a/arch/powerpc/boot/dts/fsl/t4240si-pre.dtsi b/arch/powerpc/boot/dts/fsl/t4240si-pre.dtsi
new file mode 100644
index 0000000..12af298
--- /dev/null
+++ b/arch/powerpc/boot/dts/fsl/t4240si-pre.dtsi
@@ -0,0 +1,127 @@
+/*
+ * T4240 Silicon/SoC Device Tree Source (pre include)
+ *
+ * Copyright 2012 Freescale Semiconductor Inc.
+ *
+ * Redistribution and use in source and binary forms, with or without
+ * modification, are permitted provided that the following conditions are met:
+ * * Redistributions of source code must retain the above copyright
+ * notice, this list of conditions and the following disclaimer.
+ * * Redistributions in binary form must reproduce the above copyright
+ * notice, this list of conditions and the following disclaimer in the
+ * documentation and/or other materials provided with the distribution.
+ * * Neither the name of Freescale Semiconductor nor the
+ * names of its contributors may be used to endorse or promote products
+ * derived from this software without specific prior written permission.
+ *
+ *
+ * ALTERNATIVELY, this software may be distributed under the terms of the
+ * GNU General Public License ("GPL") as published by the Free Software
+ * Foundation, either version 2 of that License or (at your option) any
+ * later version.
+ *
+ * THIS SOFTWARE IS PROVIDED BY Freescale Semiconductor ``AS IS'' AND ANY
+ * EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED
+ * WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE
+ * DISCLAIMED. IN NO EVENT SHALL Freescale Semiconductor BE LIABLE FOR ANY
+ * DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES
+ * (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES;
+ * LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND
+ * ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
+ * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS
+ * SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
+ */
+
+/dts-v1/;
+
+/include/ "e6500_power_isa.dtsi"
+
+/ {
+ compatible = "fsl,T4240";
+ #address-cells = <2>;
+ #size-cells = <2>;
+ interrupt-parent = <&mpic>;
+
+ aliases {
+ ccsr = &soc;
+
+ serial0 = &serial0;
+ serial1 = &serial1;
+ serial2 = &serial2;
+ serial3 = &serial3;
+ crypto = &crypto;
+ pci0 = &pci0;
+ pci1 = &pci1;
+ pci2 = &pci2;
+ pci3 = &pci3;
+ dma0 = &dma0;
+ dma1 = &dma1;
+ sdhc = &sdhc;
+ };
+
+ cpus {
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ PowerPC,e6500@0 {
+ device_type = "cpu";
+ reg = <0 1>;
+ next-level-cache = <&L2_1>;
+ };
+ PowerPC,e6500@1 {
+ device_type = "cpu";
+ reg = <2 3>;
+ next-level-cache = <&L2_1>;
+ };
+ PowerPC,e6500@2 {
+ device_type = "cpu";
+ reg = <4 5>;
+ next-level-cache = <&L2_1>;
+ };
+ PowerPC,e6500@3 {
+ device_type = "cpu";
+ reg = <6 7>;
+ next-level-cache = <&L2_1>;
+ };
+ PowerPC,e6500@4 {
+ device_type = "cpu";
+ reg = <8 9>;
+ next-level-cache = <&L2_2>;
+ };
+ PowerPC,e6500@5 {
+ device_type = "cpu";
+ reg = <10 11>;
+ next-level-cache = <&L2_2>;
+ };
+ PowerPC,e6500@6 {
+ device_type = "cpu";
+ reg = <12 13>;
+ next-level-cache = <&L2_2>;
+ };
+ PowerPC,e6500@7 {
+ device_type = "cpu";
+ reg = <14 15>;
+ next-level-cache = <&L2_2>;
+ };
+ PowerPC,e6500@8 {
+ device_type = "cpu";
+ reg = <16 17>;
+ next-level-cache = <&L2_3>;
+ };
+ PowerPC,e6500@9 {
+ device_type = "cpu";
+ reg = <18 19>;
+ next-level-cache = <&L2_3>;
+ };
+ PowerPC,e6500@10 {
+ device_type = "cpu";
+ reg = <20 21>;
+ next-level-cache = <&L2_3>;
+ };
+ PowerPC,e6500@11 {
+ device_type = "cpu";
+ reg = <22 23>;
+ next-level-cache = <&L2_3>;
+ };
+ };
+};
--
1.7.9.7
^ permalink raw reply related
* Re: Linux kernel 3.x problems on PowerMac G5
From: Phileas Fogg @ 2013-03-07 20:08 UTC (permalink / raw)
To: Benjamin Herrenschmidt
Cc: Andreas Schwab, Denis Kirjanov, linuxppc-dev, Aaro Koskinen
In-Reply-To: <1362338657.2969.20.camel@pasglop>
On 03/03/2013 08:24 PM, Benjamin Herrenschmidt wrote:
> On Sun, 2013-03-03 at 20:16 +0100, Phileas Fogg wrote:
>> Benjamin Herrenschmidt wrote:
>>> Thanks. It looks like a bisection might indeed be the way to go...
>>>
>>> Out of curiosity, have you tried without some of your additional drivers ?
>>> Maybe one of them is the culprit...
>>>
>>> Cheers,
>>> Ben.
>>>
>>
>> Not yet, will do.
>> But I tested the official Debian Wheezy RC netinstall CD with Linux 3.2,
>> it has the same problem and hangs at boot on my machine.
>
> Ok, so it's definitely something about your configuration. Maybe
> something in the 11,2 support code chokes on single-chip configs, I
> don't have one of them to test, both mines are dual chip (ie. quad
> core).
>
> But it does look like a regression that should be bisectable, so let me
> know went you're done there and what you get.
>
> Cheers,
> Ben.
>
>
> _______________________________________________
> Linuxppc-dev mailing list
> Linuxppc-dev@lists.ozlabs.org
> https://lists.ozlabs.org/listinfo/linuxppc-dev
>
Hi,
i'm completely confused now.
I did a bisect between the following 2 commits:
61c4f2c81c61f73549928dfd9f3e8f26aa36a8cf (good) Linux 2.6.39
and
55922c9d1b84b89cb946c777fddccb3247e7df2c (bad) Linux 3.0-rc1
Both commist were tested by me on my machine. And Linux 3.0-rc1 hangs
on my machine but Linux 2.6.39 works fine.
And the bisect couldn't find the commit which causes hangs on my machine.
All commits which were provided by the bisect were bad.
And the commit before tha last bad bisect commit was bad too.
I did bisect several times, and got the same results.
Fo testing i used linux-3.0.y branch of
git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable.git.
Did i miss something or do something wrong here ?
Regards
^ permalink raw reply
* Re: Linux kernel 3.x problems on PowerMac G5
From: Benjamin Herrenschmidt @ 2013-03-07 20:22 UTC (permalink / raw)
To: Phileas Fogg; +Cc: Andreas Schwab, Denis Kirjanov, linuxppc-dev, Aaro Koskinen
In-Reply-To: <5138F3AB.5040401@mail.ru>
On Thu, 2013-03-07 at 21:08 +0100, Phileas Fogg wrote:
> And the bisect couldn't find the commit which causes hangs on my
> machine.
> All commits which were provided by the bisect were bad.
> And the commit before tha last bad bisect commit was bad too.
> I did bisect several times, and got the same results.
>
> Fo testing i used linux-3.0.y branch of
> git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable.git.
>
> Did i miss something or do something wrong here ?
Did git bisect go down a merge commit ? It does for me if I try that and
asks to test that merge first. If you get that wrong it can get very
confused.
That's all I can think of... do you have the bisection log just in
case ?
Also you can use gitk -- arch/powerpc to look at the changes to powerpc
code and try manually random points before/after that if you think
bisect isn't doing the right thing.
Cheers,
Ben.
^ permalink raw reply
* Re: Linux kernel 3.x problems on PowerMac G5
From: Phileas Fogg @ 2013-03-07 21:07 UTC (permalink / raw)
To: Benjamin Herrenschmidt
Cc: Andreas Schwab, Denis Kirjanov, linuxppc-dev, Aaro Koskinen
In-Reply-To: <1362687724.6977.1.camel@pasglop>
On 03/07/2013 09:22 PM, Benjamin Herrenschmidt wrote:
> On Thu, 2013-03-07 at 21:08 +0100, Phileas Fogg wrote:
>> And the bisect couldn't find the commit which causes hangs on my
>> machine.
>> All commits which were provided by the bisect were bad.
>> And the commit before tha last bad bisect commit was bad too.
>> I did bisect several times, and got the same results.
>>
>> Fo testing i used linux-3.0.y branch of
>> git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable.git.
>>
>> Did i miss something or do something wrong here ?
>
> Did git bisect go down a merge commit ? It does for me if I try that and
> asks to test that merge first. If you get that wrong it can get very
> confused.
>
> That's all I can think of... do you have the bisection log just in
> case ?
>
> Also you can use gitk -- arch/powerpc to look at the changes to powerpc
> code and try manually random points before/after that if you think
> bisect isn't doing the right thing.
>
> Cheers,
> Ben.
>
>
Thanks. I'll try manually some commits then.
And here is the bisect log:
git bisect log
# bad: [55922c9d1b84b89cb946c777fddccb3247e7df2c] Linux 3.0-rc1
# good: [61c4f2c81c61f73549928dfd9f3e8f26aa36a8cf] Linux 2.6.39
git bisect start '55922c9d1b84b89cb946c777fddccb3247e7df2c'
'61c4f2c81c61f73549928dfd9f3e8f26aa36a8cf'
# bad: [c44dead70a841d90ddc01968012f323c33217c9e] Merge branch
'usb-next' of git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb-2.6
git bisect bad c44dead70a841d90ddc01968012f323c33217c9e
# bad: [d93515611bbc70c2fe4db232e5feb448ed8e4cc9] macvlan: fix panic if
lowerdev in a bond
git bisect bad d93515611bbc70c2fe4db232e5feb448ed8e4cc9
# bad: [9c6a02f41d10dc9fbf5dd42058e8846f38dd2d9a] sctp: make sctp over
IPv6 work with IPsec
git bisect bad 9c6a02f41d10dc9fbf5dd42058e8846f38dd2d9a
# bad: [d30ee670f25ea8f265a2804e2a0a53804cac5185] net-bonding: Fix minor
sparse complaints
git bisect bad d30ee670f25ea8f265a2804e2a0a53804cac5185
# bad: [b37e3b6d64358604960b35e8ecbb7aed22e0926e] Merge branch 'master'
of git://git.kernel.org/pub/scm/linux/kernel/git/linville/wireless-2.6
git bisect bad b37e3b6d64358604960b35e8ecbb7aed22e0926e
# bad: [6c74608bd479bbe02ce330f83df43c3f535ed200] ssb: pci: trivial:
drop useless pointer
git bisect bad 6c74608bd479bbe02ce330f83df43c3f535ed200
# bad: [83860c594f65945b1a2c99e84338e1145cd34890] ath9k_hw: remove
pCap->tx_triglevel_max
git bisect bad 83860c594f65945b1a2c99e84338e1145cd34890
# bad: [f171760c558946c7a2e0ee310dfb968f9d4853c6] ath9k_hw: enable a
BlockAck related fixup specific to AR9100
git bisect bad f171760c558946c7a2e0ee310dfb968f9d4853c6
# bad: [e600707b021efdc109e7becd467798da339ec26d] mwl8k: differentiate
between WMM queues and AMPDU queues
git bisect bad e600707b021efdc109e7becd467798da339ec26d
# bad: [e7fc63388def06d2d1bdb6916748c92c037a42c6] ath9k_hw: Speedup
register ops for HTC driver
git bisect bad e7fc63388def06d2d1bdb6916748c92c037a42c6
# bad: [6d64ab7f9240e3201fde3fd16ce4227bd795d2ab] ath9k_htc: Fix LED pin
for AR9287 HTC device
git bisect bad 6d64ab7f9240e3201fde3fd16ce4227bd795d2ab
# bad: [22dd2fd283ea96b4d45185d3e861ef46005082f4] iwlwifi: remove
duplicate initialization in __iwl_down()
git bisect bad 22dd2fd283ea96b4d45185d3e861ef46005082f4
Regards
^ permalink raw reply
* [PATCH] powerpc/wsp: drop "select PPC_WSP_COPRO"
From: Paul Bolle @ 2013-03-07 22:15 UTC (permalink / raw)
To: Benjamin Herrenschmidt, Paul Mackerras; +Cc: linuxppc-dev, linux-kernel
There is no Kconfig symbol PPC_WSP_COPRO. The select statement for it is
a nop. Drop it.
Signed-off-by: Paul Bolle <pebolle@tiscali.nl>
---
A short treatise on the uneventful life of PPC_WSP_COPRO in the mainline
kernel tree
Release v3.0 included commit 76b4eda866c4936af8d696f040abea56bf688e16
("powerpc: Add A2 cpu support"). It added some code wrapped in an
"#ifdef CONFIG_PPC_WSP_COPRO" and "#endif" pair. It did not add a
Kconfig symbol PPC_WSP_COPRO. Neither did it add a preprocessor #define
for CONFIG_PPC_WSP_COPRO. There haS actually never been such a symbol or
such a macro in the mainline tree.
Release v3.3 included commit fac26ad4f9cb794c9d1032f55f40a31cb55be09a
("powerpc/book3e: Add ICSWX/ACOP support to Book3e cores like A2"). It
basically renamed CONFIG_PPC_WSP_COPRO to CONFIG_PPC_ICSWX. It did not
elaborate why it did that. But at least PPC_ICSWX was a valid Kconfig
symbol.
Release v3.3 also included commit
cc35b6766878e31accc95c3fdae945bdadc73a46 ("powerpc/book3e: Add Chroma as
a new WSP/PowerEN platform."). That commit added a Kconfig select
statement for PPC_WSP_COPRO. It is not clear why it did that. Current
opinion is that it served no purpose and that the kernel tree would be
better of without that statement.
arch/powerpc/platforms/wsp/Kconfig | 1 -
1 file changed, 1 deletion(-)
diff --git a/arch/powerpc/platforms/wsp/Kconfig b/arch/powerpc/platforms/wsp/Kconfig
index 79d2225..56203a4 100644
--- a/arch/powerpc/platforms/wsp/Kconfig
+++ b/arch/powerpc/platforms/wsp/Kconfig
@@ -9,7 +9,6 @@ config PPC_WSP
select PCI
select PPC_IO_WORKAROUNDS if PCI
select PPC_INDIRECT_PIO if PCI
- select PPC_WSP_COPRO
default n
menu "WSP platform selection"
--
1.7.11.7
^ permalink raw reply related
* Re: 3.9-rc1 powerpc ptrace.c: 'brk.len' is used uninitialized
From: Michael Neuling @ 2013-03-07 22:32 UTC (permalink / raw)
To: Philippe De Muyter; +Cc: linuxppc-dev, linux-kernel
In-Reply-To: <20130307095907.GA16489@frolo.macqel>
Philippe De Muyter <phdm@macqel.be> wrote:
> Hello Mikey,
>
> On Thu, Mar 07, 2013 at 10:14:30AM +1100, Michael Neuling wrote:
> > Philippe De Muyter <phdm@macqel.be> wrote:
> >
> > > On Thu, Mar 07, 2013 at 09:09:48AM +1100, Michael Neuling wrote:
> > > > > bisect tells me that since your commit 9422de3e953d0e60eb95f5430a9dd803eec1c6d7
> > > > > "powerpc: Hardware breakpoints rewrite to handle non DABR breakpoint registers",
> > > > > compiling linux fails with :
> > > > >
> > > > > cc1: warnings being treated as errors
> > > > > arch/powerpc/kernel/ptrace.c: In function 'arch_ptrace':
> > > > > arch/powerpc/kernel/ptrace.c:1450: warning: 'brk.len' is used uninitialized in this function
> > > > > arch/powerpc/kernel/ptrace.c:1352: note: 'brk.len' was declared here
> > > > >
> > > > > could you look at that ?
> > > >
> > > > Sure.
> > >
> > > I use gcc-4.2.2, and my .config follows.
> >
> > I'm a bit lost.
> >
> > I don't have 4.2.2 (which is ancient BTW) and I can't hit this on
> > 4.3,4.5 or 4.6 with your config. It compiles fine.
> >
> > Also:
> >
> > > arch/powerpc/kernel/ptrace.c:1450: warning: 'brk.len' is used uninitialized in this function
> > > arch/powerpc/kernel/ptrace.c:1352: note: 'brk.len' was declared here
> >
> > These line numbers make no sense at all WRT v3.9-rc1. brk.len is neither
> > declared or used in those lines:
>
> those were the line numbers just after your commit
>
> In 3.9-rc1 they are :
>
> cc1: warnings being treated as errors
> arch/powerpc/kernel/ptrace.c: In function 'arch_ptrace':
> arch/powerpc/kernel/ptrace.c:1479: warning: 'brk.len' is used uninitialized in this function
> arch/powerpc/kernel/ptrace.c:1381: note: 'brk.len' was declared here
>
> if (child->thread.hw_brk.address)
> return -ENOSPC;
>
> 1479: child->thread.hw_brk = brk;
>
> return 1;
> #endif /* !CONFIG_PPC_ADV_DEBUG_DVCS */
Got it. I still can't replicate the issue here, so can you check if the
below works for you?
Thanks,
Mikey
diff --git a/arch/powerpc/kernel/ptrace.c b/arch/powerpc/kernel/ptrace.c
index 245c1b6..3b5f9dc 100644
--- a/arch/powerpc/kernel/ptrace.c
+++ b/arch/powerpc/kernel/ptrace.c
@@ -1428,6 +1428,7 @@ static long ppc_set_hwdebug(struct task_struct *child,
brk.address = bp_info->addr & ~7UL;
brk.type = HW_BRK_TYPE_TRANSLATE;
+ brk.len = len;
if (bp_info->trigger_type & PPC_BREAKPOINT_TRIGGER_READ)
brk.type |= HW_BRK_TYPE_READ;
if (bp_info->trigger_type & PPC_BREAKPOINT_TRIGGER_WRITE)
^ permalink raw reply related
* [PATCH] pseries/iommu: close DDW race between functions of adapter
From: Nishanth Aravamudan @ 2013-03-07 22:33 UTC (permalink / raw)
To: benh; +Cc: miltonm, paulus, rlary, linuxppc-dev, anton
Given a PCI device with multiple functions in a DDW capable slot, the
following situation can be encountered: When the first function sets a
64-bit DMA mask, enable_ddw() will be called and we can fail to properly
configure DDW (the most common reason being the new DMA window's size is
not large enough to map all of an LPAR's memory). With the recent
changes to DDW, we remove the base window in order to determine if the
new window is of sufficient size to cover an LPAR's memory. We correctly
replace the base window if we find that not to be the case. However,
once we go through and re-configured 32-bit DMA via the IOMMU, the next
function of the adapter will go through the same process. And since DDW
is a characteristic of the slot itself, we are most likely going to fail
again. But to determine we are going to fail the second slot, we again
remove the base window -- but that is now in-use by the first
function/driver, which might be issuing I/O already.
To close this window, keep a list of all the failed struct device_nodes
that have failed to configure DDW. If the current device_node is in that
list, just fail out immediately and fall back to 32-bit DMA without
doing any DDW manipulation.
Signed-off-by: Nishanth Aravamudan <nacc@linux.vnet.ibm.com>
---
This is pretty ugly, but I couldn't immediately see a better solution.
In particular, I'm not sure there is much we can do if the kzalloc
fails, so I just have it return as normal.
diff --git a/arch/powerpc/platforms/pseries/iommu.c b/arch/powerpc/platforms/pseries/iommu.c
index 1b2a174..86ae364 100644
--- a/arch/powerpc/platforms/pseries/iommu.c
+++ b/arch/powerpc/platforms/pseries/iommu.c
@@ -924,6 +924,13 @@ static void restore_default_window(struct pci_dev *dev,
__restore_default_window(pci_dev_to_eeh_dev(dev), ddw_restore_token);
}
+struct failed_ddw_pdn {
+ struct device_node *pdn;
+ struct list_head list;
+};
+
+static LIST_HEAD(failed_ddw_pdn_list);
+
/*
* If the PE supports dynamic dma windows, and there is space for a table
* that can map all pages in a linear offset, then setup such a table,
@@ -951,6 +958,7 @@ static u64 enable_ddw(struct pci_dev *dev, struct device_node *pdn)
struct dynamic_dma_window_prop *ddwprop;
const void *dma_window = NULL;
unsigned long liobn, offset, size;
+ struct failed_ddw_pdn *fpdn;
mutex_lock(&direct_window_init_mutex);
@@ -959,6 +967,18 @@ static u64 enable_ddw(struct pci_dev *dev, struct device_node *pdn)
goto out_unlock;
/*
+ * If we already went through this for a previous function of
+ * the same device and failed, we don't want to muck with the
+ * DMA window again, as it will race with in-flight operations
+ * and can lead to EEHs. The above mutex protects access to the
+ * list.
+ */
+ list_for_each_entry(fpdn, &failed_ddw_pdn_list, list) {
+ if (!strcmp(fpdn->pdn->full_name, pdn->full_name))
+ goto out_unlock;
+ }
+
+ /*
* the ibm,ddw-applicable property holds the tokens for:
* ibm,query-pe-dma-window
* ibm,create-pe-dma-window
@@ -1114,6 +1134,12 @@ out_restore_window:
if (ddw_restore_token)
restore_default_window(dev, ddw_restore_token);
+ fpdn = kzalloc(sizeof(*fpdn), GFP_KERNEL);
+ if (!fpdn)
+ goto out_unlock;
+ fpdn->pdn = pdn;
+ list_add(&fpdn->list, &failed_ddw_pdn_list);
+
out_unlock:
mutex_unlock(&direct_window_init_mutex);
return dma_addr;
^ permalink raw reply related
* Re: 3.9-rc1 powerpc ptrace.c: 'brk.len' is used uninitialized
From: Michael Neuling @ 2013-03-07 23:03 UTC (permalink / raw)
To: Philippe De Muyter; +Cc: linuxppc-dev, linux-kernel
In-Reply-To: <22285.1362695571@ale.ozlabs.ibm.com>
Michael Neuling <mikey@neuling.org> wrote:
> Philippe De Muyter <phdm@macqel.be> wrote:
>
> > Hello Mikey,
> >
> > On Thu, Mar 07, 2013 at 10:14:30AM +1100, Michael Neuling wrote:
> > > Philippe De Muyter <phdm@macqel.be> wrote:
> > >
> > > > On Thu, Mar 07, 2013 at 09:09:48AM +1100, Michael Neuling wrote:
> > > > > > bisect tells me that since your commit 9422de3e953d0e60eb95f5430a9dd803eec1c6d7
> > > > > > "powerpc: Hardware breakpoints rewrite to handle non DABR breakpoint registers",
> > > > > > compiling linux fails with :
> > > > > >
> > > > > > cc1: warnings being treated as errors
> > > > > > arch/powerpc/kernel/ptrace.c: In function 'arch_ptrace':
> > > > > > arch/powerpc/kernel/ptrace.c:1450: warning: 'brk.len' is used uninitialized in this function
> > > > > > arch/powerpc/kernel/ptrace.c:1352: note: 'brk.len' was declared here
> > > > > >
> > > > > > could you look at that ?
> > > > >
> > > > > Sure.
> > > >
> > > > I use gcc-4.2.2, and my .config follows.
> > >
> > > I'm a bit lost.
> > >
> > > I don't have 4.2.2 (which is ancient BTW) and I can't hit this on
> > > 4.3,4.5 or 4.6 with your config. It compiles fine.
> > >
> > > Also:
> > >
> > > > arch/powerpc/kernel/ptrace.c:1450: warning: 'brk.len' is used uninitialized in this function
> > > > arch/powerpc/kernel/ptrace.c:1352: note: 'brk.len' was declared here
> > >
> > > These line numbers make no sense at all WRT v3.9-rc1. brk.len is neither
> > > declared or used in those lines:
> >
> > those were the line numbers just after your commit
> >
> > In 3.9-rc1 they are :
> >
> > cc1: warnings being treated as errors
> > arch/powerpc/kernel/ptrace.c: In function 'arch_ptrace':
> > arch/powerpc/kernel/ptrace.c:1479: warning: 'brk.len' is used uninitialized in this function
> > arch/powerpc/kernel/ptrace.c:1381: note: 'brk.len' was declared here
> >
> > if (child->thread.hw_brk.address)
> > return -ENOSPC;
> >
> > 1479: child->thread.hw_brk = brk;
> >
> > return 1;
> > #endif /* !CONFIG_PPC_ADV_DEBUG_DVCS */
>
> Got it. I still can't replicate the issue here, so can you check if the
> below works for you?
Argh, scrap that..... try this.
diff --git a/arch/powerpc/kernel/ptrace.c b/arch/powerpc/kernel/ptrace.c
index 245c1b6..8564515 100644
--- a/arch/powerpc/kernel/ptrace.c
+++ b/arch/powerpc/kernel/ptrace.c
@@ -1428,6 +1428,7 @@ static long ppc_set_hwdebug(struct task_struct *child,
brk.address = bp_info->addr & ~7UL;
brk.type = HW_BRK_TYPE_TRANSLATE;
+ brk.len = 0;
if (bp_info->trigger_type & PPC_BREAKPOINT_TRIGGER_READ)
brk.type |= HW_BRK_TYPE_READ;
if (bp_info->trigger_type & PPC_BREAKPOINT_TRIGGER_WRITE)
^ permalink raw reply related
* Re: [PATCH] mmc: sdhci-pltfm: Fix timeout on t4240's sdhci controller
From: Chunhe Lan @ 2013-03-08 2:57 UTC (permalink / raw)
To: Gala Kumar-B11780; +Cc: <linuxppc-dev@lists.ozlabs.org>
In-Reply-To: <CF1EE7AED478CD48A05574C8E2DA142D746975@039-SN1MPN1-004.039d.mgd.msft.net>
On 03/08/2013 12:30 AM, Gala Kumar-B11780 wrote:
> On Mar 7, 2013, at 2:05 AM, Chunhe Lan wrote:
>
>> This patch fixes timeout problems on t4240's sdhci controller:
>>
>> mmc0: Too large timeout requested for CMD25!
>> mmc0: Too large timeout requested for CMD25!
>> mmc0: Too large timeout requested for CMD25!
>>
>> Signed-off-by: Chunhe Lan <Chunhe.Lan@freescale.com>
>> ---
>> drivers/mmc/host/sdhci-pltfm.c | 1 +
>> 1 files changed, 1 insertions(+), 0 deletions(-)
>>
>> diff --git a/drivers/mmc/host/sdhci-pltfm.c b/drivers/mmc/host/sdhci-pltfm.c
>> index 3145a78..9db7b12 100644
>> --- a/drivers/mmc/host/sdhci-pltfm.c
>> +++ b/drivers/mmc/host/sdhci-pltfm.c
>> @@ -94,6 +94,7 @@ void sdhci_get_of_property(struct platform_device *pdev)
>>
>> if (of_device_is_compatible(np, "fsl,p2020-esdhc") ||
>> of_device_is_compatible(np, "fsl,p1010-esdhc") ||
>> + of_device_is_compatible(np, "fsl,t4240-esdhc") ||
>> of_device_is_compatible(np, "fsl,mpc8536-esdhc"))
>> host->quirks |= SDHCI_QUIRK_BROKEN_TIMEOUT_VAL;
>>
>> --
>> 1.7.6.5
>>
>
> Why does this occur? Is it a board issue? Is it a silicon issue? Is it due to some erratum? Why T4 only?
It would be the property of T4 hardware, and please see below the
patch which locates
the mail list of freescale:
eSDHC: mmc:host host need long time to generate command complete interrupt
According to Spec 2.0, command complete interrupt will generate within
150 SD-CLK.
But this was not enough on T4240 board. So give it sufficient time to
detect command
timeout. 1000 * HZ will be enough, this value was test on all T4 board,
all worked well.
Signed-off-by: Jerry Huang <Chang-Ming.Huang@freescale.com>
Signed-off-by: Haijun Zhang <Haijun.Zhang@freescale.com>
Thanks,
Chunhe
>
> - k
^ permalink raw reply
* RE: [PATCH][V2] powerpc: remove the PPC_CLOCK dependency
From: Tang Yuantian-B29983 @ 2013-03-08 2:57 UTC (permalink / raw)
To: Kumar Gala; +Cc: linuxppc-dev@ozlabs.org, kernel@pengutronix.de
In-Reply-To: <BED928B9-2212-413F-8C96-BCDFCE57C76A@kernel.crashing.org>
> Subject: Re: [PATCH][V2] powerpc: remove the PPC_CLOCK dependency
>=20
>=20
> On Mar 6, 2013, at 3:16 AM, <Yuantian.Tang@freescale.com>
> <Yuantian.Tang@freescale.com> wrote:
>=20
> > From: Tang Yuantian <Yuantian.Tang@freescale.com>
> >
> > config FSL_SOC and CPM do not really depend on PPC_CLOCK. So remove it.
> > PPC_CLOCK also keeps powerpc archtecture from supporting COMMON_CLK.
> >
> > Signed-off-by: Tang Yuantian <Yuantian.Tang@freescale.com>
> > ---
> > v2: correct the title
> >
> > arch/powerpc/Kconfig | 1 -
> > arch/powerpc/platforms/Kconfig | 1 -
> > 2 files changed, 0 insertions(+), 2 deletions(-)
>=20
> Does the Flexcan driver use this?
>=20
In SDK, Flexcan did select the PPC_CLOCK, in upstream, it didn't.
Whatever it selects PPC_CLOCK or not, it doesn't use it.
Added the patch author to this loop.
- Yuantian
> - k
>=20
> >
> > diff --git a/arch/powerpc/Kconfig b/arch/powerpc/Kconfig index
> > 352f416..383485b 100644
> > --- a/arch/powerpc/Kconfig
> > +++ b/arch/powerpc/Kconfig
> > @@ -655,7 +655,6 @@ config SBUS
> > config FSL_SOC
> > bool
> > select HAVE_CAN_FLEXCAN if NET && CAN
> > - select PPC_CLOCK
> >
> > config FSL_PCI
> > bool
> > diff --git a/arch/powerpc/platforms/Kconfig
> > b/arch/powerpc/platforms/Kconfig index e7a896a..aba81cd 100644
> > --- a/arch/powerpc/platforms/Kconfig
> > +++ b/arch/powerpc/platforms/Kconfig
> > @@ -343,7 +343,6 @@ config FSL_ULI1575
> >
> > config CPM
> > bool
> > - select PPC_CLOCK
> >
> > config OF_RTC
> > bool
> > --
> > 1.7.0.4
> >
>=20
^ permalink raw reply
* [PATCH] drivers/tty/hvc: fixup original commit: 9276dfd27897a0b29d8b5814f39a1f82f56b6b6b
From: Chen Gang @ 2013-03-08 3:38 UTC (permalink / raw)
To: Benjamin Herrenschmidt
Cc: Greg KH, linuxppc-dev, wfp5p, tklauser, Jiri Slaby, alan
In-Reply-To: <1362636305.3548.58.camel@pasglop>
originally I did not notice src buf len and dest buf len are the same.
so origianlly, it is not a bug issue, it is only for beautify code.
and now, using strcpy is better.
Signed-off-by: Chen Gang <gang.chen@asianux.com>
Signed-off-by: Jiri Slaby <jslaby@suse.cz>
---
drivers/tty/hvc/hvcs.c | 3 +--
1 files changed, 1 insertions(+), 2 deletions(-)
diff --git a/drivers/tty/hvc/hvcs.c b/drivers/tty/hvc/hvcs.c
index 81e939e..9330a4b 100644
--- a/drivers/tty/hvc/hvcs.c
+++ b/drivers/tty/hvc/hvcs.c
@@ -885,8 +885,7 @@ static void hvcs_set_pi(struct hvcs_partner_info
*pi, struct hvcs_struct *hvcsd)
hvcsd->p_partition_ID = pi->partition_ID;
/* copy the null-term char too */
- strlcpy(&hvcsd->p_location_code[0],
- &pi->location_code[0], sizeof(hvcsd->p_location_code));
+ strcpy(&hvcsd->p_location_code[0], &pi->location_code[0]);
}
/*
--
1.7.7.6
^ permalink raw reply related
page: next (older) | prev (newer) | latest
- recent:[subjects (threaded)|topics (new)|topics (active)]
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox