LinuxPPC-Dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH v10 3/3] DMA: Freescale: update driver to support 8-channel DMA engine
From: hongbo.zhang @ 2013-09-18 10:15 UTC (permalink / raw)
  To: rob.herring, pawel.moll, mark.rutland, swarren, ian.campbell,
	vinod.koul, djbw
  Cc: Hongbo Zhang, devicetree, linuxppc-dev, linux-kernel
In-Reply-To: <1379499333-4745-1-git-send-email-hongbo.zhang@freescale.com>

From: Hongbo Zhang <hongbo.zhang@freescale.com>

This patch adds support to 8-channel DMA engine, thus the driver works for both
the new 8-channel and the legacy 4-channel DMA engines.

Signed-off-by: Hongbo Zhang <hongbo.zhang@freescale.com>
---
 drivers/dma/Kconfig  |    9 +++++----
 drivers/dma/fsldma.c |    9 ++++++---
 drivers/dma/fsldma.h |    2 +-
 3 files changed, 12 insertions(+), 8 deletions(-)

diff --git a/drivers/dma/Kconfig b/drivers/dma/Kconfig
index 6825957..3979c65 100644
--- a/drivers/dma/Kconfig
+++ b/drivers/dma/Kconfig
@@ -89,14 +89,15 @@ config AT_HDMAC
 	  Support the Atmel AHB DMA controller.
 
 config FSL_DMA
-	tristate "Freescale Elo and Elo Plus DMA support"
+	tristate "Freescale Elo series DMA support"
 	depends on FSL_SOC
 	select DMA_ENGINE
 	select ASYNC_TX_ENABLE_CHANNEL_SWITCH
 	---help---
-	  Enable support for the Freescale Elo and Elo Plus DMA controllers.
-	  The Elo is the DMA controller on some 82xx and 83xx parts, and the
-	  Elo Plus is the DMA controller on 85xx and 86xx parts.
+	  Enable support for the Freescale Elo series DMA controllers.
+	  The Elo is the DMA controller on some mpc82xx and mpc83xx parts, the
+	  EloPlus is on mpc85xx and mpc86xx and Pxxx parts, and the Elo3 is on
+	  some Txxx and Bxxx parts.
 
 config MPC512X_DMA
 	tristate "Freescale MPC512x built-in DMA engine support"
diff --git a/drivers/dma/fsldma.c b/drivers/dma/fsldma.c
index 49e8fbd..16a9a48 100644
--- a/drivers/dma/fsldma.c
+++ b/drivers/dma/fsldma.c
@@ -1261,7 +1261,9 @@ static int fsl_dma_chan_probe(struct fsldma_device *fdev,
 	WARN_ON(fdev->feature != chan->feature);
 
 	chan->dev = fdev->dev;
-	chan->id = ((res.start - 0x100) & 0xfff) >> 7;
+	chan->id = (res.start & 0xfff) < 0x300 ?
+		   ((res.start - 0x100) & 0xfff) >> 7 :
+		   ((res.start - 0x200) & 0xfff) >> 7;
 	if (chan->id >= FSL_DMA_MAX_CHANS_PER_DEVICE) {
 		dev_err(fdev->dev, "too many channels for device\n");
 		err = -EINVAL;
@@ -1434,6 +1436,7 @@ static int fsldma_of_remove(struct platform_device *op)
 }
 
 static const struct of_device_id fsldma_of_ids[] = {
+	{ .compatible = "fsl,elo3-dma", },
 	{ .compatible = "fsl,eloplus-dma", },
 	{ .compatible = "fsl,elo-dma", },
 	{}
@@ -1455,7 +1458,7 @@ static struct platform_driver fsldma_of_driver = {
 
 static __init int fsldma_init(void)
 {
-	pr_info("Freescale Elo / Elo Plus DMA driver\n");
+	pr_info("Freescale Elo series DMA driver\n");
 	return platform_driver_register(&fsldma_of_driver);
 }
 
@@ -1467,5 +1470,5 @@ static void __exit fsldma_exit(void)
 subsys_initcall(fsldma_init);
 module_exit(fsldma_exit);
 
-MODULE_DESCRIPTION("Freescale Elo / Elo Plus DMA driver");
+MODULE_DESCRIPTION("Freescale Elo series DMA driver");
 MODULE_LICENSE("GPL");
diff --git a/drivers/dma/fsldma.h b/drivers/dma/fsldma.h
index f5c3879..1ffc244 100644
--- a/drivers/dma/fsldma.h
+++ b/drivers/dma/fsldma.h
@@ -112,7 +112,7 @@ struct fsldma_chan_regs {
 };
 
 struct fsldma_chan;
-#define FSL_DMA_MAX_CHANS_PER_DEVICE 4
+#define FSL_DMA_MAX_CHANS_PER_DEVICE 8
 
 struct fsldma_device {
 	void __iomem *regs;	/* DGSR register base */
-- 
1.7.9.5

^ permalink raw reply related

* [PATCH v10 2/3] DMA: Freescale: Add new 8-channel DMA engine device tree nodes
From: hongbo.zhang @ 2013-09-18 10:15 UTC (permalink / raw)
  To: rob.herring, pawel.moll, mark.rutland, swarren, ian.campbell,
	vinod.koul, djbw
  Cc: Hongbo Zhang, devicetree, linuxppc-dev, linux-kernel
In-Reply-To: <1379499333-4745-1-git-send-email-hongbo.zhang@freescale.com>

From: Hongbo Zhang <hongbo.zhang@freescale.com>

Freescale QorIQ T4 and B4 introduce new 8-channel DMA engines, this patch adds
the device tree nodes for them.

Signed-off-by: Hongbo Zhang <hongbo.zhang@freescale.com>
---
 .../devicetree/bindings/powerpc/fsl/dma.txt        |   69 ++++++++++++++++
 arch/powerpc/boot/dts/fsl/b4si-post.dtsi           |    4 +-
 arch/powerpc/boot/dts/fsl/elo3-dma-0.dtsi          |   82 ++++++++++++++++++++
 arch/powerpc/boot/dts/fsl/elo3-dma-1.dtsi          |   82 ++++++++++++++++++++
 arch/powerpc/boot/dts/fsl/t4240si-post.dtsi        |    4 +-
 5 files changed, 237 insertions(+), 4 deletions(-)
 create mode 100644 arch/powerpc/boot/dts/fsl/elo3-dma-0.dtsi
 create mode 100644 arch/powerpc/boot/dts/fsl/elo3-dma-1.dtsi

diff --git a/Documentation/devicetree/bindings/powerpc/fsl/dma.txt b/Documentation/devicetree/bindings/powerpc/fsl/dma.txt
index 0584168..414fe42 100644
--- a/Documentation/devicetree/bindings/powerpc/fsl/dma.txt
+++ b/Documentation/devicetree/bindings/powerpc/fsl/dma.txt
@@ -128,6 +128,75 @@ Example:
 		};
 	};
 
+** Freescale Elo3 DMA Controller
+   DMA controller which has same function as EloPlus except that Elo3 has 8
+   channels while EloPlus has only 4, it is used in Freescale Txxx and Bxxx
+   series chips, such as t1040, t4240, b4860.
+
+Required properties:
+
+- compatible        : must include "fsl,elo3-dma"
+- reg               : DMA General Status Registers, i.e. DGSR0 which contains
+                      status for channel 1~4, and DGSR1 for channel 5~8
+- ranges            : describes the mapping between the address space of the
+                      DMA channels and the address space of the DMA controller
+
+- DMA channel nodes:
+        - compatible        : must include "fsl,eloplus-dma-channel"
+        - reg               : DMA channel specific registers
+        - interrupts        : interrupt specifier for DMA channel IRQ
+        - interrupt-parent  : optional, if needed for interrupt mapping
+
+Example:
+dma@100300 {
+	#address-cells = <1>;
+	#size-cells = <1>;
+	compatible = "fsl,elo3-dma";
+	reg = <0x100300 0x4>,
+	      <0x100600 0x4>;
+	ranges = <0x0 0x100100 0x500>;
+	dma-channel@0 {
+		compatible = "fsl,eloplus-dma-channel";
+		reg = <0x0 0x80>;
+		interrupts = <28 2 0 0>;
+	};
+	dma-channel@80 {
+		compatible = "fsl,eloplus-dma-channel";
+		reg = <0x80 0x80>;
+		interrupts = <29 2 0 0>;
+	};
+	dma-channel@100 {
+		compatible = "fsl,eloplus-dma-channel";
+		reg = <0x100 0x80>;
+		interrupts = <30 2 0 0>;
+	};
+	dma-channel@180 {
+		compatible = "fsl,eloplus-dma-channel";
+		reg = <0x180 0x80>;
+		interrupts = <31 2 0 0>;
+	};
+	dma-channel@300 {
+		compatible = "fsl,eloplus-dma-channel";
+		reg = <0x300 0x80>;
+		interrupts = <76 2 0 0>;
+	};
+	dma-channel@380 {
+		compatible = "fsl,eloplus-dma-channel";
+		reg = <0x380 0x80>;
+		interrupts = <77 2 0 0>;
+	};
+	dma-channel@400 {
+		compatible = "fsl,eloplus-dma-channel";
+		reg = <0x400 0x80>;
+		interrupts = <78 2 0 0>;
+	};
+	dma-channel@480 {
+		compatible = "fsl,eloplus-dma-channel";
+		reg = <0x480 0x80>;
+		interrupts = <79 2 0 0>;
+	};
+};
+
 Note on DMA channel compatible properties: The compatible property must say
 "fsl,elo-dma-channel" or "fsl,eloplus-dma-channel" to be used by the Elo DMA
 driver (fsldma).  Any DMA channel used by fsldma cannot be used by another
diff --git a/arch/powerpc/boot/dts/fsl/b4si-post.dtsi b/arch/powerpc/boot/dts/fsl/b4si-post.dtsi
index 7399154..ea53ea1 100644
--- a/arch/powerpc/boot/dts/fsl/b4si-post.dtsi
+++ b/arch/powerpc/boot/dts/fsl/b4si-post.dtsi
@@ -223,13 +223,13 @@
 		reg = <0xe2000 0x1000>;
 	};
 
-/include/ "qoriq-dma-0.dtsi"
+/include/ "elo3-dma-0.dtsi"
 	dma@100300 {
 		fsl,iommu-parent = <&pamu0>;
 		fsl,liodn-reg = <&guts 0x580>; /* DMA1LIODNR */
 	};
 
-/include/ "qoriq-dma-1.dtsi"
+/include/ "elo3-dma-1.dtsi"
 	dma@101300 {
 		fsl,iommu-parent = <&pamu0>;
 		fsl,liodn-reg = <&guts 0x584>; /* DMA2LIODNR */
diff --git a/arch/powerpc/boot/dts/fsl/elo3-dma-0.dtsi b/arch/powerpc/boot/dts/fsl/elo3-dma-0.dtsi
new file mode 100644
index 0000000..3c210e0
--- /dev/null
+++ b/arch/powerpc/boot/dts/fsl/elo3-dma-0.dtsi
@@ -0,0 +1,82 @@
+/*
+ * QorIQ Elo3 DMA device tree stub [ controller @ offset 0x100000 ]
+ *
+ * Copyright 2013 Freescale Semiconductor Inc.
+ *
+ * Redistribution and use in source and binary forms, with or without
+ * modification, are permitted provided that the following conditions are met:
+ *     * Redistributions of source code must retain the above copyright
+ *       notice, this list of conditions and the following disclaimer.
+ *     * Redistributions in binary form must reproduce the above copyright
+ *       notice, this list of conditions and the following disclaimer in the
+ *       documentation and/or other materials provided with the distribution.
+ *     * Neither the name of Freescale Semiconductor nor the
+ *       names of its contributors may be used to endorse or promote products
+ *       derived from this software without specific prior written permission.
+ *
+ *
+ * ALTERNATIVELY, this software may be distributed under the terms of the
+ * GNU General Public License ("GPL") as published by the Free Software
+ * Foundation, either version 2 of that License or (at your option) any
+ * later version.
+ *
+ * THIS SOFTWARE IS PROVIDED BY Freescale Semiconductor ``AS IS'' AND ANY
+ * EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED
+ * WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE
+ * DISCLAIMED. IN NO EVENT SHALL Freescale Semiconductor BE LIABLE FOR ANY
+ * DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES
+ * (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES;
+ * LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND
+ * ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
+ * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS
+ * SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
+ */
+
+dma0: dma@100300 {
+	#address-cells = <1>;
+	#size-cells = <1>;
+	compatible = "fsl,elo3-dma";
+	reg = <0x100300 0x4>,
+	      <0x100600 0x4>;
+	ranges = <0x0 0x100100 0x500>;
+	dma-channel@0 {
+		compatible = "fsl,eloplus-dma-channel";
+		reg = <0x0 0x80>;
+		interrupts = <28 2 0 0>;
+	};
+	dma-channel@80 {
+		compatible = "fsl,eloplus-dma-channel";
+		reg = <0x80 0x80>;
+		interrupts = <29 2 0 0>;
+	};
+	dma-channel@100 {
+		compatible = "fsl,eloplus-dma-channel";
+		reg = <0x100 0x80>;
+		interrupts = <30 2 0 0>;
+	};
+	dma-channel@180 {
+		compatible = "fsl,eloplus-dma-channel";
+		reg = <0x180 0x80>;
+		interrupts = <31 2 0 0>;
+	};
+	dma-channel@300 {
+		compatible = "fsl,eloplus-dma-channel";
+		reg = <0x300 0x80>;
+		interrupts = <76 2 0 0>;
+	};
+	dma-channel@380 {
+		compatible = "fsl,eloplus-dma-channel";
+		reg = <0x380 0x80>;
+		interrupts = <77 2 0 0>;
+	};
+	dma-channel@400 {
+		compatible = "fsl,eloplus-dma-channel";
+		reg = <0x400 0x80>;
+		interrupts = <78 2 0 0>;
+	};
+	dma-channel@480 {
+		compatible = "fsl,eloplus-dma-channel";
+		reg = <0x480 0x80>;
+		interrupts = <79 2 0 0>;
+	};
+};
diff --git a/arch/powerpc/boot/dts/fsl/elo3-dma-1.dtsi b/arch/powerpc/boot/dts/fsl/elo3-dma-1.dtsi
new file mode 100644
index 0000000..cccf3bb
--- /dev/null
+++ b/arch/powerpc/boot/dts/fsl/elo3-dma-1.dtsi
@@ -0,0 +1,82 @@
+/*
+ * QorIQ Elo3 DMA device tree stub [ controller @ offset 0x101000 ]
+ *
+ * Copyright 2013 Freescale Semiconductor Inc.
+ *
+ * Redistribution and use in source and binary forms, with or without
+ * modification, are permitted provided that the following conditions are met:
+ *     * Redistributions of source code must retain the above copyright
+ *       notice, this list of conditions and the following disclaimer.
+ *     * Redistributions in binary form must reproduce the above copyright
+ *       notice, this list of conditions and the following disclaimer in the
+ *       documentation and/or other materials provided with the distribution.
+ *     * Neither the name of Freescale Semiconductor nor the
+ *       names of its contributors may be used to endorse or promote products
+ *       derived from this software without specific prior written permission.
+ *
+ *
+ * ALTERNATIVELY, this software may be distributed under the terms of the
+ * GNU General Public License ("GPL") as published by the Free Software
+ * Foundation, either version 2 of that License or (at your option) any
+ * later version.
+ *
+ * THIS SOFTWARE IS PROVIDED BY Freescale Semiconductor ``AS IS'' AND ANY
+ * EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED
+ * WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE
+ * DISCLAIMED. IN NO EVENT SHALL Freescale Semiconductor BE LIABLE FOR ANY
+ * DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES
+ * (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES;
+ * LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND
+ * ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
+ * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS
+ * SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
+ */
+
+dma1: dma@101300 {
+	#address-cells = <1>;
+	#size-cells = <1>;
+	compatible = "fsl,elo3-dma";
+	reg = <0x101300 0x4>,
+	      <0x101600 0x4>;
+	ranges = <0x0 0x101100 0x500>;
+	dma-channel@0 {
+		compatible = "fsl,eloplus-dma-channel";
+		reg = <0x0 0x80>;
+		interrupts = <32 2 0 0>;
+	};
+	dma-channel@80 {
+		compatible = "fsl,eloplus-dma-channel";
+		reg = <0x80 0x80>;
+		interrupts = <33 2 0 0>;
+	};
+	dma-channel@100 {
+		compatible = "fsl,eloplus-dma-channel";
+		reg = <0x100 0x80>;
+		interrupts = <34 2 0 0>;
+	};
+	dma-channel@180 {
+		compatible = "fsl,eloplus-dma-channel";
+		reg = <0x180 0x80>;
+		interrupts = <35 2 0 0>;
+	};
+	dma-channel@300 {
+		compatible = "fsl,eloplus-dma-channel";
+		reg = <0x300 0x80>;
+		interrupts = <80 2 0 0>;
+	};
+	dma-channel@380 {
+		compatible = "fsl,eloplus-dma-channel";
+		reg = <0x380 0x80>;
+		interrupts = <81 2 0 0>;
+	};
+	dma-channel@400 {
+		compatible = "fsl,eloplus-dma-channel";
+		reg = <0x400 0x80>;
+		interrupts = <82 2 0 0>;
+	};
+	dma-channel@480 {
+		compatible = "fsl,eloplus-dma-channel";
+		reg = <0x480 0x80>;
+		interrupts = <83 2 0 0>;
+	};
+};
diff --git a/arch/powerpc/boot/dts/fsl/t4240si-post.dtsi b/arch/powerpc/boot/dts/fsl/t4240si-post.dtsi
index bd611a9..ec95c60 100644
--- a/arch/powerpc/boot/dts/fsl/t4240si-post.dtsi
+++ b/arch/powerpc/boot/dts/fsl/t4240si-post.dtsi
@@ -387,8 +387,8 @@
 		reg	   = <0xea000 0x4000>;
 	};
 
-/include/ "qoriq-dma-0.dtsi"
-/include/ "qoriq-dma-1.dtsi"
+/include/ "elo3-dma-0.dtsi"
+/include/ "elo3-dma-1.dtsi"
 
 /include/ "qoriq-espi-0.dtsi"
 	spi@110000 {
-- 
1.7.9.5

^ permalink raw reply related

* [PATCH v10 1/3] DMA: Freescale: revise device tree binding document
From: hongbo.zhang @ 2013-09-18 10:15 UTC (permalink / raw)
  To: rob.herring, pawel.moll, mark.rutland, swarren, ian.campbell,
	vinod.koul, djbw
  Cc: Hongbo Zhang, devicetree, linuxppc-dev, linux-kernel
In-Reply-To: <1379499333-4745-1-git-send-email-hongbo.zhang@freescale.com>

From: Hongbo Zhang <hongbo.zhang@freescale.com>

This patch updates the discription of each type of DMA controller and its
channels, it is preparation for adding another new DMA controller binding, it
also fixes some defects of indent for text alignment at the same time.

Signed-off-by: Hongbo Zhang <hongbo.zhang@freescale.com>
Acked-by: Mark Rutland <mark.rutland@arm.com>
---
 .../devicetree/bindings/powerpc/fsl/dma.txt        |   68 +++++++++-----------
 1 file changed, 31 insertions(+), 37 deletions(-)

diff --git a/Documentation/devicetree/bindings/powerpc/fsl/dma.txt b/Documentation/devicetree/bindings/powerpc/fsl/dma.txt
index 2a4b4bc..0584168 100644
--- a/Documentation/devicetree/bindings/powerpc/fsl/dma.txt
+++ b/Documentation/devicetree/bindings/powerpc/fsl/dma.txt
@@ -1,33 +1,30 @@
-* Freescale 83xx DMA Controller
+* Freescale DMA Controllers
 
-Freescale PowerPC 83xx have on chip general purpose DMA controllers.
+** Freescale Elo DMA Controller
+   This is a little-endian 4-channel DMA controller, used in Freescale mpc83xx
+   series chips such as mpc8315, mpc8349, mpc8379 etc.
 
 Required properties:
 
-- compatible        : compatible list, contains 2 entries, first is
-		 "fsl,CHIP-dma", where CHIP is the processor
-		 (mpc8349, mpc8360, etc.) and the second is
-		 "fsl,elo-dma"
-- reg               : <registers mapping for DMA general status reg>
-- ranges		: Should be defined as specified in 1) to describe the
-		  DMA controller channels.
+- compatible        : must include "fsl,elo-dma"
+- reg               : DMA General Status Register, i.e. DGSR which contains
+                      status for all the 4 DMA channels
+- ranges            : describes the mapping between the address space of the
+                      DMA channels and the address space of the DMA controller
 - cell-index        : controller index.  0 for controller @ 0x8100
-- interrupts        : <interrupt mapping for DMA IRQ>
+- interrupts        : interrupt specifier for DMA IRQ
 - interrupt-parent  : optional, if needed for interrupt mapping
 
-
 - DMA channel nodes:
-        - compatible        : compatible list, contains 2 entries, first is
-			 "fsl,CHIP-dma-channel", where CHIP is the processor
-			 (mpc8349, mpc8350, etc.) and the second is
-			 "fsl,elo-dma-channel". However, see note below.
-        - reg               : <registers mapping for channel>
-        - cell-index        : dma channel index starts at 0.
+        - compatible        : must include "fsl,elo-dma-channel"
+                              However, see note below.
+        - reg               : DMA channel specific registers
+        - cell-index        : DMA channel index starts at 0.
 
 Optional properties:
-        - interrupts        : <interrupt mapping for DMA channel IRQ>
-			  (on 83xx this is expected to be identical to
-			   the interrupts property of the parent node)
+        - interrupts        : interrupt specifier for DMA channel IRQ
+                              (on 83xx this is expected to be identical to
+                              the interrupts property of the parent node)
         - interrupt-parent  : optional, if needed for interrupt mapping
 
 Example:
@@ -70,30 +67,27 @@ Example:
 		};
 	};
 
-* Freescale 85xx/86xx DMA Controller
-
-Freescale PowerPC 85xx/86xx have on chip general purpose DMA controllers.
+** Freescale EloPlus DMA Controller
+   This is a 4-channel DMA controller with extended addresses and chaining,
+   mainly used in Freescale mpc85xx/86xx, Pxxx and BSC series chips, such as
+   mpc8540, mpc8641 p4080, bsc9131 etc.
 
 Required properties:
 
-- compatible        : compatible list, contains 2 entries, first is
-		 "fsl,CHIP-dma", where CHIP is the processor
-		 (mpc8540, mpc8540, etc.) and the second is
-		 "fsl,eloplus-dma"
-- reg               : <registers mapping for DMA general status reg>
+- compatible        : must include "fsl,eloplus-dma"
+- reg               : DMA General Status Register, i.e. DGSR which contains
+                      status for all the 4 DMA channels
 - cell-index        : controller index.  0 for controller @ 0x21000,
                                          1 for controller @ 0xc000
-- ranges		: Should be defined as specified in 1) to describe the
-		  DMA controller channels.
+- ranges            : describes the mapping between the address space of the
+                      DMA channels and the address space of the DMA controller
 
 - DMA channel nodes:
-        - compatible        : compatible list, contains 2 entries, first is
-			 "fsl,CHIP-dma-channel", where CHIP is the processor
-			 (mpc8540, mpc8560, etc.) and the second is
-			 "fsl,eloplus-dma-channel". However, see note below.
-        - cell-index        : dma channel index starts at 0.
-        - reg               : <registers mapping for channel>
-        - interrupts        : <interrupt mapping for DMA channel IRQ>
+        - compatible        : must include "fsl,eloplus-dma-channel"
+                              However, see note below.
+        - cell-index        : DMA channel index starts at 0.
+        - reg               : DMA channel specific registers
+        - interrupts        : interrupt specifier for DMA channel IRQ
         - interrupt-parent  : optional, if needed for interrupt mapping
 
 Example:
-- 
1.7.9.5

^ permalink raw reply related

* [PATCH v10 0/3] DMA: Freescale: Add support for 8-channel DMA engine
From: hongbo.zhang @ 2013-09-18 10:15 UTC (permalink / raw)
  To: rob.herring, pawel.moll, mark.rutland, swarren, ian.campbell,
	vinod.koul, djbw
  Cc: Hongbo Zhang, devicetree, linuxppc-dev, linux-kernel

From: Hongbo Zhang <hongbo.zhang@freescale.com>

Hi DMA and DT maintainers, please have a look at these V10 patches.

Freescale QorIQ T4 and B4 introduce new 8-channel DMA engines, this patch set
adds support this DMA engine.

V9->V10 changes:
- update binding description text, mainly about the reg property and also Elo3
  DMA controller specification

V8->V9 changes:
- add "Acked-by: Mark Rutland <mark.rutland@arm.com>" into patch [1/3]
- update reg entry <0x100300 0x4 0x100600 0x4> to two seperate ones
  <0x100300 0x4>, <0x100600 0x4> in patch [2/3]
- and also use "QorIQ Elo3 DMA" to mention previous "QorIQ DMA" in [2/3]

V7->V8 changes:
- change the word "mapping" to "specifier" for reg and interrupts description

V6->V7 changes:
- only remove unnecessary "CHIP-dma" explanations in [1/3]

V5->V6 changes:
- minor updates of descriptions in binding document and Kconfig
- remove [4/4], that should be another patch in future

V4->V5 changes:
- update description in the dt binding document, to make it more resonable
- add new patch [4/4] to eliminate a compiling warning which already exists
  for a long time

V3->V4 changes:
- introduce new patch [1/3] to revise the legacy dma binding document
- and then add new paragraph to describe new dt node binding in [2/3]
- rebase to latest kernel v3.11-rc1

V2->V3 changes:
- edit Documentation/devicetree/bindings/powerpc/fsl/dma.txt
- edit text string in Kconfig and the driver files, using "elo series" to
  mention all the current "elo*"

V1->V2 changes:
- removed the codes handling the register dgsr1, since it isn't used currently
- renamed the DMA DT compatible to "fsl,elo3-dma"
- renamed the new dts files to "elo3-dma-<n>.dtsi"

Hongbo Zhang (3):
  DMA: Freescale: revise device tree binding document
  DMA: Freescale: Add new 8-channel DMA engine device tree nodes
  DMA: Freescale: update driver to support 8-channel DMA engine

 .../devicetree/bindings/powerpc/fsl/dma.txt        |  137 ++++++++++++++------
 arch/powerpc/boot/dts/fsl/b4si-post.dtsi           |    4 +-
 arch/powerpc/boot/dts/fsl/elo3-dma-0.dtsi          |   82 ++++++++++++
 arch/powerpc/boot/dts/fsl/elo3-dma-1.dtsi          |   82 ++++++++++++
 arch/powerpc/boot/dts/fsl/t4240si-post.dtsi        |    4 +-
 drivers/dma/Kconfig                                |    9 +-
 drivers/dma/fsldma.c                               |    9 +-
 drivers/dma/fsldma.h                               |    2 +-
 8 files changed, 280 insertions(+), 49 deletions(-)
 create mode 100644 arch/powerpc/boot/dts/fsl/elo3-dma-0.dtsi
 create mode 100644 arch/powerpc/boot/dts/fsl/elo3-dma-1.dtsi

-- 
1.7.9.5

^ permalink raw reply

* Re: [PATCH v2 2/6] PCI/MSI: Factor out pci_get_msi_cap() interface
From: Alexander Gordeev @ 2013-09-18  9:48 UTC (permalink / raw)
  To: Michael Ellerman
  Cc: linuxppc-dev, Joerg Roedel, x86@kernel.org,
	linux-kernel@vger.kernel.org, linux-ide@vger.kernel.org,
	Jan Beulich, linux-pci@vger.kernel.org, Tejun Heo, Bjorn Helgaas,
	Ingo Molnar
In-Reply-To: <20130917143022.GA7707@concordia>

On Wed, Sep 18, 2013 at 12:30:23AM +1000, Michael Ellerman wrote:
> How about no?
> 
> We have a small number of MSIs available, limited by hardware &
> firmware, if we don't impose a quota then the first device that probes
> will get most/all of the MSIs and other devices miss out.

Out of curiosity - how pSeries has had done it without quotas before
448e2ca ("powerpc/pseries: Implement a quota system for MSIs")?

> Anyway I don't see what problem you're trying to solve? I agree the
> -ve/0/+ve return value pattern is ugly, but it's hardly the end of the
> world.

Well, the interface recently has been re-classified from "ugly" to
"unnecessarily complex and actively harmful" in Tejun's words ;)

Indeed, I checked most of the drivers and it is incredible how people
are creative in misusing the interface: from innocent pci_disable_msix()
calls when if pci_enable_msix() failed to assuming MSI-Xs were enabled
if pci_enable_msix() returned a positive value (apparently untested).

Roughly third of the drivers just do not care and bail out once
pci_enable_msix() has not succeeded. Not sure how many of these are
mandated by the hardware.

Another quite common pattern is a call to pci_enable_msix() to figure out
the number of MSI-Xs available and a repeated call of pci_enable_msix()
to enable those MSI-Xs, this time.

The last pattern makes most of sense to me and could be updated with a more
clear sequence - a call to (bit modified) pci_msix_table_size() followed
by a call to pci_enable_msix(). I think this pattern can effectively
supersede the currently recommended "loop" practice.

But as pSeries quota is still required I propose to introduce a new interface
pci_get_msix_limit() that combines pci_msix_table_size() and (also new)
arch_get_msix_limit(). The latter would check the quota thing in case of
pSeries and none in case of all other architectures.

The recommended practice would be:

	/*
	 * Retrieving 'nvec' by means other than pci_msix_table_size()
	 */

	rc = pci_get_msix_limit(pdev);
	if (rc < 0)
		return rc;

	/*
	 * nvec = min(rc, nvec);
	 */

	for (i = 0; i < nvec; i++)
		msix_entry[i].entry = i;

	rc = pci_enable_msix(pdev, msix_entry, nvec);
	if (rc)
		return rc;

Thoughts?

> cheers

-- 
Regards,
Alexander Gordeev
agordeev@redhat.com

^ permalink raw reply

* RE: [PATCH v3] powerpc/p1010rdb-pb:make a new dts for p1010rdb-pb
From: Liu Shengzhou-B36685 @ 2013-09-18  5:43 UTC (permalink / raw)
  To: Zhao Qiang-B45475; +Cc: linuxppc-dev@lists.ozlabs.org
In-Reply-To: <1379480097-11698-1-git-send-email-B45475@freescale.com>



> -----Original Message-----
> From: Zhao Qiang-B45475
> Sent: Wednesday, September 18, 2013 12:55 PM
> To: linuxppc-dev@lists.ozlabs.org
> Cc: Zhao Qiang-B45475; Liu Shengzhou-B36685
> Subject: [PATCH v3] powerpc/p1010rdb-pb:make a new dts for p1010rdb-pb
>=20
> P1010RDB-PA and P1010RDB-PB boards use different external PHY interrupt s=
ignals.
> So make a new dts for P1010RDB-PB.
>=20
> Signed-off-by: Shengzhou Liu <Shengzhou.Liu@freescale.com>
> Signed-off-by: Zhao Qiang <B45475@freescale.com>
> ---
> Changes for v2:
> 	-Remove phy interrupts for p1010rdb-pb
> Changes for v3:
> 	-Maintain the phy interrupts p1010rdb-pa and make a new device
> 	tree for p1010rdb-pb
>=20
>  arch/powerpc/boot/dts/p1010rdb-pa.dtsi | 11 ++++++
> arch/powerpc/boot/dts/p1010rdb-pb.dts  | 67 +++++++++++++++++++++++++++++=
+++++
>  arch/powerpc/boot/dts/p1010rdb-pb.dtsi | 11 ++++++
>  arch/powerpc/boot/dts/p1010rdb.dts     |  1 +
>  arch/powerpc/boot/dts/p1010rdb.dtsi    |  3 --
>  arch/powerpc/platforms/85xx/p1010rdb.c | 29 +++++++++++++++
>  6 files changed, 119 insertions(+), 3 deletions(-)  create mode 100644
> arch/powerpc/boot/dts/p1010rdb-pa.dtsi
>  create mode 100644 arch/powerpc/boot/dts/p1010rdb-pb.dts
>  create mode 100644 arch/powerpc/boot/dts/p1010rdb-pb.dtsi
>=20

Don't touch p1010rdb.c, create two p1010rdb-pa.dts and p1010rdb-pb.dts, whi=
ch include the common p1010rdb.dtsi.
Combine original p1010rdb.dts and p1010rdb.dtsi into new p1010rdb.dtsi with=
 removing compatible part.
Place phy node and following part in p1010rdb-pa.dts and p1010rdb-pb.dts.
/ {
        model =3D "fsl,P1010RDB-PA";
        compatible =3D "fsl,P1010RDB";
  }

/ {
        model =3D "fsl,P1010RDB-PB";
        compatible =3D "fsl,P1010RDB";
  }

-Shengzhou

^ permalink raw reply

* Re: [PATCH 1/8][v4] powerpc/perf: Rename Power8 macros to start with PME
From: Anshuman Khandual @ 2013-09-18  5:24 UTC (permalink / raw)
  To: Sukadev Bhattiprolu
  Cc: linuxppc-dev, Michael Ellerman, Paul Mackerras, linux-kernel,
	Stephane Eranian
In-Reply-To: <1379119755-21025-2-git-send-email-sukadev@linux.vnet.ibm.com>

On 09/14/2013 06:19 AM, Sukadev Bhattiprolu wrote:
> We use helpers like GENERIC_EVENT_ATTR() to list the generic events in
> sysfs. To avoid name collisions, GENERIC_EVENT_ATTR() requires the perf
> event macros to start with PME.

We got all the raw event codes covered for P7 with the help of power7-events-list.h
enumeration.

/*
 * Power7 event codes.
 */
#define EVENT(_name, _code) \
	PME_##_name = _code,

enum {
#include "power7-events-list.h"
};
#undef EVENT

Just wondering if its a good idea to name change these selected macros to be consumed
by GENERIC_EVENT_ATTR() right here for this purpose or we need to get the comprehensive
list of raw events for P8 first. Just an idea.

Regards
Anshuman

^ permalink raw reply

* [PATCH v3] powerpc/p1010rdb-pb:make a new dts for p1010rdb-pb
From: Zhao Qiang @ 2013-09-18  4:54 UTC (permalink / raw)
  To: linuxppc-dev; +Cc: Zhao Qiang, Shengzhou Liu

P1010RDB-PA and P1010RDB-PB boards use different external PHY
interrupt signals.
So make a new dts for P1010RDB-PB.

Signed-off-by: Shengzhou Liu <Shengzhou.Liu@freescale.com>
Signed-off-by: Zhao Qiang <B45475@freescale.com>
---
Changes for v2:
	-Remove phy interrupts for p1010rdb-pb
Changes for v3:
	-Maintain the phy interrupts p1010rdb-pa and make a new device 
	tree for p1010rdb-pb

 arch/powerpc/boot/dts/p1010rdb-pa.dtsi | 11 ++++++
 arch/powerpc/boot/dts/p1010rdb-pb.dts  | 67 ++++++++++++++++++++++++++++++++++
 arch/powerpc/boot/dts/p1010rdb-pb.dtsi | 11 ++++++
 arch/powerpc/boot/dts/p1010rdb.dts     |  1 +
 arch/powerpc/boot/dts/p1010rdb.dtsi    |  3 --
 arch/powerpc/platforms/85xx/p1010rdb.c | 29 +++++++++++++++
 6 files changed, 119 insertions(+), 3 deletions(-)
 create mode 100644 arch/powerpc/boot/dts/p1010rdb-pa.dtsi
 create mode 100644 arch/powerpc/boot/dts/p1010rdb-pb.dts
 create mode 100644 arch/powerpc/boot/dts/p1010rdb-pb.dtsi

diff --git a/arch/powerpc/boot/dts/p1010rdb-pa.dtsi b/arch/powerpc/boot/dts/p1010rdb-pa.dtsi
new file mode 100644
index 0000000..122996e
--- /dev/null
+++ b/arch/powerpc/boot/dts/p1010rdb-pa.dtsi
@@ -0,0 +1,11 @@
+&phy0 {
+	interrupts = <3 1 0 0>;
+};
+
+&phy1 {
+	interrupts = <2 1 0 0>;
+};
+
+&phy2 {
+	interrupts = <2 1 0 0>;
+};
diff --git a/arch/powerpc/boot/dts/p1010rdb-pb.dts b/arch/powerpc/boot/dts/p1010rdb-pb.dts
new file mode 100644
index 0000000..0213552
--- /dev/null
+++ b/arch/powerpc/boot/dts/p1010rdb-pb.dts
@@ -0,0 +1,67 @@
+/*
+ * P1010 RDB-PB Device Tree Source
+ *
+ * Copyright 2011 Freescale Semiconductor Inc.
+ *
+ * This program is free software; you can redistribute  it and/or modify it
+ * under  the terms of  the GNU General  Public License as published by the
+ * Free Software Foundation;  either version 2 of the  License, or (at your
+ * option) any later version.
+ */
+
+/include/ "fsl/p1010si-pre.dtsi"
+
+/ {
+	model = "fsl,P1010RDB-PB";
+	compatible = "fsl,P1010RDB-PB";
+
+	memory {
+		device_type = "memory";
+	};
+
+	board_ifc: ifc: ifc@ffe1e000 {
+		/* NOR, NAND Flashes and CPLD on board */
+		ranges = <0x0 0x0 0x0 0xee000000 0x02000000
+			  0x1 0x0 0x0 0xff800000 0x00010000
+			  0x3 0x0 0x0 0xffb00000 0x00000020>;
+		reg = <0x0 0xffe1e000 0 0x2000>;
+	};
+
+	board_soc: soc: soc@ffe00000 {
+		ranges = <0x0 0x0 0xffe00000 0x100000>;
+	};
+
+	pci0: pcie@ffe09000 {
+		reg = <0 0xffe09000 0 0x1000>;
+		ranges = <0x2000000 0x0 0xa0000000 0 0xa0000000 0x0 0x20000000
+			  0x1000000 0x0 0x00000000 0 0xffc10000 0x0 0x10000>;
+		pcie@0 {
+			ranges = <0x2000000 0x0 0xa0000000
+				  0x2000000 0x0 0xa0000000
+				  0x0 0x20000000
+
+				  0x1000000 0x0 0x0
+				  0x1000000 0x0 0x0
+				  0x0 0x100000>;
+		};
+	};
+
+	pci1: pcie@ffe0a000 {
+		reg = <0 0xffe0a000 0 0x1000>;
+		ranges = <0x2000000 0x0 0x80000000 0 0x80000000 0x0 0x20000000
+			  0x1000000 0x0 0x00000000 0 0xffc00000 0x0 0x10000>;
+		pcie@0 {
+			ranges = <0x2000000 0x0 0x80000000
+				  0x2000000 0x0 0x80000000
+				  0x0 0x20000000
+
+				  0x1000000 0x0 0x0
+				  0x1000000 0x0 0x0
+				  0x0 0x100000>;
+		};
+	};
+};
+
+/include/ "p1010rdb.dtsi"
+/include/ "p1010rdb-pb.dtsi"
+/include/ "fsl/p1010si-post.dtsi"
diff --git a/arch/powerpc/boot/dts/p1010rdb-pb.dtsi b/arch/powerpc/boot/dts/p1010rdb-pb.dtsi
new file mode 100644
index 0000000..52cd22e
--- /dev/null
+++ b/arch/powerpc/boot/dts/p1010rdb-pb.dtsi
@@ -0,0 +1,11 @@
+&phy0 {
+	interrupts = <0 1 0 0>;
+};
+
+&phy1 {
+	interrupts = <2 1 0 0>;
+};
+
+&phy2 {
+	interrupts = <1 1 0 0>;
+};
diff --git a/arch/powerpc/boot/dts/p1010rdb.dts b/arch/powerpc/boot/dts/p1010rdb.dts
index b868d22..0980ff0 100644
--- a/arch/powerpc/boot/dts/p1010rdb.dts
+++ b/arch/powerpc/boot/dts/p1010rdb.dts
@@ -63,4 +63,5 @@
 };
 
 /include/ "p1010rdb.dtsi"
+/include/ "p1010rdb-pa.dtsi"
 /include/ "fsl/p1010si-post.dtsi"
diff --git a/arch/powerpc/boot/dts/p1010rdb.dtsi b/arch/powerpc/boot/dts/p1010rdb.dtsi
index 7fc3402..2433ae4 100644
--- a/arch/powerpc/boot/dts/p1010rdb.dtsi
+++ b/arch/powerpc/boot/dts/p1010rdb.dtsi
@@ -199,17 +199,14 @@
 
 	mdio@24000 {
 		phy0: ethernet-phy@0 {
-			interrupts = <3 1 0 0>;
 			reg = <0x1>;
 		};
 
 		phy1: ethernet-phy@1 {
-			interrupts = <2 1 0 0>;
 			reg = <0x0>;
 		};
 
 		phy2: ethernet-phy@2 {
-			interrupts = <2 1 0 0>;
 			reg = <0x2>;
 		};
 
diff --git a/arch/powerpc/platforms/85xx/p1010rdb.c b/arch/powerpc/platforms/85xx/p1010rdb.c
index 0252961..7d9eab7 100644
--- a/arch/powerpc/platforms/85xx/p1010rdb.c
+++ b/arch/powerpc/platforms/85xx/p1010rdb.c
@@ -82,3 +82,32 @@ define_machine(p1010_rdb) {
 	.calibrate_decr		= generic_calibrate_decr,
 	.progress		= udbg_progress,
 };
+
+machine_arch_initcall(p1010_rdb_pb, mpc85xx_common_publish_devices);
+machine_arch_initcall(p1010_rdb_pb, swiotlb_setup_bus_notifier);
+
+/*
+ * Called very early, device-tree isn't unflattened
+ */
+static int __init p1010_rdb_pb_probe(void)
+{
+	unsigned long root = of_get_flat_dt_root();
+
+	if (of_flat_dt_is_compatible(root, "fsl,P1010RDB-PB"))
+		return 1;
+	return 0;
+}
+
+define_machine(p1010_rdb_pb) {
+	.name			= "P1010 RDB-PB",
+	.probe			= p1010_rdb_pb_probe,
+	.setup_arch		= p1010_rdb_setup_arch,
+	.init_IRQ		= p1010_rdb_pic_init,
+#ifdef CONFIG_PCI
+	.pcibios_fixup_bus	= fsl_pcibios_fixup_bus,
+#endif
+	.get_irq		= mpic_get_irq,
+	.restart		= fsl_rstcr_restart,
+	.calibrate_decr		= generic_calibrate_decr,
+	.progress		= udbg_progress,
+};
-- 
1.8.0

^ permalink raw reply related

* [PATCH v3] powerpc/p1010rdb-pb:make a new dts for p1010rdb-pb
From: Zhao Qiang @ 2013-09-18  4:04 UTC (permalink / raw)
  To: linuxppc-dev; +Cc: Zhao Qiang, Shengzhou Liu

P1010RDB-PA and P1010RDB-PB boards use different external PHY
interrupt signals.
So make a new dts for P1010RDB-PB.

Signed-off-by: Shengzhou Liu <Shengzhou.Liu@freescale.com>
Signed-off-by: Zhao Qiang <B45475@freescale.com>
---
Changes for v2:
	-Remove phy interrupts for p1010rdb-pb
Changes for v3
	-Maintain the phy interrupts p1010rdb-pa and make a new device 
	tree for p1010rdb-pb

 arch/powerpc/boot/dts/p1010rdb-pa.dtsi |  11 ++++++
 arch/powerpc/boot/dts/p1010rdb-pb.dts  |  67 +++++++++++++++++++++++++++++++++
 arch/powerpc/boot/dts/p1010rdb-pb.dtsi |  11 ++++++
 arch/powerpc/boot/dts/p1010rdb.dts     |   1 +
 arch/powerpc/boot/dts/p1010rdb.dtsi    |   3 --
 arch/powerpc/boot/p1010rdb-pb.dtb      | Bin 0 -> 14030 bytes
 arch/powerpc/boot/p1010rdb.dtb         | Bin 0 -> 14030 bytes
 arch/powerpc/platforms/85xx/p1010rdb.c |  29 ++++++++++++++
 8 files changed, 119 insertions(+), 3 deletions(-)
 create mode 100644 arch/powerpc/boot/dts/p1010rdb-pa.dtsi
 create mode 100644 arch/powerpc/boot/dts/p1010rdb-pb.dts
 create mode 100644 arch/powerpc/boot/dts/p1010rdb-pb.dtsi
 create mode 100644 arch/powerpc/boot/p1010rdb-pb.dtb
 create mode 100644 arch/powerpc/boot/p1010rdb.dtb

diff --git a/arch/powerpc/boot/dts/p1010rdb-pa.dtsi b/arch/powerpc/boot/dts/p1010rdb-pa.dtsi
new file mode 100644
index 0000000..122996e
--- /dev/null
+++ b/arch/powerpc/boot/dts/p1010rdb-pa.dtsi
@@ -0,0 +1,11 @@
+&phy0 {
+	interrupts = <3 1 0 0>;
+};
+
+&phy1 {
+	interrupts = <2 1 0 0>;
+};
+
+&phy2 {
+	interrupts = <2 1 0 0>;
+};
diff --git a/arch/powerpc/boot/dts/p1010rdb-pb.dts b/arch/powerpc/boot/dts/p1010rdb-pb.dts
new file mode 100644
index 0000000..0213552
--- /dev/null
+++ b/arch/powerpc/boot/dts/p1010rdb-pb.dts
@@ -0,0 +1,67 @@
+/*
+ * P1010 RDB-PB Device Tree Source
+ *
+ * Copyright 2011 Freescale Semiconductor Inc.
+ *
+ * This program is free software; you can redistribute  it and/or modify it
+ * under  the terms of  the GNU General  Public License as published by the
+ * Free Software Foundation;  either version 2 of the  License, or (at your
+ * option) any later version.
+ */
+
+/include/ "fsl/p1010si-pre.dtsi"
+
+/ {
+	model = "fsl,P1010RDB-PB";
+	compatible = "fsl,P1010RDB-PB";
+
+	memory {
+		device_type = "memory";
+	};
+
+	board_ifc: ifc: ifc@ffe1e000 {
+		/* NOR, NAND Flashes and CPLD on board */
+		ranges = <0x0 0x0 0x0 0xee000000 0x02000000
+			  0x1 0x0 0x0 0xff800000 0x00010000
+			  0x3 0x0 0x0 0xffb00000 0x00000020>;
+		reg = <0x0 0xffe1e000 0 0x2000>;
+	};
+
+	board_soc: soc: soc@ffe00000 {
+		ranges = <0x0 0x0 0xffe00000 0x100000>;
+	};
+
+	pci0: pcie@ffe09000 {
+		reg = <0 0xffe09000 0 0x1000>;
+		ranges = <0x2000000 0x0 0xa0000000 0 0xa0000000 0x0 0x20000000
+			  0x1000000 0x0 0x00000000 0 0xffc10000 0x0 0x10000>;
+		pcie@0 {
+			ranges = <0x2000000 0x0 0xa0000000
+				  0x2000000 0x0 0xa0000000
+				  0x0 0x20000000
+
+				  0x1000000 0x0 0x0
+				  0x1000000 0x0 0x0
+				  0x0 0x100000>;
+		};
+	};
+
+	pci1: pcie@ffe0a000 {
+		reg = <0 0xffe0a000 0 0x1000>;
+		ranges = <0x2000000 0x0 0x80000000 0 0x80000000 0x0 0x20000000
+			  0x1000000 0x0 0x00000000 0 0xffc00000 0x0 0x10000>;
+		pcie@0 {
+			ranges = <0x2000000 0x0 0x80000000
+				  0x2000000 0x0 0x80000000
+				  0x0 0x20000000
+
+				  0x1000000 0x0 0x0
+				  0x1000000 0x0 0x0
+				  0x0 0x100000>;
+		};
+	};
+};
+
+/include/ "p1010rdb.dtsi"
+/include/ "p1010rdb-pb.dtsi"
+/include/ "fsl/p1010si-post.dtsi"
diff --git a/arch/powerpc/boot/dts/p1010rdb-pb.dtsi b/arch/powerpc/boot/dts/p1010rdb-pb.dtsi
new file mode 100644
index 0000000..52cd22e
--- /dev/null
+++ b/arch/powerpc/boot/dts/p1010rdb-pb.dtsi
@@ -0,0 +1,11 @@
+&phy0 {
+	interrupts = <0 1 0 0>;
+};
+
+&phy1 {
+	interrupts = <2 1 0 0>;
+};
+
+&phy2 {
+	interrupts = <1 1 0 0>;
+};
diff --git a/arch/powerpc/boot/dts/p1010rdb.dts b/arch/powerpc/boot/dts/p1010rdb.dts
index b868d22..0980ff0 100644
--- a/arch/powerpc/boot/dts/p1010rdb.dts
+++ b/arch/powerpc/boot/dts/p1010rdb.dts
@@ -63,4 +63,5 @@
 };
 
 /include/ "p1010rdb.dtsi"
+/include/ "p1010rdb-pa.dtsi"
 /include/ "fsl/p1010si-post.dtsi"
diff --git a/arch/powerpc/boot/dts/p1010rdb.dtsi b/arch/powerpc/boot/dts/p1010rdb.dtsi
index 7fc3402..2433ae4 100644
--- a/arch/powerpc/boot/dts/p1010rdb.dtsi
+++ b/arch/powerpc/boot/dts/p1010rdb.dtsi
@@ -199,17 +199,14 @@
 
 	mdio@24000 {
 		phy0: ethernet-phy@0 {
-			interrupts = <3 1 0 0>;
 			reg = <0x1>;
 		};
 
 		phy1: ethernet-phy@1 {
-			interrupts = <2 1 0 0>;
 			reg = <0x0>;
 		};
 
 		phy2: ethernet-phy@2 {
-			interrupts = <2 1 0 0>;
 			reg = <0x2>;
 		};
 
diff --git a/arch/powerpc/boot/p1010rdb-pb.dtb b/arch/powerpc/boot/p1010rdb-pb.dtb
new file mode 100644
index 0000000000000000000000000000000000000000..3d9865f45acf180ca5154948b43203701a0c247a
GIT binary patch
literal 14030
zcmeHO%a7zn8Mk|uM_95f?+{)c2BAR4v)w(9od7{*lMHM?$!0e}hzRX^+@2X{?QXB_
zo}Gz=Gzxz}76~M7?2!v7z=Z=s$uSp{Tf_x6JQWmB#3j7M@cVsLWmmg<COgSq5>k?<
z>-*}f-}k8USLL$j*_;3SSI1fYmE$-ojx+y5{N9f1-MEh9LOJp&@H15(`|E0I2EQV^
zUL<p8x}9$4>^-NvGpE?hwj;QX;%Zs+tqmGF9O4<QlT)zVFdG$+VWHexaNX6L?<|mk
zLLSQlxJ>;KtG;2?M^^oDtNtCUe$}e~*sA}+sy}1Ze{I!Y(DirW_n+DDa+G^fx)$~O
zQ6C&-pNWg{n>6FX;+|ojGk2?a`W^D<6J*>L;$YLqNT8VZ_n^*Lo68N7I4B|s9c7@y
zojp+uLw|ie>ad(BqC5@~e{rcJniLl0?wBsOY|DKVatq^fQMnoAgQ)b^2oIes)J@sD
z_LJ>S%6@4-+1|J;;_N<nA`9b4oVwGrQYYKKR<{Lq+bw8&WL!rW4E%1Wh1j1m7pBPc
zwG89zrcpY~cTiJ)z74FF#S@u$T|(Yv&_z<oejc)srsd~v_{$C`<{oqQb}NcDN!fc+
ze%km;-f@V_T-ba58c3El|FF%>HNqO2bIr`X_oD9bo`a1}5vN%ad29M^qkJ2p34Wo&
zn1-6;u%9+nXm>Eo{mz`YXY}yiH+sw*H}pH$D_oDg^&}`Z1w!n5r}2d>tw7_smo>}K
zkAo(jn+16pm+^4mFCxN~4R04LYUZW<N1WUz?tkEH`<{nRwNIzPh8_T_vT#-=ae(Gz
zgb_PGXmGw74@TSVuW;5U7T`2IF--SYw(SDN2S;Ik*kInbx_YkHK06$i?bSGm+UItP
zGD=0Rf!kfDp&FQR5nT5r)Q*chdC2L?=ZC#h#I)QNUm)Us4}XX)_=8~3_q%E^!PD`U
zTyDm%Ii5E|&dei^{Yj&+uNhPJg(~&89y77NvRzth+mX{?`xo!Or#)#r`=C^|TjR%!
zV!|ResCW~%#%6v{*yEF-5o2bYDOhb_`M8vi%oPf2`h;j;B9BhPyZ|&Gm%?NoR+x7W
z(=3mQBI>u#uAZ|8uz|}QH^tVgKzxa?5{r*ixcg7E25y&$)c{vx<z4||R^it1d>HFW
zJIJFz+K451VV3m$g+t9Nu4yu_GVU+({+dS+fgPJ$dM-F^G_j8PDfxo4&CrjdPP($k
zUJAiyp)6)dotO8nDUNRAygw+fQEv;l5ECrs+S-0EPSd=ZW-I%CKv@(w?uGtB6>if$
zRWId@e?KCDLYmo%dOcvVs(D-|Iv^Pa;n7#-_d9SgE~Zc(#r-+|L{XLxQ-6s)QP?K=
zyC~;+i(zkRS=hp-|6GgC;F2-V%g|q55drq&{?f^?>j;PGTvnb87Z(;(tHL$?Hz8Jy
zlf(nJH2b0uXTNc<+Fi!OjQ;`g=xVXU$D>DW${yr6#|g?bN*Iz3F^!!PkF%gFe~K*j
zPabZ3C2m}&(=1$BT3GfXfKUkv<Dv4K+>97f#Y08L_H&?{W6L=I5`4zTl{I*5uQ_$D
znOMFLeVif-1_hSfxuUmJB;DT1q|X%7W92^ATKfiRD@V(4TDGHAOqV{gzMeaCy1mN%
z!DRAhKa@k}ewhV=4<FnoYW%SUK;~_|K6R_j02J2t-U7<UrFh)mT6ohJ0mwG6m!@NX
z9g;pSh5fN{?D56GTFe{RcTUItK2UjgDeOiZ^n$Q@j_t$~%p!?HH9f?C8KuX9Jc$Pv
z=aOh;rMD~@z>Kx*MKwO>*>lcglEy2%QL*Ot>Ww`6;hD~TVN|B}oF?z@o5P|+I}7Cy
zXO-80(ewJbx7D3rmPDr+Y)7fbsnrH4CX@F{c>{uS&tQ!d-|-_w;*j>^q2J>kQ+U^j
zr}BSP7E##q2*J+mOI^pDmanQuB{9=J*E~ge+2)QFcgB*jHTR*h6)cs|SwYcux&P92
zP16Nw6JN%3NV=-}+2dz)NFM^|V(WM-c(xAGlR8wgH2tW9GNg?T$wi<|F|zdICS0}-
z(xRhWizQ48suyLL3tO5`uEC*B*4a<`s`13LZwH)8Zffo`?bzdtjVIKQQ~81MJOdIg
z9X(D|8Bb$lcQVe*>j&9P-|<Xoe4yDvH+<lJl1)bLwfb-YP&d>E?ichph!3PIAF?t|
zqa0@jct8f9g|Z)Dg=^kM91PZj+{?<$6HzuO8MW>ml_~qA=HaKsOmFmkhzyIi&zyKq
zF~%GxBaf=k>{H!~)`^CZ`-1L68uPJrI^Rg+*o*t1S&ZB_QMd4?j*YpeW$xkt<?=AU
zXfSv`os1qjckkWgC|vGAB{nLrkgD{tqwW8<EE?6;6IvFyt*fY;V(k4X7|6YjdubGn
zB5xxfjxx)AqvsX<I3^ODN6I#gt>jkbaG3;bK*9PpMt`C~8@rwce-D?TpVc(68e>(R
zC>dFf72{~=-=c2rE5_k;!Lb7q#mKxK$BpAYK5kVgj9=F?ZXC0TahnCx9=A_6=-V5#
ziQ^&0t=bfrz8p8^dP8&EOfGpNjT`Uh@o}p{VSK-yaccu+V%$Csraf*Hvgz9zw2AdA
zk6V~}NpM+jQN&Jp4r0!ZR2!g$&%CDh6_tI+iLJk&oqg2(8>W6eU8P^O2FUZj2UL~y
z@GFJ3YV5H&3qo=YnYOQ@N1e}l;c!sq!z97dQw5uN-1~_ZrE@}>&6eIa$jYY!^)^o1
zb)4ln)nLl`v63T8^vLrTV>&3h%S(6)H@~`F`+qM;*Ysg*UnYS<J;tujpgs`~W0yYN
zx9uVz>DOS_D!RWqyEd|TXpa&PI|0U`ZJc2ar$3~tGsx`Hg2%q#v9L|Y=p|GuTTDz&
zfN95s@+dRrjN2`OGVtXwP&MFhwGYfLd2IH!>iw<K<?ccZDk@vY&LfQO`_OLdW?k!R
zzRS>aa$kK{&~-weiH*_s>1q1PKJL3}3n}rc_7`aD&UesD`9Yjxj(Y(lpj%Jjw~fn;
z$J9B;9FCY&#f;r7IJ>yS=drgh3QryyIq%hdxSmAYkWw)9n7U7aQ~7QDq{YNFrPg8I
z-W*EDv%s0qaTk~qI+C6j2H|F8&s$~}8iYc-@!rSIFH?F{*=Nz4)~a#TJQE8l+i>5{
z@L{~IWk|2e?o;W8;MBaR$3*tRMAWo^^A9h#p9X%fi<3zZC|c&gbx919^&lB$$*Ayv
zVft$Od7D-HW2^=G?6t*5BhhbcGv}MM!wWZq0baS-YY$Ik)ap>{GIDGpj?zg=&Alcz
zX%i#nT`_>dC?*C5(_c}6V4uV2-i16bTQ`%Et^56;57e!XLl3E&Y9@43kFA?)?!mg1
z<A>F~J4H7!Y~48bo6s$BFZ!FI->crBvd^u!syn5F6H$n$@s}D~1zXRvYanGh+WNi>
zrtK@+aL<h8F|cMH)N*c^?_}jrj_1|rD;<?BIOXxS7Uvhm5KU-7jXkqQKz%{if%i{+
zKd^@kpXJjy56;QG{aHxbKDm$P)wYT~=5X2OEqad**StI)Y}njR&4oDo>3fGU<Rv_#
z(*temWSx4=#_9&>Z3FVU^_tfwH$ZRaFnZ15;0@60U$0(?b%rC_>g~508}y&ya!Fgv
zJVVvcGvC&HwyUwF6fY&i=PsEMDZp7rp)B}rYnVj?Z=BEO?`j$T{6N=%IP){q_i9?!
z8I$wSE>nlJ_@a)37Q0rCtDXaBi?@*s*Mg*Z7R0%D%sIk!15iiC))gPT1P!Lp4;FPt
zDZfaIA^0`z&0n!E#j99+Ip8mL5pniX@}iJyo!GdwFyHmkVk58Gb&RWJh1kBf>q*p&
zZg%)dgXWox-OhO0H0y3!#IQ;4;+0L+o>**x0OVMxTiYX{-K}{u&!CPXp`qNaw(%P3
zc6r_=Q2$+n{(Xb~LxcWfgZ@*4{&RyCANAbmy}G$^8zAA=ky%1x-boyM?H_3t`pm*J
zFcw4Oyg`bg`Ru`BXt7UE%~2UA_#`DNeEHI<lB=H^_&(d)7?nlUrp7~_k};Jl+?n5?
zF4*!t839kqtfO8LRC5mR1s7MmEDcRxgO`EP#^vI@v==59{S`_meE2-`A_Q4PhmpBc
z@u)*&ba2LGx?+a-FEVUI8I$QP3a`QewTnyBk_Q-PO$!3)af~H!Dw&xVQTJ<FFzAAf
zL3$j6yW&blFxoXO7<}fjF-Q}`T<+v&W+IO<P-h!^*RDXE1uTVyP`eQUSgy+7`nL@l
zvvI8KJ*`RAKzroLvVIPt6_S=O4fFVtM-oq;^9v20g3<oCEr^k$Y1uo`EJGXLNh5YM
z|E4gCm9twfyZ^cRFnE-q&&;QE)VPN#-tY2Lybh}(=QsT~!dEGQ(#B=Sz^=1hg;KDP
zIL#T7wAg>NAF`$q!uZ8~*?xXv&W^=pKcBR}M=&q{Ve91m&$cVLMP&bPHPQxNylp02
z(sHzmZJh7>$q=7y%su<b7#+07mLb0AkTKympVcRjVmJMjY_oUmDnwbpQa+8%+g)-|
zcIB_*wDD^zB75&C{zXv@wEGP+Z+GDg1Ie;0e<x$mjK}MI-qOnnm$d6<-m-l^88dH<
ztnNDYW9F@qHI3|JuAA_kP!^Q&S`s<4LBG$h;Jh$OlERrS;>U2zBK3GsMtMHUN)O*{
zM1#^vhy5sV)Cbscf#bO-=hrG0XU(cdRy`=~mawpzqIp<RV@C5?YLlU@FvU7tix$}!
zF~8n#(6*W)n_u5@(sbmNJ6YuPqpdiM&PzRyHk?7UU3y8h6(#DV$x+9*9sS#N%&YxQ
zRjYYD2g#trKV1ihX&wIQI(abIz<1(R6bol97+mx&$Nh3s>(@jQtRb%WvajzA2g#0u
zZ-u?}Ji?p8LAc{^FuZuskG7rudXeX{B=JinZ!k)6Y!YWhltdx+JmjUpw$&HkIw&9e
z`FW0>gU?Gw+jAMtdHM)D*T1sx${{{aMk-U#Wr~-=d7+;A!(<p<^orpq4<k?MaRBOR
z09JA0KY)5n1QlBK;@L=01?)VZZ=aVppM@wTryS$pt6@BYWI=c_Djg`rlSmqbo}Qi3
z3A->GHQ)Bu;u2Ds@}nmCX@KP+!-O{~g`=FQBRi|k!ez2Ij>QF%vE<g+E0Q6?tBxQM
zK`?NaXj-Z~8;R$F5h59;{ccaX^PnQigL(#7$Cu7*H81qtwia)A(V&mF^7xi<uz^p;
z@t+A^u)ZD-;&R8q7h5G}fw?2qh&Xum@Pe%%#tcFSJ>wYi&7kn|q72oLB69euCk={=
cGPgv|G7BM8jWs@_`eu1E0&hm(|2G2v1J)fHaR2}S

literal 0
HcmV?d00001

diff --git a/arch/powerpc/boot/p1010rdb.dtb b/arch/powerpc/boot/p1010rdb.dtb
new file mode 100644
index 0000000000000000000000000000000000000000..435166cb47f2b3adf04fe9e10376f5737d795962
GIT binary patch
literal 14030
zcmeHO%a7zn8Mk|uM_95f?+{)c2BAR4v)w(9od7{5kAV#++3Y3=5ushT+cV>=-R-sA
zvon#9M&S=gkU-+b9=U)5TsR<<9CJarMO<LRQ$YbmT*6BXzu#9?cD1`_vy<#4Atkw8
z-&bG#zDIqovdivgZ~X6H9cT4dj^nI3&f*Voz7@y2aU92ia^zFsXR1E&>uPEa=Nnny
zD3XQK-A=c2=I%SKwj-z?#nHk+S<*K*Xy|Z=XRuDrz;eTETtJ3}a&N(LM{lvSL<S0Z
zEcfFu^@pwcrd1zX^~bFGcdYtltNvrF{tK)Aj8*@&RewR(--Yu(v(cp}_oB2P4F=Hw
z9A%%0i}BmUh3)QX_Bnl*il^VP`nWB`!KROqK%vjTaNmP7V{HyMNaCP~By^NP?A`ej
z#VGVQHlhy8i6YA5An})1I-*HoQSP?ca;vu7M<KT~DHoMnQ9g`HzfXARWT9@#-f@s@
zcUtyK2g&v(Wf5ohffHF6N8;4&rj<I`_O-e#u-k4z+ryJO!eHokLoLMqlsP{`W}syl
zXE%+~QND|s^7CzAwJe^<#2XUwE`u(TO7`=RjWjK%zu}i1P|P*v?C(_+ZIZJ8q@3FL
zCGR-IB^UOezXFn_%^$XzTqCTZc@3J}doSv8{lZ44h|?^IyuQBLDBp%?f-`g&(@=99
z_S2>c?G8t|-&qj%j2>S5MvuvHL%)N)!j0J5NP=QZAjH0R8ehoL3N)U3NwW<77--_T
zS&)};8IOkkG9p~r@OHtXW**9a#L0d9zWdL#?|$&k_Ng@3)B`|O7S7r<4$z#8Fk<Hi
z4bE5N;drP06=r>60nWk`!*qXT+a6GSa1`c;4d%V;>t}oIGow-2UXPQgeRj7fqg3P?
zxZMpJs(~37!F69k?YPL3hdEvO{E&AiF)g>n7l^pu!w<0qe;5o0epd}9cskxPmz(ix
zj%T$FAdfuuM?V(!HDk)YP^EtBF%#=6+oiR(9djCN|Kfdjx2KI~AC$^=Yy3E)n6QWq
zD&EAcu{l2|?8#(k#F#VA46HV=d>qP0&J_x4c0x2TF^|r|JP$M<hr;AMtT68yrCA;o
zMKoxiSwCwJU;~$P+zeYU1MwxoN-RE7;U1i54csm#Rs&p(mHPw`vkJG4=R;Um+Cd%#
z(nc)73$tY4FC8kcxTeYcl=1!|AM`zf2<${|>0EHyXks1tDf0!h&CrjbPP($kUJAiy
zp)4|_o|pHpD2{Gp-d}BAquv&9AtqRyYis+xI8F2BG+WvC1InVfaWC|js&Je3nR+R2
z{QD6J6w;insMiA)tD47kq63m)5FUNy{C*n_#>EuMqqslkPZVYODD_v^6NPOue;4IK
zZ#nF(tO{HB^q*_dX&f@<c^UevYa+mYyuWlZ+;xPbbRjEGhRaJ!s#W2d{#y{M#!2FV
zOPYOAh;z_5SnV$3VaER|@#t!?!^fjXZOR_ZagGy|X_PP|9by_gB_3x$SN;@P?4LZ`
z_)6S(Z=7b~+RD<Z7XgGyP#6z2zsbdjAyqt7WNbeNx;eIt^Dn_?d|X+BC+;<8=9-D+
z`_RWJvS3(X$z3RVD@D@ntxfw(F+Eo9bFKb2NLzEX45wu~TE%qfBkSwg)2G_&yg!(p
z{MirXkaNFef#Aaj_wgEkVgZo6t=Fe+bu$2kwY@ii@^L60?{6)<*^2;V8`vwevA+&U
zABV#J*d+GkVqh)i4eZ-zV}Bp0yt)*2BMy2&SU<~l;t6Jv#Gy(L@n1&i(I8La;e~}H
zT3hR_$_!w}TJA+PKJ)B3=TVu)E4*>h_j~n?Jp199&V6BArglz~_xG()QKFrNa)`5<
z*MQOU2D!K0U0jukPBYk!Qjb%s4N^=d@0I2a2+B2sHBx-XNs7cF9mFHQ$9qiST_c{F
z|D&>q!k$M6c4lAdI_9)|RXr*bGwpNDQ<Rr&?OJhXEE!vK9U5DSMV=|zF85zxu&!yk
zAa(I&LWfLOMox4XS))Vxkg1EU<E`M?I!I6JP?M$UM?WY-`dW0{pk)yQc5_IJj<O$1
zn3l*@c$^Dcns0a}cGSmy(pQZqo_#wMGd|3m`%F9TaVEwSYRIYlz<8bp373u@C#sC6
zv9UWHXU^-i=^&dqhIpnlwu$eg8$R%U65LAewfb-#P}kK5-Y@8}7avGhK4fK_MmhEj
z@PG_H3uQmR3fH{NI2djOxtEohC!%anGK||X=cr6MPih`cE$}OSA0oq|?L8;v1!K%{
zvh5?yKGn5o?PwUeFX%p`k&mrY`DPl&UOWKJV&uMwx`jV;Y|J$+d4LU+OQZaP!Ql0D
zGJ5drJ$I3#aCr|Zu~G91sY)L^+WvpbqET%<u4RGSx{SIh#@?TTfw|XlFOH*e<Zb4o
zab~%1^t_@U7#Bh#kCbf~TbWxqhf5N$0R`*Z1pSEyZR~m){CymTepb`OYK&F2qhw?`
zR*a*ee~Y@gt{8_?1;-9d6eII`95;^p<hWI#Fn(RjxN*#;#%&%<d)z+Rpl@x^CXR;~
zx9X<A^yRp5t~WHt&CDflq;cbwGC6KlD2(sdGHz|aOpV*e!L-MXLN<L%gEp~#<#7vB
zF9|N`TNJTVo`X1NN2(3b!sooE?+YvYFekSDf_C;%*Ke5mb-GHwY7LO*e-Ef?*27r}
zZPnNlISWGO8ZvEPMUUE_^}^Ax%tuLrrKbuu@p$hiT9nQyX*OGW+aN2SuBx}O+pgm*
z&#49za}xFsWLKUn(Id}WjOnoGuCCxI+?;j0_WvG`uIa<rzDxpzdW>D4L47J7#xA|P
zZ`(yc(yzg;b##Aqc5P<y$Q~tbb^?q=+c?KLoc@rm_8_y1OCI}z$HF!pqnA*vY%wu8
z0j3=j%A?GgJ#M!M%D|V$K-GZX>OL^L=&{+`uJ3P^E_V-NP*K@Bu^(Y{--~uzH|tto
z^Ie9{$piI0fv!{fOl*w4PtVd<4shL7w~!LA>iz<4-Ng=iDL;sF%yG|y1a#{uoZC3e
zc+AW>&f$njRm|AUgR_T2e4cpwqVVLQk$JDK!;K``fs}%&$JBiaoXT(GCoLwfDYXvs
z_U2GJo(0a7jyu4d(vkGMFbKCIJ8wC=&>$4rjrTtG{4%3QHTx`kvsyKd$}_Q`vJKb$
z93RHpT88wx+<hwD5S%$L>M@afVIpc;!1=?&9i)NZ>tbgT1d5iq>bfL`$$F5CvSeI%
zz%YHa{k+Vo`(vyHdhfNxM<da1Y%}|tw8IOxf+1eH*lQ1WWYp?V>oRg|B978YO66V?
zo3x1$=Up*?!YC#N2Gd_tfncA*=-z`o4_h}UC0qCVL0?t3-VQyaZmOBmO+B`5uDMs&
ztsFnB?!6hhiDB!;zTcE?iF+~F3jJR729<qo#!+1<9qfogM2)}H*ecjM&#r)!bhPz-
z8BE((w&9wYn8(1HdqB&%VZNJ{BiWu;qpx&SwqTdX+g@H=7DF_l1vU0upMd&+uB%=@
z_4U9WGJKX#lRP*l*Y;;2Y5U|pl2^A??6H8uHgDN`WYqWac(`eEJ2e;L?5D3C#*l~b
zj7|@<t&?@?H8)n*L2nz7*R0pPKDiEhJBQJ0HV3bRUjJJ4N~|+%(N=H2)!3l_9G6Sl
zV)6`CL(hF%^VzP(mQp;F44=CsBT|5~jzU@R-PS0JhTbHf&EM5BJpDk|fjIXw)c0#z
z))_PBp<PmkwD_X7gO<D299KOD&=zkq8TEstxfjG-JmwtXx&f#o6YGi(UV;Ww=m(3s
zqLg2x#SolLd-E*zrFa#KF9-bPE+WoeN?sIltrHu!mlnHTT5RT3yN+?StPtDRc0Gx@
z(ajD&Y0%u0vD+C>n`Yfjix@WPyLe?&bx$ldK>%_r)UEB2(C*c|xo1#Ek<d_XPuq9}
zb-O%o6R7{LLI1u%|Di$uu|fZ-LI1fyi;p@tdao`wZUH3xIx<ga<ekL9*Zz@aq0cPb
z17k5X_8X)an$I3Ah8FvDYL3e|!6zwE;mem+m0bPY!1vkS=C~}XHZ>mdl#EoaaOZx5
zx?s!qWCT1ZSx3DhsB#YP1((;nEDcRxgO`EP#^K_<v==59{547_eE2-~A_Q4PhmpBm
z@u)*&bZ{nQx?+a-FEVUInULu%3$MZfwTDB~G7m7$nid4olNc-DR5EifqVCtUV9*5{
zgY+Z@?}{rK!D!dCVDOp8#vn}$bGXx=nTb5cK<#bpUwH!JEMO@tgxZY=z;aoB>vJ14
zvT>s9KdnjCKzroLvVIPt6*4Vf9Odyvk0hQx7nd451*83OTM#2h(^KDJ8sFKD*v<W0
zb+_m2*30gHE<dC(=riY2I%?cw7ZsxptD?(q`fr3UQv#)p!;XPnXS)ieU}54kdq~n^
z|7gEtO(Vp$_=%jIh|57f5escckeC0kb@KXW+Y@M$`+uvEHt^tOGv$(&V<_0hd_PEr
z_-y0cbC8VDL3?Z&;){+dZ>vur#cuj5v(5gM%MfJ&OZhaBw|nHG?8&d=v~ji-k-h&E
ze^FEe?S8}L?H-&ldCNLW8;2bOyUzC4dEU~4DVNAZF?q}OgJewJ8d>Ss_%V5FWKA>s
znBxX~CzJ(c+)pBBJ{S!66`U7FNm4lTMf@nXS)?8h%P7ysS?S@sjc8ap>1Yroj`{#Q
zF0efp<@{R3;`FV0WYvSxZV3ykDO!XTHD<J!r8XJb3RA4ZwP=w|5Q`gw25qY;vc-*U
zCr!s*xtm4KAli<@=$zE^Xww-+JEfOI+fkx+njE!#+tKH)V_xlds#?wKIhYJO{OLN_
zOzZHc>*T?36W@tfQ7oK(FudShiU;ME)~|^q=p(N9vTxvxhRLpjZ-u>$Ji?p8VYusX
zFuZs;h<2R8Mv>>TB=JinZ#Yh|Z4zfiltdx!dB{tH9jh<Cbx=MI@^c(L2cMUWcNQ}2
z^9&Gnu773Wl_PwfjL+8<beZC%a9*gV{xBJZ7rbIL&cn!4dK`dy8h};o_z$5TiJ(HO
zUOXEKs(_v6@||<?=Ccr`<dhQ}d^L<`kSqu<M5P0zcoIp2(9_u|op2XsqvktaKQ1Aa
zDL-nGp9WYSGE8`*QaH+)I<oU>FI<wnu`Mo;j3sZ4y&@SQylM*)5d;HQiKeB>y^(k!
z7$cHlI_UPKJ2xt#Jg76k+P-w=tGv)xTR-0PqTv8<<?$`!a1)=5<DUs$u(1&j<8s%*
z7h5H=z+91PL>xSOc)@lMBZJUEXB<Pm6%<}xl%X0@L=Io|q(N~(a!ceavk*enSmQIQ
PZ<aSB@MZ-5e<Sce9HbcW

literal 0
HcmV?d00001

diff --git a/arch/powerpc/platforms/85xx/p1010rdb.c b/arch/powerpc/platforms/85xx/p1010rdb.c
index 0252961..7d9eab7 100644
--- a/arch/powerpc/platforms/85xx/p1010rdb.c
+++ b/arch/powerpc/platforms/85xx/p1010rdb.c
@@ -82,3 +82,32 @@ define_machine(p1010_rdb) {
 	.calibrate_decr		= generic_calibrate_decr,
 	.progress		= udbg_progress,
 };
+
+machine_arch_initcall(p1010_rdb_pb, mpc85xx_common_publish_devices);
+machine_arch_initcall(p1010_rdb_pb, swiotlb_setup_bus_notifier);
+
+/*
+ * Called very early, device-tree isn't unflattened
+ */
+static int __init p1010_rdb_pb_probe(void)
+{
+	unsigned long root = of_get_flat_dt_root();
+
+	if (of_flat_dt_is_compatible(root, "fsl,P1010RDB-PB"))
+		return 1;
+	return 0;
+}
+
+define_machine(p1010_rdb_pb) {
+	.name			= "P1010 RDB-PB",
+	.probe			= p1010_rdb_pb_probe,
+	.setup_arch		= p1010_rdb_setup_arch,
+	.init_IRQ		= p1010_rdb_pic_init,
+#ifdef CONFIG_PCI
+	.pcibios_fixup_bus	= fsl_pcibios_fixup_bus,
+#endif
+	.get_irq		= mpic_get_irq,
+	.restart		= fsl_rstcr_restart,
+	.calibrate_decr		= generic_calibrate_decr,
+	.progress		= udbg_progress,
+};
-- 
1.8.0

^ permalink raw reply related

* RE: [PATCH v3 4/4] powerpc/85xx: add sysfs for pw20 state and altivec idle
From: Wang Dongsheng-B40534 @ 2013-09-18  3:35 UTC (permalink / raw)
  To: Wood Scott-B07421; +Cc: linuxppc-dev@lists.ozlabs.org
In-Reply-To: <1379365769.2536.169.camel@snotra.buserror.net>

DQoNCj4gLS0tLS1PcmlnaW5hbCBNZXNzYWdlLS0tLS0NCj4gRnJvbTogV29vZCBTY290dC1CMDc0
MjENCj4gU2VudDogVHVlc2RheSwgU2VwdGVtYmVyIDE3LCAyMDEzIDU6MDkgQU0NCj4gVG86IFdh
bmcgRG9uZ3NoZW5nLUI0MDUzNA0KPiBDYzogV29vZCBTY290dC1CMDc0MjE7IGdhbGFrQGtlcm5l
bC5jcmFzaGluZy5vcmc7IGxpbnV4cHBjLQ0KPiBkZXZAbGlzdHMub3psYWJzLm9yZw0KPiBTdWJq
ZWN0OiBSZTogW1BBVENIIHYzIDQvNF0gcG93ZXJwYy84NXh4OiBhZGQgc3lzZnMgZm9yIHB3MjAg
c3RhdGUgYW5kDQo+IGFsdGl2ZWMgaWRsZQ0KPiANCj4gT24gVGh1LCAyMDEzLTA5LTEyIGF0IDIx
OjUzIC0wNTAwLCBXYW5nIERvbmdzaGVuZy1CNDA1MzQgd3JvdGU6DQo+ID4NCj4gPiA+IC0tLS0t
T3JpZ2luYWwgTWVzc2FnZS0tLS0tDQo+ID4gPiBGcm9tOiBXb29kIFNjb3R0LUIwNzQyMQ0KPiA+
ID4gU2VudDogRnJpZGF5LCBTZXB0ZW1iZXIgMTMsIDIwMTMgMjowNyBBTQ0KPiA+ID4gVG86IFdh
bmcgRG9uZ3NoZW5nLUI0MDUzNA0KPiA+ID4gQ2M6IFdvb2QgU2NvdHQtQjA3NDIxOyBnYWxha0Br
ZXJuZWwuY3Jhc2hpbmcub3JnOyBsaW51eHBwYy0NCj4gPiA+IGRldkBsaXN0cy5vemxhYnMub3Jn
DQo+ID4gPiBTdWJqZWN0OiBSZTogW1BBVENIIHYzIDQvNF0gcG93ZXJwYy84NXh4OiBhZGQgc3lz
ZnMgZm9yIHB3MjAgc3RhdGUNCj4gPiA+IGFuZCBhbHRpdmVjIGlkbGUNCj4gPiA+DQo+ID4gPiBP
biBXZWQsIDIwMTMtMDktMTEgYXQgMjI6NDggLTA1MDAsIFdhbmcgRG9uZ3NoZW5nLUI0MDUzNCB3
cm90ZToNCj4gPiA+ID4NCj4gPiA+ID4gPiAtLS0tLU9yaWdpbmFsIE1lc3NhZ2UtLS0tLQ0KPiA+
ID4gPiA+IEZyb206IFdvb2QgU2NvdHQtQjA3NDIxDQo+ID4gPiA+ID4gU2VudDogVGh1cnNkYXks
IFNlcHRlbWJlciAxMiwgMjAxMyA3OjA0IEFNDQo+ID4gPiA+ID4gVG86IFdhbmcgRG9uZ3NoZW5n
LUI0MDUzNA0KPiA+ID4gPiA+IENjOiBnYWxha0BrZXJuZWwuY3Jhc2hpbmcub3JnOyBsaW51eHBw
Yy1kZXZAbGlzdHMub3psYWJzLm9yZw0KPiA+ID4gPiA+IFN1YmplY3Q6IFJlOiBbUEFUQ0ggdjMg
NC80XSBwb3dlcnBjLzg1eHg6IGFkZCBzeXNmcyBmb3IgcHcyMA0KPiA+ID4gPiA+IHN0YXRlIGFu
ZCBhbHRpdmVjIGlkbGUNCj4gPiA+ID4gPg0KPiA+ID4gPiA+IE9uIFdlZCwgMjAxMy0wOS0xMSBh
dCAxMzo1NiArMDgwMCwgRG9uZ3NoZW5nIFdhbmcgd3JvdGU6DQo+ID4gPiA+ID4gPiBGcm9tOiBX
YW5nIERvbmdzaGVuZyA8ZG9uZ3NoZW5nLndhbmdAZnJlZXNjYWxlLmNvbT4NCj4gPiA+ID4gPiA+
DQo+ID4gPiA+ID4gPiBBZGQgYSBzeXMgaW50ZXJmYWNlIHRvIGVuYWJsZS9kaWFibGUgcHcyMCBz
dGF0ZSBvciBhbHRpdmVjDQo+ID4gPiA+ID4gPiBpZGxlLCBhbmQgY29udHJvbCB0aGUgd2FpdCBl
bnRyeSB0aW1lLg0KPiA+ID4gPiA+ID4NCj4gPiA+ID4gPiA+IEVuYWJsZS9EaXNhYmxlIGludGVy
ZmFjZToNCj4gPiA+ID4gPiA+IDAsIGRpc2FibGUuIDEsIGVuYWJsZS4NCj4gPiA+ID4gPiA+IC9z
eXMvZGV2aWNlcy9zeXN0ZW0vY3B1L2NwdVgvcHcyMF9zdGF0ZQ0KPiA+ID4gPiA+ID4gL3N5cy9k
ZXZpY2VzL3N5c3RlbS9jcHUvY3B1WC9hbHRpdmVjX2lkbGUNCj4gPiA+ID4gPiA+DQo+ID4gPiA+
ID4gPiBTZXQgd2FpdCBlbnRyeSBiaXQgaW50ZXJmYWNlOg0KPiA+ID4gPiA+ID4gYml0IHZhbHVl
IHJhbmdlIDB+NjMsIDAgYml0IGlzIE1pbnRpbWUsIDYzIGJpdCBpcyBNYXh0aW1lLg0KPiA+ID4g
PiA+ID4gL3N5cy9kZXZpY2VzL3N5c3RlbS9jcHUvY3B1WC9wdzIwX3dhaXRfZW50cnlfYml0DQo+
ID4gPiA+ID4gPiAvc3lzL2RldmljZXMvc3lzdGVtL2NwdS9jcHVYL2FsdGl2ZWNfaWRsZV93YWl0
X2VudHJ5X2JpdA0KPiA+ID4gPiA+DQo+ID4gPiA+ID4gSSdtIG5vIGZhbiBvZiB0aGUgd2F5IHBv
d2VycGMgZG9lcyBiaXQgbnVtYmVyaW5nLCBidXQgZG9uJ3QgZmxpcA0KPiA+ID4gPiA+IGl0IGFy
b3VuZCBoZXJlIC0tIHlvdSdsbCBqdXN0IGNhdXNlIGNvbmZ1c2lvbi4NCj4gPiA+ID4gPg0KPiA+
ID4gPiBPSy4gMCBiaXQgaXMgbWF4dGltZSwgNjMgYml0IGlzIG1pbnRpbWUuDQo+ID4gPiA+DQo+
ID4gPiA+ID4gQmV0dGVyIHlldCwgdGhpcyBpbnRlcmZhY2Ugc2hvdWxkIHRha2UgcmVhbCB0aW1l
IHVuaXRzIHJhdGhlcg0KPiA+ID4gPiA+IHRoYW4gYSB0aW1lYmFzZSBiaXQuDQo+ID4gPiA+ID4N
Cj4gPiA+ID4gSSB0aGluayB0aGUgcmVhbCB0aW1lIGlzIG5vdCBzdWl0YWJsZSwgYmVjYXVzZSB0
aW1lYmFzZSBiaXQgZG9lcw0KPiA+ID4gPiBub3QgY29ycmVzcG9uZCB3aXRoIHJlYWwgdGltZS4N
Cj4gPiA+DQo+ID4gPiBJdCdzIGEgYml0IHNsb3BweSBkdWUgdG8gaG93IHRoZSBoYXJkd2FyZSB3
b3JrcywgYnV0IHlvdSBjb3VsZA0KPiA+ID4gY29udmVydCBpdCBsaWtlIHlvdSBkaWQgaW4gZWFy
bGllciBwYXRjaGVzLiAgU2VtYW50aWNhbGx5IGl0IHNob3VsZA0KPiA+ID4gcHJvYmFibHkgYmUg
dGhlIG1pbmltdW0gdGltZSB0byB3YWl0IGJlZm9yZSBlbnRlcmluZyB0aGUgbG93IHBvd2VyDQo+
IHN0YXRlLg0KPiA+ID4NCj4gPiBCdXQgdGhlcmUgaGFzIGEgcHJvYmxlbSwgd2UgY2FuJ3QgY29u
dmVydCBiaXQgdG8gdGhlIHJlYWwgdGltZSB3aGVuDQo+IHVzZXIgcmVhZCB0aGlzIHN5c2ZzLg0K
PiA+IExpa2U6DQo+ID4gZWNobyAxMDAwKHVzKSA+IC9zeXMvKi9wdzIwX3dhaXRfZW50cnlfYml0
LCBhZnRlciBjb252ZXJ0IHdlIGdldCBiaXQgaXMNCj4gNDkuDQo+ID4gY2F0IC9zeXMvKi9wdzIw
X3dhaXRfZW50cnlfYml0LCBhZnRlciBjb252ZXJ0IHRoZSB0aW1lIGlzIDE1OTgodXMpLg0KPiA+
DQo+ID4gVGhlIHJlYWQgb3V0IG9mIHRoZSB0aW1lIGlzIG5vdCByZWFsIHRpbWUuIFVubGVzcyB3
ZSBkZWZpbmUgYSB2YXJpYWJsZQ0KPiB0byBzYXZlIHRoZSByZWFsIHRpbWUuDQo+IA0KPiBJdCdz
IG5vdCB0aGUgZW5kIG9mIHRoZSB3b3JsZCBpZiB0aGUgdmFsdWUgaXMgZGlmZmVyZW50IHdoZW4g
cmVhZCBiYWNrLg0KPiBJdCBqdXN0IGdldHMgcm91bmRlZCB1cCB3aGVuIHlvdSB3cml0ZSBpdC4N
Cj4gDQpPaywgbWFrZSBhIHZhcmlhYmxlIHRvIHNhdmUgaXQuDQoNCj4gPiA+ID4gPiBBbHNvLCB5
b3UgZGlzYWJsZSB0aGUgcG93ZXIgc2F2aW5nIG1vZGUgaWYgdGhlIG1heGltdW0gaW50ZXJ2YWwN
Cj4gPiA+ID4gPiBpcyBzZWxlY3RlZCwNCj4gPiA+ID4gSXQncyBub3QgZGlzYWJsZSB0aGUgcHcy
MCBzdGF0ZSBvciBhbHRpdmVjIGlkbGUsIGp1c3QgbWF4LWRlbGF5DQo+ID4gPiA+IGVudHJ5DQo+
ID4gPiB0aW1lLg0KPiA+ID4NCj4gPiA+IE5vLCB0aGUgY29kZSBjaGVja3MgZm9yIHplcm8gdG8g
c2V0IG9yIGNsZWFyIHRoZSBlbmFibGluZyBiaXQgKGUuZy4NCj4gPiA+IFBXMjBfV0FJVCkuDQo+
ID4gPg0KPiA+IFRoZXJlIGhhcyBwdzIwX3N0YXRlL2FsdGl2ZWNfaWRsZSBzeXMgaW50ZXJmYWNl
IHRvIGNvbnRyb2wNCj4gPiAiZW5hYmxlL2Rpc2FibGUiLCBUaGVyZSBpcyBvbmx5IHRvIGNvbnRy
b2wgd2FpdCBiaXQuIERpZCB5b3UgbWVhbg0KPiByZW1vdmUgInB3MjBfc3RhdGUvYWx0aXZlY19p
ZGxlIg0KPiA+IHN5cyBpbnRlcmZhY2UsIGFuZCByZXVzZSAicHcyMF93YWl0X2VudHJ5X2JpdC9h
bHRpdmVjX2lkbGUqIiBzeXMNCj4gaW50ZXJmYWNlPw0KPiA+IFdoZW4gZWNobyB6ZXJvIGludG8g
InB3MjBfd2FpdF9lbnRyeV9iaXQiIHdlIGp1c3QgdG8gZGlzYWJsZSBwdzIwDQo+ID4gc3RhdGUs
IEkgdGhpbmsgdGhhdCBpcyByZWFzb25hYmxlLiA6KQ0KPiANCj4gU29ycnksIEkgbWlzcmVhZCB0
aGUgcGF0Y2ggYW5kIGRpZG4ndCByZWFsaXplIHRoZXNlIHdlcmUgc2VwYXJhdGUNCj4gaW50ZXJm
YWNlcy4NCktlZXAgdGhlICJwdzIwX3N0YXRlL2FsdGl2ZWNfaWRsZSIgaW50ZXJmYWNlcy4NCg0K
LWRvbmdzaGVuZw0K

^ permalink raw reply

* [PATCH v3] powerpc 8xx: Fixing issue with CONFIG_PIN_TLB
From: Christophe Leroy @ 2013-09-17 17:09 UTC (permalink / raw)
  To: Benjamin Herrenschmidt, Paul Mackerras, scottwood
  Cc: linuxppc-dev, linux-kernel

Activating CONFIG_PIN_TLB is supposed to pin the IMMR and the first three
8Mbytes pages. But the setting of the MD_CTR was missing so as the index is
decremented every DTLB update, the pinning of the third 8Mbytes page was
overwriting the DTLB entry for IMMR. At the same time, the last entry written
being entry 31, next entries would possibly get overwritten after.
We are now starting from entry 31 and decrementing.

Signed-off-by: Christophe Leroy <christophe.leroy@c-s.fr>

diff -ur linux-3.11.org/arch/powerpc/kernel/head_8xx.S linux-3.11/arch/powerpc/kernel/head_8xx.S
--- linux-3.11.org/arch/powerpc/kernel/head_8xx.S	2013-09-02 22:46:10.000000000 +0200
+++ linux-3.11/arch/powerpc/kernel/head_8xx.S	2013-09-09 11:28:54.000000000 +0200
@@ -796,8 +796,7 @@
 
 #ifdef CONFIG_PIN_TLB
 	lis	r10, (MD_RSV4I | MD_RESETVAL)@h
-	ori	r10, r10, 0x1c00
-	mr	r8, r10
+	ori	r10, r10, 0x1f00
 #else
 	lis	r10, MD_RESETVAL@h
 #endif
@@ -829,7 +828,7 @@
 	 * internal registers (among other things).
 	 */
 #ifdef CONFIG_PIN_TLB
-	addi	r10, r10, 0x0100
+	addi	r10, r10, -0x0100
 	mtspr	SPRN_MD_CTR, r10
 #endif
 	mfspr	r9, 638			/* Get current IMMR */
@@ -848,7 +847,7 @@
 #ifdef CONFIG_PIN_TLB
 	/* Map two more 8M kernel data pages.
 	*/
-	addi	r10, r10, 0x0100
+	addi	r10, r10, -0x0100
 	mtspr	SPRN_MD_CTR, r10
 
 	lis	r8, KERNELBASE@h	/* Create vaddr for TLB */
@@ -862,6 +861,9 @@
 	addis	r11, r11, 0x0080	/* Add 8M */
 	mtspr	SPRN_MD_RPN, r11
 
+	addi	r10, r10, -0x0100
+	mtspr	SPRN_MD_CTR, r10
+
 	addis	r8, r8, 0x0080		/* Add 8M */
 	mtspr	SPRN_MD_EPN, r8
 	mtspr	SPRN_MD_TWC, r9

^ permalink raw reply

* Re: [PATCH v2] powerpc 8xx: Fixing issue with CONFIG_PIN_TLB
From: leroy christophe @ 2013-09-17 16:40 UTC (permalink / raw)
  To: Scott Wood; +Cc: linuxppc-dev, Paul Mackerras, linux-kernel
In-Reply-To: <1379365336.2536.166.camel@snotra.buserror.net>


Le 16/09/2013 23:02, Scott Wood a écrit :
> On Fri, 2013-09-13 at 07:04 +0200, leroy christophe wrote:
>> Le 12/09/2013 20:44, Scott Wood a écrit :
>>> On Thu, 2013-09-12 at 20:25 +0200, Christophe Leroy wrote:
>>>> This is a reorganisation of the setup of the TLB at kernel startup, in order
>>>> to handle the CONFIG_PIN_TLB case in accordance with chapter 8.10.3 of MPC866
>>>> and MPC885 reference manuals.
>>>>
>>>> Signed-off-by: Christophe Leroy <christophe.leroy@c-s.fr>
>>>>
>>>> diff -ur linux-3.11.org/arch/powerpc/kernel/head_8xx.S linux-3.11/arch/powerpc/kernel/head_8xx.S
>>>> --- linux-3.11.org/arch/powerpc/kernel/head_8xx.S	2013-09-02 22:46:10.000000000 +0200
>>>> +++ linux-3.11/arch/powerpc/kernel/head_8xx.S	2013-09-09 11:28:54.000000000 +0200
>>>> @@ -785,27 +785,24 @@
>>>>     * these mappings is mapped by page tables.
>>>>     */
>>>>    initial_mmu:
>>>> -	tlbia			/* Invalidate all TLB entries */
>>>> -/* Always pin the first 8 MB ITLB to prevent ITLB
>>>> -   misses while mucking around with SRR0/SRR1 in asm
>>>> -*/
>>>> -	lis	r8, MI_RSV4I@h
>>>> -	ori	r8, r8, 0x1c00
>>>> -
>>>> +	lis	r8, MI_RESETVAL@h
>>>>    	mtspr	SPRN_MI_CTR, r8	/* Set instruction MMU control */
>>>>    
>>>> -#ifdef CONFIG_PIN_TLB
>>>> -	lis	r10, (MD_RSV4I | MD_RESETVAL)@h
>>>> -	ori	r10, r10, 0x1c00
>>>> -	mr	r8, r10
>>>> -#else
>>>>    	lis	r10, MD_RESETVAL@h
>>>> -#endif
>>>>    #ifndef CONFIG_8xx_COPYBACK
>>>>    	oris	r10, r10, MD_WTDEF@h
>>>>    #endif
>>>>    	mtspr	SPRN_MD_CTR, r10	/* Set data TLB control */
>>>>    
>>>> +	tlbia			/* Invalidate all TLB entries */
>>> Is this change to make sure we invalidate everything even if the
>>> bootloader set RSV4I?
>> Most probably. It is step 2 of the process defined in MPC866 and MPC885
>> Reference Manuals:
>>
>> §8.10.3 Loading Locked TLB Entries:
>> The process of loading a single reserved entry in the TLB is as follows:
> To minimize code churn we should just fix actual problems, rather than
> shuffle things around to conform to a suggested sequence.  After all,
> we're not just trying to load a single entry.
Ok, I'll try again.
>
>>>> +	ori	r8, r8, 0x1c00
>>>> +	mtspr	SPRN_MI_CTR, r8	/* Set instruction MMU control */
>>>> +#ifdef CONFIG_PIN_TLB
>>>> +	ori	r10, r10, 0x1c00
>>>> +	mtspr	SPRN_MD_CTR, r10	/* Set data TLB control */
>>>> +#endif
>>> Still 0x1c00?
>> Yes, I kept the same entries in order to limit modifications:
>> * 28 = First 8Mbytes page
>> * 29 = IMMR
>> * 30 = Second 8Mbytes page
>> * 31 = Third 8Mbytes page
> If you actually want to program them in increasing order then it looks
> like you're still missing a write to CTR between the last two 8M entries
> -- thus you'll overwrite the IMMR with the last 8M entry.  That was the
> same problem that v1 fixed -- did that change get lost accidentally?
Oops, no, in fact I diffed from the version which was including it 
already. My mistake.
>
> The hardware wants to decrement; why fight it?
I see your point.
However it is not clear in the documentation if the decrement is done 
really after the update, or at xTLB interrupt. So I propose to still set 
the CTR ourself as described in the reference Manual and not assume that 
the HW decrements it.
>
>>>>    	/* Now map the lower 8 Meg into the TLBs.  For this quick hack,
>>>>    	 * we can load the instruction and data TLB registers with the
>>>>    	 * same values.
>>>> @@ -825,6 +822,12 @@
>>>>    	mtspr	SPRN_MI_AP, r8
>>>>    	mtspr	SPRN_MD_AP, r8
>>>>    
>>>> +	/* Always pin the first 8 MB ITLB to prevent ITLB
>>>> +	 * misses while mucking around with SRR0/SRR1 in asm
>>>> +	 */
>>>> +	lis	r8, (MI_RSV4I | MI_RESETVAL)@h
>>>> +	mtspr	SPRN_MI_CTR, r8	/* Set instruction MMU control */
>>> Entry 0 is not pinnable.
>> Here we are not trying to pin entry 0.
> Sorry, misread the patch.
>
>> We are at step 8, we are setting
>> MI_RSV4I. At the same time, we set MD_CTR to 0 which is off the pinned
>> range, to be sure that we won't overwrite one of the pinned entries.
>>
>> The main difference compared to the previous implementation is that
>> before, we were setting the RSV4I bit before loading the TLB entries.
>> Now, as defined in the Reference Manuals, we are doing it at the end.
> Have you seen any evidence that it matters?
Not really.

Ok, propose a new patch in a few minutes.

Christophe

^ permalink raw reply

* Re: [PATCH v2 2/6] PCI/MSI: Factor out pci_get_msi_cap() interface
From: Michael Ellerman @ 2013-09-17 14:30 UTC (permalink / raw)
  To: Alexander Gordeev
  Cc: linuxppc-dev, Joerg Roedel, x86@kernel.org,
	linux-kernel@vger.kernel.org, linux-ide@vger.kernel.org,
	Jan Beulich, linux-pci@vger.kernel.org, Tejun Heo, Bjorn Helgaas,
	Ingo Molnar
In-Reply-To: <20130916102210.GA14102@dhcp-26-207.brq.redhat.com>

On Mon, Sep 16, 2013 at 12:22:11PM +0200, Alexander Gordeev wrote:
> On Mon, Sep 09, 2013 at 05:20:44PM +0200, Alexander Gordeev wrote:
> > On Fri, Sep 06, 2013 at 05:32:05PM -0600, Bjorn Helgaas wrote:
> > > I propose that you rework it that way, and at least find out what
> > > (if anything) would break if we do that.  Or maybe we just give up
> > > some optimization; it would be nice to quantify that, too.
> > 
> > Hi Bjorn,
> > 
> > The series is what it seems a direction to take.
> > 
> > Looks like we need PPC folks to agree on the quota check update
> > for pSeries (yes, they do bail out with a positive return value
> > from arch_msi_check_device()):
> 
> Hi Ben,
> 
> An initiative to simplify MSI/MSI-X allocation interface is brewing.
> It seems pSeries quota thing is an obstacle. If it could be given up
> (patch 2/9).

How about no?

We have a small number of MSIs available, limited by hardware &
firmware, if we don't impose a quota then the first device that probes
will get most/all of the MSIs and other devices miss out.

Anyway I don't see what problem you're trying to solve? I agree the
-ve/0/+ve return value pattern is ugly, but it's hardly the end of the
world.

cheers

^ permalink raw reply

* RE: [PATCH] powerpc/85xx: DTS - re-organize the SPI partitions property
From: Hu Mingkai-B21284 @ 2013-09-17 11:06 UTC (permalink / raw)
  To: Wood Scott-B07421; +Cc: linuxppc-dev@ozlabs.org
In-Reply-To: <1378948542.12204.490.camel@snotra.buserror.net>

U2NvdHQsDQpTb3JyeSBmb3IgdGhlIGRlbGF5ZWQgcmVzcG9uc2UuDQpQbGVhc2UgZmluZSBteSBj
b21tZW50cy4NClRoYW5rcywNCk1pbmdrYWkNCg0KPiAtLS0tLU9yaWdpbmFsIE1lc3NhZ2UtLS0t
LQ0KPiBGcm9tOiBXb29kIFNjb3R0LUIwNzQyMQ0KPiBTZW50OiBUaHVyc2RheSwgU2VwdGVtYmVy
IDEyLCAyMDEzIDk6MTYgQU0NCj4gVG86IEh1IE1pbmdrYWktQjIxMjg0DQo+IENjOiBXb29kIFNj
b3R0LUIwNzQyMTsgbGludXhwcGMtZGV2QG96bGFicy5vcmcNCj4gU3ViamVjdDogUmU6IFtQQVRD
SF0gcG93ZXJwYy84NXh4OiBEVFMgLSByZS1vcmdhbml6ZSB0aGUgU1BJIHBhcnRpdGlvbnMNCj4g
cHJvcGVydHkNCj4gDQo+IE9uIFR1ZSwgMjAxMy0wOS0xMCBhdCAyMTowNyAtMDUwMCwgSHUgTWlu
Z2thaS1CMjEyODQgd3JvdGU6DQo+ID4NCj4gPiA+IC0tLS0tT3JpZ2luYWwgTWVzc2FnZS0tLS0t
DQo+ID4gPiBGcm9tOiBXb29kIFNjb3R0LUIwNzQyMQ0KPiA+ID4gU2VudDogV2VkbmVzZGF5LCBT
ZXB0ZW1iZXIgMTEsIDIwMTMgNzozMyBBTQ0KPiA+ID4gVG86IEh1IE1pbmdrYWktQjIxMjg0DQo+
ID4gPiBDYzogbGludXhwcGMtZGV2QG96bGFicy5vcmcNCj4gPiA+IFN1YmplY3Q6IFJlOiBbUEFU
Q0hdIHBvd2VycGMvODV4eDogRFRTIC0gcmUtb3JnYW5pemUgdGhlIFNQSQ0KPiA+ID4gcGFydGl0
aW9ucyBwcm9wZXJ0eQ0KPiA+ID4NCj4gPiA+IFdoYXQgaGFwcGVucyB0byBleHN0aW5nIHVzZXJz
IHdob3NlIGZsYXNoIGlzIGxhaWQgb3V0IHRoZSBleGlzdGluZw0KPiA+ID4gd2F5LCB3aGVuIHRo
ZXkgdXBncmFkZSB0byB0aGVzZSBkZXZpY2UgdHJlZXM/DQo+ID4gPg0KPiA+DQo+ID4gVGhlIFNQ
SSBmbGFzaCBsYXlvdXQgc2hvdWxkIGJlIG1hcHBpbmcgdGhlIG5ldyBkZXZpY2UgdHJlZS4NCj4g
Pg0KPiA+IElmIHRoZSBleGlzdGluZyBkZXZpY2UgdHJlZSBpcyB1c2VkIHRvIGRlcGxveSB0aGUg
U1BJIGZsYXNoLCB0aGUNCj4gPiBmb2xsb3dpbmcgaXNzdWVzIG11c3QgYmUgcnVuIGludG8gYXMg
dGhlIGNvbW1pdCBtZXNzYWdlIGRlc2NyaWJlZDoNCj4gPg0KPiA+IDEuIEtlcm5lbCBpbWFnZXMg
d291bGQgYmUgb3ZlcmxhcHBlZCB3aXRoIFUtQm9vdCBpbWFnZS4NCj4gPiAyLiBLZXJuZWwgaW1h
Z2VzIHdvdWxkIGJlIG92ZXJsYXBwZWQgd2l0aCBGTUFOIHVjb2RlLg0KPiA+IDMuIFNhdmluZyBl
bnZpcm9ubWVudCB2YXJpYWJsZXMgd2lsbCBjcmFzaCB0aGUga2VybmVsIGltYWdlLg0KPiANCj4g
SGFzIHRoZSBTUEkgVS1Cb290IGltYWdlIGFsd2F5cyBiZWVuIGxhcmdlciB0aGFuIDUxMksgZm9y
IGFsbCB0aGVzZQ0KPiBwbGF0Zm9ybXM/ICBXaHksIGdpdmVuIHRoYXQgd2UncmUgdW5kZXIgNTEy
SyBmb3Igb3RoZXIgYm9vdCBtb2Rlcz8NCj4gDQoNCkZvciBEUEFBIHBsYXRmb3JtLCB0aGUgbGQg
c2NyaXB0IHVzZWQgdG8gbGluayB0aGUgdS1ib290IGltYWdlIGlzIA0KIi4vYXJjaC9wb3dlcnBj
L2NwdS9tcGM4NXh4L3UtYm9vdC5sZHMiIHdoaWNoIHdpbGwgZ2VuZXJhdGUgdGhlIDUxMksgdS1i
b290DQpJbWFnZS4gVGhpcyBpbWFnZSB3aWxsIGJlIHNwbGl0IGludG8gNjRieXRlcyBhbmQgYXBw
ZW5kZWQgUEJMIGNvbW1hbmQgZm9yIA0KRWFjaCA2NGJ5dGVzIHBpZWNlcywgc28gdGhlIHNpemUg
b2YgZmluYWwgaW1hZ2UgbXVzdCBiZSBncmVhdGVyIHRoYW4gNTEySy4NCg0KVGhlIHNhbWUgYXBw
bGllcyB0byB0aGUgbm9uLURQQUEgcGxhdGZvcm0gd2hpY2ggZG9lc24ndCBzdXBwb3J0IFRQTC4N
Cg0KRm9yIG5vbi1EUEFBIHBsYXRmb3JtIHdoaWNoIHN1cHBvcnQgVFBMLCB0aGUgaW1hZ2Ugc2l6
ZSBpcyBhbHNvIGdyZWF0ZXIgdGhhbiA1MTJLLg0KDQo+ID4gPiBXZSByZWFsbHkgc2hvdWxkIG5v
dCBiZSBwdXR0aW5nIHBhcnRpdGlvbiBsYXlvdXQgaW5mbyBpbiB0aGUgZGV2aWNlDQo+ID4gPiB0
cmVlIHRvIGJlZ2luIHdpdGguLi4NCj4gPiA+DQo+ID4gT0ssIEkgd2lsbCByZW1vdmUgdGhlIGxh
eW91dCBkaWFncmFtIGluIHRoZSBjb21taXQgbWVzc2FnZS4NCj4gDQo+IFRoYXQncyBub3Qgd2hh
dCBJIG1lYW50LiAgSSBtZWFudCB0aGF0IHRoZSBkdHMgc2hvdWxkIGJlIGRlc2NyaWJpbmcNCj4g
aGFyZHdhcmUsIGFuZCB0aGlzIGlzIHRoZSBzb3J0IG9mIHRyb3VibGUgd2UgcnVuIGludG8gd2hl
biB3ZSBkZXZpYXRlDQo+IGZyb20gdGhhdC4gIEEgYmV0dGVyIHdheSB3b3VsZCBiZSB0byB1c2Ug
dGhlIG10ZHBhcnRzIGNvbW1hbmQgbGluZSBvcHRpb24uDQo+IEV2ZW4gYmV0dGVyIHdvdWxkIGJl
IHNvbWUgc29ydCBvZiBvbi1mbGFzaCBwYXJ0aXRpb24gdGFibGUuDQo+IA0KDQpZb3UncmUgcmln
aHQsIGJ1dCBtYXliZSBzb21lIGN1c3RvbWVyIGhhcyBhbHJlYWR5IHVzZWQgdGhlIGRldmljZSB0
cmVlIHBhcnRpdGlvbiB0YWJsZS4uLg0KDQpUaGFua3MsDQpNaW5na2FpDQoNCg==

^ permalink raw reply

* [PATCH] powerpc: prom_init exception when updating core value
From: Laurent Dufour @ 2013-09-17  9:52 UTC (permalink / raw)
  To: linuxppc-dev; +Cc: tbreeds, benh

Since the CPU is generating an exception when accessing unaligned word, and
as this exception is not yet handled when running prom_init, data should be
copied from the architecture vector byte per byte.

Signed-off-by: Laurent Dufour <ldufour@linux.vnet.ibm.com>
---
 arch/powerpc/kernel/prom_init.c |   28 ++++++++++++++++++++++------
 1 file changed, 22 insertions(+), 6 deletions(-)

diff --git a/arch/powerpc/kernel/prom_init.c b/arch/powerpc/kernel/prom_init.c
index edcb6be..50065ee 100644
--- a/arch/powerpc/kernel/prom_init.c
+++ b/arch/powerpc/kernel/prom_init.c
@@ -855,7 +855,8 @@ static void __init prom_send_capabilities(void)
 {
 	ihandle root;
 	prom_arg_t ret;
-	__be32 *cores;
+	u32 cores;
+	unsigned char *ptcores;
 
 	root = call_prom("open", 1, 1, ADDR("/"));
 	if (root != 0) {
@@ -865,15 +866,30 @@ static void __init prom_send_capabilities(void)
 		 * (we assume this is the same for all cores) and use it to
 		 * divide NR_CPUS.
 		 */
-		cores = (__be32 *)&ibm_architecture_vec[IBM_ARCH_VEC_NRCORES_OFFSET];
-		if (be32_to_cpup(cores) != NR_CPUS) {
+
+		/* The core value may start at an odd address. If such a word
+		 * access is made at a cache line boundary, this leads to an
+		 * exception which may not be handled at this time.
+		 * Forcing a per byte access to avoid exception.
+		 */
+		ptcores = &ibm_architecture_vec[IBM_ARCH_VEC_NRCORES_OFFSET];
+		cores = 0;
+		cores |= ptcores[0] << 24;
+		cores |= ptcores[1] << 16;
+		cores |= ptcores[2] << 8;
+		cores |= ptcores[3];
+		if (cores != NR_CPUS) {
 			prom_printf("WARNING ! "
 				    "ibm_architecture_vec structure inconsistent: %lu!\n",
-				    be32_to_cpup(cores));
+				    cores);
 		} else {
-			*cores = cpu_to_be32(DIV_ROUND_UP(NR_CPUS, prom_count_smt_threads()));
+			cores = DIV_ROUND_UP(NR_CPUS, prom_count_smt_threads());
 			prom_printf("Max number of cores passed to firmware: %lu (NR_CPUS = %lu)\n",
-				    be32_to_cpup(cores), NR_CPUS);
+				    cores, NR_CPUS);
+			ptcores[0] = (cores >> 24) & 0xff;
+			ptcores[1] = (cores >> 16) & 0xff;
+			ptcores[2] = (cores >> 8) & 0xff;
+			ptcores[3] = cores & 0xff;
 		}
 
 		/* try calling the ibm,client-architecture-support method */

^ permalink raw reply related

* Re: [PATCH 2/2][RFC][v3] pci: fsl: rework PCI driver compatible with Layerscape
From: Lian Minghuan-b31939 @ 2013-09-17  9:23 UTC (permalink / raw)
  To: Scott Wood; +Cc: Minghuan Lian, linuxppc-dev, Zang Roy-R61911
In-Reply-To: <1379376308.2536.217.camel@snotra.buserror.net>

Hi Scott,

Thanks for your comments.
please see my replies in line.


On 09/17/2013 08:05 AM, Scott Wood wrote:
> On Thu, 2013-09-12 at 18:07 +0800, Minghuan Lian wrote:
>> The Freescale's Layerscape series processors will use the same PCI
>> controller but change cores from PowerPC to ARM. This patch is to
>> rework FSL PCI driver to support PowerPC and ARM simultaneously.
>> PowerPC uses structure pci_controller to describe PCI controller,
>> but arm uses structure hw_pci and pci_sys_data. They also have
>> different architecture implementation and initialization flow.
>> The architecture-dependent driver will bridge the gap, get the
>> settings from the common driver and initialize the corresponding
>> structure and call the related interface to register PCI controller.
>> The common driver pci-fsl.c removes all the architecture-specific
>> code and provides structure fsl_pci to store all the controller
>> settings and the common functionalities that include reading/writing
>> PCI configuration space, parsing dts node and getting the MEM/IO and
>> bus number ranges, setting ATMU and check link status.
>>
>> Signed-off-by: Minghuan Lian <Minghuan.Lian@freescale.com>
>> ---
>> Based on upstream master
>> The function has been tested on MPC8315ERDB MPC8572DS P5020DS P3041DS
>> and T4240QDS boards
>>
>> Change log:
>> v3:
>> 1. use 'fsl_arch' as function name prefix of all the
>>     architecture-specific hooks.
>> 2. Move PCI compatible definitions from arch/powerpc/sysdev/fsl_pci.c
>>     to driver/pci/host/pci-fsl.c
>>
>> v2:
>> 1. Use 'pci' instead of 'pcie' in new file name and file contents.
>> 2. Use iowrite32be()/iowrite32() instead of out_be32/le32()
>> 3. Fix ppc_md.dma_set_mask setting
>> 4. Synchronizes host->first_busno and pci->first_busno.
>> 5. Fix PCI IO space settings
>> 6. Some small changes according to Scott's comments.
>>
>>
>>   arch/powerpc/Kconfig          |   1 +
>>   arch/powerpc/sysdev/fsl_pci.c | 150 +++++++++-
>>   drivers/edac/mpc85xx_edac.c   |   9 -
>>   drivers/pci/host/Kconfig      |   4 +
>>   drivers/pci/host/Makefile     |   1 +
>>   drivers/pci/host/pci-fsl.c    | 656 +++++++++++++++++++++++++++---------------
>>   include/linux/fsl/pci.h       |  69 +++++
>>   7 files changed, 648 insertions(+), 242 deletions(-)
> The PCI mailing list and maintainer should be included.
[Minghuan] Ok, I will remove 'RFC' and re-send the patch according to
you comments.
>> diff --git a/arch/powerpc/Kconfig b/arch/powerpc/Kconfig
>> index 6b7530f..657d90f 100644
>> --- a/arch/powerpc/Kconfig
>> +++ b/arch/powerpc/Kconfig
>> @@ -691,6 +691,7 @@ config FSL_SOC
>>   
>>   config FSL_PCI
>>    	bool
>> +	select PCI_FSL if FSL_SOC_BOOKE || PPC_86xx
>>   	select PPC_INDIRECT_PCI
>>   	select PCI_QUIRKS
>>   
>> diff --git a/arch/powerpc/sysdev/fsl_pci.c b/arch/powerpc/sysdev/fsl_pci.c
>> index a189ff0..4cb12e8 100644
>> --- a/arch/powerpc/sysdev/fsl_pci.c
>> +++ b/arch/powerpc/sysdev/fsl_pci.c
>> @@ -62,7 +62,11 @@ static void quirk_fsl_pcie_header(struct pci_dev *dev)
>>   #if defined(CONFIG_FSL_SOC_BOOKE) || defined(CONFIG_PPC_86xx)
>>   
>>   #define MAX_PHYS_ADDR_BITS	40
>> -static u64 pci64_dma_offset = 1ull << MAX_PHYS_ADDR_BITS;
>> +
>> +u64 fsl_arch_pci64_dma_offset(void)
>> +{
>> +	return 1ull << MAX_PHYS_ADDR_BITS;
>> +}
>>   
>>   static int fsl_pci_dma_set_mask(struct device *dev, u64 dma_mask)
>>   {
>> @@ -77,17 +81,43 @@ static int fsl_pci_dma_set_mask(struct device *dev, u64 dma_mask)
>>   	if ((dev->bus == &pci_bus_type) &&
>>   	    dma_mask >= DMA_BIT_MASK(MAX_PHYS_ADDR_BITS)) {
>>   		set_dma_ops(dev, &dma_direct_ops);
>> -		set_dma_offset(dev, pci64_dma_offset);
>> +		set_dma_offset(dev, fsl_arch_pci64_dma_offset());
>>   	}
> Is the intent for fsl_arch_pci64_dma_offset() to eventually do something
> that isn't calculable at compile time?
>   
[Minghuan]  fsl_arch_pci64_dma_offset() is also called by pci-fsl.c to 
setup inbound ATMU.
I think different platform or architecture(LS1) may use different dma 
offset(maybe I am wrong
they can use the same offset 1ull << MAX_PHYS_ADDR_BITS).  I selected
  u64 fsl_arch_pci64_dma_offset(void) not extern u64 pci64_dma_offset to 
share the global
value between /driver/pci/host/pci-fsl.c and 
arch/powerpc/sysdev/fsl_pci.c or / arch/arm/..../fsl_pci.c
'extern' variable will cause the warning when checking patch.
>>   	*dev->dma_mask = dma_mask;
>>   	return 0;
>>   }
>>   
>> +struct fsl_pci *fsl_arch_sys_to_pci(void *sys)
>> +{
>> +	struct pci_controller *hose = sys;
>> +	struct fsl_pci *pci = hose->private_data;
> If this were just to convert to fsl_pci, that seems like header
> material.
[Minghuan] In arm architecture it will be implemented like this:
struct fsl_pci *fsl_arch_sys_to_pci(void *sys) {
  struct pci_sys_data *sys_data  = sys;
   return  sys_data->private_data;
}

driver/pci/host/pci-fsl.c should not include any arch specific header file.
and can not recognize structure pci_controller used in powerpc and
  pci_sys_data used in arm.

>> +	/* Update the first bus number */
>> +	if (pci->first_busno != hose->first_busno)
>> +		pci->first_busno = hose->first_busno;
> This isn't part of the interface description in the header...
[Minghuan] Yes. host->first_busno will be reassigned if defined 
PCI_REASSIGN_ALL_BUS.
and I can not find a chance to update pci->first_busno. this will cause 
we can not
read/write pci configuration space when the hose->first_busno is changed 
but pci->first_busno
is not updated synchronously.

the following code to check first_busno when access the configuration space.

     if (pci->indirect_type & INDIRECT_TYPE_NO_PCIE_LINK) {
         if (bus != pci->first_busno)
             return PCIBIOS_DEVICE_NOT_FOUND;
...
     }

bus_no = (bus == pci->first_busno) ? pci->self_busno : bus;

So I added the sentences to this function to fix the issue.
>   
>> +static int mpc83xx_pcie_check_link(struct pci_controller *hose)
>> +{
>> +	u32 val = 0;
>> +
>> +#define PCIE_LTSSM	0x0404		/* PCIE Link Training and Status */
>> +#define PCIE_LTSSM_L0	0x16		/* L0 state */
>> +
>> +	early_read_config_dword(hose, 0, 0, PCIE_LTSSM, &val);
>> +	if (val < PCIE_LTSSM_L0)
>> +		return 1;
>> +	return 0;
>> +}
> Aren't PCIE_LTSSM and PCIE_LTSSM_L0 defined in include/linux/fsl/pci.h
> at this point?
[Minghuan] Yes. I will remove the duplicate definitions.
>> @@ -260,14 +259,6 @@ int mpc85xx_pci_err_probe(struct platform_device *op)
>>   	/* we only need the error registers */
>>   	r.start += 0xe00;
>>   
>> -	if (!devm_request_mem_region(&op->dev, r.start, resource_size(&r),
>> -					pdata->name)) {
>> -		printk(KERN_ERR "%s: Error while requesting mem region\n",
>> -		       __func__);
>> -		res = -EBUSY;
>> -		goto err;
>> -	}
> Why?  If the relationship between the edac driver and the main pci
> driver is changing, explain that.
[Minghuan] Ok.
The main pci driver used devm_ioremap_resource() to map regester space.
So PCI EDAC driver would encounter an error when calling 
devm_request_mem_region()
EDAC just only need to ioremap the error interrupt registers region and 
not need
to call  devm_request_mem_region().
>
>>   	pdata->pci_vbase = devm_ioremap(&op->dev, r.start, resource_size(&r));
>>   	if (!pdata->pci_vbase) {
>>   		printk(KERN_ERR "%s: Unable to setup PCI err regs\n", __func__);
>> diff --git a/drivers/pci/host/Kconfig b/drivers/pci/host/Kconfig
>> index 3d95048..37d25ae 100644
>> --- a/drivers/pci/host/Kconfig
>> +++ b/drivers/pci/host/Kconfig
>> @@ -19,4 +19,8 @@ config PCI_TEGRA
>>   	bool "NVIDIA Tegra PCIe controller"
>>   	depends on ARCH_TEGRA
>>   
>> +config PCI_FSL
>> +	bool "Freescale PCI/PCIe controller"
>> +	depends on FSL_SOC_BOOKE || PPC_86xx
> Needs help text.
>
> Make it clear that this is for 85xx/86xx/QorIQ/Layerscape, not all
> Freescale chips with PCI/PCIe.
[Minghuan] Ok. I will add help text.
>>   no_bridge:
>> -	iounmap(hose->private_data);
>> -	/* unmap cfg_data & cfg_addr separately if not on same page */
>> -	if (((unsigned long)hose->cfg_data & PAGE_MASK) !=
>> -	    ((unsigned long)hose->cfg_addr & PAGE_MASK))
>> -		iounmap(hose->cfg_data);
>> -	iounmap(hose->cfg_addr);
>> -	pcibios_free_controller(hose);
>> -	return -ENODEV;
>> +	dev_info(&pdev->dev, "It works as EP mode\n");
>> +	return -EPERM;
> This is a poorly phrased message.  In any case, what does this change
> have to do with making the PCI driver compatible with layerscape?
[Minghuan] I can not quite understand what you mean.
Should I remove the "dev_info(&pdev->dev, "It works as EP mode\n");"
and not change ENODEV to EPERM?
we do not really need this change.
If the controller is in EP mode, we only need to return an error, 
because at this time
'hose' has not been created.

> -Scott
>
>

^ permalink raw reply

* RE: [PATCH v4] powerpc/mpc85xx: Update the clock device tree nodes
From: Tang Yuantian-B29983 @ 2013-09-17  7:19 UTC (permalink / raw)
  To: Wood Scott-B07421
  Cc: devicetree@vger.kernel.org, linuxppc-dev@lists.ozlabs.org,
	Li Yang-Leo-R58472
In-Reply-To: <1379363970.2536.151.camel@snotra.buserror.net>

PiA+ID4gT24gV2VkLCAyMDEzLTA5LTExIGF0IDIwOjMxIC0wNTAwLCBUYW5nIFl1YW50aWFuLUIy
OTk4MyB3cm90ZToNCj4gPiA+ID4gPiAtLS0tLU9yaWdpbmFsIE1lc3NhZ2UtLS0tLQ0KPiA+ID4g
PiA+IEZyb206IFdvb2QgU2NvdHQtQjA3NDIxDQo+ID4gPiA+ID4gU2VudDogMjAxM+W5tDnmnIgx
MuaXpSDmmJ/mnJ/lm5sgOToxMA0KPiA+ID4gPiA+IFRvOiBUYW5nIFl1YW50aWFuLUIyOTk4Mw0K
PiA+ID4gPiA+IENjOiBnYWxha0BrZXJuZWwuY3Jhc2hpbmcub3JnOyBsaW51eHBwYy1kZXZAbGlz
dHMub3psYWJzLm9yZzsNCj4gPiA+ID4gPiBkZXZpY2V0cmVlQHZnZXIua2VybmVsLm9yZzsgTGkg
WWFuZy1MZW8tUjU4NDcyDQo+ID4gPiA+ID4gU3ViamVjdDogUmU6IFtQQVRDSCB2NF0gcG93ZXJw
Yy9tcGM4NXh4OiBVcGRhdGUgdGhlIGNsb2NrIGRldmljZQ0KPiA+ID4gPiA+IHRyZWUgbm9kZXMN
Cj4gPiA+ID4gPg0KPiA+ID4gPiA+IFRoaXMgZGVzY3JpcHRpb24gb2YgInJlZyIgaXMgb3Zlcmx5
IHNwZWNpZmljIChhc3N1bWVzIGhvdyB0aGUNCj4gPiA+ID4gPiBwYXJlbnQgbm9kZSdzIHJhbmdl
cyBhcmUgc2V0IHVwKSwgaW5jb21wbGV0ZSAodGhlcmUncyBhIHNpemUgYXMNCj4gPiA+ID4gPiB3
ZWxsIGFzIHRoZSBvZmZzZXQpLCBhbmQgZG9lcyBub3QgYXBwbHkgdG8gdGhlIGNsb2NrZ2VuIG5v
ZGUNCj4gPiA+ID4gPiBpdHNlbGYgKHlvdSBwcm9iYWJseSBzaG91bGRuJ3QgbHVtcCB0aGVtIHRv
Z2V0aGVyIGxpa2UgdGhpcykuDQo+ID4gPiA+ID4NCj4gPiA+ID4gRG8geW91IG1lYW4gSSBzaG91
bGQgZXhwbGFpbiB0aGUgUkVHIG9mIGNsb2NrZ2VuIGFuZCBpdHMgY2hpbGQNCj4gPiA+ID4gbm9k
ZQ0KPiA+ID4gcmVzcGVjdGl2ZWx5Pw0KPiA+ID4gPg0KPiA+ID4gPiA+ID4gKy0gY2xvY2tzIDog
c2hhbGwgYmUgdGhlIGlucHV0IHBhcmVudCBjbG9jayBwaGFuZGxlIGZvciB0aGUNCj4gY2xvY2su
DQo+ID4gPiA+ID4NCj4gPiA+ID4gPiBOb3QgcmVxdWlyZWQgb24gdGhlIGNsb2NrZ2VuIG5vZGUN
Cj4gPiA+ID4gPg0KPiA+ID4gPiBSZXF1aXJlZCBieSBjaGlsZCBub2RlIG9mIGNsb2NrZ2VuLg0K
PiA+ID4NCj4gPiA+IE15IHBvaW50IGlzIHRoYXQgeW91J3JlIGx1bXBpbmcgc2V2ZXJhbCBkaWZm
ZXJlbnQgdHlwZXMgb2Ygbm9kZXMNCj4gPiA+IHRvZ2V0aGVyIHdpdGggb25lIGJpbmRpbmcsIHdo
ZW4gc29tZSBwYXJ0cyBvZiB0aGUgYmluZGluZyBhcmUgbm90DQo+ID4gPiBhcHBsaWNhYmxlIHRv
IHRoZSBjbG9ja2dlbiBub2RlLg0KPiA+ID4NCj4gPiBOb3Qgc2V2ZXJhbCwganVzdCB0d28gdHlw
ZXMgb2Ygbm9kZXMuDQo+ID4gT25lIGlzIGNsb2NrZ2VuIG5vZGUsIHRoZSBvdGhlciBpcyBQTEwg
YW5kIG11eCBub2Rlcy4NCj4gDQo+IGNsb2NrZ2VuICsgUExMICsgbXV4ID0gMyA9IHNldmVyYWwg
Oi0pDQo+IA0KPiA+IFRoZSByZWFzb24gdGhleSBsdW1wZWQgdG9nZXRoZXIgaXMgdGhhdCB0aGUg
Y2xvY2tnZW4gbm9kZSBpcyBub3Qgb25seQ0KPiA+IElQIGJsb2NrIE5vZGUgYnV0IGFsc28gYSBj
bG9jayBwcm92aWRlciBub2RlDQo+IA0KPiBJIGRvbid0IHVuZGVyc3RhbmQgd2h5IHRoYXQgbWVy
aXRzIGx1bXBpbmcgdGhlbSB0b2dldGhlci4NCj4gDQo+IEp1c3QgZGVzY3JpYmUgdGhlbSBzZXBh
cmF0ZWx5Lg0KPiANCkl0IGlzIG5vdCB0aGF0IGVhc3kgdG8gc2VwYXJhdGUgdGhlbSBiZWNhdXNl
IGNsb2NrZ2VuIG5vZGUgcGxheXMgdHdvIHR5cGVzDQpPZiByb2xlcy4gVGFrZSBSRUcgcHJvcGVy
dHkgYXMgZXhhbXBsZToNCkFzIElQIGJsb2NrIG5vZGUsIFJFRyBzaG91bGQgYmUgcmVnID0gPDB4
ZTEwMDAgMHgxMDAwPiwgd2hpbGUgYXMNCkNsb2NrIHByb3ZpZGVyIG5vZGUsIGl0IHNob3VsZCBi
ZSByZWcgPSA8MHhhYmMgMHg0PiBvciBubyByZWcgYXQgYWxsKGZvciBmaXhlZCBjbG9jaykuDQoN
Cj4gPiBBdCBmaXJzdCwgSSB3YW50IHRvIGFkZCBhIGV4dHJhIGZpeGVkLWNsb2NrIG5vZGUgYW5k
IG1vdmUgdGhlDQo+ID4gY2xvY2stZnJlcXVlbmN5IG9mIGNsb2NrZ2VuIE5vZGUgdG8gaXQsIGJ1
dCBpdCBpcyBhZ2FpbnN0IHRoZSBiYWNrd2FyZA0KPiA+IGNvbXBhdGliaWxpdHkNCj4gDQo+IFJp
Z2h0Lg0KPiANCj4gPiB3aGljaCBJIHRoaW5rIGl0IGlzIG5vdCBhIGJpZyBkZWFsLCBCZWNhdXNl
IG5vYm9keSBoYXNuJ3QgdXNlZCBpdCB5ZXQuDQo+IA0KPiBUaGUgcG9pbnQgaXMgaXQgd2lsbCBy
ZXF1aXJlIHVwZGF0aW5nIFUtQm9vdCB0byB1c2UgaXQsIHZlcnN1cyBleGlzdGluZw0KPiBVLUJv
b3RzIHdoaWNoIGFscmVhZHkgcGF0Y2ggdXAgdGhlIGNsb2NrLWZyZXF1ZW5jeSBpbiB0aGUgY2xv
Y2tnZW4gbm9kZS4NCj4gQW5kIHRoZXJlJ3Mgbm90aGluZyBzZW1hbnRpY2FsbHkgd3Jvbmcgd2l0
aCB0aGUgd2F5IGl0IGN1cnJlbnRseSBpcy4NCj4gDQpZZXMsIG5vdGhpbmcgd3JvbmcgYWJvdXQg
aXQuDQpCdXQgd2Ugd2lsbCBrZWVwIGFkZGluZyB0aGUgY2xvY2tnZW4teC55IG5vZGUgYWxsIHRo
ZSB0aW1lIGluIHVib290Lg0KSWYgd2UgaGF2ZSBvbmUgZXh0cmEgbm9kZSB0byBrZWVwIGNsb2Nr
LWZyZXF1ZW5jeSwgaXQgd291bGQgYmUgdXBkYXRlZCBvbmx5IG9uY2UuDQoNCj4gPiBJZiBJIGFk
ZCBhIGV4dHJhIG5vZGUgd2l0aCB0aGUgY2xvY2stZnJlcXVlbmN5IHByb3BlcnR5IGFuZCBkb24n
dCBtb3ZlDQo+ID4gdGhlIGNsb2NrLWZyZXF1ZW5jeSBwcm9wZXJ0eSBvZiBjbG9ja2dlbiwgdGhh
dCB3b3VsZCBiZSByZWR1bmRhbnQNCj4gPiBiZWNhdXNlIGJvdGggY2xvY2tnZW4gbm9kZSBhbmQg
dGhlIGV4dHJhIG5vZGUgaGF2ZSB0aGUgc2FtZSBjbG9jay0NCj4gZnJlcXVlbmN5IG5vZGUuDQo+
ID4gU28sIEkgY2hvb3NlIHdoYXQgSSBkaWQgbm93Lg0KPiANCj4gSSdtIG5vdCBjb21wbGFpbmlu
ZyBhYm91dCBob3cgeW91IHN0cnVjdHVyZWQgdGhlIG5vZGVzLCBqdXN0IGhvdyB5b3UNCj4gZG9j
dW1lbnRlZCB0aGVtLg0KPiANCkFzIEkgc2FpZCBpdCBpcyBoYXJkIHRvIGRvY3VtZW50IGNsb2Nr
Z2VuIG5vZGUgaWYgd2UgZG9uJ3Qgc2VwYXJhdGUgaXRzDQp0d28gcm9sZXMuDQpJIHRoaW5rIHRo
ZSBmb2xsb3dpbmcgc3RydWN0dXJlIGlzIGJldHRlci4NCg0KKyAgIGNsb2NrZ2VuOiBnbG9iYWwt
dXRpbGl0aWVzQGUxMDAwIHsNCisgICAgICAgY29tcGF0aWJsZSA9ICJmc2wscDUwMjAtY2xvY2tn
ZW4iLCAiZnNsLHFvcmlxLWNsb2NrZ2VuLTEuMCI7DQorICAgICAgIHJlZyA9IDwweGUxMDAwIDB4
MTAwMD47DQorICAgICAgICNhZGRyZXNzLWNlbGxzID0gPDE+Ow0KKyAgICAgICAjc2l6ZS1jZWxs
cyA9IDwxPjsNCgkgIA0KCSAgU3lzY2xrOnN5c2NsayB7DQoJICAJY29tcGF0aWJsZSA9ICJmc2ws
cW9yaXEtc3lzY2xrIiwgImZpeGVkLWNsb2NrIjsNCiAgICAgICAJY2xvY2stb3V0cHV0LW5hbWVz
ID0gInN5c2NsayI7DQogICAgICAgCSNjbG9jay1jZWxscyA9IDwwPjsgICANCgkJY2xvY2stZnJl
cXVlbmN5ID0gPDA+OwkJDQoJICB9DQorICAgICAgIHBsbDA6IHBsbDBAODAwIHsNCisgICAgICAg
ICAgICNjbG9jay1jZWxscyA9IDwxPjsNCisgICAgICAgICAgIHJlZyA9IDwweDgwMCAweDQ+Ow0K
KyAgICAgICAgICAgY29tcGF0aWJsZSA9ICJmc2wscW9yaXEtY2hhc3NpczEtY29yZS1wbGwiOw0K
KyAgICAgICAgICAgY2xvY2tzID0gPCYgU3lzY2xrID47DQorICAgICAgICAgICBjbG9jay1vdXRw
dXQtbmFtZXMgPSAicGxsMCIsICJwbGwwLWRpdjIiOw0KKyAgICAgICB9Ow0KDQpSZWdhcmRzLA0K
WXVhbnRpYW4NCg0KPiAtU2NvdHQNCj4gDQoNCg==

^ permalink raw reply

* RE: [PATCH] powerpc/mpc85xx:Add initial device tree support of T104x
From: Kushwaha Prabhakar-B32579 @ 2013-09-17  2:11 UTC (permalink / raw)
  To: Wood Scott-B07421
  Cc: Sethi Varun-B16395, Jain Priyanka-B32167, Aggrwal Poonam-B10812,
	linuxppc-dev@lists.ozlabs.org
In-Reply-To: <1379366325.2536.178.camel@snotra.buserror.net>

DQoNCj4gLS0tLS1PcmlnaW5hbCBNZXNzYWdlLS0tLS0NCj4gRnJvbTogV29vZCBTY290dC1CMDc0
MjENCj4gU2VudDogVHVlc2RheSwgU2VwdGVtYmVyIDE3LCAyMDEzIDI6NDkgQU0NCj4gVG86IEt1
c2h3YWhhIFByYWJoYWthci1CMzI1NzkNCj4gQ2M6IFdvb2QgU2NvdHQtQjA3NDIxOyBsaW51eHBw
Yy1kZXZAbGlzdHMub3psYWJzLm9yZzsNCj4gZ2FsYWtAa2VybmVsLmNyYXNoaW5nLm9yZzsgQWdn
cndhbCBQb29uYW0tQjEwODEyOyBKYWluIFByaXlhbmthLUIzMjE2NzsNCj4gU2V0aGkgVmFydW4t
QjE2Mzk1DQo+IFN1YmplY3Q6IFJlOiBbUEFUQ0hdIHBvd2VycGMvbXBjODV4eDpBZGQgaW5pdGlh
bCBkZXZpY2UgdHJlZSBzdXBwb3J0IG9mDQo+IFQxMDR4DQo+IA0KPiBPbiBGcmksIDIwMTMtMDkt
MTMgYXQgMDI6MzAgLTA1MDAsIEt1c2h3YWhhIFByYWJoYWthci1CMzI1Nzkgd3JvdGU6DQo+ID4g
PiBJIGFsc28gcXVlc3Rpb24gdGhlIG5lZWQgdG8gZGVmaW5lIHNlcGFyYXRlIHQxMDQwIGNvbXBh
dGlibGUgdmFsdWVzDQo+ID4gPiBmb3IgYWxsIG9mIHRoZXNlLCBpZiB0aGUgb25seSBkaWZmZXJl
bmNlIGlzIHdoZXRoZXIgdGhlIG9uYm9hcmQNCj4gPiA+IHN3aXRjaCBpcyBlbmFibGVkIG9yIG5v
dC4NCj4gPiA+DQo+ID4NCj4gPiBzbyBzaG91bGQgSSB1c2UgVDEwNHggYXMgY29tcGF0aWJsZSBm
aWVsZC4gYW5kIGluIFQxMDQwIGRldmljZSB0cmVlIGFkZA0KPiBleHRyYSBub2RlIGZvciBsMiBz
d2l0Y2guDQoNCkkgYW0gdXNpbmcgVDEwNDIgYXMgYmFzZSBkdHMgYW5kIFQxMDQwIGluY2x1ZGVz
IFQxMDQwICsgbDJzd2l0Y2guIA0KDQpzbyBpZiBJIHVzZSBUMTA0MiBpbiBjb21wYXRpYmxlLiBJ
dCB3aWxsIGdpdmUgd3JvbmcgZmllbGQgZm9yIHNvbWVvbmUgd29ya2luZyBvbiBUMTA0MFFEUy4N
Cg0KYmVzdCBzb2x1dGlvbiBzaG91bGQgYmUgdG8gaGF2ZSANCiBhKSBoYXZlIFQxMDQyIGluIGNv
bXBhdGlibGUgZmllbGQuDQogYikgVDEwNDAgZHRzIG92ZXJyaWRlIFQxMDQyIHRvIHQxMDQwIGlu
IGNvbXBhdGlibGUgZmllbGQuDQppdCB3aWxsIGdpdmUgY29ycmVjdCBwaWN0dXJlDQoNCg0KUmVn
YXJkcywNClByYWJoYWthcg0KDQo=

^ permalink raw reply

* Re: [PATCH] Powerpc/dts: Correct sdhci quirk for bsc9131
From: Zhang Haijun @ 2013-09-17  0:56 UTC (permalink / raw)
  To: Scott Wood; +Cc: linuxppc-dev, X.Xie, Haijun Zhang
In-Reply-To: <1379360577.2536.142.camel@snotra.buserror.net>

I see, thanks. ^_^

=E4=BA=8E 2013/9/17 3:42, Scott Wood =E5=86=99=E9=81=93:
> On Mon, 2013-09-16 at 16:12 +0800, Zhang Haijun wrote:
>> On 09/02/2013 06:37 PM, Haijun Zhang wrote:
>>> We use property "sdhci,auto-cmd12" instead of "fsl,sdhci-auto-cmd12"
>>> to distinguish if the sdhc host has quirk SDHCI_QUIRK_MULTIBLOCK_READ=
_ACMD12.
>>>
>>> Signed-off-by: Haijun Zhang <Haijun.Zhang@freescale.com>
>>> ---
>>>    arch/powerpc/boot/dts/fsl/bsc9131si-post.dtsi | 2 +-
>>>    1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/arch/powerpc/boot/dts/fsl/bsc9131si-post.dtsi b/arch/pow=
erpc/boot/dts/fsl/bsc9131si-post.dtsi
>>> index 5180d9d..0c0efa9 100644
>>> --- a/arch/powerpc/boot/dts/fsl/bsc9131si-post.dtsi
>>> +++ b/arch/powerpc/boot/dts/fsl/bsc9131si-post.dtsi
>>> @@ -130,7 +130,7 @@ usb@22000 {
>>>
>>>    /include/ "pq3-esdhc-0.dtsi"
>>>    	sdhc@2e000 {
>>> -		fsl,sdhci-auto-cmd12;
>>> +		sdhci,auto-cmd12;
>>>    		interrupts =3D <41 0x2 0 0>;
>>>    	};
>>>
>>>
>>
>> Hi, scott
>>
>> Could you help review this patch?
> I process patches in periodic batches.  There's no need for a reminder
> when it's only been two weeks, as long as it's still marked "new" or
> "under review" in patchwork (and you should include a patchwork link in
> any such reminder e-mail).  Especially for a trivial patch such as this=
,
> no comment often means I looked at it and saw no problems and will take
> it in the next batch.
>
> Though if you want a comment, don't capitalize "powerpc" in the
> subject. :-)
>
> -Scott
>
>

--=20
Thanks & Regards
Haijun.

^ permalink raw reply

* Re: [PATCH v2 1/3] powerpc/booke64: add sync after writing PTE
From: Scott Wood @ 2013-09-17  0:06 UTC (permalink / raw)
  To: Benjamin Herrenschmidt; +Cc: linuxppc-dev
In-Reply-To: <1379281131.4098.48.camel@pasglop>

On Mon, 2013-09-16 at 07:38 +1000, Benjamin Herrenschmidt wrote:
> On Fri, 2013-09-13 at 22:50 -0500, Scott Wood wrote:
> > The ISA says that a sync is needed to order a PTE write with a
> > subsequent hardware tablewalk lookup.  On e6500, without this sync
> > we've been observed to die with a DSI due to a PTE write not being seen
> > by a subsequent access, even when everything happens on the same
> > CPU.
> 
> This is gross, I didn't realize we had that bogosity in the
> architecture...
> 
> Did you measure the performance impact ?

I didn't see a noticeable impact on the tests I ran, but those were
aimed at measuring TLB miss overhead.  I'll need to try it with a
benchmark that's more oriented around lots of page table updates.

-Scott

^ permalink raw reply

* Re: [PATCH 2/2][RFC][v3] pci: fsl: rework PCI driver compatible with Layerscape
From: Scott Wood @ 2013-09-17  0:05 UTC (permalink / raw)
  To: Minghuan Lian; +Cc: linuxppc-dev, Zang Roy-R61911
In-Reply-To: <1378980438-29888-2-git-send-email-Minghuan.Lian@freescale.com>

On Thu, 2013-09-12 at 18:07 +0800, Minghuan Lian wrote:
> The Freescale's Layerscape series processors will use the same PCI
> controller but change cores from PowerPC to ARM. This patch is to
> rework FSL PCI driver to support PowerPC and ARM simultaneously.
> PowerPC uses structure pci_controller to describe PCI controller,
> but arm uses structure hw_pci and pci_sys_data. They also have
> different architecture implementation and initialization flow.
> The architecture-dependent driver will bridge the gap, get the
> settings from the common driver and initialize the corresponding
> structure and call the related interface to register PCI controller.
> The common driver pci-fsl.c removes all the architecture-specific
> code and provides structure fsl_pci to store all the controller
> settings and the common functionalities that include reading/writing
> PCI configuration space, parsing dts node and getting the MEM/IO and
> bus number ranges, setting ATMU and check link status.
> 
> Signed-off-by: Minghuan Lian <Minghuan.Lian@freescale.com>
> ---
> Based on upstream master
> The function has been tested on MPC8315ERDB MPC8572DS P5020DS P3041DS
> and T4240QDS boards 
> 
> Change log:
> v3:
> 1. use 'fsl_arch' as function name prefix of all the
>    architecture-specific hooks.
> 2. Move PCI compatible definitions from arch/powerpc/sysdev/fsl_pci.c
>    to driver/pci/host/pci-fsl.c 
> 
> v2:
> 1. Use 'pci' instead of 'pcie' in new file name and file contents. 
> 2. Use iowrite32be()/iowrite32() instead of out_be32/le32()
> 3. Fix ppc_md.dma_set_mask setting
> 4. Synchronizes host->first_busno and pci->first_busno.
> 5. Fix PCI IO space settings
> 6. Some small changes according to Scott's comments.
> 
> 
>  arch/powerpc/Kconfig          |   1 +
>  arch/powerpc/sysdev/fsl_pci.c | 150 +++++++++-
>  drivers/edac/mpc85xx_edac.c   |   9 -
>  drivers/pci/host/Kconfig      |   4 +
>  drivers/pci/host/Makefile     |   1 +
>  drivers/pci/host/pci-fsl.c    | 656 +++++++++++++++++++++++++++---------------
>  include/linux/fsl/pci.h       |  69 +++++
>  7 files changed, 648 insertions(+), 242 deletions(-)

The PCI mailing list and maintainer should be included.

> diff --git a/arch/powerpc/Kconfig b/arch/powerpc/Kconfig
> index 6b7530f..657d90f 100644
> --- a/arch/powerpc/Kconfig
> +++ b/arch/powerpc/Kconfig
> @@ -691,6 +691,7 @@ config FSL_SOC
>  
>  config FSL_PCI
>   	bool
> +	select PCI_FSL if FSL_SOC_BOOKE || PPC_86xx
>  	select PPC_INDIRECT_PCI
>  	select PCI_QUIRKS
>  
> diff --git a/arch/powerpc/sysdev/fsl_pci.c b/arch/powerpc/sysdev/fsl_pci.c
> index a189ff0..4cb12e8 100644
> --- a/arch/powerpc/sysdev/fsl_pci.c
> +++ b/arch/powerpc/sysdev/fsl_pci.c
> @@ -62,7 +62,11 @@ static void quirk_fsl_pcie_header(struct pci_dev *dev)
>  #if defined(CONFIG_FSL_SOC_BOOKE) || defined(CONFIG_PPC_86xx)
>  
>  #define MAX_PHYS_ADDR_BITS	40
> -static u64 pci64_dma_offset = 1ull << MAX_PHYS_ADDR_BITS;
> +
> +u64 fsl_arch_pci64_dma_offset(void)
> +{
> +	return 1ull << MAX_PHYS_ADDR_BITS;
> +}
>  
>  static int fsl_pci_dma_set_mask(struct device *dev, u64 dma_mask)
>  {
> @@ -77,17 +81,43 @@ static int fsl_pci_dma_set_mask(struct device *dev, u64 dma_mask)
>  	if ((dev->bus == &pci_bus_type) &&
>  	    dma_mask >= DMA_BIT_MASK(MAX_PHYS_ADDR_BITS)) {
>  		set_dma_ops(dev, &dma_direct_ops);
> -		set_dma_offset(dev, pci64_dma_offset);
> +		set_dma_offset(dev, fsl_arch_pci64_dma_offset());
>  	}

Is the intent for fsl_arch_pci64_dma_offset() to eventually do something
that isn't calculable at compile time?
 
>  	*dev->dma_mask = dma_mask;
>  	return 0;
>  }
>  
> +struct fsl_pci *fsl_arch_sys_to_pci(void *sys)
> +{
> +	struct pci_controller *hose = sys;
> +	struct fsl_pci *pci = hose->private_data;

If this were just to convert to fsl_pci, that seems like header
material.

> +	/* Update the first bus number */
> +	if (pci->first_busno != hose->first_busno)
> +		pci->first_busno = hose->first_busno;

This isn't part of the interface description in the header...

> +static int mpc83xx_pcie_check_link(struct pci_controller *hose)
> +{
> +	u32 val = 0;
> +
> +#define PCIE_LTSSM	0x0404		/* PCIE Link Training and Status */
> +#define PCIE_LTSSM_L0	0x16		/* L0 state */
> +
> +	early_read_config_dword(hose, 0, 0, PCIE_LTSSM, &val);
> +	if (val < PCIE_LTSSM_L0)
> +		return 1;
> +	return 0;
> +}

Aren't PCIE_LTSSM and PCIE_LTSSM_L0 defined in include/linux/fsl/pci.h
at this point?

> @@ -260,14 +259,6 @@ int mpc85xx_pci_err_probe(struct platform_device *op)
>  	/* we only need the error registers */
>  	r.start += 0xe00;
>  
> -	if (!devm_request_mem_region(&op->dev, r.start, resource_size(&r),
> -					pdata->name)) {
> -		printk(KERN_ERR "%s: Error while requesting mem region\n",
> -		       __func__);
> -		res = -EBUSY;
> -		goto err;
> -	}

Why?  If the relationship between the edac driver and the main pci
driver is changing, explain that.

>  	pdata->pci_vbase = devm_ioremap(&op->dev, r.start, resource_size(&r));
>  	if (!pdata->pci_vbase) {
>  		printk(KERN_ERR "%s: Unable to setup PCI err regs\n", __func__);
> diff --git a/drivers/pci/host/Kconfig b/drivers/pci/host/Kconfig
> index 3d95048..37d25ae 100644
> --- a/drivers/pci/host/Kconfig
> +++ b/drivers/pci/host/Kconfig
> @@ -19,4 +19,8 @@ config PCI_TEGRA
>  	bool "NVIDIA Tegra PCIe controller"
>  	depends on ARCH_TEGRA
>  
> +config PCI_FSL
> +	bool "Freescale PCI/PCIe controller"
> +	depends on FSL_SOC_BOOKE || PPC_86xx

Needs help text.

Make it clear that this is for 85xx/86xx/QorIQ/Layerscape, not all
Freescale chips with PCI/PCIe.

>  no_bridge:
> -	iounmap(hose->private_data);
> -	/* unmap cfg_data & cfg_addr separately if not on same page */
> -	if (((unsigned long)hose->cfg_data & PAGE_MASK) !=
> -	    ((unsigned long)hose->cfg_addr & PAGE_MASK))
> -		iounmap(hose->cfg_data);
> -	iounmap(hose->cfg_addr);
> -	pcibios_free_controller(hose);
> -	return -ENODEV;
> +	dev_info(&pdev->dev, "It works as EP mode\n");
> +	return -EPERM;

This is a poorly phrased message.  In any case, what does this change
have to do with making the PCI driver compatible with layerscape?

-Scott

^ permalink raw reply

* Re: [linuxppc-release] [Patch v2 1/2] powerpc/t4240emu: Add device tree file for t4240emu
From: York Sun @ 2013-09-16 23:40 UTC (permalink / raw)
  To: galak; +Cc: scottwood, linuxppc-dev
In-Reply-To: <1379374687-13922-1-git-send-email-yorksun@freescale.com>

On 09/16/2013 04:38 PM, York Sun wrote:
> T4240EMU is an emulator target with minimum peripherals. It is based on
> T4240QDS and trimmed down most peripherals due to either not modeled or
> lack of board level connections. The main purpose of this minimum dts is
> to speed up booting on emulator.
> 
> Signed-off-by: York Sun <yorksun@freescale.com>
> ---
> Change log:
>  v2: remote reviewed-by and tested-by lines added by gerrit
>      resync with t4240qds.dts
> 

Pardon my typo. I meant to type "remove", instead of "remote".

York

^ permalink raw reply

* Re: [linuxppc-release] [Patch v2] powerpc/corenet64_smp_defconfig: Enable most SPI splash
From: York Sun @ 2013-09-16 23:40 UTC (permalink / raw)
  To: galak; +Cc: scottwood, linuxppc-dev
In-Reply-To: <1379374541-13838-1-git-send-email-yorksun@freescale.com>

On 09/16/2013 04:35 PM, York Sun wrote:
> Enable CONFIG_MTD_M25P80 for corenet64_smp_defconfig. Verified on
> P5040DS.
> 
> Signed-off-by: York Sun <yorksun@freescale.com>
> ---
> Change log:
>  v2: remote reviewed-by and tested-by lines added by gerrit
> 

Pardon my typo. I meant to type "remove", instead of "remote".

York

^ permalink raw reply

* [Patch v2 2/2] powerpc/b4860emu: Add device tree file for b4860emu
From: York Sun @ 2013-09-16 23:38 UTC (permalink / raw)
  To: galak; +Cc: scottwood, linuxppc-dev
In-Reply-To: <1379374687-13922-1-git-send-email-yorksun@freescale.com>

B4860EMU is a emualtor target with minimum peripherals. It is based on
B4860QDS and trimmed down most peripherals due to either not modeled or
lack of board level connections. The main purpose of this minimum dts is
to speed up booting on emulator.

Signed-off-by: York Sun <yorksun@freescale.com>
---
Change log:
 v2: remote reviewed-by and tested-by lines added by gerrit
     resync with b4860qds.dts

 arch/powerpc/boot/dts/b4860emu.dts |  219 ++++++++++++++++++++++++++++++++++++
 1 file changed, 219 insertions(+)
 create mode 100644 arch/powerpc/boot/dts/b4860emu.dts

diff --git a/arch/powerpc/boot/dts/b4860emu.dts b/arch/powerpc/boot/dts/b4860emu.dts
new file mode 100644
index 0000000..0f91230
--- /dev/null
+++ b/arch/powerpc/boot/dts/b4860emu.dts
@@ -0,0 +1,219 @@
+/*
+ * B4860 emulator Device Tree Source
+ *
+ * Copyright 2013 Freescale Semiconductor Inc.
+ *
+ * Redistribution and use in source and binary forms, with or without
+ * modification, are permitted provided that the following conditions are met:
+ *     * Redistributions of source code must retain the above copyright
+ *       notice, this list of conditions and the following disclaimer.
+ *     * Redistributions in binary form must reproduce the above copyright
+ *       notice, this list of conditions and the following disclaimer in the
+ *       documentation and/or other materials provided with the distribution.
+ *     * Neither the name of Freescale Semiconductor nor the
+ *       names of its contributors may be used to endorse or promote products
+ *       derived from this software without specific prior written permission.
+ *
+ *
+ * ALTERNATIVELY, this software may be distributed under the terms of the
+ * GNU General Public License ("GPL") as published by the Free Software
+ * Foundation, either version 2 of that License or (at your option) any
+ * later version.
+ *
+ * This software is provided by Freescale Semiconductor "as is" and any
+ * express or implied warranties, including, but not limited to, the implied
+ * warranties of merchantability and fitness for a particular purpose are
+ * disclaimed. In no event shall Freescale Semiconductor be liable for any
+ * direct, indirect, incidental, special, exemplary, or consequential damages
+ * (including, but not limited to, procurement of substitute goods or services;
+ * loss of use, data, or profits; or business interruption) however caused and
+ * on any theory of liability, whether in contract, strict liability, or tort
+ * (including negligence or otherwise) arising in any way out of the use of
+ * this software, even if advised of the possibility of such damage.
+ */
+
+/dts-v1/;
+
+/include/ "fsl/e6500_power_isa.dtsi"
+
+/ {
+	compatible = "fsl,B4860";
+	#address-cells = <2>;
+	#size-cells = <2>;
+	interrupt-parent = <&mpic>;
+
+	aliases {
+		ccsr = &soc;
+
+		serial0 = &serial0;
+		serial1 = &serial1;
+		serial2 = &serial2;
+		serial3 = &serial3;
+		dma0 = &dma0;
+		dma1 = &dma1;
+	};
+
+	cpus {
+		#address-cells = <1>;
+		#size-cells = <0>;
+
+		cpu0: PowerPC,e6500@0 {
+			device_type = "cpu";
+			reg = <0 1>;
+			next-level-cache = <&L2>;
+		};
+		cpu1: PowerPC,e6500@2 {
+			device_type = "cpu";
+			reg = <2 3>;
+			next-level-cache = <&L2>;
+		};
+		cpu2: PowerPC,e6500@4 {
+			device_type = "cpu";
+			reg = <4 5>;
+			next-level-cache = <&L2>;
+		};
+		cpu3: PowerPC,e6500@6 {
+			device_type = "cpu";
+			reg = <6 7>;
+			next-level-cache = <&L2>;
+		};
+	};
+};
+
+/ {
+	model = "fsl,B4860QDS";
+	compatible = "fsl,B4860EMU", "fsl,B4860QDS";
+	#address-cells = <2>;
+	#size-cells = <2>;
+	interrupt-parent = <&mpic>;
+
+	ifc: localbus@ffe124000 {
+		reg = <0xf 0xfe124000 0 0x2000>;
+		ranges = <0 0 0xf 0xe8000000 0x08000000
+			  2 0 0xf 0xff800000 0x00010000
+			  3 0 0xf 0xffdf0000 0x00008000>;
+
+		nor@0,0 {
+			#address-cells = <1>;
+			#size-cells = <1>;
+			compatible = "cfi-flash";
+			reg = <0x0 0x0 0x8000000>;
+			bank-width = <2>;
+			device-width = <1>;
+		};
+	};
+
+	memory {
+		device_type = "memory";
+	};
+
+	soc: soc@ffe000000 {
+		ranges = <0x00000000 0xf 0xfe000000 0x1000000>;
+		reg = <0xf 0xfe000000 0 0x00001000>;
+
+	};
+};
+
+&ifc {
+	#address-cells = <2>;
+	#size-cells = <1>;
+	compatible = "fsl,ifc", "simple-bus";
+	interrupts = <25 2 0 0>;
+};
+
+&soc {
+	#address-cells = <1>;
+	#size-cells = <1>;
+	device_type = "soc";
+	compatible = "simple-bus";
+
+	soc-sram-error {
+		compatible = "fsl,soc-sram-error";
+		interrupts = <16 2 1 2>;
+	};
+
+	corenet-law@0 {
+		compatible = "fsl,corenet-law";
+		reg = <0x0 0x1000>;
+		fsl,num-laws = <32>;
+	};
+
+	ddr1: memory-controller@8000 {
+		compatible = "fsl,qoriq-memory-controller-v4.5", "fsl,qoriq-memory-controller";
+		reg = <0x8000 0x1000>;
+		interrupts = <16 2 1 8>;
+	};
+
+	ddr2: memory-controller@9000 {
+		compatible = "fsl,qoriq-memory-controller-v4.5","fsl,qoriq-memory-controller";
+		reg = <0x9000 0x1000>;
+		interrupts = <16 2 1 9>;
+	};
+
+	cpc: l3-cache-controller@10000 {
+		compatible = "fsl,b4-l3-cache-controller", "cache";
+		reg = <0x10000 0x1000
+		       0x11000 0x1000>;
+		interrupts = <16 2 1 4>;
+	};
+
+	corenet-cf@18000 {
+		compatible = "fsl,b4-corenet-cf";
+		reg = <0x18000 0x1000>;
+		interrupts = <16 2 1 0>;
+		fsl,ccf-num-csdids = <32>;
+		fsl,ccf-num-snoopids = <32>;
+	};
+
+	iommu@20000 {
+		compatible = "fsl,pamu-v1.0", "fsl,pamu";
+		reg = <0x20000 0x4000>;
+		#address-cells = <1>;
+		#size-cells = <1>;
+		interrupts = <
+			24 2 0 0
+			16 2 1 1>;
+		pamu0: pamu@0 {
+			reg = <0 0x1000>;
+			fsl,primary-cache-geometry = <8 1>;
+			fsl,secondary-cache-geometry = <32 2>;
+		};
+	};
+
+/include/ "fsl/qoriq-mpic.dtsi"
+
+	guts: global-utilities@e0000 {
+		compatible = "fsl,b4-device-config";
+		reg = <0xe0000 0xe00>;
+		fsl,has-rstcr;
+		fsl,liodn-bits = <12>;
+	};
+
+	clockgen: global-utilities@e1000 {
+		compatible = "fsl,b4-clockgen", "fsl,qoriq-clockgen-2.0";
+		reg = <0xe1000 0x1000>;
+	};
+
+/include/ "fsl/qoriq-dma-0.dtsi"
+	dma@100300 {
+		fsl,iommu-parent = <&pamu0>;
+		fsl,liodn-reg = <&guts 0x580>; /* DMA1LIODNR */
+	};
+
+/include/ "fsl/qoriq-dma-1.dtsi"
+	dma@101300 {
+		fsl,iommu-parent = <&pamu0>;
+		fsl,liodn-reg = <&guts 0x584>; /* DMA2LIODNR */
+	};
+
+/include/ "fsl/qoriq-i2c-0.dtsi"
+/include/ "fsl/qoriq-i2c-1.dtsi"
+/include/ "fsl/qoriq-duart-0.dtsi"
+/include/ "fsl/qoriq-duart-1.dtsi"
+
+	L2: l2-cache-controller@c20000 {
+		compatible = "fsl,b4-l2-cache-controller";
+		reg = <0xc20000 0x1000>;
+		next-level-cache = <&cpc>;
+	};
+};
-- 
1.7.9.5

^ permalink raw reply related

* [Patch v2 1/2] powerpc/t4240emu: Add device tree file for t4240emu
From: York Sun @ 2013-09-16 23:38 UTC (permalink / raw)
  To: galak; +Cc: scottwood, linuxppc-dev

T4240EMU is an emulator target with minimum peripherals. It is based on
T4240QDS and trimmed down most peripherals due to either not modeled or
lack of board level connections. The main purpose of this minimum dts is
to speed up booting on emulator.

Signed-off-by: York Sun <yorksun@freescale.com>
---
Change log:
 v2: remote reviewed-by and tested-by lines added by gerrit
     resync with t4240qds.dts

 arch/powerpc/boot/dts/t4240emu.dts |  270 ++++++++++++++++++++++++++++++++++++
 1 file changed, 270 insertions(+)
 create mode 100644 arch/powerpc/boot/dts/t4240emu.dts

diff --git a/arch/powerpc/boot/dts/t4240emu.dts b/arch/powerpc/boot/dts/t4240emu.dts
new file mode 100644
index 0000000..44c5a0d
--- /dev/null
+++ b/arch/powerpc/boot/dts/t4240emu.dts
@@ -0,0 +1,270 @@
+/*
+ * T4240 emulator Device Tree Source
+ *
+ * Copyright 2013 Freescale Semiconductor Inc.
+ *
+ * Redistribution and use in source and binary forms, with or without
+ * modification, are permitted provided that the following conditions are met:
+ *     * Redistributions of source code must retain the above copyright
+ *       notice, this list of conditions and the following disclaimer.
+ *     * Redistributions in binary form must reproduce the above copyright
+ *       notice, this list of conditions and the following disclaimer in the
+ *       documentation and/or other materials provided with the distribution.
+ *     * Neither the name of Freescale Semiconductor nor the
+ *       names of its contributors may be used to endorse or promote products
+ *       derived from this software without specific prior written permission.
+ *
+ *
+ * ALTERNATIVELY, this software may be distributed under the terms of the
+ * GNU General Public License ("GPL") as published by the Free Software
+ * Foundation, either version 2 of that License or (at your option) any
+ * later version.
+ *
+ * THIS SOFTWARE IS PROVIDED BY Freescale Semiconductor "AS IS" AND ANY
+ * EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED
+ * WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE
+ * DISCLAIMED. IN NO EVENT SHALL Freescale Semiconductor BE LIABLE FOR ANY
+ * DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES
+ * (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES;
+ * LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND
+ * ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
+ * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS
+ * SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
+ */
+
+/dts-v1/;
+
+/include/ "fsl/e6500_power_isa.dtsi"
+/ {
+	compatible = "fsl,T4240";
+	#address-cells = <2>;
+	#size-cells = <2>;
+	interrupt-parent = <&mpic>;
+
+	aliases {
+		ccsr = &soc;
+
+		serial0 = &serial0;
+		serial1 = &serial1;
+		serial2 = &serial2;
+		serial3 = &serial3;
+		dma0 = &dma0;
+		dma1 = &dma1;
+	};
+
+	cpus {
+		#address-cells = <1>;
+		#size-cells = <0>;
+
+		cpu0: PowerPC,e6500@0 {
+			device_type = "cpu";
+			reg = <0 1>;
+			next-level-cache = <&L2_1>;
+		};
+		cpu1: PowerPC,e6500@2 {
+			device_type = "cpu";
+			reg = <2 3>;
+			next-level-cache = <&L2_1>;
+		};
+		cpu2: PowerPC,e6500@4 {
+			device_type = "cpu";
+			reg = <4 5>;
+			next-level-cache = <&L2_1>;
+		};
+		cpu3: PowerPC,e6500@6 {
+			device_type = "cpu";
+			reg = <6 7>;
+			next-level-cache = <&L2_1>;
+		};
+
+		cpu4: PowerPC,e6500@8 {
+			device_type = "cpu";
+			reg = <8 9>;
+			next-level-cache = <&L2_2>;
+		};
+		cpu5: PowerPC,e6500@10 {
+			device_type = "cpu";
+			reg = <10 11>;
+			next-level-cache = <&L2_2>;
+		};
+		cpu6: PowerPC,e6500@12 {
+			device_type = "cpu";
+			reg = <12 13>;
+			next-level-cache = <&L2_2>;
+		};
+		cpu7: PowerPC,e6500@14 {
+			device_type = "cpu";
+			reg = <14 15>;
+			next-level-cache = <&L2_2>;
+		};
+
+		cpu8: PowerPC,e6500@16 {
+			device_type = "cpu";
+			reg = <16 17>;
+			next-level-cache = <&L2_3>;
+		};
+		cpu9: PowerPC,e6500@18 {
+			device_type = "cpu";
+			reg = <18 19>;
+			next-level-cache = <&L2_3>;
+		};
+		cpu10: PowerPC,e6500@20 {
+			device_type = "cpu";
+			reg = <20 21>;
+			next-level-cache = <&L2_3>;
+		};
+		cpu11: PowerPC,e6500@22 {
+			device_type = "cpu";
+			reg = <22 23>;
+			next-level-cache = <&L2_3>;
+		};
+	};
+};
+
+/ {
+	model = "fsl,T4240QDS";
+	compatible = "fsl,T4240EMU", "fsl,T4240QDS";
+	#address-cells = <2>;
+	#size-cells = <2>;
+	interrupt-parent = <&mpic>;
+
+	ifc: localbus@ffe124000 {
+		reg = <0xf 0xfe124000 0 0x2000>;
+		ranges = <0 0 0xf 0xe8000000 0x08000000
+			  2 0 0xf 0xff800000 0x00010000
+			  3 0 0xf 0xffdf0000 0x00008000>;
+
+		nor@0,0 {
+			#address-cells = <1>;
+			#size-cells = <1>;
+			compatible = "cfi-flash";
+			reg = <0x0 0x0 0x8000000>;
+
+			bank-width = <2>;
+			device-width = <1>;
+		};
+
+	};
+
+	memory {
+		device_type = "memory";
+	};
+
+	soc: soc@ffe000000 {
+		ranges = <0x00000000 0xf 0xfe000000 0x1000000>;
+		reg = <0xf 0xfe000000 0 0x00001000>;
+
+	};
+
+};
+
+&ifc {
+	#address-cells = <2>;
+	#size-cells = <1>;
+	compatible = "fsl,ifc", "simple-bus";
+	interrupts = <25 2 0 0>;
+};
+
+&soc {
+	#address-cells = <1>;
+	#size-cells = <1>;
+	device_type = "soc";
+	compatible = "simple-bus";
+
+	soc-sram-error {
+		compatible = "fsl,soc-sram-error";
+		interrupts = <16 2 1 29>;
+	};
+
+	corenet-law@0 {
+		compatible = "fsl,corenet-law";
+		reg = <0x0 0x1000>;
+		fsl,num-laws = <32>;
+	};
+
+	ddr1: memory-controller@8000 {
+		compatible = "fsl,qoriq-memory-controller-v4.7",
+				"fsl,qoriq-memory-controller";
+		reg = <0x8000 0x1000>;
+		interrupts = <16 2 1 23>;
+	};
+
+	ddr2: memory-controller@9000 {
+		compatible = "fsl,qoriq-memory-controller-v4.7",
+				"fsl,qoriq-memory-controller";
+		reg = <0x9000 0x1000>;
+		interrupts = <16 2 1 22>;
+	};
+
+	ddr3: memory-controller@a000 {
+		compatible = "fsl,qoriq-memory-controller-v4.7",
+				"fsl,qoriq-memory-controller";
+		reg = <0xa000 0x1000>;
+		interrupts = <16 2 1 21>;
+	};
+
+	cpc: l3-cache-controller@10000 {
+		compatible = "fsl,t4240-l3-cache-controller", "cache";
+		reg = <0x10000 0x1000
+		       0x11000 0x1000
+		       0x12000 0x1000>;
+		interrupts = <16 2 1 27
+			      16 2 1 26
+			      16 2 1 25>;
+	};
+
+	corenet-cf@18000 {
+		compatible = "fsl,corenet-cf";
+		reg = <0x18000 0x1000>;
+		interrupts = <16 2 1 31>;
+		fsl,ccf-num-csdids = <32>;
+		fsl,ccf-num-snoopids = <32>;
+	};
+
+	iommu@20000 {
+		compatible = "fsl,pamu-v1.0", "fsl,pamu";
+		reg = <0x20000 0x6000>;
+		interrupts = <
+			24 2 0 0
+			16 2 1 30>;
+	};
+
+/include/ "fsl/qoriq-mpic.dtsi"
+
+	guts: global-utilities@e0000 {
+		compatible = "fsl,t4240-device-config", "fsl,qoriq-device-config-2.0";
+		reg = <0xe0000 0xe00>;
+		fsl,has-rstcr;
+		fsl,liodn-bits = <12>;
+	};
+
+	clockgen: global-utilities@e1000 {
+		compatible = "fsl,t4240-clockgen", "fsl,qoriq-clockgen-2.0";
+		reg = <0xe1000 0x1000>;
+	};
+
+/include/ "fsl/qoriq-dma-0.dtsi"
+/include/ "fsl/qoriq-dma-1.dtsi"
+
+/include/ "fsl/qoriq-i2c-0.dtsi"
+/include/ "fsl/qoriq-i2c-1.dtsi"
+/include/ "fsl/qoriq-duart-0.dtsi"
+/include/ "fsl/qoriq-duart-1.dtsi"
+
+	L2_1: l2-cache-controller@c20000 {
+		compatible = "fsl,t4240-l2-cache-controller";
+		reg = <0xc20000 0x40000>;
+		next-level-cache = <&cpc>;
+	};
+	L2_2: l2-cache-controller@c60000 {
+		compatible = "fsl,t4240-l2-cache-controller";
+		reg = <0xc60000 0x40000>;
+		next-level-cache = <&cpc>;
+	};
+	L2_3: l2-cache-controller@ca0000 {
+		compatible = "fsl,t4240-l2-cache-controller";
+		reg = <0xca0000 0x40000>;
+		next-level-cache = <&cpc>;
+	};
+};
+
-- 
1.7.9.5

^ permalink raw reply related


This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox