* Re: [v2] xmon: Setup xmon debugger hooks when first break-point is set
From: Michael Ellerman @ 2018-03-14 9:28 UTC (permalink / raw)
To: Vaibhav Jain, Balbir Singh
Cc: Vaibhav Jain, Frederic Barrat, linux-kernel, Paul Mackerras,
Nicholas Piggin, Douglas Miller, linuxppc-dev
In-Reply-To: <20180304173025.19520-1-vaibhav@linux.vnet.ibm.com>
On Sun, 2018-03-04 at 17:30:25 UTC, Vaibhav Jain wrote:
> Presently sysrq key for xmon('x') is registered during kernel init
> irrespective of the value of kernel param 'xmon'. Thus xmon is enabled
> even if 'xmon=off' is passed on the kernel command line. However this
> doesn't enable the kernel debugger hooks needed for instruction or data
> breakpoints. Thus when a break-point is hit with xmon=off a kernel oops
> of the form below is reported:
>
> Oops: Exception in kernel mode, sig: 5 [#1]
> < snip >
> Trace/breakpoint trap
>
> To fix this the patch checks and enables debugger hooks when an
> instruction or data break-point is set via xmon console.
>
> Signed-off-by: Vaibhav Jain <vaibhav@linux.vnet.ibm.com>
> Reviewed-by: Balbir Singh <bsingharora@gmail.com>
Applied to powerpc next, thanks.
https://git.kernel.org/powerpc/c/e1368d0c9edbc366e45216e7295fd6
cheers
^ permalink raw reply
* Re: [v2, 01/10] powerpc/mm/slice: Simplify and optimise slice context initialisation
From: Michael Ellerman @ 2018-03-14 9:28 UTC (permalink / raw)
To: Nicholas Piggin, linuxppc-dev; +Cc: Aneesh Kumar K . V, Nicholas Piggin
In-Reply-To: <20180307013718.13749-2-npiggin@gmail.com>
On Wed, 2018-03-07 at 01:37:09 UTC, Nicholas Piggin wrote:
> The slice state of an mm gets zeroed then initialised upon exec.
> This is the only caller of slice_set_user_psize now, so that can be
> removed and instead implement a faster and simplified approach that
> requires no locking or checking existing state.
>
> This speeds up vfork+exec+exit performance on POWER8 by 3%.
>
> Signed-off-by: Nicholas Piggin <npiggin@gmail.com>
Patches 1-9 applied to powerpc next, thanks.
https://git.kernel.org/powerpc/c/1753dd1830367709144f68f539554d
cheers
^ permalink raw reply
* Re: selftests/powerpc: Skip tm-unavailable if TM is not enabled
From: Michael Ellerman @ 2018-03-14 9:28 UTC (permalink / raw)
To: Gustavo Romero, linuxppc-dev; +Cc: cyrilbur, gromero
In-Reply-To: <1520282935-20111-2-git-send-email-gromero@linux.vnet.ibm.com>
On Mon, 2018-03-05 at 20:48:55 UTC, Gustavo Romero wrote:
> Some processor revisions do not support transactional memory, and
> additionally kernel support can be disabled. In either case the
> tm-unavailable test should be skipped, otherwise it will fail with
> a SIGILL.
>
> That commit also sets this selftest to be called through the test
> harness as it's done for other TM selftests.
>
> Finally, it avoids using "ping" as a thread name since it's
> ambiguous and can be confusing when shown, for instance,
> in a kernel backtrace log.
>
> Fixes: 77fad8bfb1d2 ("selftests/powerpc: Check FP/VEC on exception in TM")
> Signed-off-by: Gustavo Romero <gromero@linux.vnet.ibm.com>
> Reviewed-by: Cyril Bur <cyrilbur@gmail.com>
Applied to powerpc next, thanks.
https://git.kernel.org/powerpc/c/b395e55b49ecd56ea28dc629f4ca4c
cheers
^ permalink raw reply
* Re: xmon: Clear all breakpoints when xmon is disabled via debugfs
From: Michael Ellerman @ 2018-03-14 9:28 UTC (permalink / raw)
To: Vaibhav Jain, Balbir Singh
Cc: Vaibhav Jain, Frederic Barrat, linux-kernel, Paul Mackerras,
Nicholas Piggin, Douglas Miller, linuxppc-dev
In-Reply-To: <20180304173132.19677-1-vaibhav@linux.vnet.ibm.com>
On Sun, 2018-03-04 at 17:31:32 UTC, Vaibhav Jain wrote:
> Presently when xmon is disabled by debugfs any existing
> instruction/data-access breakpoints set are not disabled. This may
> lead to kernel oops when those breakpoints are hit as the necessary
> debugger hooks aren't installed.
>
> Hence this patch introduces a new function named clear_all_bpt()
> which is called when xmon is disabled via debugfs. The function will
> unpatch/clear all the trap and ciabr/dab based breakpoints.
>
> Signed-off-by: Vaibhav Jain <vaibhav@linux.vnet.ibm.com>
> Reviewed-by: Balbir Singh <bsingharora@gmail.com>
Applied to powerpc next, thanks.
https://git.kernel.org/powerpc/c/1ff3b404019adf9d605224e1dce067
cheers
^ permalink raw reply
* Re: [v2, 06/21] powerpc: Avoid comparison of unsigned long >= 0 in __access_ok
From: Michael Ellerman @ 2018-03-14 9:28 UTC (permalink / raw)
To: Mathieu Malaterre
Cc: Mathieu Malaterre, linux-kernel, Paul Mackerras, linuxppc-dev
In-Reply-To: <20180302195051.4472-1-malat@debian.org>
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain, Size: 1940 bytes --]
On Fri, 2018-03-02 at 19:50:51 UTC, Mathieu Malaterre wrote:
> Rewrite function-like macro into regular static inline function to avoid a
> warning during macro expansion.
> Fix warning (treated as error in W=1):
>
> CC arch/powerpc/kernel/signal_32.o
> In file included from ./include/linux/uaccess.h:14:0,
> from ./include/asm-generic/termios-base.h:8,
> from ./arch/powerpc/include/asm/termios.h:20,
> from ./include/uapi/linux/termios.h:6,
> from ./include/linux/tty.h:7,
> from arch/powerpc/kernel/signal_32.c:36:
> ./include/asm-generic/termios-base.h: In function ‘user_termio_to_kernel_termios’:
> ./arch/powerpc/include/asm/uaccess.h:52:35: error: comparison of unsigned expression >= 0 is always true [-Werror=type-limits]
> (((size) == 0) || (((size) - 1) <= ((segment).seg - (addr)))))
> ^
> ./arch/powerpc/include/asm/uaccess.h:58:3: note: in expansion of macro ‘__access_ok’
> __access_ok((__force unsigned long)(addr), (size), get_fs()))
> ^~~~~~~~~~~
> ./arch/powerpc/include/asm/uaccess.h:262:6: note: in expansion of macro ‘access_ok’
> if (access_ok(VERIFY_READ, __gu_addr, (size))) \
> ^~~~~~~~~
> ./arch/powerpc/include/asm/uaccess.h:80:2: note: in expansion of macro ‘__get_user_check’
> __get_user_check((x), (ptr), sizeof(*(ptr)))
> ^~~~~~~~~~~~~~~~
> ./include/asm-generic/termios-base.h:36:6: note: in expansion of macro ‘get_user’
> if (get_user(termios->c_line, &termio->c_line) < 0)
> ^~~~~~~~
> [...]
> cc1: all warnings being treated as errors
>
> Suggested-by: Segher Boessenkool <segher@kernel.crashing.org>
> Signed-off-by: Mathieu Malaterre <malat@debian.org>
> Reviewed-by: Christophe Leroy <christophe.leroy@c-s.fr>
Applied to powerpc next, thanks.
https://git.kernel.org/powerpc/c/ef85dffd4251ff6c23056651f6f83b
cheers
^ permalink raw reply
* Re: [v2, 05/21] powerpc: Avoid comparison of unsigned long >= 0 in pfn_valid
From: Michael Ellerman @ 2018-03-14 9:28 UTC (permalink / raw)
To: Mathieu Malaterre
Cc: Mathieu Malaterre, open list, Paul Mackerras,
open list:LINUX FOR POWERPC 32-BIT AND 64-BIT
In-Reply-To: <20180307203436.23696-1-malat@debian.org>
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain, Size: 1355 bytes --]
On Wed, 2018-03-07 at 20:34:35 UTC, Mathieu Malaterre wrote:
> Rewrite comparison since all values compared are of type `unsigned long`.
>
> Instead of using unsigned properties and rewriting the original code as:
> (originally suggested by Segher Boessenkool <segher@kernel.crashing.org>)
>
> #define pfn_valid(pfn) \
> (((pfn) - ARCH_PFN_OFFSET) < (max_mapnr - ARCH_PFN_OFFSET))
>
> Prefer a static inline function to make code as readable as possible.
>
> Fix a warning (treated as error in W=1):
>
> CC arch/powerpc/kernel/irq.o
> In file included from ./include/linux/bug.h:5:0,
> from ./include/linux/cpumask.h:13,
> from ./include/linux/smp.h:13,
> from ./include/linux/kernel_stat.h:5,
> from arch/powerpc/kernel/irq.c:35:
> ./include/linux/dma-mapping.h: In function ‘dma_map_resource’:
> ./arch/powerpc/include/asm/page.h:129:32: error: comparison of unsigned expression >= 0 is always true [-Werror=type-limits]
> #define pfn_valid(pfn) ((pfn) >= ARCH_PFN_OFFSET && (pfn) < max_mapnr)
> ^
> Suggested-by: Christophe Leroy <christophe.leroy@c-s.fr>
> Signed-off-by: Mathieu Malaterre <malat@debian.org>
Applied to powerpc next, thanks.
https://git.kernel.org/powerpc/c/603b892200e653dd7e86a0e4a31556
cheers
^ permalink raw reply
* Re: powerpc/mm: Drop the function native_register_proc_table()
From: Michael Ellerman @ 2018-03-14 9:28 UTC (permalink / raw)
To: Anshuman Khandual, linuxppc-dev; +Cc: aneesh.kumar
In-Reply-To: <20180303092402.6032-1-khandual@linux.vnet.ibm.com>
On Sat, 2018-03-03 at 09:24:02 UTC, Anshuman Khandual wrote:
> This is left over from the segment table implementation and not getting
> called from any where now. Hence just drop it.
>
> Suggested-by: Aneesh Kumar K.V <aneesh.kumar@linux.vnet.ibm.com>
> Signed-off-by: Anshuman Khandual <khandual@linux.vnet.ibm.com>
Applied to powerpc next, thanks.
https://git.kernel.org/powerpc/c/3d4f5f58484c8f86bfd9a97f152db6
cheers
^ permalink raw reply
* Re: [v2,15/21] powerpc: Make function MMU_setup static
From: Michael Ellerman @ 2018-03-14 9:28 UTC (permalink / raw)
To: Mathieu Malaterre
Cc: Mathieu Malaterre, open list, Paul Mackerras, Aneesh Kumar K.V,
open list:LINUX FOR POWERPC 32-BIT AND 64-BIT
In-Reply-To: <20180307203257.23542-1-malat@debian.org>
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain, Size: 602 bytes --]
On Wed, 2018-03-07 at 20:32:55 UTC, Mathieu Malaterre wrote:
> Since function `MMU_setup` is not meant to be exported, change the
> signature to `static`. Fix warning (treated as error with W=1):
>
> CC kernel/sys.o
> arch/powerpc/mm/init_32.c:102:13: error: no previous prototype for ‘MMU_setup’ [-Werror=missing-prototypes]
> void __init MMU_setup(void)
> ^~~~~~~~~
> cc1: all warnings being treated as errors
>
> Signed-off-by: Mathieu Malaterre <malat@debian.org>
Applied to powerpc next, thanks.
https://git.kernel.org/powerpc/c/d15a261d876da3267c8c706ef21e7f
cheers
^ permalink raw reply
* Re: powerpc/8xx: fix cpm_cascade() dual end of interrupt
From: Michael Ellerman @ 2018-03-14 9:28 UTC (permalink / raw)
To: Christophe Leroy, Benjamin Herrenschmidt, Paul Mackerras,
Scott Wood, Vitaly Bordug
Cc: linuxppc-dev, linux-kernel
In-Reply-To: <20180227112555.DEBCE6E8BA@po15720vm.idsi0.si.c-s.fr>
On Tue, 2018-02-27 at 11:25:55 UTC, Christophe Leroy wrote:
> cpm_cascade() doesn't have to call eoi() as it is already called
> by handle_fasteoi_irq()
>
> And cpm_get_irq() will always return an unsigned int so the test
> is useless
>
> Signed-off-by: Christophe Leroy <christophe.leroy@c-s.fr>
Applied to powerpc next, thanks.
https://git.kernel.org/powerpc/c/c554ac91ce2213faa91c51c4542377
cheers
^ permalink raw reply
* Re: [v2,01/21] powerpc: Remove warning on array size when empty
From: Michael Ellerman @ 2018-03-14 9:28 UTC (permalink / raw)
To: Mathieu Malaterre
Cc: Mathieu Malaterre, linux-kernel, Andy Shevchenko, Paul Mackerras,
linuxppc-dev
In-Reply-To: <20180302194918.4358-1-malat@debian.org>
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain, Size: 857 bytes --]
On Fri, 2018-03-02 at 19:49:18 UTC, Mathieu Malaterre wrote:
> When neither CONFIG_ALTIVEC, nor CONFIG_VSX or CONFIG_PPC64 is defined, the
> array feature_properties is defined as an empty array, which in turn
> triggers the following warning (treated as error on W=1):
>
> CC arch/powerpc/kernel/prom.o
> arch/powerpc/kernel/prom.c: In function ‘check_cpu_feature_properties’:
> arch/powerpc/kernel/prom.c:298:16: error: comparison of unsigned expression < 0 is always false [-Werror=type-limits]
> for (i = 0; i < ARRAY_SIZE(feature_properties); ++i, ++fp) {
> ^
> cc1: all warnings being treated as errors
>
> Suggested-by: Michael Ellerman <mpe@ellerman.id.au>
> Signed-off-by: Mathieu Malaterre <malat@debian.org>
Applied to powerpc next, thanks.
https://git.kernel.org/powerpc/c/4f1f40f7b2b4487f582ecafec64076
cheers
^ permalink raw reply
* Re: [v3] powerpc/npu-dma.c: Fix deadlock in mmio_invalidate
From: Michael Ellerman @ 2018-03-14 9:28 UTC (permalink / raw)
To: Alistair Popple, linuxppc-dev; +Cc: Mark Hairgrove, Alistair Popple
In-Reply-To: <20180302051845.26844-1-alistair@popple.id.au>
On Fri, 2018-03-02 at 05:18:45 UTC, Alistair Popple wrote:
> When sending TLB invalidates to the NPU we need to send extra flushes due
> to a hardware issue. The original implementation would lock the all the
> ATSD MMIO registers sequentially before unlocking and relocking each of
> them sequentially to do the extra flush.
>
> This introduced a deadlock as it is possible for one thread to hold one
> ATSD register whilst waiting for another register to be freed while the
> other thread is holding that register waiting for the one in the first
> thread to be freed.
>
> For example if there are two threads and two ATSD registers:
>
> Thread A Thread B
> Acquire 1
> Acquire 2
> Release 1 Acquire 1
> Wait 1 Wait 2
>
> Both threads will be stuck waiting to acquire a register resulting in an
> RCU stall warning or soft lockup.
>
> This patch solves the deadlock by refactoring the code to ensure registers
> are not released between flushes and to ensure all registers are either
> acquired or released together and in order.
>
> Fixes: bbd5ff50afff ("powerpc/powernv/npu-dma: Add explicit flush when sending an ATSD")
> Signed-off-by: Alistair Popple <alistair@popple.id.au>
Applied to powerpc next, thanks.
https://git.kernel.org/powerpc/c/2b74e2a9b39df40a2b489af2d24079
cheers
^ permalink raw reply
* Re: [v10,1/2] powerpc/powernv: Enable tunneled operations
From: Michael Ellerman @ 2018-03-14 9:28 UTC (permalink / raw)
To: Philippe Bergheaud, linuxppc-dev
Cc: Philippe Bergheaud, benh, clombard, fbarrat
In-Reply-To: <20180302095612.19493-1-felix@linux.vnet.ibm.com>
On Fri, 2018-03-02 at 09:56:11 UTC, Philippe Bergheaud wrote:
> P9 supports PCI tunneled operations (atomics and as_notify). This
> patch adds support for tunneled operations on powernv, with a new
> API, to be called by device drivers:
>
> pnv_pci_enable_tunnel()
> Enable tunnel operations, tell driver the 16-bit ASN indication
> used by kernel.
>
> pnv_pci_disable_tunnel()
> Disable tunnel operations.
>
> pnv_pci_set_tunnel_bar()
> Tell kernel the Tunnel BAR Response address used by driver.
> This function uses two new OPAL calls, as the PBCQ Tunnel BAR
> register is configured by skiboot.
>
> pnv_pci_get_as_notify_info()
> Return the ASN info of the thread to be woken up.
>
> Signed-off-by: Philippe Bergheaud <felix@linux.vnet.ibm.com>
> Reviewed-by: Frederic Barrat <fbarrat@linux.vnet.ibm.com>
> Reviewed-by: Christophe Lombard <clombard@linux.vnet.ibm.com>
Series applied to powerpc next, thanks.
https://git.kernel.org/powerpc/c/d6a90bb83b5084829558788ea5b881
cheers
^ permalink raw reply
* Re: [21/21] powerpc: Add missing prototypes in setup_32.c
From: Michael Ellerman @ 2018-03-14 9:28 UTC (permalink / raw)
To: Mathieu Malaterre
Cc: Mathieu Malaterre, linux-kernel, Paul Mackerras, Jiri Slaby,
linuxppc-dev
In-Reply-To: <20180225172236.29650-22-malat@debian.org>
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain, Size: 2173 bytes --]
On Sun, 2018-02-25 at 17:22:36 UTC, Mathieu Malaterre wrote:
> This commit add the prototypes for the following function:
>
> - early_init
> - machine_init
> - ppc_setup_l2cr
> - ppc_setup_l3cr
> - ppc_init
>
> the other missing ones were already added in setup.h previously. Fix the
> following warnings (treated as error in W=1):
>
> AR init/built-in.o
> arch/powerpc/kernel/setup_32.c:68:30: error: no previous prototype for ‘early_init’ [-Werror=missing-prototypes]
> notrace unsigned long __init early_init(unsigned long dt_ptr)
> ^~~~~~~~~~
> arch/powerpc/kernel/setup_32.c:99:21: error: no previous prototype for ‘machine_init’ [-Werror=missing-prototypes]
> notrace void __init machine_init(u64 dt_ptr)
> ^~~~~~~~~~~~
> arch/powerpc/kernel/setup_32.c:124:12: error: no previous prototype for ‘ppc_setup_l2cr’ [-Werror=missing-prototypes]
> int __init ppc_setup_l2cr(char *str)
> ^~~~~~~~~~~~~~
> arch/powerpc/kernel/setup_32.c:137:12: error: no previous prototype for ‘ppc_setup_l3cr’ [-Werror=missing-prototypes]
> int __init ppc_setup_l3cr(char *str)
> ^~~~~~~~~~~~~~
> arch/powerpc/kernel/setup_32.c:183:12: error: no previous prototype for ‘ppc_init’ [-Werror=missing-prototypes]
> int __init ppc_init(void)
> ^~~~~~~~
> arch/powerpc/kernel/setup_32.c:198:13: error: no previous prototype for ‘irqstack_early_init’ [-Werror=missing-prototypes]
> void __init irqstack_early_init(void)
> ^~~~~~~~~~~~~~~~~~~
> arch/powerpc/kernel/setup_32.c:238:13: error: no previous prototype for ‘setup_power_save’ [-Werror=missing-prototypes]
> void __init setup_power_save(void)
> ^~~~~~~~~~~~~~~~
> arch/powerpc/kernel/setup_32.c:253:13: error: no previous prototype for ‘initialize_cache_info’ [-Werror=missing-prototypes]
> __init void initialize_cache_info(void)
> ^~~~~~~~~~~~~~~~~~~~~
> cc1: all warnings being treated as errors
>
> Signed-off-by: Mathieu Malaterre <malat@debian.org>
Applied to powerpc next, thanks.
https://git.kernel.org/powerpc/c/e82d70cf965072a3872ea97b7d8df4
cheers
^ permalink raw reply
* Re: [08/21] powerpc: Make function __giveup_fpu static
From: Michael Ellerman @ 2018-03-14 9:28 UTC (permalink / raw)
To: Mathieu Malaterre
Cc: Mathieu Malaterre, linux-kernel, Paul Mackerras, Jiri Slaby,
linuxppc-dev
In-Reply-To: <20180225172236.29650-9-malat@debian.org>
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain, Size: 735 bytes --]
On Sun, 2018-02-25 at 17:22:23 UTC, Mathieu Malaterre wrote:
> When CONFIG_PPC_FPU is defined the prototype exposed in asm/switch_to.h is:
>
> extern void giveup_fpu(struct task_struct *);
>
> Change the function prototype of __giveup_fpu to static. Fix warning
> (treated as error in W=1):
>
> CC arch/powerpc/kernel/process.o
> arch/powerpc/kernel/process.c:176:6: error: no previous prototype for ‘__giveup_fpu’ [-Werror=missing-prototypes]
> void __giveup_fpu(struct task_struct *tsk)
> ^~~~~~~~~~~~
> cc1: all warnings being treated as errors
>
> Signed-off-by: Mathieu Malaterre <malat@debian.org>
Applied to powerpc next, thanks.
https://git.kernel.org/powerpc/c/1cdf039bf82a39d816ca4b8161b01c
cheers
^ permalink raw reply
* Re: [20/21] powerpc: Add missing prototypes for ppc_select & ppc_fadvise64_64
From: Michael Ellerman @ 2018-03-14 9:28 UTC (permalink / raw)
To: Mathieu Malaterre
Cc: Mathieu Malaterre, linux-kernel, Paul Mackerras, Jiri Slaby,
linuxppc-dev
In-Reply-To: <20180225172236.29650-21-malat@debian.org>
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain, Size: 928 bytes --]
On Sun, 2018-02-25 at 17:22:35 UTC, Mathieu Malaterre wrote:
> Add missing prototypes for ppc_select & ppc_fadvise64_64 to header
> asm-prototypes.h. Fix the following warnings (treated as errors in W=1)
>
> CC arch/powerpc/kernel/syscalls.o
> arch/powerpc/kernel/syscalls.c:87:1: error: no previous prototype for ‘ppc_select’ [-Werror=missing-prototypes]
> ppc_select(int n, fd_set __user *inp, fd_set __user *outp, fd_set __user *exp, struct timeval __user *tvp)
> ^~~~~~~~~~
> arch/powerpc/kernel/syscalls.c:119:6: error: no previous prototype for ‘ppc_fadvise64_64’ [-Werror=missing-prototypes]
> long ppc_fadvise64_64(int fd, int advice, u32 offset_high, u32 offset_low,
> ^~~~~~~~~~~~~~~~
> cc1: all warnings being treated as errors
>
> Signed-off-by: Mathieu Malaterre <malat@debian.org>
Applied to powerpc next, thanks.
https://git.kernel.org/powerpc/c/bf7fb32dd5fc8a6bd25aaab05d3acd
cheers
^ permalink raw reply
* Re: [19/21] powerpc: Add missing prototypes for hw_breakpoint_handler & arch_unregister_hw_breakpoint
From: Michael Ellerman @ 2018-03-14 9:28 UTC (permalink / raw)
To: Mathieu Malaterre
Cc: Mathieu Malaterre, linux-kernel, Paul Mackerras, Jiri Slaby,
linuxppc-dev
In-Reply-To: <20180225172236.29650-20-malat@debian.org>
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain, Size: 1064 bytes --]
On Sun, 2018-02-25 at 17:22:34 UTC, Mathieu Malaterre wrote:
> In commit 5aae8a537080 ("powerpc, hw_breakpoints: Implement hw_breakpoints
> for 64-bit server processors") function hw_breakpoint_handler and
> arch_unregister_hw_breakpoint were added without function prototypes in
> hw_breakpoint.h header.
>
> Fix the following warning(s) (treated as error in W=1):
>
> AR init/built-in.o
> arch/powerpc/kernel/hw_breakpoint.c:106:6: error: no previous prototype for ‘arch_unregister_hw_breakpoint’ [-Werror=missing-prototypes]
> void arch_unregister_hw_breakpoint(struct perf_event *bp)
> ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> arch/powerpc/kernel/hw_breakpoint.c:209:5: error: no previous prototype for ‘hw_breakpoint_handler’ [-Werror=missing-prototypes]
> int hw_breakpoint_handler(struct die_args *args)
> ^~~~~~~~~~~~~~~~~~~~~
> cc1: all warnings being treated as errors
>
> Signed-off-by: Mathieu Malaterre <malat@debian.org>
Applied to powerpc next, thanks.
https://git.kernel.org/powerpc/c/b0d876da1d1cd33a1c28049512a136
cheers
^ permalink raw reply
* Re: [17/21] powerpc: Add missing prototype for sys_debug_setcontext
From: Michael Ellerman @ 2018-03-14 9:28 UTC (permalink / raw)
To: Mathieu Malaterre
Cc: Mathieu Malaterre, linux-kernel, Paul Mackerras, Jiri Slaby,
linuxppc-dev
In-Reply-To: <20180225172236.29650-18-malat@debian.org>
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain, Size: 733 bytes --]
On Sun, 2018-02-25 at 17:22:32 UTC, Mathieu Malaterre wrote:
> In commit 81e7009ea46c ("powerpc: merge ppc signal.c and ppc64 signal32.c")
> the function sys_debug_setcontext was added without a prototype.
>
> Fix compilation warning (treated as error in W=1):
>
> CC arch/powerpc/kernel/signal_32.o
> arch/powerpc/kernel/signal_32.c:1227:5: error: no previous prototype for ‘sys_debug_setcontext’ [-Werror=missing-prototypes]
> int sys_debug_setcontext(struct ucontext __user *ctx,
> ^~~~~~~~~~~~~~~~~~~~
> cc1: all warnings being treated as errors
>
> Signed-off-by: Mathieu Malaterre <malat@debian.org>
Applied to powerpc next, thanks.
https://git.kernel.org/powerpc/c/0d60619e1c0ca20eb2610361034992
cheers
^ permalink raw reply
* Re: [18/21] powerpc: Add missing prototypes for sys_sigreturn & sys_rt_sigreturn
From: Michael Ellerman @ 2018-03-14 9:28 UTC (permalink / raw)
To: Mathieu Malaterre
Cc: Mathieu Malaterre, linux-kernel, Paul Mackerras, Jiri Slaby,
linuxppc-dev
In-Reply-To: <20180225172236.29650-19-malat@debian.org>
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain, Size: 887 bytes --]
On Sun, 2018-02-25 at 17:22:33 UTC, Mathieu Malaterre wrote:
> Two functions did not have a prototype defined in signal.h header. Fix the
> following two warnings (treated as errors in W=1):
>
> CC arch/powerpc/kernel/signal_32.o
> arch/powerpc/kernel/signal_32.c:1135:6: error: no previous prototype for ‘sys_rt_sigreturn’ [-Werror=missing-prototypes]
> long sys_rt_sigreturn(int r3, int r4, int r5, int r6, int r7, int r8,
> ^~~~~~~~~~~~~~~~
> arch/powerpc/kernel/signal_32.c:1422:6: error: no previous prototype for ‘sys_sigreturn’ [-Werror=missing-prototypes]
> long sys_sigreturn(int r3, int r4, int r5, int r6, int r7, int r8,
> ^~~~~~~~~~~~~
> cc1: all warnings being treated as errors
>
> Signed-off-by: Mathieu Malaterre <malat@debian.org>
Applied to powerpc next, thanks.
https://git.kernel.org/powerpc/c/b53875c4b4f212a7a8e505e2d10635
cheers
^ permalink raw reply
* Re: [16/21] powerpc: Add missing prototype for init_IRQ
From: Michael Ellerman @ 2018-03-14 9:28 UTC (permalink / raw)
To: Mathieu Malaterre
Cc: Mathieu Malaterre, linux-kernel, Paul Mackerras, Jiri Slaby,
linuxppc-dev
In-Reply-To: <20180225172236.29650-17-malat@debian.org>
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain, Size: 610 bytes --]
On Sun, 2018-02-25 at 17:22:31 UTC, Mathieu Malaterre wrote:
> A function init_IRQ was added without a prototype declared in header irq.h.
> Fix the following warning (treated as error in W=1):
>
> CC arch/powerpc/kernel/irq.o
> arch/powerpc/kernel/irq.c:662:13: error: no previous prototype for ‘init_IRQ’ [-Werror=missing-prototypes]
> void __init init_IRQ(void)
> ^~~~~~~~
> cc1: all warnings being treated as errors
>
> Signed-off-by: Mathieu Malaterre <malat@debian.org>
Applied to powerpc next, thanks.
https://git.kernel.org/powerpc/c/23a6d8b9634897add6ebff32372f34
cheers
^ permalink raw reply
* Re: [13/21] powerpc: Add missing prototype for arch_dup_task_struct
From: Michael Ellerman @ 2018-03-14 9:27 UTC (permalink / raw)
To: Mathieu Malaterre
Cc: Mathieu Malaterre, linux-kernel, Paul Mackerras, Jiri Slaby,
linuxppc-dev
In-Reply-To: <20180225172236.29650-14-malat@debian.org>
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain, Size: 798 bytes --]
On Sun, 2018-02-25 at 17:22:28 UTC, Mathieu Malaterre wrote:
> In commit 55ccf3fe3f9a ("fork: move the real prepare_to_copy() users to
> arch_dup_task_struct()") a new arch_dup_task_struct was added without a
> prototype declared in thread_info.h header. Fix the following warning
> (treated as error in W=1):
>
> CC arch/powerpc/kernel/process.o
> arch/powerpc/kernel/process.c:1609:5: error: no previous prototype for ‘arch_dup_task_struct’ [-Werror=missing-prototypes]
> int arch_dup_task_struct(struct task_struct *dst, struct task_struct *src)
> ^~~~~~~~~~~~~~~~~~~~
> cc1: all warnings being treated as errors
>
> Signed-off-by: Mathieu Malaterre <malat@debian.org>
Applied to powerpc next, thanks.
https://git.kernel.org/powerpc/c/fd70d9f96d8182a67e28b99c999157
cheers
^ permalink raw reply
* Re: [14/21] powerpc: Add missing prototype for arch_irq_work_raise
From: Michael Ellerman @ 2018-03-14 9:27 UTC (permalink / raw)
To: Mathieu Malaterre
Cc: Mathieu Malaterre, linux-kernel, Paul Mackerras, Jiri Slaby,
linuxppc-dev
In-Reply-To: <20180225172236.29650-15-malat@debian.org>
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain, Size: 706 bytes --]
On Sun, 2018-02-25 at 17:22:29 UTC, Mathieu Malaterre wrote:
> In commit 4f8b50bbbe63 ("irq_work, ppc: Fix up arch hooks") a new function
> arch_irq_work_raise was added without a prototype in header irq_work.h.
>
> Fix the following warning (treated as error in W=1):
>
> CC arch/powerpc/kernel/time.o
> arch/powerpc/kernel/time.c:523:6: error: no previous prototype for ‘arch_irq_work_raise’ [-Werror=missing-prototypes]
> void arch_irq_work_raise(void)
> ^~~~~~~~~~~~~~~~~~~
> cc1: all warnings being treated as errors
>
> Signed-off-by: Mathieu Malaterre <malat@debian.org>
Applied to powerpc next, thanks.
https://git.kernel.org/powerpc/c/f5246862f82f1e16bbf84cda4cddf2
cheers
^ permalink raw reply
* Re: [12/21] powerpc: Add missing prototype for time_init
From: Michael Ellerman @ 2018-03-14 9:27 UTC (permalink / raw)
To: Mathieu Malaterre
Cc: Mathieu Malaterre, linux-kernel, Paul Mackerras, Jiri Slaby,
linuxppc-dev
In-Reply-To: <20180225172236.29650-13-malat@debian.org>
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain, Size: 618 bytes --]
On Sun, 2018-02-25 at 17:22:27 UTC, Mathieu Malaterre wrote:
> The function time_init did not have a prototype defined in the time.h
> header. Fix the following warning (treated as error in W=1):
>
> CC arch/powerpc/kernel/time.o
> arch/powerpc/kernel/time.c:1068:13: error: no previous prototype for ‘time_init’ [-Werror=missing-prototypes]
> void __init time_init(void)
> ^~~~~~~~~
> cc1: all warnings being treated as errors
>
> Signed-off-by: Mathieu Malaterre <malat@debian.org>
Applied to powerpc next, thanks.
https://git.kernel.org/powerpc/c/848092faa0c7687a99bf465808f7da
cheers
^ permalink raw reply
* Re: [11/21] powerpc: Add missing prototype for hdec_interrupt
From: Michael Ellerman @ 2018-03-14 9:27 UTC (permalink / raw)
To: Mathieu Malaterre
Cc: Mathieu Malaterre, linux-kernel, Paul Mackerras, Jiri Slaby,
linuxppc-dev
In-Reply-To: <20180225172236.29650-12-malat@debian.org>
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain, Size: 701 bytes --]
On Sun, 2018-02-25 at 17:22:26 UTC, Mathieu Malaterre wrote:
> In commit dabe859ec636 ("powerpc: Give hypervisor decrementer interrupts
> their own handler") an empty body function was added, but no prototype was
> declared. Fix warning (treated as error in W=1):
>
> CC arch/powerpc/kernel/time.o
> arch/powerpc/kernel/time.c:629:6: error: no previous prototype for ‘hdec_interrupt’ [-Werror=missing-prototypes]
> void hdec_interrupt(struct pt_regs *regs)
> ^~~~~~~~~~~~~~
> cc1: all warnings being treated as errors
>
> Signed-off-by: Mathieu Malaterre <malat@debian.org>
Applied to powerpc next, thanks.
https://git.kernel.org/powerpc/c/8b604faff7d421904ebd1fa65d642f
cheers
^ permalink raw reply
* Re: [10/21] powerpc: Add missing prototype for slb_miss_bad_addr
From: Michael Ellerman @ 2018-03-14 9:27 UTC (permalink / raw)
To: Mathieu Malaterre
Cc: Mathieu Malaterre, linux-kernel, Paul Mackerras, Jiri Slaby,
linuxppc-dev
In-Reply-To: <20180225172236.29650-11-malat@debian.org>
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain, Size: 751 bytes --]
On Sun, 2018-02-25 at 17:22:25 UTC, Mathieu Malaterre wrote:
> In commit f0f558b131db ("powerpc/mm: Preserve CFAR value on SLB miss caused
> by access to bogus address"), the function slb_miss_bad_addr was added
> without a prototype. This commit adds it.
>
> Fix a warning (treated as error in W=1):
>
> CC arch/powerpc/kernel/traps.o
> arch/powerpc/kernel/traps.c:1498:6: error: no previous prototype for ‘slb_miss_bad_addr’ [-Werror=missing-prototypes]
> void slb_miss_bad_addr(struct pt_regs *regs)
> ^~~~~~~~~~~~~~~~~
> cc1: all warnings being treated as errors
>
> Signed-off-by: Mathieu Malaterre <malat@debian.org>
Applied to powerpc next, thanks.
https://git.kernel.org/powerpc/c/45b4d27a3897d6094bcf84bc877439
cheers
^ permalink raw reply
* Re: [07/21] powerpc: Make functions flipper_pic_init & ug_udbg_putc static
From: Michael Ellerman @ 2018-03-14 9:27 UTC (permalink / raw)
To: Mathieu Malaterre
Cc: Mathieu Malaterre, linux-kernel, Paul Mackerras, Jiri Slaby,
linuxppc-dev
In-Reply-To: <20180225172236.29650-8-malat@debian.org>
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain, Size: 997 bytes --]
On Sun, 2018-02-25 at 17:22:22 UTC, Mathieu Malaterre wrote:
> Change signature of two functions, adding static keyword to prevent the
> following two warnings (treated as errors on W=1):
>
> CC kernel/sys.o
> arch/powerpc/platforms/embedded6xx/flipper-pic.c:135:28: error: no previous prototype for ‘flipper_pic_init’ [-Werror=missing-prototypes]
> struct irq_domain * __init flipper_pic_init(struct device_node *np)
> ^~~~~~~~~~~~~~~~
> cc1: all warnings being treated as errors
>
> and
>
> CC arch/powerpc/platforms/embedded6xx/usbgecko_udbg.o
> arch/powerpc/platforms/embedded6xx/usbgecko_udbg.c:172:6: error: no previous prototype for ‘ug_udbg_putc’ [-Werror=missing-prototypes]
> void ug_udbg_putc(char ch)
> ^~~~~~~~~~~~
> cc1: all warnings being treated as errors
>
> Signed-off-by: Mathieu Malaterre <malat@debian.org>
Applied to powerpc next, thanks.
https://git.kernel.org/powerpc/c/8b51e679a54e808bdf1f2cc6552cf2
cheers
^ permalink raw reply
page: next (older) | prev (newer) | latest
- recent:[subjects (threaded)|topics (new)|topics (active)]
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox