* [PATCH kernel] KVM: PPC: Expose userspace mm context id via debugfs
From: Alexey Kardashevskiy @ 2018-07-12 7:30 UTC (permalink / raw)
To: linuxppc-dev; +Cc: Alexey Kardashevskiy, kvm-ppc, Paul Mackerras
This adds a debugfs entry with mm context id of a process which is using
KVM. This id is an index in the process table so the userspace can dump
that tree provided it is granted access to /dev/mem.
Signed-off-by: Alexey Kardashevskiy <aik@ozlabs.ru>
---
arch/powerpc/include/asm/kvm_host.h | 1 +
arch/powerpc/kvm/book3s_64_mmu_hv.c | 58 +++++++++++++++++++++++++++++++++++++
2 files changed, 59 insertions(+)
diff --git a/arch/powerpc/include/asm/kvm_host.h b/arch/powerpc/include/asm/kvm_host.h
index fa4efa7..bb72667 100644
--- a/arch/powerpc/include/asm/kvm_host.h
+++ b/arch/powerpc/include/asm/kvm_host.h
@@ -284,6 +284,7 @@ struct kvm_arch {
u64 process_table;
struct dentry *debugfs_dir;
struct dentry *htab_dentry;
+ struct dentry *mm_ctxid_dentry;
struct kvm_resize_hpt *resize_hpt; /* protected by kvm->lock */
#endif /* CONFIG_KVM_BOOK3S_HV_POSSIBLE */
#ifdef CONFIG_KVM_BOOK3S_PR_POSSIBLE
diff --git a/arch/powerpc/kvm/book3s_64_mmu_hv.c b/arch/powerpc/kvm/book3s_64_mmu_hv.c
index 7f3a8cf..3b9eb17 100644
--- a/arch/powerpc/kvm/book3s_64_mmu_hv.c
+++ b/arch/powerpc/kvm/book3s_64_mmu_hv.c
@@ -2138,11 +2138,69 @@ static const struct file_operations debugfs_htab_fops = {
.llseek = generic_file_llseek,
};
+static int debugfs_mm_ctxid_open(struct inode *inode, struct file *file)
+{
+ struct kvm *kvm = inode->i_private;
+
+ kvm_get_kvm(kvm);
+ file->private_data = kvm;
+
+ return nonseekable_open(inode, file);
+}
+
+static int debugfs_mm_ctxid_release(struct inode *inode, struct file *file)
+{
+ struct kvm *kvm = file->private_data;
+
+ kvm_put_kvm(kvm);
+ return 0;
+}
+
+static ssize_t debugfs_mm_ctxid_read(struct file *file, char __user *buf,
+ size_t len, loff_t *ppos)
+{
+ struct kvm *kvm = file->private_data;
+ ssize_t n, left, ret;
+ char tmp[64];
+
+ if (!kvm_is_radix(kvm))
+ return 0;
+
+ ret = snprintf(tmp, sizeof(tmp) - 1, "%lu\n", kvm->mm->context.id);
+ if (*ppos >= ret)
+ return 0;
+
+ left = min_t(ssize_t, ret - *ppos, len);
+ n = copy_to_user(buf, tmp + *ppos, left);
+ ret = left - n;
+ *ppos += ret;
+
+ return ret;
+}
+
+static ssize_t debugfs_mm_ctxid_write(struct file *file, const char __user *buf,
+ size_t len, loff_t *ppos)
+{
+ return -EACCES;
+}
+
+static const struct file_operations debugfs_mm_ctxid_fops = {
+ .owner = THIS_MODULE,
+ .open = debugfs_mm_ctxid_open,
+ .release = debugfs_mm_ctxid_release,
+ .read = debugfs_mm_ctxid_read,
+ .write = debugfs_mm_ctxid_write,
+ .llseek = generic_file_llseek,
+};
+
void kvmppc_mmu_debugfs_init(struct kvm *kvm)
{
kvm->arch.htab_dentry = debugfs_create_file("htab", 0400,
kvm->arch.debugfs_dir, kvm,
&debugfs_htab_fops);
+ kvm->arch.mm_ctxid_dentry = debugfs_create_file("mm_ctxid", 0400,
+ kvm->arch.debugfs_dir, kvm,
+ &debugfs_mm_ctxid_fops);
}
void kvmppc_mmu_book3s_hv_init(struct kvm_vcpu *vcpu)
--
2.11.0
^ permalink raw reply related
* Re: [PATCH 1/2] mm/cma: remove unsupported gfp_mask parameter from cma_alloc()
From: Christoph Hellwig @ 2018-07-12 7:15 UTC (permalink / raw)
To: Joonsoo Kim
Cc: Michal Hocko, Marek Szyprowski, Linux Memory Management List,
LKML, linux-arm-kernel, linuxppc-dev, iommu, Andrew Morton,
Michal Nazarewicz, Joonsoo Kim, Vlastimil Babka,
Christoph Hellwig, Russell King, Catalin Marinas, Will Deacon,
Paul Mackerras, Benjamin Herrenschmidt, Chris Zankel,
Martin Schwidefsky, Joerg Roedel, Sumit Semwal, Robin Murphy,
Laura Abbott, linaro-mm-sig
In-Reply-To: <CAAmzW4M3KADCZD9+B2h7=WsYksGtg-GzYRCJjbqK5Scceynrrg@mail.gmail.com>
On Thu, Jul 12, 2018 at 11:48:47AM +0900, Joonsoo Kim wrote:
> One of existing user is general DMA layer and it takes gfp flags that is
> provided by user. I don't check all the DMA allocation sites but how do
> you convince that none of them try to use anything other
> than GFP_KERNEL [|__GFP_NOWARN]?
They use a few others things still like __GFP_COMP, __GPF_DMA or
GFP_HUGEPAGE. But all these are bogus as we have various implementations
that can't respect them. I plan to get rid of the gfp_t argument
in the dma_map_ops alloc method in a few merge windows because of that,
but it needs further implementation consolidation first.
^ permalink raw reply
* Re: Boot failures with "mm/sparse: Remove CONFIG_SPARSEMEM_ALLOC_MEM_MAP_TOGETHER" on powerpc (was Re: mmotm 2018-07-10-16-50 uploaded)
From: Stephen Rothwell @ 2018-07-12 6:55 UTC (permalink / raw)
To: Andrew Morton
Cc: Pavel Tatashin, osalvador, mpe, broonie, mhocko, linux-next,
linux-fsdevel, Linux Memory Management List, LKML, mm-commits,
linuxppc-dev, bhe, aneesh.kumar, khandual
In-Reply-To: <20180712094729.1112f290@canb.auug.org.au>
[-- Attachment #1: Type: text/plain, Size: 500 bytes --]
Hi all,
On Thu, 12 Jul 2018 09:47:29 +1000 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> On Wed, 11 Jul 2018 14:13:44 -0700 Andrew Morton <akpm@linux-foundation.org> wrote:
> >
> > OK, I shall drop
> > mm-sparse-remove-config_sparsemem_alloc_mem_map_together.patch for now.
>
> I have dropped it from linux-next today (in case you don't get time).
I am certain I did drop it, but some how it is still in there :-(
I will drop it for tomorrow.
--
Cheers,
Stephen Rothwell
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply
* Re: Several suspected memory leaks
From: Michael Ellerman @ 2018-07-12 6:54 UTC (permalink / raw)
To: Paul Menzel; +Cc: linuxppc-dev, linux-kernel
In-Reply-To: <877em1alut.fsf@concordia.ellerman.id.au>
Michael Ellerman <mpe@ellerman.id.au> writes:
> Hi Paul,
>
> Paul Menzel <pmenzel@molgen.mpg.de> writes:
>> Dear Liunx folks,
>>
>> On a the IBM S822LC (8335-GTA) with Ubuntu 18.04 I built Linux master
>> =E2=80=93 4.18-rc4+, commit 092150a2 (Merge branch 'for-linus'
>> of git://git.kernel.org/pub/scm/linux/kernel/git/jikos/hid) =E2=80=93 wi=
th
>> kmemleak. Several issues are found.
>
> Is this the first time you've tested it?
> Or did these warnings only show up recently?
>
>> ```
>> $ grep KMEMLEAK /boot/config-4.18.0-rc4+
>> CONFIG_HAVE_DEBUG_KMEMLEAK=3Dy
>> CONFIG_DEBUG_KMEMLEAK=3Dy
>> CONFIG_DEBUG_KMEMLEAK_EARLY_LOG_SIZE=3D10000
>> # CONFIG_DEBUG_KMEMLEAK_TEST is not set
>> # CONFIG_DEBUG_KMEMLEAK_DEFAULT_OFF is not set
>
>
> I'm not seeing any warnings on my machine here, maybe it's something
> config related. Can you send your full .config ?
Scratch that. I just didn't wait long enough.
cheers
^ permalink raw reply
* Re: [PATCH] [RESEND] powerpc: xmon: use ktime_get_coarse_boottime64
From: Michael Ellerman @ 2018-07-12 6:28 UTC (permalink / raw)
To: Arnd Bergmann, Benjamin Herrenschmidt, Paul Mackerras
Cc: y2038, Arnd Bergmann, Balbir Singh, Nicholas Piggin, Vaibhav Jain,
Breno Leitao, Mathieu Malaterre, Yisheng Xie, linuxppc-dev,
linux-kernel
In-Reply-To: <20180711125338.1365368-1-arnd@arndb.de>
Arnd Bergmann <arnd@arndb.de> writes:
> get_monotonic_boottime() is deprecated, and may not be safe to call in
> every context, as it has to read a hardware clocksource.
>
> This changes xmon to print the time using ktime_get_coarse_boottime64()
> instead, which avoids the old timespec type and the HW access.
>
> Acked-by: Balbir Singh <bsingharora@gmail.com>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
> Originally sent Jun 18, but this hasn't appeared in linux-next yet.
>
> Resending to make sure this is still on the radar. Please apply
> to the powerpc git for 4.19
I had applied it but forgot to push.
Should be there today.
cheers
^ permalink raw reply
* Re: [PATCH] powerpc: Replaced msleep(x) with msleep(OPAL_BUSY_DELAY_MS)
From: Michael Ellerman @ 2018-07-12 5:46 UTC (permalink / raw)
To: Daniel Klamt, benh
Cc: paulus, linuxppc-dev, linux-kernel, linux-kernel, Daniel Klamt,
Bjoern Noetel
In-Reply-To: <1531346584-9157-1-git-send-email-eleon@ele0n.de>
Daniel Klamt <eleon@ele0n.de> writes:
> Replaced msleep(x) with with msleep(OPAL_BUSY_DELAY_MS)
> to diocument these sleep is to wait for opal.
>
> Signed-off-by: Daniel Klamt <eleon@ele0n.de>
> Signed-off-by: Bjoern Noetel <bjoern@br3ak3r.de>
Thanks.
Your change log should be in the imperative mood, see:
https://git.kernel.org/pub/scm/git/git.git/tree/Documentation/SubmittingPatches?id=HEAD#n133
In this case that just means saying "Replace" rather than "Replaced".
Also the prefix should be "powerpc/xive". You can guess that by doing:
$ git log --oneline arch/powerpc/sysdev/xive/native.c
And notice that the majority of commits use that prefix.
I've fixed both of those things up for you.
cheers
^ permalink raw reply
* Re: Boot failures with "mm/sparse: Remove CONFIG_SPARSEMEM_ALLOC_MEM_MAP_TOGETHER" on powerpc (was Re: mmotm 2018-07-10-16-50 uploaded)
From: Michael Ellerman @ 2018-07-12 5:24 UTC (permalink / raw)
To: Oscar Salvador, Pavel Tatashin
Cc: Andrew Morton, broonie, mhocko, Stephen Rothwell, linux-next,
linux-fsdevel, Linux Memory Management List, LKML, mm-commits,
linuxppc-dev, bhe, aneesh.kumar, khandual
In-Reply-To: <CAOXBz7ixEK85S-029XrM4+g4fxtSY6_tke0gcQ-hOXFCb7wcZg@mail.gmail.com>
Oscar Salvador <osalvador.vilardaga@gmail.com> writes:
> El dc., 11 jul. 2018 , 15:56, Pavel Tatashin <pasha.tatashin@oracle.com> va
> escriure:
>
>> I am OK, if this patch is removed from Baoquan's series. But, I would
>> still like to get rid of CONFIG_SPARSEMEM_ALLOC_MEM_MAP_TOGETHER, I
>> can work on this in my sparse_init re-write series. ppc64 should
>> really fallback safely to small chunks allocs, and if it does not
>> there is some existing bug. Michael please send the config that you
>> used.
>>
>> Thank you,
>> Pavel
>> On Wed, Jul 11, 2018 at 9:37 AM Oscar Salvador
>> <osalvador@techadventures.net> wrote:
>> >
>> > On Wed, Jul 11, 2018 at 10:49:58PM +1000, Michael Ellerman wrote:
>> > > akpm@linux-foundation.org writes:
>> > > > The mm-of-the-moment snapshot 2018-07-10-16-50 has been uploaded to
>> > > >
>> > > > http://www.ozlabs.org/~akpm/mmotm/
>> > > ...
>> > >
>> > > > * mm-sparse-add-a-static-variable-nr_present_sections.patch
>> > > > * mm-sparsemem-defer-the-ms-section_mem_map-clearing.patch
>> > > > * mm-sparsemem-defer-the-ms-section_mem_map-clearing-fix.patch
>> > > > *
>> mm-sparse-add-a-new-parameter-data_unit_size-for-alloc_usemap_and_memmap.patch
>> > > > * mm-sparse-optimize-memmap-allocation-during-sparse_init.patch
>> > > > *
>> mm-sparse-optimize-memmap-allocation-during-sparse_init-checkpatch-fixes.patch
>> > >
>> > > > * mm-sparse-remove-config_sparsemem_alloc_mem_map_together.patch
>> > >
>> > > This seems to be breaking my powerpc pseries qemu boots.
>> > >
>> > > The boot log with some extra debug shows eg:
>> > >
>> > > $ make pseries_le_defconfig
>> >
>> > Could you please share the config?
>> > I was not able to find such config in the kernel tree.
>>
>>
> I just roughly check, but if I checked the right place,
> vmemmap_populated() checks for the section to contain the flags we are
> setting in sparse_init_one_section().
Yes.
> But with this patch, we populate first everything, and then we call
> sparse_init_one_section() in sparse_init().
> As I said I could be mistaken because I just checked the surface.
Yeah I think that's correct.
This might just be a bug in our code, let me look at it a bit.
cheers
^ permalink raw reply
* Re: [PATCH kernel] powerpc/powernv/ioda2: Add 256M IOMMU page size to the default POWER8 case
From: Alexey Kardashevskiy @ 2018-07-12 5:12 UTC (permalink / raw)
To: linuxppc-dev; +Cc: Russell Currey, linux-kernel
In-Reply-To: <20180702074205.12837-1-aik@ozlabs.ru>
On Mon, 2 Jul 2018 17:42:05 +1000
Alexey Kardashevskiy <aik@ozlabs.ru> wrote:
> The sketchy bypass uses 256M pages so add this page size as well.
>
> This should cause no behavioral change but will be used later.
>
> Fixes: 477afd6ea6 "powerpc/ioda: Use ibm,supported-tce-sizes for IOMMU page size mask"
> Signed-off-by: Alexey Kardashevskiy <aik@ozlabs.ru>
> ---
> arch/powerpc/platforms/powernv/pci-ioda.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/powerpc/platforms/powernv/pci-ioda.c b/arch/powerpc/platforms/powernv/pci-ioda.c
> index 5bd0eb6..557c11d 100644
> --- a/arch/powerpc/platforms/powernv/pci-ioda.c
> +++ b/arch/powerpc/platforms/powernv/pci-ioda.c
> @@ -2925,7 +2925,7 @@ static unsigned long pnv_ioda_parse_tce_sizes(struct pnv_phb *phb)
> /* Add 16M for POWER8 by default */
> if (cpu_has_feature(CPU_FTR_ARCH_207S) &&
> !cpu_has_feature(CPU_FTR_ARCH_300))
> - mask |= SZ_16M;
> + mask |= SZ_16M | SZ_256M;
Ping?
> return mask;
> }
>
> --
> 2.11.0
>
--
Alexey
^ permalink raw reply
* Re: Boot failures with "mm/sparse: Remove CONFIG_SPARSEMEM_ALLOC_MEM_MAP_TOGETHER" on powerpc (was Re: mmotm 2018-07-10-16-50 uploaded)
From: Michael Ellerman @ 2018-07-12 4:36 UTC (permalink / raw)
To: Oscar Salvador
Cc: akpm, broonie, mhocko, sfr, linux-next, linux-fsdevel, linux-mm,
linux-kernel, mm-commits, linuxppc-dev, bhe, pasha.tatashin,
Aneesh Kumar K.V, Anshuman Khandual
In-Reply-To: <20180711133737.GA29573@techadventures.net>
Oscar Salvador <osalvador@techadventures.net> writes:
> On Wed, Jul 11, 2018 at 10:49:58PM +1000, Michael Ellerman wrote:
>> akpm@linux-foundation.org writes:
>> > The mm-of-the-moment snapshot 2018-07-10-16-50 has been uploaded to
>> >
>> > http://www.ozlabs.org/~akpm/mmotm/
>> ...
>>
>> > * mm-sparse-add-a-static-variable-nr_present_sections.patch
>> > * mm-sparsemem-defer-the-ms-section_mem_map-clearing.patch
>> > * mm-sparsemem-defer-the-ms-section_mem_map-clearing-fix.patch
>> > * mm-sparse-add-a-new-parameter-data_unit_size-for-alloc_usemap_and_memmap.patch
>> > * mm-sparse-optimize-memmap-allocation-during-sparse_init.patch
>> > * mm-sparse-optimize-memmap-allocation-during-sparse_init-checkpatch-fixes.patch
>>
>> > * mm-sparse-remove-config_sparsemem_alloc_mem_map_together.patch
>>
>> This seems to be breaking my powerpc pseries qemu boots.
>>
>> The boot log with some extra debug shows eg:
>>
>> $ make pseries_le_defconfig
>
> Could you please share the config?
> I was not able to find such config in the kernel tree.
It's a generated config, see:
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/arch/powerpc/Makefile?commit=021c91791a5e7e85c567452f1be3e4c2c6cb6063#n315
It's based on pseries_defconfig, which is an actual file in the tree,
but with the endian flipped.
You can see the generated result from a recent build here:
http://kisskb.ellerman.id.au/kisskb/buildresult/13428803/config/
cheers
^ permalink raw reply
* Re: Boot failures with "mm/sparse: Remove CONFIG_SPARSEMEM_ALLOC_MEM_MAP_TOGETHER" on powerpc (was Re: mmotm 2018-07-10-16-50 uploaded)
From: Michael Ellerman @ 2018-07-12 4:29 UTC (permalink / raw)
To: Baoquan He
Cc: akpm, broonie, mhocko, sfr, linux-next, linux-fsdevel, linux-mm,
linux-kernel, mm-commits, linuxppc-dev, pasha.tatashin,
Aneesh Kumar K.V, Anshuman Khandual
In-Reply-To: <20180711131225.GI1969@MiWiFi-R3L-srv>
Baoquan He <bhe@redhat.com> writes:
> On 07/11/18 at 10:49pm, Michael Ellerman wrote:
>> akpm@linux-foundation.org writes:
>> > The mm-of-the-moment snapshot 2018-07-10-16-50 has been uploaded to
>> >
>> > http://www.ozlabs.org/~akpm/mmotm/
>> ...
>>
>> > * mm-sparse-add-a-static-variable-nr_present_sections.patch
>> > * mm-sparsemem-defer-the-ms-section_mem_map-clearing.patch
>> > * mm-sparsemem-defer-the-ms-section_mem_map-clearing-fix.patch
>> > * mm-sparse-add-a-new-parameter-data_unit_size-for-alloc_usemap_and_memmap.patch
>> > * mm-sparse-optimize-memmap-allocation-during-sparse_init.patch
>> > * mm-sparse-optimize-memmap-allocation-during-sparse_init-checkpatch-fixes.patch
>>
>> > * mm-sparse-remove-config_sparsemem_alloc_mem_map_together.patch
>>
>> This seems to be breaking my powerpc pseries qemu boots.
...
>
> Have you tried reverting that patch and building kernel to test again?
> Does it work?
Yes.
Reverting that patch on top of 98be45067040799a801e6ce52d8bf4659a153893
works as before.
cheers
^ permalink raw reply
* Re: [PATCH 1/2] mm/cma: remove unsupported gfp_mask parameter from cma_alloc()
From: Joonsoo Kim @ 2018-07-12 2:48 UTC (permalink / raw)
To: Michal Hocko
Cc: Marek Szyprowski, Linux Memory Management List, LKML,
linux-arm-kernel, linuxppc-dev, iommu, Andrew Morton,
Michal Nazarewicz, Joonsoo Kim, Vlastimil Babka,
Christoph Hellwig, Russell King, Catalin Marinas, Will Deacon,
Paul Mackerras, Benjamin Herrenschmidt, Chris Zankel,
Martin Schwidefsky, Joerg Roedel, Sumit Semwal, Robin Murphy,
Laura Abbott, linaro-mm-sig
In-Reply-To: <20180711085407.GB20050@dhcp22.suse.cz>
2018-07-11 17:54 GMT+09:00 Michal Hocko <mhocko@kernel.org>:
> On Wed 11-07-18 16:35:28, Joonsoo Kim wrote:
>> 2018-07-10 18:50 GMT+09:00 Michal Hocko <mhocko@kernel.org>:
>> > On Tue 10-07-18 16:19:32, Joonsoo Kim wrote:
>> >> Hello, Marek.
>> >>
>> >> 2018-07-09 21:19 GMT+09:00 Marek Szyprowski <m.szyprowski@samsung.com>:
>> >> > cma_alloc() function doesn't really support gfp flags other than
>> >> > __GFP_NOWARN, so convert gfp_mask parameter to boolean no_warn parameter.
>> >>
>> >> Although gfp_mask isn't used in cma_alloc() except no_warn, it can be used
>> >> in alloc_contig_range(). For example, if passed gfp mask has no __GFP_FS,
>> >> compaction(isolation) would work differently. Do you have considered
>> >> such a case?
>> >
>> > Does any of cma_alloc users actually care about GFP_NO{FS,IO}?
>>
>> I don't know. My guess is that cma_alloc() is used for DMA allocation so
>> block device would use it, too. If fs/block subsystem initiates the
>> request for the device,
>> it would be possible that cma_alloc() is called with such a flag.
>> Again, I don't know
>> much about those subsystem so I would be wrong.
>
> The patch converts existing users and none of them really tries to use
> anything other than GFP_KERNEL [|__GFP_NOWARN] so this doesn't seem to
> be the case. Should there be a new user requiring more restricted
> gfp_mask we should carefuly re-evaluate and think how to support it.
One of existing user is general DMA layer and it takes gfp flags that is
provided by user. I don't check all the DMA allocation sites but how do
you convince that none of them try to use anything other
than GFP_KERNEL [|__GFP_NOWARN]?
Thanks.
^ permalink raw reply
* Re: [PATCH 2/3] selftests/powerpc: Remove Power9 paste tests
From: Michael Neuling @ 2018-07-12 2:00 UTC (permalink / raw)
To: Michael Ellerman, linuxppc-dev; +Cc: chris
In-Reply-To: <20180711071017.5128-2-mpe@ellerman.id.au>
On Wed, 2018-07-11 at 17:10 +1000, Michael Ellerman wrote:
> Paste on POWER9 only works to accelerators and not on real memory. So
> these tests just generate a SIGILL.
>=20
> So just delete them.
>=20
> Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
Acked-by: Michael Neuling <mikey@neuling.org>
^ permalink raw reply
* Re: [PATCH 1/3] selftests/powerpc: Remove Power9 copy_unaligned test
From: Michael Neuling @ 2018-07-12 2:00 UTC (permalink / raw)
To: Michael Ellerman, linuxppc-dev; +Cc: chris
In-Reply-To: <20180711071017.5128-1-mpe@ellerman.id.au>
On Wed, 2018-07-11 at 17:10 +1000, Michael Ellerman wrote:
> This is a test of the ISA 3.0 "copy" instruction. That instruction has
> an L field, which if set to 1 specifies that "the instruction
> identifies the beginning of a move group" (pp 858). That's also
> referred to as "copy first" vs "copy".
>=20
> In ISA 3.0B the copy instruction does not have an L field, and the
> corresponding bit in the instruction must be set to 1.
>=20
> This test is generating a "copy" instruction, not a "copy first", and
> so on Power9 (which implements 3.0B), this results in an illegal
> instruction.
>=20
> So just drop the test entirely. We still have copy_first_unaligned to
> test the "copy first" behaviour.
>=20
> Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
Acked-by: Michael Neuling <mikey@neuling.org>
^ permalink raw reply
* Re: [PATCH kernel] powerpc/ioda/npu2: Call hot reset skiboot hook when disabling NPU
From: Alistair Popple @ 2018-07-12 1:38 UTC (permalink / raw)
To: Alexey Kardashevskiy
Cc: linuxppc-dev, Benjamin Herrenschmidt, Russell Currey,
Balbir Singh, Stewart Smith
In-Reply-To: <20180711194510.0bc8dc39@aik.ozlabs.ibm.com>
Hi Alexey,
On Wednesday, 11 July 2018 7:45:10 PM AEST Alexey Kardashevskiy wrote:
> On Thu, 7 Jun 2018 17:06:07 +1000
> Alexey Kardashevskiy <aik@ozlabs.ru> wrote:
>
> > This brings NPU2 in a safe mode when it does not throw HMI if GPU
> > coherent memory is gone.
It might be helpful if you you could describe the problem and what you are
trying to solve in a bit more depth. Assuming the memory was online how are you
offlining it? If the memory has been online merely fencing/hot-resetting the
NVLink is likely not sufficient as you also need to flush caches prior to taking
the links down.
- Alistair
> > Signed-off-by: Alexey Kardashevskiy <aik@ozlabs.ru>
>
>
> Anyone, ping?
>
>
> > ---
> >
> > The main aim for this is nvlink2 pass through, helps a lot.
> >
> >
> > ---
> > arch/powerpc/platforms/powernv/pci-ioda.c | 11 +++++++++++
> > 1 file changed, 11 insertions(+)
> >
> > diff --git a/arch/powerpc/platforms/powernv/pci-ioda.c b/arch/powerpc/platforms/powernv/pci-ioda.c
> > index 66c2804..29f798c 100644
> > --- a/arch/powerpc/platforms/powernv/pci-ioda.c
> > +++ b/arch/powerpc/platforms/powernv/pci-ioda.c
> > @@ -3797,6 +3797,16 @@ static void pnv_pci_release_device(struct pci_dev *pdev)
> > pnv_ioda_release_pe(pe);
> > }
> >
> > +void pnv_npu_disable_device(struct pci_dev *pdev)
> > +{
> > + struct eeh_dev *edev = pci_dev_to_eeh_dev(pdev);
> > + struct eeh_pe *eehpe = edev ? edev->pe : NULL;
> > +
> > + if (eehpe && eeh_ops && eeh_ops->reset) {
> > + eeh_ops->reset(eehpe, EEH_RESET_HOT);
> > + }
> > +}
> > +
> > static void pnv_pci_ioda_shutdown(struct pci_controller *hose)
> > {
> > struct pnv_phb *phb = hose->private_data;
> > @@ -3841,6 +3851,7 @@ static const struct pci_controller_ops pnv_npu_ioda_controller_ops = {
> > .reset_secondary_bus = pnv_pci_reset_secondary_bus,
> > .dma_set_mask = pnv_npu_dma_set_mask,
> > .shutdown = pnv_pci_ioda_shutdown,
> > + .disable_device = pnv_npu_disable_device,
> > };
> >
> > static const struct pci_controller_ops pnv_npu_ocapi_ioda_controller_ops = {
>
>
>
> --
> Alexey
>
^ permalink raw reply
* Re: Boot failures with "mm/sparse: Remove CONFIG_SPARSEMEM_ALLOC_MEM_MAP_TOGETHER" on powerpc (was Re: mmotm 2018-07-10-16-50 uploaded)
From: Stephen Rothwell @ 2018-07-11 23:47 UTC (permalink / raw)
To: Andrew Morton
Cc: Pavel Tatashin, osalvador, mpe, broonie, mhocko, linux-next,
linux-fsdevel, Linux Memory Management List, LKML, mm-commits,
linuxppc-dev, bhe, aneesh.kumar, khandual
In-Reply-To: <20180711141344.10eb6d22b0ee1423cc94faf8@linux-foundation.org>
[-- Attachment #1: Type: text/plain, Size: 304 bytes --]
Hi Andrew,
On Wed, 11 Jul 2018 14:13:44 -0700 Andrew Morton <akpm@linux-foundation.org> wrote:
>
> OK, I shall drop
> mm-sparse-remove-config_sparsemem_alloc_mem_map_together.patch for now.
I have dropped it from linux-next today (in case you don't get time).
--
Cheers,
Stephen Rothwell
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply
* [PATCH] powerpc: Replaced msleep(x) with msleep(OPAL_BUSY_DELAY_MS)
From: Daniel Klamt @ 2018-07-11 22:03 UTC (permalink / raw)
To: benh
Cc: paulus, mpe, linuxppc-dev, linux-kernel, linux-kernel,
Daniel Klamt, Bjoern Noetel
In-Reply-To: <878t6hami4.fsf@concordia.ellerman.id.au>
Replaced msleep(x) with with msleep(OPAL_BUSY_DELAY_MS)
to diocument these sleep is to wait for opal.
Signed-off-by: Daniel Klamt <eleon@ele0n.de>
Signed-off-by: Bjoern Noetel <bjoern@br3ak3r.de>
---
arch/powerpc/sysdev/xive/native.c | 24 ++++++++++++------------
1 file changed, 12 insertions(+), 12 deletions(-)
diff --git a/arch/powerpc/sysdev/xive/native.c b/arch/powerpc/sysdev/xive/native.c
index 311185b9960a..39ab5ad58297 100644
--- a/arch/powerpc/sysdev/xive/native.c
+++ b/arch/powerpc/sysdev/xive/native.c
@@ -109,7 +109,7 @@ int xive_native_configure_irq(u32 hw_irq, u32 target, u8 prio, u32 sw_irq)
rc = opal_xive_set_irq_config(hw_irq, target, prio, sw_irq);
if (rc != OPAL_BUSY)
break;
- msleep(1);
+ msleep(OPAL_BUSY_DELAY_MS);
}
return rc == 0 ? 0 : -ENXIO;
}
@@ -163,7 +163,7 @@ int xive_native_configure_queue(u32 vp_id, struct xive_q *q, u8 prio,
rc = opal_xive_set_queue_info(vp_id, prio, qpage_phys, order, flags);
if (rc != OPAL_BUSY)
break;
- msleep(1);
+ msleep(OPAL_BUSY_DELAY_MS);
}
if (rc) {
pr_err("Error %lld setting queue for prio %d\n", rc, prio);
@@ -190,7 +190,7 @@ static void __xive_native_disable_queue(u32 vp_id, struct xive_q *q, u8 prio)
rc = opal_xive_set_queue_info(vp_id, prio, 0, 0, 0);
if (rc != OPAL_BUSY)
break;
- msleep(1);
+ msleep(OPAL_BUSY_DELAY_MS);
}
if (rc)
pr_err("Error %lld disabling queue for prio %d\n", rc, prio);
@@ -253,7 +253,7 @@ static int xive_native_get_ipi(unsigned int cpu, struct xive_cpu *xc)
for (;;) {
irq = opal_xive_allocate_irq(chip_id);
if (irq == OPAL_BUSY) {
- msleep(1);
+ msleep(OPAL_BUSY_DELAY_MS);
continue;
}
if (irq < 0) {
@@ -275,7 +275,7 @@ u32 xive_native_alloc_irq(void)
rc = opal_xive_allocate_irq(OPAL_XIVE_ANY_CHIP);
if (rc != OPAL_BUSY)
break;
- msleep(1);
+ msleep(OPAL_BUSY_DELAY_MS);
}
if (rc < 0)
return 0;
@@ -289,7 +289,7 @@ void xive_native_free_irq(u32 irq)
s64 rc = opal_xive_free_irq(irq);
if (rc != OPAL_BUSY)
break;
- msleep(1);
+ msleep(OPAL_BUSY_DELAY_MS);
}
}
EXPORT_SYMBOL_GPL(xive_native_free_irq);
@@ -305,7 +305,7 @@ static void xive_native_put_ipi(unsigned int cpu, struct xive_cpu *xc)
for (;;) {
rc = opal_xive_free_irq(xc->hw_ipi);
if (rc == OPAL_BUSY) {
- msleep(1);
+ msleep(OPAL_BUSY_DELAY_MS);
continue;
}
xc->hw_ipi = 0;
@@ -400,7 +400,7 @@ static void xive_native_setup_cpu(unsigned int cpu, struct xive_cpu *xc)
rc = opal_xive_set_vp_info(vp, OPAL_XIVE_VP_ENABLED, 0);
if (rc != OPAL_BUSY)
break;
- msleep(1);
+ msleep(OPAL_BUSY_DELAY_MS);
}
if (rc) {
pr_err("Failed to enable pool VP on CPU %d\n", cpu);
@@ -444,7 +444,7 @@ static void xive_native_teardown_cpu(unsigned int cpu, struct xive_cpu *xc)
rc = opal_xive_set_vp_info(vp, 0, 0);
if (rc != OPAL_BUSY)
break;
- msleep(1);
+ msleep(OPAL_BUSY_DELAY_MS);
}
}
@@ -645,7 +645,7 @@ u32 xive_native_alloc_vp_block(u32 max_vcpus)
rc = opal_xive_alloc_vp_block(order);
switch (rc) {
case OPAL_BUSY:
- msleep(1);
+ msleep(OPAL_BUSY_DELAY_MS);
break;
case OPAL_XIVE_PROVISIONING:
if (!xive_native_provision_pages())
@@ -687,7 +687,7 @@ int xive_native_enable_vp(u32 vp_id, bool single_escalation)
rc = opal_xive_set_vp_info(vp_id, flags, 0);
if (rc != OPAL_BUSY)
break;
- msleep(1);
+ msleep(OPAL_BUSY_DELAY_MS);
}
return rc ? -EIO : 0;
}
@@ -701,7 +701,7 @@ int xive_native_disable_vp(u32 vp_id)
rc = opal_xive_set_vp_info(vp_id, 0, 0);
if (rc != OPAL_BUSY)
break;
- msleep(1);
+ msleep(OPAL_BUSY_DELAY_MS);
}
return rc ? -EIO : 0;
}
--
2.11.0
^ permalink raw reply related
* Re: Boot failures with "mm/sparse: Remove CONFIG_SPARSEMEM_ALLOC_MEM_MAP_TOGETHER" on powerpc (was Re: mmotm 2018-07-10-16-50 uploaded)
From: Andrew Morton @ 2018-07-11 21:13 UTC (permalink / raw)
To: Pavel Tatashin
Cc: osalvador, mpe, broonie, mhocko, Stephen Rothwell, linux-next,
linux-fsdevel, Linux Memory Management List, LKML, mm-commits,
linuxppc-dev, bhe, aneesh.kumar, khandual
In-Reply-To: <CAGM2reYsSi5kDGtnTQASnp1v49T8Y+9o_pNxmSq-+m68QhF2Tg@mail.gmail.com>
On Wed, 11 Jul 2018 09:55:59 -0400 Pavel Tatashin <pasha.tatashin@oracle.com> wrote:
> On Wed, Jul 11, 2018 at 9:37 AM Oscar Salvador
> <osalvador@techadventures.net> wrote:
> >
> > On Wed, Jul 11, 2018 at 10:49:58PM +1000, Michael Ellerman wrote:
> > > akpm@linux-foundation.org writes:
> > > > The mm-of-the-moment snapshot 2018-07-10-16-50 has been uploaded to
> > > >
> > > > http://www.ozlabs.org/~akpm/mmotm/
> > > ...
> > >
> > > > * mm-sparse-add-a-static-variable-nr_present_sections.patch
> > > > * mm-sparsemem-defer-the-ms-section_mem_map-clearing.patch
> > > > * mm-sparsemem-defer-the-ms-section_mem_map-clearing-fix.patch
> > > > * mm-sparse-add-a-new-parameter-data_unit_size-for-alloc_usemap_and_memmap.patch
> > > > * mm-sparse-optimize-memmap-allocation-during-sparse_init.patch
> > > > * mm-sparse-optimize-memmap-allocation-during-sparse_init-checkpatch-fixes.patch
> > >
> > > > * mm-sparse-remove-config_sparsemem_alloc_mem_map_together.patch
> > >
> > > This seems to be breaking my powerpc pseries qemu boots.
> > >
> > > The boot log with some extra debug shows eg:
> > >
> > > $ make pseries_le_defconfig
> >
> > Could you please share the config?
> > I was not able to find such config in the kernel tree.
(top-posting repaired so I can reply to your email, add other people
and not confuse the heck out of them. Please don't)
> I am OK, if this patch is removed from Baoquan's series. But, I would
> still like to get rid of CONFIG_SPARSEMEM_ALLOC_MEM_MAP_TOGETHER, I
> can work on this in my sparse_init re-write series. ppc64 should
> really fallback safely to small chunks allocs, and if it does not
> there is some existing bug. Michael please send the config that you
> used.
OK, I shall drop
mm-sparse-remove-config_sparsemem_alloc_mem_map_together.patch for now.
^ permalink raw reply
* Re: Boot failures with "mm/sparse: Remove CONFIG_SPARSEMEM_ALLOC_MEM_MAP_TOGETHER" on powerpc (was Re: mmotm 2018-07-10-16-50 uploaded)
From: Pavel Tatashin @ 2018-07-11 13:55 UTC (permalink / raw)
To: osalvador
Cc: mpe, Andrew Morton, broonie, mhocko, Stephen Rothwell, linux-next,
linux-fsdevel, Linux Memory Management List, LKML, mm-commits,
linuxppc-dev, bhe, aneesh.kumar, khandual
In-Reply-To: <20180711133737.GA29573@techadventures.net>
I am OK, if this patch is removed from Baoquan's series. But, I would
still like to get rid of CONFIG_SPARSEMEM_ALLOC_MEM_MAP_TOGETHER, I
can work on this in my sparse_init re-write series. ppc64 should
really fallback safely to small chunks allocs, and if it does not
there is some existing bug. Michael please send the config that you
used.
Thank you,
Pavel
On Wed, Jul 11, 2018 at 9:37 AM Oscar Salvador
<osalvador@techadventures.net> wrote:
>
> On Wed, Jul 11, 2018 at 10:49:58PM +1000, Michael Ellerman wrote:
> > akpm@linux-foundation.org writes:
> > > The mm-of-the-moment snapshot 2018-07-10-16-50 has been uploaded to
> > >
> > > http://www.ozlabs.org/~akpm/mmotm/
> > ...
> >
> > > * mm-sparse-add-a-static-variable-nr_present_sections.patch
> > > * mm-sparsemem-defer-the-ms-section_mem_map-clearing.patch
> > > * mm-sparsemem-defer-the-ms-section_mem_map-clearing-fix.patch
> > > * mm-sparse-add-a-new-parameter-data_unit_size-for-alloc_usemap_and_memmap.patch
> > > * mm-sparse-optimize-memmap-allocation-during-sparse_init.patch
> > > * mm-sparse-optimize-memmap-allocation-during-sparse_init-checkpatch-fixes.patch
> >
> > > * mm-sparse-remove-config_sparsemem_alloc_mem_map_together.patch
> >
> > This seems to be breaking my powerpc pseries qemu boots.
> >
> > The boot log with some extra debug shows eg:
> >
> > $ make pseries_le_defconfig
>
> Could you please share the config?
> I was not able to find such config in the kernel tree.
> --
> Oscar Salvador
> SUSE L3
>
^ permalink raw reply
* Re: [PATCH v11 00/26] Speculative page faults
From: Laurent Dufour @ 2018-07-11 17:05 UTC (permalink / raw)
To: Song, HaiyanX
Cc: akpm@linux-foundation.org, mhocko@kernel.org,
peterz@infradead.org, kirill@shutemov.name, ak@linux.intel.com,
dave@stgolabs.net, jack@suse.cz, Matthew Wilcox,
khandual@linux.vnet.ibm.com, aneesh.kumar@linux.vnet.ibm.com,
benh@kernel.crashing.org, mpe@ellerman.id.au, paulus@samba.org,
Thomas Gleixner, Ingo Molnar, hpa@zytor.com, Will Deacon,
Sergey Senozhatsky, sergey.senozhatsky.work@gmail.com,
Andrea Arcangeli, Alexei Starovoitov, Wang, Kemi, Daniel Jordan,
David Rientjes, Jerome Glisse, Ganesh Mahendran, Minchan Kim,
Punit Agrawal, vinayak menon, Yang Shi,
linux-kernel@vger.kernel.org, linux-mm@kvack.org,
haren@linux.vnet.ibm.com, npiggin@gmail.com,
bsingharora@gmail.com, paulmck@linux.vnet.ibm.com, Tim Chen,
linuxppc-dev@lists.ozlabs.org, x86@kernel.org
In-Reply-To: <a69cc75c-8252-246b-5583-04f6a7478ecd@linux.vnet.ibm.com>
Hi Haiyan,
Do you get a chance to capture some performance cycles on your system ?
I still can't get these numbers on my hardware.
Thanks,
Laurent.
On 04/07/2018 09:51, Laurent Dufour wrote:
> On 04/07/2018 05:23, Song, HaiyanX wrote:
>> Hi Laurent,
>>
>>
>> For the test result on Intel 4s skylake platform (192 CPUs, 768G Memory), the below test cases all were run 3 times.
>> I check the test results, only page_fault3_thread/enable THP have 6% stddev for head commit, other tests have lower stddev.
>
> Repeating the test only 3 times seems a bit too low to me.
>
> I'll focus on the higher change for the moment, but I don't have access to such
> a hardware.
>
> Is possible to provide a diff between base and SPF of the performance cycles
> measured when running page_fault3 and page_fault2 when the 20% change is detected.
>
> Please stay focus on the test case process to see exactly where the series is
> impacting.
>
> Thanks,
> Laurent.
>
>>
>> And I did not find other high variation on test case result.
>>
>> a). Enable THP
>> testcase base stddev change head stddev metric
>> page_fault3/enable THP 10519 ± 3% -20.5% 8368 ±6% will-it-scale.per_thread_ops
>> page_fault2/enalbe THP 8281 ± 2% -18.8% 6728 will-it-scale.per_thread_ops
>> brk1/eanble THP 998475 -2.2% 976893 will-it-scale.per_process_ops
>> context_switch1/enable THP 223910 -1.3% 220930 will-it-scale.per_process_ops
>> context_switch1/enable THP 233722 -1.0% 231288 will-it-scale.per_thread_ops
>>
>> b). Disable THP
>> page_fault3/disable THP 10856 -23.1% 8344 will-it-scale.per_thread_ops
>> page_fault2/disable THP 8147 -18.8% 6613 will-it-scale.per_thread_ops
>> brk1/disable THP 957 -7.9% 881 will-it-scale.per_thread_ops
>> context_switch1/disable THP 237006 -2.2% 231907 will-it-scale.per_thread_ops
>> brk1/disable THP 997317 -2.0% 977778 will-it-scale.per_process_ops
>> page_fault3/disable THP 467454 -1.8% 459251 will-it-scale.per_process_ops
>> context_switch1/disable THP 224431 -1.3% 221567 will-it-scale.per_process_ops
>>
>>
>> Best regards,
>> Haiyan Song
>> ________________________________________
>> From: Laurent Dufour [ldufour@linux.vnet.ibm.com]
>> Sent: Monday, July 02, 2018 4:59 PM
>> To: Song, HaiyanX
>> Cc: akpm@linux-foundation.org; mhocko@kernel.org; peterz@infradead.org; kirill@shutemov.name; ak@linux.intel.com; dave@stgolabs.net; jack@suse.cz; Matthew Wilcox; khandual@linux.vnet.ibm.com; aneesh.kumar@linux.vnet.ibm.com; benh@kernel.crashing.org; mpe@ellerman.id.au; paulus@samba.org; Thomas Gleixner; Ingo Molnar; hpa@zytor.com; Will Deacon; Sergey Senozhatsky; sergey.senozhatsky.work@gmail.com; Andrea Arcangeli; Alexei Starovoitov; Wang, Kemi; Daniel Jordan; David Rientjes; Jerome Glisse; Ganesh Mahendran; Minchan Kim; Punit Agrawal; vinayak menon; Yang Shi; linux-kernel@vger.kernel.org; linux-mm@kvack.org; haren@linux.vnet.ibm.com; npiggin@gmail.com; bsingharora@gmail.com; paulmck@linux.vnet.ibm.com; Tim Chen; linuxppc-dev@lists.ozlabs.org; x86@kernel.org
>> Subject: Re: [PATCH v11 00/26] Speculative page faults
>>
>> On 11/06/2018 09:49, Song, HaiyanX wrote:
>>> Hi Laurent,
>>>
>>> Regression test for v11 patch serials have been run, some regression is found by LKP-tools (linux kernel performance)
>>> tested on Intel 4s skylake platform. This time only test the cases which have been run and found regressions on
>>> V9 patch serials.
>>>
>>> The regression result is sorted by the metric will-it-scale.per_thread_ops.
>>> branch: Laurent-Dufour/Speculative-page-faults/20180520-045126
>>> commit id:
>>> head commit : a7a8993bfe3ccb54ad468b9f1799649e4ad1ff12
>>> base commit : ba98a1cdad71d259a194461b3a61471b49b14df1
>>> Benchmark: will-it-scale
>>> Download link: https://github.com/antonblanchard/will-it-scale/tree/master
>>>
>>> Metrics:
>>> will-it-scale.per_process_ops=processes/nr_cpu
>>> will-it-scale.per_thread_ops=threads/nr_cpu
>>> test box: lkp-skl-4sp1(nr_cpu=192,memory=768G)
>>> THP: enable / disable
>>> nr_task:100%
>>>
>>> 1. Regressions:
>>>
>>> a). Enable THP
>>> testcase base change head metric
>>> page_fault3/enable THP 10519 -20.5% 836 will-it-scale.per_thread_ops
>>> page_fault2/enalbe THP 8281 -18.8% 6728 will-it-scale.per_thread_ops
>>> brk1/eanble THP 998475 -2.2% 976893 will-it-scale.per_process_ops
>>> context_switch1/enable THP 223910 -1.3% 220930 will-it-scale.per_process_ops
>>> context_switch1/enable THP 233722 -1.0% 231288 will-it-scale.per_thread_ops
>>>
>>> b). Disable THP
>>> page_fault3/disable THP 10856 -23.1% 8344 will-it-scale.per_thread_ops
>>> page_fault2/disable THP 8147 -18.8% 6613 will-it-scale.per_thread_ops
>>> brk1/disable THP 957 -7.9% 881 will-it-scale.per_thread_ops
>>> context_switch1/disable THP 237006 -2.2% 231907 will-it-scale.per_thread_ops
>>> brk1/disable THP 997317 -2.0% 977778 will-it-scale.per_process_ops
>>> page_fault3/disable THP 467454 -1.8% 459251 will-it-scale.per_process_ops
>>> context_switch1/disable THP 224431 -1.3% 221567 will-it-scale.per_process_ops
>>>
>>> Notes: for the above values of test result, the higher is better.
>>
>> I tried the same tests on my PowerPC victim VM (1024 CPUs, 11TB) and I can't
>> get reproducible results. The results have huge variation, even on the vanilla
>> kernel, and I can't state on any changes due to that.
>>
>> I tried on smaller node (80 CPUs, 32G), and the tests ran better, but I didn't
>> measure any changes between the vanilla and the SPF patched ones:
>>
>> test THP enabled 4.17.0-rc4-mm1 spf delta
>> page_fault3_threads 2697.7 2683.5 -0.53%
>> page_fault2_threads 170660.6 169574.1 -0.64%
>> context_switch1_threads 6915269.2 6877507.3 -0.55%
>> context_switch1_processes 6478076.2 6529493.5 0.79%
>> brk1 243391.2 238527.5 -2.00%
>>
>> Tests were run 10 times, no high variation detected.
>>
>> Did you see high variation on your side ? How many times the test were run to
>> compute the average values ?
>>
>> Thanks,
>> Laurent.
>>
>>
>>>
>>> 2. Improvement: not found improvement based on the selected test cases.
>>>
>>>
>>> Best regards
>>> Haiyan Song
>>> ________________________________________
>>> From: owner-linux-mm@kvack.org [owner-linux-mm@kvack.org] on behalf of Laurent Dufour [ldufour@linux.vnet.ibm.com]
>>> Sent: Monday, May 28, 2018 4:54 PM
>>> To: Song, HaiyanX
>>> Cc: akpm@linux-foundation.org; mhocko@kernel.org; peterz@infradead.org; kirill@shutemov.name; ak@linux.intel.com; dave@stgolabs.net; jack@suse.cz; Matthew Wilcox; khandual@linux.vnet.ibm.com; aneesh.kumar@linux.vnet.ibm.com; benh@kernel.crashing.org; mpe@ellerman.id.au; paulus@samba.org; Thomas Gleixner; Ingo Molnar; hpa@zytor.com; Will Deacon; Sergey Senozhatsky; sergey.senozhatsky.work@gmail.com; Andrea Arcangeli; Alexei Starovoitov; Wang, Kemi; Daniel Jordan; David Rientjes; Jerome Glisse; Ganesh Mahendran; Minchan Kim; Punit Agrawal; vinayak menon; Yang Shi; linux-kernel@vger.kernel.org; linux-mm@kvack.org; haren@linux.vnet.ibm.com; npiggin@gmail.com; bsingharora@gmail.com; paulmck@linux.vnet.ibm.com; Tim Chen; linuxppc-dev@lists.ozlabs.org; x86@kernel.org
>>> Subject: Re: [PATCH v11 00/26] Speculative page faults
>>>
>>> On 28/05/2018 10:22, Haiyan Song wrote:
>>>> Hi Laurent,
>>>>
>>>> Yes, these tests are done on V9 patch.
>>>
>>> Do you plan to give this V11 a run ?
>>>
>>>>
>>>>
>>>> Best regards,
>>>> Haiyan Song
>>>>
>>>> On Mon, May 28, 2018 at 09:51:34AM +0200, Laurent Dufour wrote:
>>>>> On 28/05/2018 07:23, Song, HaiyanX wrote:
>>>>>>
>>>>>> Some regression and improvements is found by LKP-tools(linux kernel performance) on V9 patch series
>>>>>> tested on Intel 4s Skylake platform.
>>>>>
>>>>> Hi,
>>>>>
>>>>> Thanks for reporting this benchmark results, but you mentioned the "V9 patch
>>>>> series" while responding to the v11 header series...
>>>>> Were these tests done on v9 or v11 ?
>>>>>
>>>>> Cheers,
>>>>> Laurent.
>>>>>
>>>>>>
>>>>>> The regression result is sorted by the metric will-it-scale.per_thread_ops.
>>>>>> Branch: Laurent-Dufour/Speculative-page-faults/20180316-151833 (V9 patch series)
>>>>>> Commit id:
>>>>>> base commit: d55f34411b1b126429a823d06c3124c16283231f
>>>>>> head commit: 0355322b3577eeab7669066df42c550a56801110
>>>>>> Benchmark suite: will-it-scale
>>>>>> Download link:
>>>>>> https://github.com/antonblanchard/will-it-scale/tree/master/tests
>>>>>> Metrics:
>>>>>> will-it-scale.per_process_ops=processes/nr_cpu
>>>>>> will-it-scale.per_thread_ops=threads/nr_cpu
>>>>>> test box: lkp-skl-4sp1(nr_cpu=192,memory=768G)
>>>>>> THP: enable / disable
>>>>>> nr_task: 100%
>>>>>>
>>>>>> 1. Regressions:
>>>>>> a) THP enabled:
>>>>>> testcase base change head metric
>>>>>> page_fault3/ enable THP 10092 -17.5% 8323 will-it-scale.per_thread_ops
>>>>>> page_fault2/ enable THP 8300 -17.2% 6869 will-it-scale.per_thread_ops
>>>>>> brk1/ enable THP 957.67 -7.6% 885 will-it-scale.per_thread_ops
>>>>>> page_fault3/ enable THP 172821 -5.3% 163692 will-it-scale.per_process_ops
>>>>>> signal1/ enable THP 9125 -3.2% 8834 will-it-scale.per_process_ops
>>>>>>
>>>>>> b) THP disabled:
>>>>>> testcase base change head metric
>>>>>> page_fault3/ disable THP 10107 -19.1% 8180 will-it-scale.per_thread_ops
>>>>>> page_fault2/ disable THP 8432 -17.8% 6931 will-it-scale.per_thread_ops
>>>>>> context_switch1/ disable THP 215389 -6.8% 200776 will-it-scale.per_thread_ops
>>>>>> brk1/ disable THP 939.67 -6.6% 877.33 will-it-scale.per_thread_ops
>>>>>> page_fault3/ disable THP 173145 -4.7% 165064 will-it-scale.per_process_ops
>>>>>> signal1/ disable THP 9162 -3.9% 8802 will-it-scale.per_process_ops
>>>>>>
>>>>>> 2. Improvements:
>>>>>> a) THP enabled:
>>>>>> testcase base change head metric
>>>>>> malloc1/ enable THP 66.33 +469.8% 383.67 will-it-scale.per_thread_ops
>>>>>> writeseek3/ enable THP 2531 +4.5% 2646 will-it-scale.per_thread_ops
>>>>>> signal1/ enable THP 989.33 +2.8% 1016 will-it-scale.per_thread_ops
>>>>>>
>>>>>> b) THP disabled:
>>>>>> testcase base change head metric
>>>>>> malloc1/ disable THP 90.33 +417.3% 467.33 will-it-scale.per_thread_ops
>>>>>> read2/ disable THP 58934 +39.2% 82060 will-it-scale.per_thread_ops
>>>>>> page_fault1/ disable THP 8607 +36.4% 11736 will-it-scale.per_thread_ops
>>>>>> read1/ disable THP 314063 +12.7% 353934 will-it-scale.per_thread_ops
>>>>>> writeseek3/ disable THP 2452 +12.5% 2759 will-it-scale.per_thread_ops
>>>>>> signal1/ disable THP 971.33 +5.5% 1024 will-it-scale.per_thread_ops
>>>>>>
>>>>>> Notes: for above values in column "change", the higher value means that the related testcase result
>>>>>> on head commit is better than that on base commit for this benchmark.
>>>>>>
>>>>>>
>>>>>> Best regards
>>>>>> Haiyan Song
>>>>>>
>>>>>> ________________________________________
>>>>>> From: owner-linux-mm@kvack.org [owner-linux-mm@kvack.org] on behalf of Laurent Dufour [ldufour@linux.vnet.ibm.com]
>>>>>> Sent: Thursday, May 17, 2018 7:06 PM
>>>>>> To: akpm@linux-foundation.org; mhocko@kernel.org; peterz@infradead.org; kirill@shutemov.name; ak@linux.intel.com; dave@stgolabs.net; jack@suse.cz; Matthew Wilcox; khandual@linux.vnet.ibm.com; aneesh.kumar@linux.vnet.ibm.com; benh@kernel.crashing.org; mpe@ellerman.id.au; paulus@samba.org; Thomas Gleixner; Ingo Molnar; hpa@zytor.com; Will Deacon; Sergey Senozhatsky; sergey.senozhatsky.work@gmail.com; Andrea Arcangeli; Alexei Starovoitov; Wang, Kemi; Daniel Jordan; David Rientjes; Jerome Glisse; Ganesh Mahendran; Minchan Kim; Punit Agrawal; vinayak menon; Yang Shi
>>>>>> Cc: linux-kernel@vger.kernel.org; linux-mm@kvack.org; haren@linux.vnet.ibm.com; npiggin@gmail.com; bsingharora@gmail.com; paulmck@linux.vnet.ibm.com; Tim Chen; linuxppc-dev@lists.ozlabs.org; x86@kernel.org
>>>>>> Subject: [PATCH v11 00/26] Speculative page faults
>>>>>>
>>>>>> This is a port on kernel 4.17 of the work done by Peter Zijlstra to handle
>>>>>> page fault without holding the mm semaphore [1].
>>>>>>
>>>>>> The idea is to try to handle user space page faults without holding the
>>>>>> mmap_sem. This should allow better concurrency for massively threaded
>>>>>> process since the page fault handler will not wait for other threads memory
>>>>>> layout change to be done, assuming that this change is done in another part
>>>>>> of the process's memory space. This type page fault is named speculative
>>>>>> page fault. If the speculative page fault fails because of a concurrency is
>>>>>> detected or because underlying PMD or PTE tables are not yet allocating, it
>>>>>> is failing its processing and a classic page fault is then tried.
>>>>>>
>>>>>> The speculative page fault (SPF) has to look for the VMA matching the fault
>>>>>> address without holding the mmap_sem, this is done by introducing a rwlock
>>>>>> which protects the access to the mm_rb tree. Previously this was done using
>>>>>> SRCU but it was introducing a lot of scheduling to process the VMA's
>>>>>> freeing operation which was hitting the performance by 20% as reported by
>>>>>> Kemi Wang [2]. Using a rwlock to protect access to the mm_rb tree is
>>>>>> limiting the locking contention to these operations which are expected to
>>>>>> be in a O(log n) order. In addition to ensure that the VMA is not freed in
>>>>>> our back a reference count is added and 2 services (get_vma() and
>>>>>> put_vma()) are introduced to handle the reference count. Once a VMA is
>>>>>> fetched from the RB tree using get_vma(), it must be later freed using
>>>>>> put_vma(). I can't see anymore the overhead I got while will-it-scale
>>>>>> benchmark anymore.
>>>>>>
>>>>>> The VMA's attributes checked during the speculative page fault processing
>>>>>> have to be protected against parallel changes. This is done by using a per
>>>>>> VMA sequence lock. This sequence lock allows the speculative page fault
>>>>>> handler to fast check for parallel changes in progress and to abort the
>>>>>> speculative page fault in that case.
>>>>>>
>>>>>> Once the VMA has been found, the speculative page fault handler would check
>>>>>> for the VMA's attributes to verify that the page fault has to be handled
>>>>>> correctly or not. Thus, the VMA is protected through a sequence lock which
>>>>>> allows fast detection of concurrent VMA changes. If such a change is
>>>>>> detected, the speculative page fault is aborted and a *classic* page fault
>>>>>> is tried. VMA sequence lockings are added when VMA attributes which are
>>>>>> checked during the page fault are modified.
>>>>>>
>>>>>> When the PTE is fetched, the VMA is checked to see if it has been changed,
>>>>>> so once the page table is locked, the VMA is valid, so any other changes
>>>>>> leading to touching this PTE will need to lock the page table, so no
>>>>>> parallel change is possible at this time.
>>>>>>
>>>>>> The locking of the PTE is done with interrupts disabled, this allows
>>>>>> checking for the PMD to ensure that there is not an ongoing collapsing
>>>>>> operation. Since khugepaged is firstly set the PMD to pmd_none and then is
>>>>>> waiting for the other CPU to have caught the IPI interrupt, if the pmd is
>>>>>> valid at the time the PTE is locked, we have the guarantee that the
>>>>>> collapsing operation will have to wait on the PTE lock to move forward.
>>>>>> This allows the SPF handler to map the PTE safely. If the PMD value is
>>>>>> different from the one recorded at the beginning of the SPF operation, the
>>>>>> classic page fault handler will be called to handle the operation while
>>>>>> holding the mmap_sem. As the PTE lock is done with the interrupts disabled,
>>>>>> the lock is done using spin_trylock() to avoid dead lock when handling a
>>>>>> page fault while a TLB invalidate is requested by another CPU holding the
>>>>>> PTE.
>>>>>>
>>>>>> In pseudo code, this could be seen as:
>>>>>> speculative_page_fault()
>>>>>> {
>>>>>> vma = get_vma()
>>>>>> check vma sequence count
>>>>>> check vma's support
>>>>>> disable interrupt
>>>>>> check pgd,p4d,...,pte
>>>>>> save pmd and pte in vmf
>>>>>> save vma sequence counter in vmf
>>>>>> enable interrupt
>>>>>> check vma sequence count
>>>>>> handle_pte_fault(vma)
>>>>>> ..
>>>>>> page = alloc_page()
>>>>>> pte_map_lock()
>>>>>> disable interrupt
>>>>>> abort if sequence counter has changed
>>>>>> abort if pmd or pte has changed
>>>>>> pte map and lock
>>>>>> enable interrupt
>>>>>> if abort
>>>>>> free page
>>>>>> abort
>>>>>> ...
>>>>>> }
>>>>>>
>>>>>> arch_fault_handler()
>>>>>> {
>>>>>> if (speculative_page_fault(&vma))
>>>>>> goto done
>>>>>> again:
>>>>>> lock(mmap_sem)
>>>>>> vma = find_vma();
>>>>>> handle_pte_fault(vma);
>>>>>> if retry
>>>>>> unlock(mmap_sem)
>>>>>> goto again;
>>>>>> done:
>>>>>> handle fault error
>>>>>> }
>>>>>>
>>>>>> Support for THP is not done because when checking for the PMD, we can be
>>>>>> confused by an in progress collapsing operation done by khugepaged. The
>>>>>> issue is that pmd_none() could be true either if the PMD is not already
>>>>>> populated or if the underlying PTE are in the way to be collapsed. So we
>>>>>> cannot safely allocate a PMD if pmd_none() is true.
>>>>>>
>>>>>> This series add a new software performance event named 'speculative-faults'
>>>>>> or 'spf'. It counts the number of successful page fault event handled
>>>>>> speculatively. When recording 'faults,spf' events, the faults one is
>>>>>> counting the total number of page fault events while 'spf' is only counting
>>>>>> the part of the faults processed speculatively.
>>>>>>
>>>>>> There are some trace events introduced by this series. They allow
>>>>>> identifying why the page faults were not processed speculatively. This
>>>>>> doesn't take in account the faults generated by a monothreaded process
>>>>>> which directly processed while holding the mmap_sem. This trace events are
>>>>>> grouped in a system named 'pagefault', they are:
>>>>>> - pagefault:spf_vma_changed : if the VMA has been changed in our back
>>>>>> - pagefault:spf_vma_noanon : the vma->anon_vma field was not yet set.
>>>>>> - pagefault:spf_vma_notsup : the VMA's type is not supported
>>>>>> - pagefault:spf_vma_access : the VMA's access right are not respected
>>>>>> - pagefault:spf_pmd_changed : the upper PMD pointer has changed in our
>>>>>> back.
>>>>>>
>>>>>> To record all the related events, the easier is to run perf with the
>>>>>> following arguments :
>>>>>> $ perf stat -e 'faults,spf,pagefault:*' <command>
>>>>>>
>>>>>> There is also a dedicated vmstat counter showing the number of successful
>>>>>> page fault handled speculatively. I can be seen this way:
>>>>>> $ grep speculative_pgfault /proc/vmstat
>>>>>>
>>>>>> This series builds on top of v4.16-mmotm-2018-04-13-17-28 and is functional
>>>>>> on x86, PowerPC and arm64.
>>>>>>
>>>>>> ---------------------
>>>>>> Real Workload results
>>>>>>
>>>>>> As mentioned in previous email, we did non official runs using a "popular
>>>>>> in memory multithreaded database product" on 176 cores SMT8 Power system
>>>>>> which showed a 30% improvements in the number of transaction processed per
>>>>>> second. This run has been done on the v6 series, but changes introduced in
>>>>>> this new version should not impact the performance boost seen.
>>>>>>
>>>>>> Here are the perf data captured during 2 of these runs on top of the v8
>>>>>> series:
>>>>>> vanilla spf
>>>>>> faults 89.418 101.364 +13%
>>>>>> spf n/a 97.989
>>>>>>
>>>>>> With the SPF kernel, most of the page fault were processed in a speculative
>>>>>> way.
>>>>>>
>>>>>> Ganesh Mahendran had backported the series on top of a 4.9 kernel and gave
>>>>>> it a try on an android device. He reported that the application launch time
>>>>>> was improved in average by 6%, and for large applications (~100 threads) by
>>>>>> 20%.
>>>>>>
>>>>>> Here are the launch time Ganesh mesured on Android 8.0 on top of a Qcom
>>>>>> MSM845 (8 cores) with 6GB (the less is better):
>>>>>>
>>>>>> Application 4.9 4.9+spf delta
>>>>>> com.tencent.mm 416 389 -7%
>>>>>> com.eg.android.AlipayGphone 1135 986 -13%
>>>>>> com.tencent.mtt 455 454 0%
>>>>>> com.qqgame.hlddz 1497 1409 -6%
>>>>>> com.autonavi.minimap 711 701 -1%
>>>>>> com.tencent.tmgp.sgame 788 748 -5%
>>>>>> com.immomo.momo 501 487 -3%
>>>>>> com.tencent.peng 2145 2112 -2%
>>>>>> com.smile.gifmaker 491 461 -6%
>>>>>> com.baidu.BaiduMap 479 366 -23%
>>>>>> com.taobao.taobao 1341 1198 -11%
>>>>>> com.baidu.searchbox 333 314 -6%
>>>>>> com.tencent.mobileqq 394 384 -3%
>>>>>> com.sina.weibo 907 906 0%
>>>>>> com.youku.phone 816 731 -11%
>>>>>> com.happyelements.AndroidAnimal.qq 763 717 -6%
>>>>>> com.UCMobile 415 411 -1%
>>>>>> com.tencent.tmgp.ak 1464 1431 -2%
>>>>>> com.tencent.qqmusic 336 329 -2%
>>>>>> com.sankuai.meituan 1661 1302 -22%
>>>>>> com.netease.cloudmusic 1193 1200 1%
>>>>>> air.tv.douyu.android 4257 4152 -2%
>>>>>>
>>>>>> ------------------
>>>>>> Benchmarks results
>>>>>>
>>>>>> Base kernel is v4.17.0-rc4-mm1
>>>>>> SPF is BASE + this series
>>>>>>
>>>>>> Kernbench:
>>>>>> ----------
>>>>>> Here are the results on a 16 CPUs X86 guest using kernbench on a 4.15
>>>>>> kernel (kernel is build 5 times):
>>>>>>
>>>>>> Average Half load -j 8
>>>>>> Run (std deviation)
>>>>>> BASE SPF
>>>>>> Elapsed Time 1448.65 (5.72312) 1455.84 (4.84951) 0.50%
>>>>>> User Time 10135.4 (30.3699) 10148.8 (31.1252) 0.13%
>>>>>> System Time 900.47 (2.81131) 923.28 (7.52779) 2.53%
>>>>>> Percent CPU 761.4 (1.14018) 760.2 (0.447214) -0.16%
>>>>>> Context Switches 85380 (3419.52) 84748 (1904.44) -0.74%
>>>>>> Sleeps 105064 (1240.96) 105074 (337.612) 0.01%
>>>>>>
>>>>>> Average Optimal load -j 16
>>>>>> Run (std deviation)
>>>>>> BASE SPF
>>>>>> Elapsed Time 920.528 (10.1212) 927.404 (8.91789) 0.75%
>>>>>> User Time 11064.8 (981.142) 11085 (990.897) 0.18%
>>>>>> System Time 979.904 (84.0615) 1001.14 (82.5523) 2.17%
>>>>>> Percent CPU 1089.5 (345.894) 1086.1 (343.545) -0.31%
>>>>>> Context Switches 159488 (78156.4) 158223 (77472.1) -0.79%
>>>>>> Sleeps 110566 (5877.49) 110388 (5617.75) -0.16%
>>>>>>
>>>>>>
>>>>>> During a run on the SPF, perf events were captured:
>>>>>> Performance counter stats for '../kernbench -M':
>>>>>> 526743764 faults
>>>>>> 210 spf
>>>>>> 3 pagefault:spf_vma_changed
>>>>>> 0 pagefault:spf_vma_noanon
>>>>>> 2278 pagefault:spf_vma_notsup
>>>>>> 0 pagefault:spf_vma_access
>>>>>> 0 pagefault:spf_pmd_changed
>>>>>>
>>>>>> Very few speculative page faults were recorded as most of the processes
>>>>>> involved are monothreaded (sounds that on this architecture some threads
>>>>>> were created during the kernel build processing).
>>>>>>
>>>>>> Here are the kerbench results on a 80 CPUs Power8 system:
>>>>>>
>>>>>> Average Half load -j 40
>>>>>> Run (std deviation)
>>>>>> BASE SPF
>>>>>> Elapsed Time 117.152 (0.774642) 117.166 (0.476057) 0.01%
>>>>>> User Time 4478.52 (24.7688) 4479.76 (9.08555) 0.03%
>>>>>> System Time 131.104 (0.720056) 134.04 (0.708414) 2.24%
>>>>>> Percent CPU 3934 (19.7104) 3937.2 (19.0184) 0.08%
>>>>>> Context Switches 92125.4 (576.787) 92581.6 (198.622) 0.50%
>>>>>> Sleeps 317923 (652.499) 318469 (1255.59) 0.17%
>>>>>>
>>>>>> Average Optimal load -j 80
>>>>>> Run (std deviation)
>>>>>> BASE SPF
>>>>>> Elapsed Time 107.73 (0.632416) 107.31 (0.584936) -0.39%
>>>>>> User Time 5869.86 (1466.72) 5871.71 (1467.27) 0.03%
>>>>>> System Time 153.728 (23.8573) 157.153 (24.3704) 2.23%
>>>>>> Percent CPU 5418.6 (1565.17) 5436.7 (1580.91) 0.33%
>>>>>> Context Switches 223861 (138865) 225032 (139632) 0.52%
>>>>>> Sleeps 330529 (13495.1) 332001 (14746.2) 0.45%
>>>>>>
>>>>>> During a run on the SPF, perf events were captured:
>>>>>> Performance counter stats for '../kernbench -M':
>>>>>> 116730856 faults
>>>>>> 0 spf
>>>>>> 3 pagefault:spf_vma_changed
>>>>>> 0 pagefault:spf_vma_noanon
>>>>>> 476 pagefault:spf_vma_notsup
>>>>>> 0 pagefault:spf_vma_access
>>>>>> 0 pagefault:spf_pmd_changed
>>>>>>
>>>>>> Most of the processes involved are monothreaded so SPF is not activated but
>>>>>> there is no impact on the performance.
>>>>>>
>>>>>> Ebizzy:
>>>>>> -------
>>>>>> The test is counting the number of records per second it can manage, the
>>>>>> higher is the best. I run it like this 'ebizzy -mTt <nrcpus>'. To get
>>>>>> consistent result I repeated the test 100 times and measure the average
>>>>>> result. The number is the record processes per second, the higher is the
>>>>>> best.
>>>>>>
>>>>>> BASE SPF delta
>>>>>> 16 CPUs x86 VM 742.57 1490.24 100.69%
>>>>>> 80 CPUs P8 node 13105.4 24174.23 84.46%
>>>>>>
>>>>>> Here are the performance counter read during a run on a 16 CPUs x86 VM:
>>>>>> Performance counter stats for './ebizzy -mTt 16':
>>>>>> 1706379 faults
>>>>>> 1674599 spf
>>>>>> 30588 pagefault:spf_vma_changed
>>>>>> 0 pagefault:spf_vma_noanon
>>>>>> 363 pagefault:spf_vma_notsup
>>>>>> 0 pagefault:spf_vma_access
>>>>>> 0 pagefault:spf_pmd_changed
>>>>>>
>>>>>> And the ones captured during a run on a 80 CPUs Power node:
>>>>>> Performance counter stats for './ebizzy -mTt 80':
>>>>>> 1874773 faults
>>>>>> 1461153 spf
>>>>>> 413293 pagefault:spf_vma_changed
>>>>>> 0 pagefault:spf_vma_noanon
>>>>>> 200 pagefault:spf_vma_notsup
>>>>>> 0 pagefault:spf_vma_access
>>>>>> 0 pagefault:spf_pmd_changed
>>>>>>
>>>>>> In ebizzy's case most of the page fault were handled in a speculative way,
>>>>>> leading the ebizzy performance boost.
>>>>>>
>>>>>> ------------------
>>>>>> Changes since v10 (https://lkml.org/lkml/2018/4/17/572):
>>>>>> - Accounted for all review feedbacks from Punit Agrawal, Ganesh Mahendran
>>>>>> and Minchan Kim, hopefully.
>>>>>> - Remove unneeded check on CONFIG_SPECULATIVE_PAGE_FAULT in
>>>>>> __do_page_fault().
>>>>>> - Loop in pte_spinlock() and pte_map_lock() when pte try lock fails
>>>>>> instead
>>>>>> of aborting the speculative page fault handling. Dropping the now
>>>>>> useless
>>>>>> trace event pagefault:spf_pte_lock.
>>>>>> - No more try to reuse the fetched VMA during the speculative page fault
>>>>>> handling when retrying is needed. This adds a lot of complexity and
>>>>>> additional tests done didn't show a significant performance improvement.
>>>>>> - Convert IS_ENABLED(CONFIG_NUMA) back to #ifdef due to build error.
>>>>>>
>>>>>> [1] http://linux-kernel.2935.n7.nabble.com/RFC-PATCH-0-6-Another-go-at-speculative-page-faults-tt965642.html#none
>>>>>> [2] https://patchwork.kernel.org/patch/9999687/
>>>>>>
>>>>>>
>>>>>> Laurent Dufour (20):
>>>>>> mm: introduce CONFIG_SPECULATIVE_PAGE_FAULT
>>>>>> x86/mm: define ARCH_SUPPORTS_SPECULATIVE_PAGE_FAULT
>>>>>> powerpc/mm: set ARCH_SUPPORTS_SPECULATIVE_PAGE_FAULT
>>>>>> mm: introduce pte_spinlock for FAULT_FLAG_SPECULATIVE
>>>>>> mm: make pte_unmap_same compatible with SPF
>>>>>> mm: introduce INIT_VMA()
>>>>>> mm: protect VMA modifications using VMA sequence count
>>>>>> mm: protect mremap() against SPF hanlder
>>>>>> mm: protect SPF handler against anon_vma changes
>>>>>> mm: cache some VMA fields in the vm_fault structure
>>>>>> mm/migrate: Pass vm_fault pointer to migrate_misplaced_page()
>>>>>> mm: introduce __lru_cache_add_active_or_unevictable
>>>>>> mm: introduce __vm_normal_page()
>>>>>> mm: introduce __page_add_new_anon_rmap()
>>>>>> mm: protect mm_rb tree with a rwlock
>>>>>> mm: adding speculative page fault failure trace events
>>>>>> perf: add a speculative page fault sw event
>>>>>> perf tools: add support for the SPF perf event
>>>>>> mm: add speculative page fault vmstats
>>>>>> powerpc/mm: add speculative page fault
>>>>>>
>>>>>> Mahendran Ganesh (2):
>>>>>> arm64/mm: define ARCH_SUPPORTS_SPECULATIVE_PAGE_FAULT
>>>>>> arm64/mm: add speculative page fault
>>>>>>
>>>>>> Peter Zijlstra (4):
>>>>>> mm: prepare for FAULT_FLAG_SPECULATIVE
>>>>>> mm: VMA sequence count
>>>>>> mm: provide speculative fault infrastructure
>>>>>> x86/mm: add speculative pagefault handling
>>>>>>
>>>>>> arch/arm64/Kconfig | 1 +
>>>>>> arch/arm64/mm/fault.c | 12 +
>>>>>> arch/powerpc/Kconfig | 1 +
>>>>>> arch/powerpc/mm/fault.c | 16 +
>>>>>> arch/x86/Kconfig | 1 +
>>>>>> arch/x86/mm/fault.c | 27 +-
>>>>>> fs/exec.c | 2 +-
>>>>>> fs/proc/task_mmu.c | 5 +-
>>>>>> fs/userfaultfd.c | 17 +-
>>>>>> include/linux/hugetlb_inline.h | 2 +-
>>>>>> include/linux/migrate.h | 4 +-
>>>>>> include/linux/mm.h | 136 +++++++-
>>>>>> include/linux/mm_types.h | 7 +
>>>>>> include/linux/pagemap.h | 4 +-
>>>>>> include/linux/rmap.h | 12 +-
>>>>>> include/linux/swap.h | 10 +-
>>>>>> include/linux/vm_event_item.h | 3 +
>>>>>> include/trace/events/pagefault.h | 80 +++++
>>>>>> include/uapi/linux/perf_event.h | 1 +
>>>>>> kernel/fork.c | 5 +-
>>>>>> mm/Kconfig | 22 ++
>>>>>> mm/huge_memory.c | 6 +-
>>>>>> mm/hugetlb.c | 2 +
>>>>>> mm/init-mm.c | 3 +
>>>>>> mm/internal.h | 20 ++
>>>>>> mm/khugepaged.c | 5 +
>>>>>> mm/madvise.c | 6 +-
>>>>>> mm/memory.c | 612 +++++++++++++++++++++++++++++-----
>>>>>> mm/mempolicy.c | 51 ++-
>>>>>> mm/migrate.c | 6 +-
>>>>>> mm/mlock.c | 13 +-
>>>>>> mm/mmap.c | 229 ++++++++++---
>>>>>> mm/mprotect.c | 4 +-
>>>>>> mm/mremap.c | 13 +
>>>>>> mm/nommu.c | 2 +-
>>>>>> mm/rmap.c | 5 +-
>>>>>> mm/swap.c | 6 +-
>>>>>> mm/swap_state.c | 8 +-
>>>>>> mm/vmstat.c | 5 +-
>>>>>> tools/include/uapi/linux/perf_event.h | 1 +
>>>>>> tools/perf/util/evsel.c | 1 +
>>>>>> tools/perf/util/parse-events.c | 4 +
>>>>>> tools/perf/util/parse-events.l | 1 +
>>>>>> tools/perf/util/python.c | 1 +
>>>>>> 44 files changed, 1161 insertions(+), 211 deletions(-)
>>>>>> create mode 100644 include/trace/events/pagefault.h
>>>>>>
>>>>>> --
>>>>>> 2.7.4
>>>>>>
>>>>>>
>>>>>
>>>>
>>>
>>
>>
>
^ permalink raw reply
* Re: [PATCH v06 1/9] hotplug/cpu: Conditionally acquire/release DRC index
From: Naveen N. Rao @ 2018-07-11 16:00 UTC (permalink / raw)
To: linuxppc-dev, Michael Bringmann
Cc: John Allen, Nathan Fontenot, Thomas Falcon, Tyrel Datwyler
In-Reply-To: <a86bdaf8-ad27-ffb4-aa89-77294c98010f@linux.vnet.ibm.com>
Michael Bringmann wrote:
> powerpc/cpu: Modify dlpar_cpu_add and dlpar_cpu_remove to allow the
> skipping of DRC index acquire or release operations during the CPU
> add or remove operations. This is intended to support subsequent
> changes to provide a 'CPU readd' operation.
>=20
> Signed-off-by: Michael Bringmann <mwb@linux.vnet.ibm.com>
> ---
> Changes in patch:
> -- Move new validity check added to pseries_smp_notifier
> to another patch
> ---
> arch/powerpc/platforms/pseries/hotplug-cpu.c | 68 +++++++++++++++-----=
------
> 1 file changed, 39 insertions(+), 29 deletions(-)
>=20
> diff --git a/arch/powerpc/platforms/pseries/hotplug-cpu.c b/arch/powerpc/=
platforms/pseries/hotplug-cpu.c
> index 6ef77ca..3632db2 100644
> --- a/arch/powerpc/platforms/pseries/hotplug-cpu.c
> +++ b/arch/powerpc/platforms/pseries/hotplug-cpu.c
> @@ -432,7 +432,7 @@ static bool valid_cpu_drc_index(struct device_node *p=
arent, u32 drc_index)
> return found;
> }
>=20
> -static ssize_t dlpar_cpu_add(u32 drc_index)
> +static ssize_t dlpar_cpu_add(u32 drc_index, bool acquire_drc)
> {
> struct device_node *dn, *parent;
> int rc, saved_rc;
> @@ -457,19 +457,22 @@ static ssize_t dlpar_cpu_add(u32 drc_index)
> return -EINVAL;
> }
>=20
> - rc =3D dlpar_acquire_drc(drc_index);
> - if (rc) {
> - pr_warn("Failed to acquire DRC, rc: %d, drc index: %x\n",
> - rc, drc_index);
> - of_node_put(parent);
> - return -EINVAL;
> + if (acquire_drc) {
> + rc =3D dlpar_acquire_drc(drc_index);
> + if (rc) {
> + pr_warn("Failed to acquire DRC, rc: %d, drc index: %x\n",
> + rc, drc_index);
> + of_node_put(parent);
> + return -EINVAL;
> + }
> }
>=20
> dn =3D dlpar_configure_connector(cpu_to_be32(drc_index), parent);
> if (!dn) {
> pr_warn("Failed call to configure-connector, drc index: %x\n",
> drc_index);
> - dlpar_release_drc(drc_index);
> + if (acquire_drc)
> + dlpar_release_drc(drc_index);
> of_node_put(parent);
> return -EINVAL;
> }
> @@ -484,8 +487,9 @@ static ssize_t dlpar_cpu_add(u32 drc_index)
> pr_warn("Failed to attach node %s, rc: %d, drc index: %x\n",
> dn->name, rc, drc_index);
>=20
> - rc =3D dlpar_release_drc(drc_index);
> - if (!rc)
> + if (acquire_drc)
> + rc =3D dlpar_release_drc(drc_index);
> + if (!rc || acquire_drc)
> dlpar_free_cc_nodes(dn);
(!rc) can only be true if acquire_drc is true, so we seem to be only=20
invoking dlpar_free_cc_nodes() if acquire_drc is true. Would it be=20
better to frame that condition in this manner:
if (acquire_drc) {
rc =3D dlpar_release_drc(drc_index):
if (!rc)
dlpar_free_cc_nodes(dn);
}
>=20
> return saved_rc;
> @@ -498,7 +502,7 @@ static ssize_t dlpar_cpu_add(u32 drc_index)
> dn->name, rc, drc_index);
>=20
> rc =3D dlpar_detach_node(dn);
> - if (!rc)
> + if (!rc && acquire_drc)
> dlpar_release_drc(drc_index);
>=20
> return saved_rc;
> @@ -566,7 +570,8 @@ static int dlpar_offline_cpu(struct device_node *dn)
>=20
> }
>=20
> -static ssize_t dlpar_cpu_remove(struct device_node *dn, u32 drc_index)
> +static ssize_t dlpar_cpu_remove(struct device_node *dn, u32 drc_index,
> + bool release_drc)
> {
> int rc;
>=20
> @@ -579,12 +584,14 @@ static ssize_t dlpar_cpu_remove(struct device_node =
*dn, u32 drc_index)
> return -EINVAL;
> }
>=20
> - rc =3D dlpar_release_drc(drc_index);
> - if (rc) {
> - pr_warn("Failed to release drc (%x) for CPU %s, rc: %d\n",
> - drc_index, dn->name, rc);
> - dlpar_online_cpu(dn);
> - return rc;
> + if (release_drc) {
> + rc =3D dlpar_release_drc(drc_index);
> + if (rc) {
> + pr_warn("Failed to release drc (%x) for CPU %s, rc: %d\n",
> + drc_index, dn->name, rc);
> + dlpar_online_cpu(dn);
> + return rc;
> + }
> }
>=20
> rc =3D dlpar_detach_node(dn);
> @@ -593,7 +600,10 @@ static ssize_t dlpar_cpu_remove(struct device_node *=
dn, u32 drc_index)
>=20
> pr_warn("Failed to detach CPU %s, rc: %d", dn->name, rc);
>=20
> - rc =3D dlpar_acquire_drc(drc_index);
> + if (release_drc)
> + rc =3D dlpar_acquire_drc(drc_index);
> + else
> + rc =3D 0;
> if (!rc)
> dlpar_online_cpu(dn);
Here, we seem to want to invoke dlpar_online_cpu() unconditionally if=20
release_drc is false. So, to make that explicit, would it be better to=20
frame that as:
if (release_drc)
rc =3D dlpar_acquire_drc(drc_index);
if (!release_drc || !rc)
dlpar_online_cpu(dn);
- Naveen
>=20
> @@ -622,7 +632,7 @@ static struct device_node *cpu_drc_index_to_dn(u32 dr=
c_index)
> return dn;
> }
>=20
> -static int dlpar_cpu_remove_by_index(u32 drc_index)
> +static int dlpar_cpu_remove_by_index(u32 drc_index, bool release_drc)
> {
> struct device_node *dn;
> int rc;
> @@ -634,7 +644,7 @@ static int dlpar_cpu_remove_by_index(u32 drc_index)
> return -ENODEV;
> }
>=20
> - rc =3D dlpar_cpu_remove(dn, drc_index);
> + rc =3D dlpar_cpu_remove(dn, drc_index, release_drc);
> of_node_put(dn);
> return rc;
> }
> @@ -699,7 +709,7 @@ static int dlpar_cpu_remove_by_count(u32 cpus_to_remo=
ve)
> }
>=20
> for (i =3D 0; i < cpus_to_remove; i++) {
> - rc =3D dlpar_cpu_remove_by_index(cpu_drcs[i]);
> + rc =3D dlpar_cpu_remove_by_index(cpu_drcs[i], true);
> if (rc)
> break;
>=20
> @@ -710,7 +720,7 @@ static int dlpar_cpu_remove_by_count(u32 cpus_to_remo=
ve)
> pr_warn("CPU hot-remove failed, adding back removed CPUs\n");
>=20
> for (i =3D 0; i < cpus_removed; i++)
> - dlpar_cpu_add(cpu_drcs[i]);
> + dlpar_cpu_add(cpu_drcs[i], true);
>=20
> rc =3D -EINVAL;
> } else {
> @@ -780,7 +790,7 @@ static int dlpar_cpu_add_by_count(u32 cpus_to_add)
> }
>=20
> for (i =3D 0; i < cpus_to_add; i++) {
> - rc =3D dlpar_cpu_add(cpu_drcs[i]);
> + rc =3D dlpar_cpu_add(cpu_drcs[i], true);
> if (rc)
> break;
>=20
> @@ -791,7 +801,7 @@ static int dlpar_cpu_add_by_count(u32 cpus_to_add)
> pr_warn("CPU hot-add failed, removing any added CPUs\n");
>=20
> for (i =3D 0; i < cpus_added; i++)
> - dlpar_cpu_remove_by_index(cpu_drcs[i]);
> + dlpar_cpu_remove_by_index(cpu_drcs[i], true);
>=20
> rc =3D -EINVAL;
> } else {
> @@ -817,7 +827,7 @@ int dlpar_cpu(struct pseries_hp_errorlog *hp_elog)
> if (hp_elog->id_type =3D=3D PSERIES_HP_ELOG_ID_DRC_COUNT)
> rc =3D dlpar_cpu_remove_by_count(count);
> else if (hp_elog->id_type =3D=3D PSERIES_HP_ELOG_ID_DRC_INDEX)
> - rc =3D dlpar_cpu_remove_by_index(drc_index);
> + rc =3D dlpar_cpu_remove_by_index(drc_index, true);
> else
> rc =3D -EINVAL;
> break;
> @@ -825,7 +835,7 @@ int dlpar_cpu(struct pseries_hp_errorlog *hp_elog)
> if (hp_elog->id_type =3D=3D PSERIES_HP_ELOG_ID_DRC_COUNT)
> rc =3D dlpar_cpu_add_by_count(count);
> else if (hp_elog->id_type =3D=3D PSERIES_HP_ELOG_ID_DRC_INDEX)
> - rc =3D dlpar_cpu_add(drc_index);
> + rc =3D dlpar_cpu_add(drc_index, true);
> else
> rc =3D -EINVAL;
> break;
> @@ -850,7 +860,7 @@ static ssize_t dlpar_cpu_probe(const char *buf, size_=
t count)
> if (rc)
> return -EINVAL;
>=20
> - rc =3D dlpar_cpu_add(drc_index);
> + rc =3D dlpar_cpu_add(drc_index, true);
>=20
> return rc ? rc : count;
> }
> @@ -871,7 +881,7 @@ static ssize_t dlpar_cpu_release(const char *buf, siz=
e_t count)
> return -EINVAL;
> }
>=20
> - rc =3D dlpar_cpu_remove(dn, drc_index);
> + rc =3D dlpar_cpu_remove(dn, drc_index, true);
> of_node_put(dn);
>=20
> return rc ? rc : count;
>=20
>=20
=
^ permalink raw reply
* Re: Several suspected memory leaks
From: Michael Ellerman @ 2018-07-11 14:27 UTC (permalink / raw)
To: Paul Menzel; +Cc: linuxppc-dev, linux-kernel
In-Reply-To: <468d3c5b-d71d-c95b-dab4-ea8c2cebe129@molgen.mpg.de>
Hi Paul,
Paul Menzel <pmenzel@molgen.mpg.de> writes:
> Dear Liunx folks,
>
> On a the IBM S822LC (8335-GTA) with Ubuntu 18.04 I built Linux master
> =E2=80=93 4.18-rc4+, commit 092150a2 (Merge branch 'for-linus'
> of git://git.kernel.org/pub/scm/linux/kernel/git/jikos/hid) =E2=80=93 with
> kmemleak. Several issues are found.
Is this the first time you've tested it?
Or did these warnings only show up recently?
> ```
> $ grep KMEMLEAK /boot/config-4.18.0-rc4+
> CONFIG_HAVE_DEBUG_KMEMLEAK=3Dy
> CONFIG_DEBUG_KMEMLEAK=3Dy
> CONFIG_DEBUG_KMEMLEAK_EARLY_LOG_SIZE=3D10000
> # CONFIG_DEBUG_KMEMLEAK_TEST is not set
> # CONFIG_DEBUG_KMEMLEAK_DEFAULT_OFF is not set
I'm not seeing any warnings on my machine here, maybe it's something
config related. Can you send your full .config ?
cheers
^ permalink raw reply
* Re: [PATCH] powerpc: Replaced msleep with usleep_range
From: Michael Ellerman @ 2018-07-11 14:13 UTC (permalink / raw)
To: Daniel Klamt, benh
Cc: paulus, linuxppc-dev, linux-kernel, linux-kernel, Daniel Klamt,
Bjoern Noetel
In-Reply-To: <1531144679-31675-1-git-send-email-eleon@ele0n.de>
Hi Daniel,
Daniel Klamt <eleon@ele0n.de> writes:
> Replaced msleep for less than 10ms with usleep_range because will
> often sleep longer than intended.
> For original explanation see:
> Documentation/timers/timers-howto.txt
>
> Signed-off-by: Daniel Klamt <eleon@ele0n.de>
> Signed-off-by: Bjoern Noetel <bjoern@br3ak3r.de>
> ---
> arch/powerpc/sysdev/xive/native.c | 24 ++++++++++++------------
> 1 file changed, 12 insertions(+), 12 deletions(-)
>
> diff --git a/arch/powerpc/sysdev/xive/native.c b/arch/powerpc/sysdev/xive/native.c
> index 311185b9960a..b164b1cdf4d6 100644
> --- a/arch/powerpc/sysdev/xive/native.c
> +++ b/arch/powerpc/sysdev/xive/native.c
> @@ -109,7 +109,7 @@ int xive_native_configure_irq(u32 hw_irq, u32 target, u8 prio, u32 sw_irq)
> rc = opal_xive_set_irq_config(hw_irq, target, prio, sw_irq);
> if (rc != OPAL_BUSY)
> break;
> - msleep(1);
> + usleep_range(1000, 1100)
> }
We have actually recently added OPAL_BUSY_DELAY_MS (see opal.h) and
should convert these to use that. eg:
msleep(OPAL_BUSY_DELAY_MS);
That has the effect of documenting that this is a short sleep to wait
for opal (our firmware), and we aren't concerned about rounding errors
in msleep().
If you send me a patch doing that I'd be happy to merge it.
cheers
^ permalink raw reply
* Re: [PATCH NEXT 1/4] powerpc/pasemi: Add PCI initialisation for Nemo board.
From: Michael Ellerman @ 2018-07-11 14:04 UTC (permalink / raw)
To: Christian Zigotzky; +Cc: Darren Stevens, linuxppc-dev
In-Reply-To: <196ECBF7-5001-4B0B-9FE3-F079CE0996EE@xenosoft.de>
Christian Zigotzky <chzigotzky@xenosoft.de> writes:
> Hello Michael,
>
> Thanks a lot for your reply. OK, first I would like to add=20
>
> pr_info("NEMO SB600 IOB base %08llx\n",res.start)
>
> to the Nemo patch. Is this line correct now?
Yes I think so.
The type of start is resource_size_t, which can be 32 or 64-bits. But in
this code it should always be 64-bit.
> After that I will try to contact Darren because of your other comments.
>
> If I don=E2=80=99t reach Darren then I will try to fix the issues but I t=
hink
> I need your help for fixing them.
Sure.
cheers
^ permalink raw reply
* Re: [PATCH 1/2] powerpc: Add ppc32_allmodconfig defconfig target
From: Michael Ellerman @ 2018-07-11 13:50 UTC (permalink / raw)
To: Mathieu Malaterre; +Cc: linuxppc-dev, Nicholas Piggin, Randy Dunlap
In-Reply-To: <CA+7wUszg2EnuExY=Wx0JWebvFmdYwRSN2nvjkvwTtmD1vS4AJQ@mail.gmail.com>
Mathieu Malaterre <malat@debian.org> writes:
> On Tue, Jul 10, 2018 at 3:47 PM Michael Ellerman <mpe@ellerman.id.au> wrote:
>> Mathieu Malaterre <malat@debian.org> writes:
>> > On Mon, Jul 9, 2018 at 4:24 PM Michael Ellerman <mpe@ellerman.id.au> wrote:
>> >> Because the allmodconfig logic just sets every symbol to M or Y, it
>> >> has the effect of always generating a 64-bit config, because
>> >> CONFIG_PPC64 becomes Y.
>> >>
>> >> So to make it easier for folks to test 32-bit code, provide a phony
>> >> defconfig target that generates a 32-bit allmodconfig.
>> >>
>> >> The 32-bit port has several mutually exclusive CPU types, we choose
>> >> the Book3S variants as that's what the help text in Kconfig says is
>> >> most common.
>> >
>> > Ok then.
>>
>> That was just me taking a stab in the dark. You suggested we should
>> mimic the Debian config, what does that use?
>
> Sorry got confused for a minute. This is the correct value (at least
> the one used in Debian).
OK cool.
>> >> diff --git a/arch/powerpc/Makefile b/arch/powerpc/Makefile
>> >> index 2ea575cb3401..2556c2182789 100644
>> >> --- a/arch/powerpc/Makefile
>> >> +++ b/arch/powerpc/Makefile
>> >> @@ -354,6 +354,11 @@ mpc86xx_smp_defconfig:
>> >> $(call merge_into_defconfig,mpc86xx_basic_defconfig,\
>> >> 86xx-smp 86xx-hw fsl-emb-nonhw)
>> >>
>> >> +PHONY += ppc32_allmodconfig
>> >> +ppc32_allmodconfig:
>> >> + $(Q)$(MAKE) KCONFIG_ALLCONFIG=$(srctree)/arch/powerpc/configs/book3s_32.config \
>> >> + -f $(srctree)/Makefile allmodconfig
>> >> +
>> >
>> > I this a good time to update line 34 at the same time:
>> >
>> > KBUILD_DEFCONFIG := $(shell uname -m)_defconfig
>> >
>> > ?
>>
>> 34 or 36?
>>
>> ifeq ($(CROSS_COMPILE),)
>> KBUILD_DEFCONFIG := $(shell uname -m)_defconfig
>> else
>> KBUILD_DEFCONFIG := ppc64_defconfig
>> endif
>>
>> Do you mean the else case?
>
> As far as I know uname -m on powerpc returns 'ppc' so the following
> has always failed from a ppc32be machine:
Oh yep it does.
I've never built a kernel *on* a 32-bit machine ;)
> $ make ARCH=powerpc defconfig
>
> I was simply suggesting to mimic what was done for ppc64:
>
> ifeq ($(CROSS_COMPILE),)
> KBUILD_DEFCONFIG := ppc32_defconfig
> else
> KBUILD_DEFCONFIG := ppc64_defconfig
> endif
That wouldn't work, CROSS_COMPILE isn't a ppc/ppc64 thing.
In fact setting CROSS_COMPILE doesn't actually mean you're cross
compiling, it just means you're using a different toolchain. I do that
all the time, because I want to use a specific version of GCC, not the
distro one.
What about:
diff --git a/arch/powerpc/Makefile b/arch/powerpc/Makefile
index 2ea575c..e70d223 100644
--- a/arch/powerpc/Makefile
+++ b/arch/powerpc/Makefile
@@ -30,10 +30,13 @@ endif
endif
endif
-ifeq ($(CROSS_COMPILE),)
-KBUILD_DEFCONFIG := $(shell uname -m)_defconfig
+host_arch := $(shell uname -m)
+ifeq ($(host_arch),ppc)
+ KBUILD_DEFCONFIG := ppc32_defconfig
+else ifeq ($(host_arch),ppc64)
+ KBUILD_DEFCONFIG := ppc64_defconfig
else
-KBUILD_DEFCONFIG := ppc64_defconfig
+ KBUILD_DEFCONFIG := ppc64le_defconfig
endif
ifeq ($(CONFIG_PPC64),y)
We obviously need a ppc32_defconfig to make that work.
> If I followed the discussion one would want the file `ppc32_defconfig`
> to contains pretty much the same thing as the .config generated from
> `book3s_32.config`, right ?
Can you boot the resulting kernel if you build ppc32_allmodconfig ?
Maybe we should just make that be ppc32_defconfig.
cheers
^ permalink raw reply related
* Re: Boot failures with "mm/sparse: Remove CONFIG_SPARSEMEM_ALLOC_MEM_MAP_TOGETHER" on powerpc (was Re: mmotm 2018-07-10-16-50 uploaded)
From: Oscar Salvador @ 2018-07-11 13:37 UTC (permalink / raw)
To: Michael Ellerman
Cc: akpm, broonie, mhocko, sfr, linux-next, linux-fsdevel, linux-mm,
linux-kernel, mm-commits, linuxppc-dev, bhe, pasha.tatashin,
Aneesh Kumar K.V, Anshuman Khandual
In-Reply-To: <87lgai9bt5.fsf@concordia.ellerman.id.au>
On Wed, Jul 11, 2018 at 10:49:58PM +1000, Michael Ellerman wrote:
> akpm@linux-foundation.org writes:
> > The mm-of-the-moment snapshot 2018-07-10-16-50 has been uploaded to
> >
> > http://www.ozlabs.org/~akpm/mmotm/
> ...
>
> > * mm-sparse-add-a-static-variable-nr_present_sections.patch
> > * mm-sparsemem-defer-the-ms-section_mem_map-clearing.patch
> > * mm-sparsemem-defer-the-ms-section_mem_map-clearing-fix.patch
> > * mm-sparse-add-a-new-parameter-data_unit_size-for-alloc_usemap_and_memmap.patch
> > * mm-sparse-optimize-memmap-allocation-during-sparse_init.patch
> > * mm-sparse-optimize-memmap-allocation-during-sparse_init-checkpatch-fixes.patch
>
> > * mm-sparse-remove-config_sparsemem_alloc_mem_map_together.patch
>
> This seems to be breaking my powerpc pseries qemu boots.
>
> The boot log with some extra debug shows eg:
>
> $ make pseries_le_defconfig
Could you please share the config?
I was not able to find such config in the kernel tree.
--
Oscar Salvador
SUSE L3
^ permalink raw reply
page: next (older) | prev (newer) | latest
- recent:[subjects (threaded)|topics (new)|topics (active)]
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox