* Re: [v3 12/15] powerpc/perf: Add support for outputting extended regs in perf intr_regs
From: Athira Rajeev @ 2020-07-24 18:13 UTC (permalink / raw)
To: Ravi Bangoria
Cc: Gautham R Shenoy, Michael Neuling, maddy, kvm, kvm-ppc, svaidyan,
acme, jolsa, linuxppc-dev
In-Reply-To: <b7aa5dfb-273b-e0f7-6337-c71094c666cd@linux.ibm.com>
> On 24-Jul-2020, at 5:56 PM, Ravi Bangoria <ravi.bangoria@linux.ibm.com> wrote:
>
> Hi Athira,
>
>> +/* Function to return the extended register values */
>> +static u64 get_ext_regs_value(int idx)
>> +{
>> + switch (idx) {
>> + case PERF_REG_POWERPC_MMCR0:
>> + return mfspr(SPRN_MMCR0);
>> + case PERF_REG_POWERPC_MMCR1:
>> + return mfspr(SPRN_MMCR1);
>> + case PERF_REG_POWERPC_MMCR2:
>> + return mfspr(SPRN_MMCR2);
>> + default: return 0;
>> + }
>> +}
>> +
>> u64 perf_reg_value(struct pt_regs *regs, int idx)
>> {
>> - if (WARN_ON_ONCE(idx >= PERF_REG_POWERPC_MAX))
>> - return 0;
>> + u64 PERF_REG_EXTENDED_MAX;
>
> PERF_REG_EXTENDED_MAX should be initialized. otherwise ...
>
>> +
>> + if (cpu_has_feature(CPU_FTR_ARCH_300))
>> + PERF_REG_EXTENDED_MAX = PERF_REG_MAX_ISA_300;
>> if (idx == PERF_REG_POWERPC_SIER &&
>> (IS_ENABLED(CONFIG_FSL_EMB_PERF_EVENT) ||
>> @@ -85,6 +103,16 @@ u64 perf_reg_value(struct pt_regs *regs, int idx)
>> IS_ENABLED(CONFIG_PPC32)))
>> return 0;
>> + if (idx >= PERF_REG_POWERPC_MAX && idx < PERF_REG_EXTENDED_MAX)
>> + return get_ext_regs_value(idx);
>
> On non p9/p10 machine, PERF_REG_EXTENDED_MAX may contain random value which will
> allow user to pass this if condition unintentionally.
>
> Neat: PERF_REG_EXTENDED_MAX is a local variable so it should be in lowercase.
> Any specific reason to define it in capital?
Hi Ravi
There is no specific reason. I will include both these changes in next version
Thanks
Athira Rajeev
>
> Ravi
^ permalink raw reply
* Re: [v3 13/15] tools/perf: Add perf tools support for extended register capability in powerpc
From: Athira Rajeev @ 2020-07-24 18:02 UTC (permalink / raw)
To: Ravi Bangoria
Cc: Gautham R Shenoy, Michael Neuling, maddy, kvm, kvm-ppc, svaidyan,
acme, jolsa, linuxppc-dev
In-Reply-To: <7fcf405f-440a-19dc-7c3a-33fc52c9d1ef@linux.ibm.com>
> On 24-Jul-2020, at 4:32 PM, Ravi Bangoria <ravi.bangoria@linux.ibm.com> wrote:
>
> Hi Athira,
>
> On 7/17/20 8:08 PM, Athira Rajeev wrote:
>> From: Anju T Sudhakar <anju@linux.vnet.ibm.com>
>> Add extended regs to sample_reg_mask in the tool side to use
>> with `-I?` option. Perf tools side uses extended mask to display
>> the platform supported register names (with -I? option) to the user
>> and also send this mask to the kernel to capture the extended registers
>> in each sample. Hence decide the mask value based on the processor
>> version.
>> Currently definitions for `mfspr`, `SPRN_PVR` are part of
>> `arch/powerpc/util/header.c`. Move this to a header file so that
>> these definitions can be re-used in other source files as well.
>
> It seems this patch has a regression.
>
> Without this patch:
>
> $ sudo ./perf record -I
> ^C[ perf record: Woken up 1 times to write data ]
> [ perf record: Captured and wrote 0.458 MB perf.data (318 samples) ]
>
> With this patch:
>
> $ sudo ./perf record -I
> Error:
> dummy:HG: PMU Hardware doesn't support sampling/overflow-interrupts. Try 'perf stat'
Hi Ravi,
Thanks for reviewing this patch and also testing. The above issue happens since
commit 0a892c1c9472 ("perf record: Add dummy event during system wide synthesis”) which adds a dummy event.
The fix for this issue is currently discussed here: https://lkml.org/lkml/2020/7/19/413
So once this fix is in, the issue will be resolved.
Thanks
Athira
>
> Ravi
^ permalink raw reply
* Re: [PATCHv3 2/2] powerpc/pseries: update device tree before ejecting hotplug uevents
From: Nathan Lynch @ 2020-07-24 16:50 UTC (permalink / raw)
To: Pingfan Liu
Cc: cheloha, Kexec Mailing List, ldufour, linuxppc-dev, Hari Bathini
In-Reply-To: <CAFgQCTu_QO=50v2J0=aY2iV8P-oM82_Kfw9My600ZARUt01grw@mail.gmail.com>
Pingfan Liu <kernelfans@gmail.com> writes:
> On Thu, Jul 23, 2020 at 9:27 PM Nathan Lynch <nathanl@linux.ibm.com> wrote:
>> Pingfan Liu <kernelfans@gmail.com> writes:
>> > This will introduce extra dt updating payload for each involved lmb when hotplug.
>> > But it should be fine since drmem_update_dt() is memory based operation and
>> > hotplug is not a hot path.
>>
>> This is great analysis but the performance implications of the change
>> are grave. The add/remove paths here are already O(n) where n is the
>> quantity of memory assigned to the LP, this change would make it O(n^2):
>>
>> dlpar_memory_add_by_count
>> for_each_drmem_lmb <--
>> dlpar_add_lmb
>> drmem_update_dt(_v1|_v2)
>> for_each_drmem_lmb <--
>>
>> Memory add/remove isn't a hot path but quadratic runtime complexity
>> isn't acceptable. Its current performance is bad enough that I have
> Yes, the quadratic runtime complexity sounds terrible.
> And I am curious about the bug. Does the system have thousands of lmb?
Yes.
>> Not to mention we leak memory every time drmem_update_dt is called
>> because we can't safely free device tree properties :-(
> Do you know what block us to free it?
It's a longstanding problem. References to device tree properties aren't
counted or tracked so there's no way to safely free them unless the node
itself is released. But the ibm,dynamic-reconfiguration-memory node does
not ever go away and its properties are only subject to updates.
Maybe there's a way to address the specific case of
ibm,dynamic-reconfiguration-memory and the ibm,dynamic-memory(-v2)
properties, instead of tackling the general problem.
Regardless of all that, the drmem code needs better data structures and
lookup functions.
^ permalink raw reply
* Re: [PATCH v4 06/12] ppc64/kexec_file: restrict memory usage of kdump kernel
From: Hari Bathini @ 2020-07-24 14:08 UTC (permalink / raw)
To: Thiago Jung Bauermann
Cc: Pingfan Liu, Petr Tesarik, Nayna Jain, Kexec-ml,
Mahesh J Salgaonkar, Mimi Zohar, lkml, linuxppc-dev, Sourabh Jain,
Andrew Morton, Dave Young, Vivek Goyal, Eric Biederman
In-Reply-To: <875zad6ajx.fsf@morokweng.localdomain>
On 24/07/20 5:36 am, Thiago Jung Bauermann wrote:
>
> Hari Bathini <hbathini@linux.ibm.com> writes:
>
>> Kdump kernel, used for capturing the kernel core image, is supposed
>> to use only specific memory regions to avoid corrupting the image to
>> be captured. The regions are crashkernel range - the memory reserved
>> explicitly for kdump kernel, memory used for the tce-table, the OPAL
>> region and RTAS region as applicable. Restrict kdump kernel memory
>> to use only these regions by setting up usable-memory DT property.
>> Also, tell the kdump kernel to run at the loaded address by setting
>> the magic word at 0x5c.
>>
>> Signed-off-by: Hari Bathini <hbathini@linux.ibm.com>
>> Tested-by: Pingfan Liu <piliu@redhat.com>
>> ---
>>
>> v3 -> v4:
>> * Updated get_node_path() to be an iterative function instead of a
>> recursive one.
>> * Added comment explaining why low memory is added to kdump kernel's
>> usable memory ranges though it doesn't fall in crashkernel region.
>> * For correctness, added fdt_add_mem_rsv() for the low memory being
>> added to kdump kernel's usable memory ranges.
>
> Good idea.
>
>> * Fixed prop pointer update in add_usable_mem_property() and changed
>> duple to tuple as suggested by Thiago.
>
> <snip>
>
>> +/**
>> + * get_node_pathlen - Get the full path length of the given node.
>> + * @dn: Node.
>> + *
>> + * Also, counts '/' at the end of the path.
>> + * For example, /memory@0 will be "/memory@0/\0" => 11 bytes.
>
> Wouldn't this function return 10 in the case of /memory@0?
Actually, it does return 11. +1 while returning is for counting %NUL.
On top of that we count an extra '/' for root node.. so, it ends up as 11.
('/'memory@0'/''\0'). Note the extra '/' before '\0'. Let me handle root node
separately. That should avoid the confusion.
>> + *
>> + * Returns the string length of the node's full path.
>> + */
>
> Maybe it's me (by analogy with strlen()), but I would expect "string
> length" to not include the terminating \0. I suggest renaming the
> function to something like get_node_path_size() and do s/length/size/ in
> the comment above if it's supposed to count the terminating \0.
Sure, will update the function name.
Thanks
Hari
^ permalink raw reply
* Re: [PATCH 1/1 V4] : PCIE PHB reset
From: Michael Ellerman @ 2020-07-24 13:25 UTC (permalink / raw)
To: linuxppc-dev, wenxiong@linux.vnet.ibm.com
Cc: brking, oohall, bobroff, wenxiong
In-Reply-To: <1594651173-32166-1-git-send-email-wenxiong@linux.vnet.ibm.com>
On Mon, 13 Jul 2020 09:39:33 -0500, wenxiong@linux.vnet.ibm.com wrote:
> Several device drivers hit EEH(Extended Error handling) when triggering
> kdump on Pseries PowerVM. This patch implemented a reset of the PHBs
> in pci general code when triggering kdump. PHB reset stop all PCI
> transactions from normal kernel. We have tested the patch in several
> enviroments:
> - direct slot adapters
> - adapters under the switch
> - a VF adapter in PowerVM
> - a VF adapter/adapter in KVM guest.
>
> [...]
Applied to powerpc/next.
[1/1] powerpc/pseries: PCIE PHB reset
https://git.kernel.org/powerpc/c/5a090f7c363fdc09b99222eae679506a58e7cc68
cheers
^ permalink raw reply
* Re: [PATCH -next] powerpc: Remove unneeded inline functions
From: Michael Ellerman @ 2020-07-24 13:25 UTC (permalink / raw)
To: npiggin, haren, paulus, dave.hansen, benh, YueHaibing, mpe
Cc: linuxppc-dev, linux-kernel
In-Reply-To: <20200717112714.19304-1-yuehaibing@huawei.com>
On Fri, 17 Jul 2020 19:27:14 +0800, YueHaibing wrote:
> Both of those functions are only called from 64-bit only code, so the
> stubs should not be needed at all.
Applied to powerpc/next.
[1/1] powerpc: Remove unneeded inline functions
https://git.kernel.org/powerpc/c/a3f3f8aa1f72dafe1450ccf8cbdfb1d12d42853a
cheers
^ permalink raw reply
* Re: [PATCH trivial] ppc64/mm: remove comment that is no longer valid
From: Michael Ellerman @ 2020-07-24 13:25 UTC (permalink / raw)
To: Santosh Sivaraj, linuxppc-dev
In-Reply-To: <20200721091915.205006-1-santosh@fossix.org>
On Tue, 21 Jul 2020 14:49:15 +0530, Santosh Sivaraj wrote:
> hash_low_64.S was removed in [1] and since flush_hash_page is not called
> from any assembly routine.
>
> [1]: commit a43c0eb8364c0 ("powerpc/mm: Convert 4k insert from asm to C")
Applied to powerpc/next.
[1/1] powerpc/mm/hash64: Remove comment that is no longer valid
https://git.kernel.org/powerpc/c/69507b984ddce803df81215cc7813825189adafa
cheers
^ permalink raw reply
* Re: [PATCH v2 1/2] powerpc/mce: Add MCE notification chain
From: Michael Ellerman @ 2020-07-24 13:25 UTC (permalink / raw)
To: Santosh Sivaraj, linuxppc-dev
Cc: Aneesh Kumar K.V, Ganesh Goudar, Oliver, Mahesh Salgaonkar,
Vaibhav Jain
In-Reply-To: <20200709135142.721504-1-santosh@fossix.org>
On Thu, 9 Jul 2020 19:21:41 +0530, Santosh Sivaraj wrote:
> Introduce notification chain which lets us know about uncorrected memory
> errors(UE). This would help prospective users in pmem or nvdimm subsystem
> to track bad blocks for better handling of persistent memory allocations.
Applied to powerpc/next.
[1/2] powerpc/mce: Add MCE notification chain
https://git.kernel.org/powerpc/c/c37a63afc429ce959402168f67e4f094ab639ace
[2/2] powerpc/papr/scm: Add bad memory ranges to nvdimm bad ranges
https://git.kernel.org/powerpc/c/85343a8da2d969df1a10ada8f7cb857d52ea70a6
cheers
^ permalink raw reply
* Re: [PATCH v4 0/3] powernv/idle: Power9 idle cleanup
From: Michael Ellerman @ 2020-07-24 13:25 UTC (permalink / raw)
To: npiggin, ego, pratik.r.sampat, Pratik Rajesh Sampat, linuxppc-dev,
mikey, paulus, benh, svaidy, linux-kernel, mpe
In-Reply-To: <20200721153708.89057-1-psampat@linux.ibm.com>
On Tue, 21 Jul 2020 21:07:05 +0530, Pratik Rajesh Sampat wrote:
> v3: https://lkml.org/lkml/2020/7/17/1093
> Changelog v3-->v4:
> Based on comments from Nicholas Piggin and Gautham Shenoy,
> 1. Changed the naming of pnv_first_spr_loss_level from
> pnv_first_fullstate_loss_level to deep_spr_loss_state
> 2. Make the P9 PVR check only on the top level function
> pnv_probe_idle_states and let the rest of the checks be DT based because
> it is faster to do so
>
> [...]
Applied to powerpc/next.
[1/3] powerpc/powernv/idle: Replace CPU feature check with PVR check
https://git.kernel.org/powerpc/c/8747bf36f312356f8a295a0c39ff092d65ce75ae
[2/3] powerpc/powernv/idle: Rename pnv_first_spr_loss_level variable
https://git.kernel.org/powerpc/c/dcbbfa6b05daca94ebcdbce80a7cf05c717d2942
[3/3] powerpc/powernv/idle: Exclude mfspr on HID1, 4, 5 on P9 and above
https://git.kernel.org/powerpc/c/5c92fb1b46102e1efe0eed69e743f711bc1c7d2e
cheers
^ permalink raw reply
* Re: [PATCH] powerpc/64: Fix an out of date comment about MMIO ordering
From: Michael Ellerman @ 2020-07-24 13:25 UTC (permalink / raw)
To: Palmer Dabbelt, Will Deacon
Cc: kernel-team, jniethe5, bigeasy, Palmer Dabbelt, linux-kernel,
npiggin, paulus, tglx, msuchanek, linuxppc-dev
In-Reply-To: <20200716193820.1141936-1-palmer@dabbelt.com>
On Thu, 16 Jul 2020 12:38:20 -0700, Palmer Dabbelt wrote:
> This primitive has been renamed, but because it was spelled incorrectly in the
> first place it must have escaped the fixup patch. As far as I can tell this
> logic is still correct: smp_mb__after_spinlock() uses the default smp_mb()
> implementation, which is "sync" rather than "hwsync" but those are the same
> (though I'm not that familiar with PowerPC).
Applied to powerpc/next.
[1/1] powerpc/64: Fix an out of date comment about MMIO ordering
https://git.kernel.org/powerpc/c/147c13413c04bc6a2bd76f2503402905e5e98cff
cheers
^ permalink raw reply
* Re: [PATCH v3] powerpc: select ARCH_HAS_MEMBARRIER_SYNC_CORE
From: Michael Ellerman @ 2020-07-24 13:25 UTC (permalink / raw)
To: linuxppc-dev, Nicholas Piggin
Cc: linux-arch, Andreas Schwab, Mathieu Desnoyers
In-Reply-To: <20200716013522.338318-1-npiggin@gmail.com>
On Thu, 16 Jul 2020 11:35:22 +1000, Nicholas Piggin wrote:
> powerpc return from interrupt and return from system call sequences are
> context synchronising.
Applied to powerpc/next.
[1/1] powerpc: Select ARCH_HAS_MEMBARRIER_SYNC_CORE
https://git.kernel.org/powerpc/c/2384b36f9156c3b815a5ce5f694edc5054ab7625
cheers
^ permalink raw reply
* Re: [PATCH v2 0/3] remove PROT_SAO support and disable
From: Michael Ellerman @ 2020-07-24 13:25 UTC (permalink / raw)
To: linuxppc-dev, Nicholas Piggin; +Cc: linux-api, kvm-ppc, linux-mm
In-Reply-To: <20200703011958.1166620-1-npiggin@gmail.com>
On Fri, 3 Jul 2020 11:19:55 +1000, Nicholas Piggin wrote:
> It was suggested that I post this to a wider audience on account of
> the change to supported userspace features in patch 2 particularly.
>
> Thanks,
> Nick
>
> Nicholas Piggin (3):
> powerpc: remove stale calc_vm_prot_bits comment
> powerpc/64s: remove PROT_SAO support
> powerpc/64s/hash: disable subpage_prot syscall by default
>
> [...]
Applied to powerpc/next.
[1/3] powerpc: Remove stale calc_vm_prot_bits() comment
https://git.kernel.org/powerpc/c/f4ac1774f2cba44994ce9ac0a65772e4656ac2df
[2/3] powerpc/64s: Remove PROT_SAO support
https://git.kernel.org/powerpc/c/5c9fa16e8abd342ce04dc830c1ebb2a03abf6c05
[3/3] powerpc/64s/hash: Disable subpage_prot syscall by default
https://git.kernel.org/powerpc/c/63396ada804c676e070bd1b8663046f18698ab27
cheers
^ permalink raw reply
* Re: [PATCH] powerpc/powernv: machine check handler for POWER10
From: Michael Ellerman @ 2020-07-24 13:25 UTC (permalink / raw)
To: linuxppc-dev, Nicholas Piggin; +Cc: Mahesh Salgaonkar
In-Reply-To: <20200702233343.1128026-1-npiggin@gmail.com>
On Fri, 3 Jul 2020 09:33:43 +1000, Nicholas Piggin wrote:
>
Applied to powerpc/next.
[1/1] powerpc/powernv: Machine check handler for POWER10
https://git.kernel.org/powerpc/c/201220bb0e8cbc163ec7f550b3b7b3da46eb5877
cheers
^ permalink raw reply
* Re: [PATCH v2] powerpc/spufs: Rework fcheck() usage
From: Michael Ellerman @ 2020-07-24 13:25 UTC (permalink / raw)
To: Michael Ellerman, linuxppc-dev; +Cc: hch, jk
In-Reply-To: <20200508130633.2532759-1-mpe@ellerman.id.au>
On Fri, 8 May 2020 23:06:33 +1000, Michael Ellerman wrote:
> Currently the spu coredump code triggers an RCU warning:
>
> =============================
> WARNING: suspicious RCU usage
> 5.7.0-rc3-01755-g7cd49f0b7ec7 #1 Not tainted
> -----------------------------
> include/linux/fdtable.h:95 suspicious rcu_dereference_check() usage!
>
> [...]
Applied to powerpc/next.
[1/1] powerpc/spufs: Rework fcheck() usage
https://git.kernel.org/powerpc/c/38b407be172d3d15afdbfe172691b7caad98120f
cheers
^ permalink raw reply
* Re: [PATCH 1/2] powerpc/64s/exception: treat NIA below __end_interrupts as soft-masked
From: Michael Ellerman @ 2020-07-24 13:25 UTC (permalink / raw)
To: linuxppc-dev, Nicholas Piggin; +Cc: linux-api, musl, libc-dev
In-Reply-To: <20200611081203.995112-2-npiggin@gmail.com>
On Thu, 11 Jun 2020 18:12:02 +1000, Nicholas Piggin wrote:
> The scv instruction causes an interrupt which can enter the kernel with
> MSR[EE]=1, thus allowing interrupts to hit at any time. These must not
> be taken as normal interrupts, because they come from MSR[PR]=0 context,
> and yet the kernel stack is not yet set up and r13 is not set to the
> PACA).
>
> Treat this as a soft-masked interrupt regardless of the soft masked
> state. This does not affect behaviour yet, because currently all
> interrupts are taken with MSR[EE]=0.
Applied to powerpc/next.
[1/2] powerpc/64s/exception: treat NIA below __end_interrupts as soft-masked
https://git.kernel.org/powerpc/c/b2dc2977cba48990df45e0a96150663d4f342700
[2/2] powerpc/64s: system call support for scv/rfscv instructions
https://git.kernel.org/powerpc/c/7fa95f9adaee7e5cbb195d3359741120829e488b
cheers
^ permalink raw reply
* Re: [PATCH] selftests/powerpc: Add test of memcmp at end of page
From: Michael Ellerman @ 2020-07-24 13:24 UTC (permalink / raw)
To: Michael Ellerman, linuxppc-dev
In-Reply-To: <20200722055315.962391-1-mpe@ellerman.id.au>
On Wed, 22 Jul 2020 15:53:15 +1000, Michael Ellerman wrote:
> Update our memcmp selftest, to test the case where we're comparing up
> to the end of a page and the subsequent page is not mapped. We have to
> make sure we don't read off the end of the page and cause a fault.
>
> We had a bug there in the past, fixed in commit
> d9470757398a ("powerpc/64: Fix memcmp reading past the end of src/dest").
Applied to powerpc/next.
[1/1] selftests/powerpc: Add test of memcmp at end of page
https://git.kernel.org/powerpc/c/8ac9b9d61f0eceba6ce571e7527798465ae9a7c5
cheers
^ permalink raw reply
* Re: [PATCH] selftests/powerpc: Run per_event_excludes test on Power8 or later
From: Michael Ellerman @ 2020-07-24 13:25 UTC (permalink / raw)
To: Michael Ellerman, linuxppc-dev
In-Reply-To: <20200716122142.3776261-1-mpe@ellerman.id.au>
On Thu, 16 Jul 2020 22:21:42 +1000, Michael Ellerman wrote:
> The per_event_excludes test wants to run on Power8 or later. But
> currently it checks that AT_BASE_PLATFORM *equals* power8, which means
> it only runs on Power8.
>
> Fix it to check for the ISA 2.07 feature, which will be set on Power8
> and later CPUs.
Applied to powerpc/next.
[1/1] selftests/powerpc: Run per_event_excludes test on Power8 or later
https://git.kernel.org/powerpc/c/9d1ebe9a98c1d7bf7cfbe1dba0052230c042ecdb
cheers
^ permalink raw reply
* Re: [PATCH] powerpc/perf: fix missing is_sier_aviable() during build
From: Michael Ellerman @ 2020-07-24 13:24 UTC (permalink / raw)
To: Madhavan Srinivasan, mpe; +Cc: Aneesh Kumar K . V, linuxppc-dev
In-Reply-To: <20200614083604.302611-1-maddy@linux.ibm.com>
On Sun, 14 Jun 2020 14:06:04 +0530, Madhavan Srinivasan wrote:
> Compilation error:
>
> arch/powerpc/perf/perf_regs.c:80:undefined reference to `.is_sier_available'
>
> Currently is_sier_available() is part of core-book3s.c.
> But then, core-book3s.c is added to build based on
> CONFIG_PPC_PERF_CTRS. A config with CONFIG_PERF_EVENTS
> and without CONFIG_PPC_PERF_CTRS will have a build break
> because of missing is_sier_available(). Patch adds
> is_sier_available() in asm/perf_event.h to fix the build
> break for configs missing CONFIG_PPC_PERF_CTRS.
Applied to powerpc/next.
[1/1] powerpc/perf: Fix missing is_sier_aviable() during build
https://git.kernel.org/powerpc/c/3c9450c053f88e525b2db1e6990cdf34d14e7696
cheers
^ permalink raw reply
* Re: [PATCH 1/1] KVM/PPC: Fix typo on H_DISABLE_AND_GET hcall
From: Michael Ellerman @ 2020-07-24 13:24 UTC (permalink / raw)
To: Ingo Molnar, Benjamin Herrenschmidt, Bharata B Rao, Mark Rutland,
Michael Ellerman, Jiri Olsa, Peter Zijlstra, Alexander Shishkin,
Arnaldo Carvalho de Melo, Namhyung Kim, Paul Mackerras,
Leonardo Bras, Vaibhav Jain, Sukadev Bhattiprolu
Cc: linuxppc-dev, linux-kernel, kvm-ppc
In-Reply-To: <20200707004812.190765-1-leobras.c@gmail.com>
On Mon, 6 Jul 2020 21:48:12 -0300, Leonardo Bras wrote:
> On PAPR+ the hcall() on 0x1B0 is called H_DISABLE_AND_GET, but got
> defined as H_DISABLE_AND_GETC instead.
>
> This define was introduced with a typo in commit <b13a96cfb055>
> ("[PATCH] powerpc: Extends HCALL interface for InfiniBand usage"), and was
> later used without having the typo noticed.
Applied to powerpc/next.
[1/1] KVM: PPC: Fix typo on H_DISABLE_AND_GET hcall
https://git.kernel.org/powerpc/c/0f10228c6ff6af36cbb31af35b01f76cdb0b3fc1
cheers
^ permalink raw reply
* Re: [PATCH 1/5] powerpc sstep: Add tests for prefixed integer load/stores
From: Michael Ellerman @ 2020-07-24 13:24 UTC (permalink / raw)
To: linuxppc-dev, Jordan Niethe; +Cc: alistair, bala24
In-Reply-To: <20200525025923.19843-1-jniethe5@gmail.com>
On Mon, 25 May 2020 12:59:19 +1000, Jordan Niethe wrote:
> Add tests for the prefixed versions of the integer load/stores that are
> currently tested. This includes the following instructions:
> * Prefixed Load Doubleword (pld)
> * Prefixed Load Word and Zero (plwz)
> * Prefixed Store Doubleword (pstd)
>
> Skip the new tests if ISA v3.1 is unsupported.
Applied to powerpc/next.
[1/5] powerpc/sstep: Add tests for prefixed integer load/stores
https://git.kernel.org/powerpc/c/b6b54b42722a2393056c891c0d05cd8cc40eb776
[2/5] powerpc/sstep: Add tests for prefixed floating-point load/stores
https://git.kernel.org/powerpc/c/0396de6d8561c721b03fce386eb9682b37a26013
[3/5] powerpc/sstep: Set NIP in instruction emulation tests
https://git.kernel.org/powerpc/c/1c89cf7fbed36f078b20fd47d308b4fc6dbff5f6
[4/5] powerpc/sstep: Let compute tests specify a required cpu feature
https://git.kernel.org/powerpc/c/301ebf7d69f6709575d137a41a0291f69f343aed
[5/5] powerpc/sstep: Add tests for Prefixed Add Immediate
https://git.kernel.org/powerpc/c/4f825900786e1c24e4c48622e12eb493a6cd27b6
cheers
^ permalink raw reply
* Re: [PATCH 1/4] powerpc: Add a ppc_inst_as_str() helper
From: Michael Ellerman @ 2020-07-24 13:24 UTC (permalink / raw)
To: Jordan Niethe, linuxppc-dev; +Cc: alistair
In-Reply-To: <20200602052728.18227-1-jniethe5@gmail.com>
On Tue, 2 Jun 2020 15:27:25 +1000, Jordan Niethe wrote:
> There are quite a few places where instructions are printed, this is
> done using a '%x' format specifier. With the introduction of prefixed
> instructions, this does not work well. Currently in these places,
> ppc_inst_val() is used for the value for %x so only the first word of
> prefixed instructions are printed.
>
> When the instructions are word instructions, only a single word should
> be printed. For prefixed instructions both the prefix and suffix should
> be printed. To accommodate both of these situations, instead of a '%x'
> specifier use '%s' and introduce a helper, __ppc_inst_as_str() which
> returns a char *. The char * __ppc_inst_as_str() returns is buffer that
> is passed to it by the caller.
>
> [...]
Patches 1-2 applied to powerpc/next.
[1/4] powerpc: Add a ppc_inst_as_str() helper
https://git.kernel.org/powerpc/c/50428fdc53ba48f6936b10dfdc0d644972403908
[2/4] powerpc/xmon: Improve dumping prefixed instructions
https://git.kernel.org/powerpc/c/8b98afc117aaf825c66d7ddd59f1849e559b42cd
cheers
^ permalink raw reply
* Re: [PATCH] powerpc/spufs: fix the type of ret in spufs_arch_write_note
From: Michael Ellerman @ 2020-07-24 13:24 UTC (permalink / raw)
To: jk, arnd, Christoph Hellwig, mpe; +Cc: linuxppc-dev, kbuild test robot
In-Reply-To: <20200610085554.5647-1-hch@lst.de>
On Wed, 10 Jun 2020 10:55:54 +0200, Christoph Hellwig wrote:
> Both the ->dump method and snprintf return an int. So switch to an
> int and properly handle errors from ->dump.
Applied to powerpc/next.
[1/1] powerpc/spufs: Fix the type of ret in spufs_arch_write_note
https://git.kernel.org/powerpc/c/7c7ff885c7bce40a487e41c68f1dac14dd2c8033
cheers
^ permalink raw reply
* Re: [PATCH] powerpc: Replace HTTP links with HTTPS ones
From: Michael Ellerman @ 2020-07-24 13:24 UTC (permalink / raw)
To: nayna, linuxppc-dev, pfsmorigo, herbert, Alexander A. Klimov,
corbet, davem, linux-doc, paulus, benh, linux-crypto, leitao,
linux-kernel, mpe
In-Reply-To: <20200718103958.5455-1-grandmaster@al2klimov.de>
On Sat, 18 Jul 2020 12:39:58 +0200, Alexander A. Klimov wrote:
> Rationale:
> Reduces attack surface on kernel devs opening the links for MITM
> as HTTPS traffic is much harder to manipulate.
>
> Deterministic algorithm:
> For each file:
> If not .svg:
> For each line:
> If doesn't contain `\bxmlns\b`:
> For each link, `\bhttp://[^# \t\r\n]*(?:\w|/)`:
> If neither `\bgnu\.org/license`, nor `\bmozilla\.org/MPL\b`:
> If both the HTTP and HTTPS versions
> return 200 OK and serve the same content:
> Replace HTTP with HTTPS.
Applied to powerpc/next.
[1/1] powerpc: Replace HTTP links with HTTPS ones
https://git.kernel.org/powerpc/c/c8ed9fc9d29e24dafd08971e6a0c6b302a8ade2d
cheers
^ permalink raw reply
* Re: [PATCH] macintosh/therm_adt746x: Replace HTTP links with HTTPS ones
From: Michael Ellerman @ 2020-07-24 13:24 UTC (permalink / raw)
To: colin, Alexander A. Klimov, linuxppc-dev, linux-kernel, benh
In-Reply-To: <20200717182940.75484-1-grandmaster@al2klimov.de>
On Fri, 17 Jul 2020 20:29:40 +0200, Alexander A. Klimov wrote:
> Rationale:
> Reduces attack surface on kernel devs opening the links for MITM
> as HTTPS traffic is much harder to manipulate.
>
> Deterministic algorithm:
> For each file:
> If not .svg:
> For each line:
> If doesn't contain `\bxmlns\b`:
> For each link, `\bhttp://[^# \t\r\n]*(?:\w|/)`:
> If neither `\bgnu\.org/license`, nor `\bmozilla\.org/MPL\b`:
> If both the HTTP and HTTPS versions
> return 200 OK and serve the same content:
> Replace HTTP with HTTPS.
Applied to powerpc/next.
[1/1] macintosh/therm_adt746x: Replace HTTP links with HTTPS ones
https://git.kernel.org/powerpc/c/1666e5ea2f838f4266e50e4f3d973c0824256429
cheers
^ permalink raw reply
* Re: [PATCH] macintosh/adb: Replace HTTP links with HTTPS ones
From: Michael Ellerman @ 2020-07-24 13:24 UTC (permalink / raw)
To: benh, Alexander A. Klimov, linuxppc-dev, linux-kernel
In-Reply-To: <20200717183522.77605-1-grandmaster@al2klimov.de>
On Fri, 17 Jul 2020 20:35:22 +0200, Alexander A. Klimov wrote:
> Rationale:
> Reduces attack surface on kernel devs opening the links for MITM
> as HTTPS traffic is much harder to manipulate.
>
> Deterministic algorithm:
> For each file:
> If not .svg:
> For each line:
> If doesn't contain `\bxmlns\b`:
> For each link, `\bhttp://[^# \t\r\n]*(?:\w|/)`:
> If neither `\bgnu\.org/license`, nor `\bmozilla\.org/MPL\b`:
> If both the HTTP and HTTPS versions
> return 200 OK and serve the same content:
> Replace HTTP with HTTPS.
Applied to powerpc/next.
[1/1] macintosh/adb: Replace HTTP links with HTTPS ones
https://git.kernel.org/powerpc/c/a7beab413e2e67dd1abe6bdd0001576892a89e81
cheers
^ permalink raw reply
page: next (older) | prev (newer) | latest
- recent:[subjects (threaded)|topics (new)|topics (active)]
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox