* Re: [PATCH 15/20] dt-bindings: usb: meson-g12a-usb: Validate DWC2/DWC3 sub-nodes
From: Rob Herring @ 2020-10-16 18:54 UTC (permalink / raw)
To: Serge Semin
Cc: Neil Armstrong, linux-kernel, Pavel Parkhomenko, Jerome Brunet,
Kevin Hilman, Andy Gross, linux-snps-arc, devicetree,
Mathias Nyman, Martin Blumenstingl, Lad Prabhakar, Alexey Malahov,
Rob Herring, linux-amlogic, Bjorn Andersson, linux-arm-kernel,
Roger Quadros, Felipe Balbi, Greg Kroah-Hartman,
Yoshihiro Shimoda, linux-usb, linux-mips, Serge Semin,
Manu Gautam, linuxppc-dev
In-Reply-To: <20201014101402.18271-16-Sergey.Semin@baikalelectronics.ru>
On Wed, 14 Oct 2020 13:13:57 +0300, Serge Semin wrote:
> Amlogic G12A USB DT sub-nodes are supposed to be compatible with the
> generic DWC USB2 and USB3 devices. Since now we've got DT schemas for
> both of the later IP cores let's make sure that the Amlogic G12A USB
> DT nodes are fully evaluated including the DWC sub-nodes.
>
> Signed-off-by: Serge Semin <Sergey.Semin@baikalelectronics.ru>
> Reviewed-by: Neil Armstrong <narmstrong@baylibre.com>
>
> ---
>
> Changelog v2:
> - Use "oneOf: [dwc2.yaml#, snps,dwc3.yaml#]" instead of the bulky "if:
> properties: compatibe: ..." statement.
> ---
> .../devicetree/bindings/usb/amlogic,meson-g12a-usb-ctrl.yaml | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
Reviewed-by: Rob Herring <robh@kernel.org>
^ permalink raw reply
* Re: [PATCH 14/20] dt-bindings: usb: meson-g12a-usb: Fix FL-adj property value
From: Rob Herring @ 2020-10-16 18:54 UTC (permalink / raw)
To: Serge Semin
Cc: Neil Armstrong, Bjorn Andersson, Pavel Parkhomenko, Jerome Brunet,
Kevin Hilman, Andy Gross, linux-snps-arc, devicetree,
Mathias Nyman, Martin Blumenstingl, Lad Prabhakar, Alexey Malahov,
Rob Herring, linux-amlogic, linux-arm-kernel, Roger Quadros,
Felipe Balbi, Greg Kroah-Hartman, Yoshihiro Shimoda, linux-usb,
linux-mips, Serge Semin, linux-kernel, Manu Gautam, linuxppc-dev
In-Reply-To: <20201014101402.18271-15-Sergey.Semin@baikalelectronics.ru>
On Wed, 14 Oct 2020 13:13:56 +0300, Serge Semin wrote:
> An empty snps,quirk-frame-length-adjustment won't cause any change
> performed by the driver. Moreover the DT schema validation will fail,
> since it expects the property being assigned with some value. So set
> fix the example by setting a valid FL-adj value in accordance with
> Neil Armstrong comment.
>
> Link: https://lore.kernel.org/linux-usb/20201010224121.12672-16-Sergey.Semin@baikalelectronics.ru/
> Signed-off-by: Serge Semin <Sergey.Semin@baikalelectronics.ru>
> Acked-by: Neil Armstrong <narmstrong@baylibre.com>
>
> ---
>
> Note the same problem is in the DT source file
> arch/arm64/boot/dts/amlogic/meson-g12-common.dtsi .
> ---
> .../devicetree/bindings/usb/amlogic,meson-g12a-usb-ctrl.yaml | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
Reviewed-by: Rob Herring <robh@kernel.org>
^ permalink raw reply
* Re: [PATCH 13/20] dt-bindings: usb: dwc3: Add Frame Length Adj restrictions
From: Rob Herring @ 2020-10-16 18:54 UTC (permalink / raw)
To: Serge Semin
Cc: Neil Armstrong, Bjorn Andersson, Pavel Parkhomenko, Kevin Hilman,
Andy Gross, linux-snps-arc, devicetree, Mathias Nyman,
Lad Prabhakar, Alexey Malahov, Rob Herring, linux-arm-kernel,
Roger Quadros, Felipe Balbi, Greg Kroah-Hartman,
Yoshihiro Shimoda, linux-usb, linux-mips, Serge Semin,
linux-kernel, Manu Gautam, linuxppc-dev
In-Reply-To: <20201014101402.18271-14-Sergey.Semin@baikalelectronics.ru>
On Wed, 14 Oct 2020 13:13:55 +0300, Serge Semin wrote:
> In accordance with the IP core databook the
> snps,quirk-frame-length-adjustment property can be set within [0, 0x3F].
> Let's make sure the DT schema applies a correct restriction on the
> property.
>
> Signed-off-by: Serge Semin <Sergey.Semin@baikalelectronics.ru>
> ---
> Documentation/devicetree/bindings/usb/snps,dwc3.yaml | 2 ++
> 1 file changed, 2 insertions(+)
>
Reviewed-by: Rob Herring <robh@kernel.org>
^ permalink raw reply
* Re: [PATCH 12/20] dt-bindings: usb: dwc3: Add Tx De-emphasis restrictions
From: Rob Herring @ 2020-10-16 18:54 UTC (permalink / raw)
To: Serge Semin
Cc: Neil Armstrong, Bjorn Andersson, Pavel Parkhomenko, Kevin Hilman,
Andy Gross, linux-snps-arc, devicetree, Mathias Nyman,
Lad Prabhakar, Alexey Malahov, Rob Herring, linux-arm-kernel,
Roger Quadros, Felipe Balbi, Greg Kroah-Hartman,
Yoshihiro Shimoda, linux-usb, linux-mips, Serge Semin,
linux-kernel, Manu Gautam, linuxppc-dev
In-Reply-To: <20201014101402.18271-13-Sergey.Semin@baikalelectronics.ru>
On Wed, 14 Oct 2020 13:13:54 +0300, Serge Semin wrote:
> In accordance with the driver comments the PIPE3 de-emphasis can be tuned
> to be either -6dB, -2.5dB or disabled. Let's add the de-emphasis
> property restriction so the DT schema would make sure the controller DT
> node is equipped with correct value.
>
> Signed-off-by: Serge Semin <Sergey.Semin@baikalelectronics.ru>
>
> ---
>
> Changelog v2:
> - Grammar fix: "s/tunned/tuned"
> - Grammar fix: remove redundant "or" conjunction.
> ---
> Documentation/devicetree/bindings/usb/snps,dwc3.yaml | 4 ++++
> 1 file changed, 4 insertions(+)
>
Reviewed-by: Rob Herring <robh@kernel.org>
^ permalink raw reply
* Re: [PATCH 11/20] dt-bindings: usb: dwc3: Add synopsys,dwc3 compatible string
From: Rob Herring @ 2020-10-16 18:53 UTC (permalink / raw)
To: Serge Semin
Cc: Neil Armstrong, linux-kernel, Pavel Parkhomenko, Kevin Hilman,
Krzysztof Kozlowski, Andy Gross, linux-snps-arc, devicetree,
Mathias Nyman, Lad Prabhakar, Alexey Malahov, Bjorn Andersson,
linux-arm-kernel, Roger Quadros, Felipe Balbi, Greg Kroah-Hartman,
Yoshihiro Shimoda, linux-usb, linux-mips, Serge Semin,
Manu Gautam, linuxppc-dev
In-Reply-To: <20201014213554.turskjyuntk35syj@mobilestation>
On Thu, Oct 15, 2020 at 12:35:54AM +0300, Serge Semin wrote:
> On Wed, Oct 14, 2020 at 10:18:18PM +0200, Krzysztof Kozlowski wrote:
> > On Wed, Oct 14, 2020 at 01:13:53PM +0300, Serge Semin wrote:
> > > The DWC USB3 driver and some DTS files like Exynos 5250, Keystone k2e, etc
> > > expects the DWC USB3 DT node to have the compatible string with the
> > > "synopsys" vendor prefix. Let's add the corresponding compatible string to
> > > the controller DT schema, but mark it as deprecated seeing the Synopsys,
> > > Inc. is presented with just "snps" vendor prefix.
> >
>
> > Instead of adding deprecated schema just correct the DTSes to use snps.
> > The "synopsys" is not even in vendor prefixes.
>
> Yeah, it's not, but the driver and some dts'es use it this way. I am not sure
> that the solution suggested by you is much better than mine. So let's hear the
> Rob'es opinion out in this matter. @Rob, what do you think?
I think we should fix the dts files given there's only 5.
Rob
^ permalink raw reply
* Re: [PATCH 10/20] dt-bindings: usb: dwc3: Add interrupt-names property support
From: Rob Herring @ 2020-10-16 18:50 UTC (permalink / raw)
To: Serge Semin
Cc: Neil Armstrong, linux-mips, Pavel Parkhomenko, Kevin Hilman,
Andy Gross, linux-snps-arc, devicetree, Mathias Nyman,
Lad Prabhakar, Alexey Malahov, Rob Herring, Bjorn Andersson,
linux-arm-kernel, Roger Quadros, Felipe Balbi, Greg Kroah-Hartman,
Yoshihiro Shimoda, linux-usb, linux-kernel, Serge Semin,
Manu Gautam, linuxppc-dev
In-Reply-To: <20201014101402.18271-11-Sergey.Semin@baikalelectronics.ru>
On Wed, 14 Oct 2020 13:13:52 +0300, Serge Semin wrote:
> The controller driver supports two types of DWC USB3 devices: with a
> common interrupt lane and with individual interrupts for each mode. Add
> support for both these cases to the DWC USB3 DT schema.
>
> Signed-off-by: Serge Semin <Sergey.Semin@baikalelectronics.ru>
>
> ---
>
> Changelog v2:
> - Grammar fix: "s/both of these cases support/support for both these cases"
> - Drop quotes from around the string constants.
> ---
> Documentation/devicetree/bindings/usb/snps,dwc3.yaml | 11 +++++++++++
> 1 file changed, 11 insertions(+)
>
Reviewed-by: Rob Herring <robh@kernel.org>
^ permalink raw reply
* Re: [PATCH 08/20] dt-bindings: usb: renesas-xhci: Refer to the usb-xhci.yaml file
From: Rob Herring @ 2020-10-16 18:50 UTC (permalink / raw)
To: Serge Semin
Cc: Neil Armstrong, linux-kernel, Pavel Parkhomenko, Kevin Hilman,
Andy Gross, linux-snps-arc, devicetree, Mathias Nyman,
Lad Prabhakar, Alexey Malahov, Rob Herring, Bjorn Andersson,
linux-arm-kernel, Roger Quadros, Felipe Balbi, Greg Kroah-Hartman,
Yoshihiro Shimoda, linux-usb, linux-mips, Serge Semin,
Manu Gautam, linuxppc-dev
In-Reply-To: <20201014101402.18271-9-Sergey.Semin@baikalelectronics.ru>
On Wed, 14 Oct 2020 13:13:50 +0300, Serge Semin wrote:
> With minor peculiarities (like uploading some vendor-specific firmware)
> these are just Generic xHCI controllers fully compatible with its
> properties. Make sure the Renesas USB xHCI DT nodes are also validated
> against the Generic xHCI DT schema.
>
> Signed-off-by: Serge Semin <Sergey.Semin@baikalelectronics.ru>
> ---
> Documentation/devicetree/bindings/usb/renesas,usb-xhci.yaml | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
Reviewed-by: Rob Herring <robh@kernel.org>
^ permalink raw reply
* Re: [PATCH 07/20] dt-bindings: usb: xhci: Add Broadcom STB v2 compatible device
From: Rob Herring @ 2020-10-16 18:49 UTC (permalink / raw)
To: Serge Semin
Cc: Neil Armstrong, Bjorn Andersson, Pavel Parkhomenko, Kevin Hilman,
Andy Gross, linux-snps-arc, devicetree, Mathias Nyman,
Lad Prabhakar, Alexey Malahov, Rob Herring, linux-arm-kernel,
Roger Quadros, Felipe Balbi, Greg Kroah-Hartman,
Yoshihiro Shimoda, linux-usb, linux-mips, Serge Semin,
linux-kernel, Manu Gautam, linuxppc-dev
In-Reply-To: <20201014101402.18271-8-Sergey.Semin@baikalelectronics.ru>
On Wed, 14 Oct 2020 13:13:49 +0300, Serge Semin wrote:
> For some reason the "brcm,xhci-brcm-v2" compatible string has been missing
> in the original bindings file. Add it to the Generic xHCI Controllers DT
> schema since the controller driver expects it to be supported.
>
> Signed-off-by: Serge Semin <Sergey.Semin@baikalelectronics.ru>
> ---
> Documentation/devicetree/bindings/usb/generic-xhci.yaml | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
Reviewed-by: Rob Herring <robh@kernel.org>
^ permalink raw reply
* Re: [PATCH 06/20] dt-bindings: usb: Convert xHCI bindings to DT schema
From: Rob Herring @ 2020-10-16 18:49 UTC (permalink / raw)
To: Serge Semin
Cc: Neil Armstrong, linux-kernel, Pavel Parkhomenko, Kevin Hilman,
Andy Gross, linux-snps-arc, devicetree, Mathias Nyman,
Lad Prabhakar, Alexey Malahov, Rob Herring, Bjorn Andersson,
linux-arm-kernel, Roger Quadros, Felipe Balbi, Greg Kroah-Hartman,
Yoshihiro Shimoda, linux-usb, linux-mips, Serge Semin,
Manu Gautam, linuxppc-dev
In-Reply-To: <20201014101402.18271-7-Sergey.Semin@baikalelectronics.ru>
On Wed, 14 Oct 2020 13:13:48 +0300, Serge Semin wrote:
> Currently the DT bindings of Generic xHCI Controllers are described by means
> of the legacy text file. Since such format is deprecated in favor of the
> DT schema, let's convert the Generic xHCI Controllers bindings file to the
> corresponding yaml files. There will be two of them: a DT schema for the
> xHCI controllers on a generic platform and a DT schema validating a generic
> xHCI controllers properties. The later will be used to validate the xHCI
> controllers, which aside from some vendor-specific features support the
> basic xHCI functionality.
>
> An xHCI-compatible DT node shall support the standard USB HCD properties
> and custom ones like: usb2-lpm-disable, usb3-lpm-capable,
> quirk-broken-port-ped and imod-interval-ns. In addition if a generic xHCI
> controller is being validated against the DT schema it is also supposed to
> be equipped with mandatory compatible string, single registers range,
> single interrupts source, and is supposed to optionally contain up to two
> reference clocks for the controller core and CSRs.
>
> Signed-off-by: Serge Semin <Sergey.Semin@baikalelectronics.ru>
>
> ---
>
> Changelog v2:
> - Add explicit "additionalProperties: true" to the usb-xhci.yaml schema,
> since additionalProperties/unevaluatedProperties are going to be mandary
> for each binding.
> ---
> .../devicetree/bindings/usb/generic-xhci.yaml | 63 +++++++++++++++++++
> .../devicetree/bindings/usb/usb-xhci.txt | 41 ------------
> .../devicetree/bindings/usb/usb-xhci.yaml | 42 +++++++++++++
> 3 files changed, 105 insertions(+), 41 deletions(-)
> create mode 100644 Documentation/devicetree/bindings/usb/generic-xhci.yaml
> delete mode 100644 Documentation/devicetree/bindings/usb/usb-xhci.txt
> create mode 100644 Documentation/devicetree/bindings/usb/usb-xhci.yaml
>
Reviewed-by: Rob Herring <robh@kernel.org>
^ permalink raw reply
* Re: [PATCH 05/20] dt-bindings: usb: usb-hcd: Add generic "usb-phy" property
From: Rob Herring @ 2020-10-16 18:47 UTC (permalink / raw)
To: Serge Semin
Cc: Neil Armstrong, linux-kernel, Pavel Parkhomenko, Kevin Hilman,
Andy Gross, linux-snps-arc, devicetree, Mathias Nyman,
Lad Prabhakar, Alexey Malahov, Rob Herring, Bjorn Andersson,
linux-arm-kernel, Roger Quadros, Felipe Balbi, Greg Kroah-Hartman,
Yoshihiro Shimoda, linux-usb, linux-mips, Serge Semin,
Manu Gautam, linuxppc-dev
In-Reply-To: <20201014101402.18271-6-Sergey.Semin@baikalelectronics.ru>
On Wed, 14 Oct 2020 13:13:47 +0300, Serge Semin wrote:
> Even though the Generic PHY framework is the more preferable way of
> setting the USB PHY up, there are still many dts-files and DT bindings
> which rely on having the legacy "usb-phy" specified to attach particular
> USB PHYs to USB cores. Let's have the "usb-phy" property described in
> the generic USB HCD binding file so it would be validated against the
> nodes in which it's specified. Mark the property as deprecated to
> discourage the developers from using it.
>
> Signed-off-by: Serge Semin <Sergey.Semin@baikalelectronics.ru>
>
> ---
>
> Changelog v2:
> - Discard '|' from the property description, since we don't need to preserve
> the text formatting.
> ---
> Documentation/devicetree/bindings/usb/usb-hcd.yaml | 7 +++++++
> 1 file changed, 7 insertions(+)
>
Reviewed-by: Rob Herring <robh@kernel.org>
^ permalink raw reply
* Re: [PATCH 04/20] dt-bindings: usb: usb-hcd: Add "tpl-support" property
From: Rob Herring @ 2020-10-16 18:47 UTC (permalink / raw)
To: Serge Semin
Cc: Neil Armstrong, linux-mips, Pavel Parkhomenko, Kevin Hilman,
Andy Gross, linux-snps-arc, devicetree, Mathias Nyman,
Lad Prabhakar, Alexey Malahov, Rob Herring, Bjorn Andersson,
linux-arm-kernel, Roger Quadros, Felipe Balbi, Greg Kroah-Hartman,
Yoshihiro Shimoda, linux-usb, linux-kernel, Serge Semin,
Manu Gautam, linuxppc-dev
In-Reply-To: <20201014101402.18271-5-Sergey.Semin@baikalelectronics.ru>
On Wed, 14 Oct 2020 13:13:46 +0300, Serge Semin wrote:
> The host controller device might be designed to work for the particular
> products or applications. In that case its DT node is supposed to be
> equipped with the tpl-support property.
>
> Signed-off-by: Serge Semin <Sergey.Semin@baikalelectronics.ru>
>
> ---
>
> Changelog v2:
> - Grammar fix: "s/it'/its"
> - Discard '|' from the property description, since we don't need to preserve
> the text formatting.
> ---
> Documentation/devicetree/bindings/usb/usb-hcd.yaml | 6 ++++++
> 1 file changed, 6 insertions(+)
>
Reviewed-by: Rob Herring <robh@kernel.org>
^ permalink raw reply
* Re: [PATCH 03/20] dt-bindings: usb: usb-hcd: Add "ulpi/serial/hsic" PHY types
From: Rob Herring @ 2020-10-16 18:34 UTC (permalink / raw)
To: Serge Semin
Cc: Neil Armstrong, linux-mips, Pavel Parkhomenko, Kevin Hilman,
Andy Gross, linux-snps-arc, devicetree, Mathias Nyman,
Lad Prabhakar, Alexey Malahov, Rob Herring, Bjorn Andersson,
linux-arm-kernel, Roger Quadros, Felipe Balbi, Greg Kroah-Hartman,
Yoshihiro Shimoda, linux-usb, linux-kernel, Serge Semin,
Manu Gautam, linuxppc-dev
In-Reply-To: <20201014101402.18271-4-Sergey.Semin@baikalelectronics.ru>
On Wed, 14 Oct 2020 13:13:45 +0300, Serge Semin wrote:
> Aside from the UTMI+ there are also ULPI, Serial and HSIC PHY types
> that can be specified in the phy_type HCD property. Add them to the
> enumeration of the acceptable values.
>
> Signed-off-by: Serge Semin <Sergey.Semin@baikalelectronics.ru>
>
> ---
>
> Changelog v2:
> - Grammar fix: "s/PHY types can be/PHY types that can be"
> - Drop quotes from around the string constants.
> ---
> Documentation/devicetree/bindings/usb/usb-hcd.yaml | 10 ++++++----
> 1 file changed, 6 insertions(+), 4 deletions(-)
>
Reviewed-by: Rob Herring <robh@kernel.org>
^ permalink raw reply
* Re: [PATCH 02/20] dt-bindings: usb: usb-hcd: Add "otg-rev" property restriction
From: Rob Herring @ 2020-10-16 18:33 UTC (permalink / raw)
To: Serge Semin
Cc: Neil Armstrong, linux-kernel, Pavel Parkhomenko, Kevin Hilman,
Andy Gross, linux-snps-arc, devicetree, Mathias Nyman,
Lad Prabhakar, Alexey Malahov, Rob Herring, Bjorn Andersson,
linux-arm-kernel, Roger Quadros, Felipe Balbi, Greg Kroah-Hartman,
Yoshihiro Shimoda, linux-usb, linux-mips, Serge Semin,
Manu Gautam, linuxppc-dev
In-Reply-To: <20201014101402.18271-3-Sergey.Semin@baikalelectronics.ru>
On Wed, 14 Oct 2020 13:13:44 +0300, Serge Semin wrote:
> There are only four OTG revisions are currently supported by the kernel:
> 0x0100, 0x0120, 0x0130, 0x0200. Any another value is considered as
> invalid.
>
> Signed-off-by: Serge Semin <Sergey.Semin@baikalelectronics.ru>
> ---
> Documentation/devicetree/bindings/usb/usb-hcd.yaml | 1 +
> 1 file changed, 1 insertion(+)
>
Reviewed-by: Rob Herring <robh@kernel.org>
^ permalink raw reply
* Re: [PATCH 01/20] dt-bindings: usb: usb-hcd: Convert generic USB properties to DT schema
From: Rob Herring @ 2020-10-16 18:33 UTC (permalink / raw)
To: Serge Semin
Cc: Neil Armstrong, linux-kernel, Pavel Parkhomenko, Kevin Hilman,
Andy Gross, linux-snps-arc, devicetree, Mathias Nyman,
Lad Prabhakar, Alexey Malahov, Rob Herring, Bjorn Andersson,
linux-arm-kernel, Roger Quadros, Felipe Balbi, Greg Kroah-Hartman,
Yoshihiro Shimoda, linux-usb, linux-mips, Serge Semin,
Manu Gautam, linuxppc-dev
In-Reply-To: <20201014101402.18271-2-Sergey.Semin@baikalelectronics.ru>
On Wed, 14 Oct 2020 13:13:43 +0300, Serge Semin wrote:
> The generic USB HCD properties have been described in the legacy bindings
> text file: Documentation/devicetree/bindings/usb/generic.txt . Let's
> convert it' content into the USB HCD DT schema properties so all USB DT
> nodes would be validated to have them properly utilized.
>
> Signed-off-by: Serge Semin <Sergey.Semin@baikalelectronics.ru>
>
> ---
>
> Changelog v2:
> - Discard '|' in all the new properties, since we don't need to preserve
> the text formatting.
> - Convert abbreviated form of the "maximum-speed" enum restriction into
> the multi-lined version of the list.
> - Drop quotes from around the string constants.
> ---
> .../devicetree/bindings/usb/generic.txt | 57 ------------
> .../devicetree/bindings/usb/usb-hcd.yaml | 88 +++++++++++++++++++
> 2 files changed, 88 insertions(+), 57 deletions(-)
> delete mode 100644 Documentation/devicetree/bindings/usb/generic.txt
>
Reviewed-by: Rob Herring <robh@kernel.org>
^ permalink raw reply
* Re: [PATCH v4 2/2] ASoC: dt-bindings: fsl_xcvr: Add document for XCVR
From: Rob Herring @ 2020-10-16 17:17 UTC (permalink / raw)
To: Viorel Suman (OSS)
Cc: devicetree, alsa-devel, Fabio Estevam, Matthias Schiffer,
Philipp Zabel, Timur Tabi, Xiubo Li, Shengjiu Wang, Mark Brown,
Takashi Iwai, Jaroslav Kysela, Nicolin Chen, Rob Herring,
Viorel Suman, Liam Girdwood, Cosmin-Gabriel Samoila, linuxppc-dev,
linux-kernel
In-Reply-To: <20201013121733.83684-3-viorel.suman@oss.nxp.com>
On Tue, 13 Oct 2020 15:17:33 +0300, Viorel Suman (OSS) wrote:
> From: Viorel Suman <viorel.suman@nxp.com>
>
> XCVR (Audio Transceiver) is a new IP module found on i.MX8MP.
>
> Signed-off-by: Viorel Suman <viorel.suman@nxp.com>
> ---
> .../devicetree/bindings/sound/fsl,xcvr.yaml | 104 ++++++++++++++++++
> 1 file changed, 104 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/sound/fsl,xcvr.yaml
>
Reviewed-by: Rob Herring <robh@kernel.org>
^ permalink raw reply
* Re: [PATCH 04/20] dt-bindings: usb: usb-hcd: Add "tpl-support" property
From: Rob Herring @ 2020-10-16 15:44 UTC (permalink / raw)
To: Serge Semin
Cc: linux-arm-kernel, devicetree, linux-snps-arc, Mathias Nyman,
Neil Armstrong, Greg Kroah-Hartman, Lad Prabhakar, linux-usb,
linux-mips, Serge Semin, Alexey Malahov, Manu Gautam, Andy Gross,
Bjorn Andersson, Pavel Parkhomenko, Kevin Hilman, Felipe Balbi,
linuxppc-dev, Yoshihiro Shimoda, linux-kernel, Roger Quadros
In-Reply-To: <20201014172710.iay3lvb37saeksaj@mobilestation>
On Wed, Oct 14, 2020 at 08:27:10PM +0300, Serge Semin wrote:
> On Wed, Oct 14, 2020 at 08:27:56AM -0500, Rob Herring wrote:
> > On Wed, 14 Oct 2020 13:13:46 +0300, Serge Semin wrote:
> > > The host controller device might be designed to work for the particular
> > > products or applications. In that case its DT node is supposed to be
> > > equipped with the tpl-support property.
> > >
> > > Signed-off-by: Serge Semin <Sergey.Semin@baikalelectronics.ru>
> > >
> > > ---
> > >
> > > Changelog v2:
> > > - Grammar fix: "s/it'/its"
> > > - Discard '|' from the property description, since we don't need to preserve
> > > the text formatting.
> > > ---
> > > Documentation/devicetree/bindings/usb/usb-hcd.yaml | 6 ++++++
> > > 1 file changed, 6 insertions(+)
> > >
> >
> >
> > My bot found errors running 'make dt_binding_check' on your patch:
> >
> > Traceback (most recent call last):
> > File "/usr/local/bin/dt-extract-example", line 45, in <module>
> > binding = yaml.load(open(args.yamlfile, encoding='utf-8').read())
> > File "/usr/local/lib/python3.8/dist-packages/ruamel/yaml/main.py", line 343, in load
> > return constructor.get_single_data()
> > File "/usr/local/lib/python3.8/dist-packages/ruamel/yaml/constructor.py", line 111, in get_single_data
> > node = self.composer.get_single_node()
> > File "_ruamel_yaml.pyx", line 706, in _ruamel_yaml.CParser.get_single_node
> > File "_ruamel_yaml.pyx", line 724, in _ruamel_yaml.CParser._compose_document
> > File "_ruamel_yaml.pyx", line 775, in _ruamel_yaml.CParser._compose_node
> > File "_ruamel_yaml.pyx", line 891, in _ruamel_yaml.CParser._compose_mapping_node
> > File "_ruamel_yaml.pyx", line 904, in _ruamel_yaml.CParser._parse_next_event
> > ruamel.yaml.scanner.ScannerError: mapping values are not allowed in this context
> > in "<unicode string>", line 27, column 14
> > make[1]: *** [Documentation/devicetree/bindings/Makefile:20: Documentation/devicetree/bindings/usb/usb-hcd.example.dts] Error 1
> > make[1]: *** Deleting file 'Documentation/devicetree/bindings/usb/usb-hcd.example.dts'
> > make[1]: *** Waiting for unfinished jobs....
> > ./Documentation/devicetree/bindings/usb/usb-hcd.yaml:27:14: [error] syntax error: mapping values are not allowed here (syntax)
> > make[1]: *** [Documentation/devicetree/bindings/Makefile:59: Documentation/devicetree/bindings/processed-schema-examples.json] Error 123
> > make: *** [Makefile:1366: dt_binding_check] Error 2
> >
> >
> > See https://patchwork.ozlabs.org/patch/1382001
> >
> > If you already ran 'make dt_binding_check' and didn't see the above
> > error(s), then make sure dt-schema is up to date:
> >
> > pip3 install git+https://github.com/devicetree-org/dt-schema.git@master --upgrade
> >
> > Please check and re-submit.
>
> Hm, that's weird. Of course I did the dt_binding_check before submission, but
> even after the dt-schema repo update I failed to see the error:
>
> $ make -j8 ARCH=mips CROSS_COMPILE=mipsel-baikal-linux- dt_binding_check DT_SCHEMA_FILES=Documentation/devicetree/bindings/usb/usb-hcd.yaml
> CHKDT Documentation/devicetree/bindings/usb/usb-hcd.yaml
> SCHEMA Documentation/devicetree/bindings/processed-schema-examples.yaml
> DTC Documentation/devicetree/bindings/usb/usb-hcd.example.dt.yaml
> CHECK Documentation/devicetree/bindings/usb/usb-hcd.example.dt.yaml
>
> Rob, any idea why has the bot got mad at me?
Humm, I'm not sure. We'll see if it happens again when you send v2.
Note that yamllint is also run now and that's the line with '[error]'.
So neither yamllint nor ruamel are happy (could be the same parser code
ultimately).
Rob
^ permalink raw reply
* [powerpc:next] BUILD SUCCESS ffd0b25ca049a477cb757e5bcf2d5e1664d12e5d
From: kernel test robot @ 2020-10-16 15:08 UTC (permalink / raw)
To: Michael Ellerman; +Cc: linuxppc-dev
tree/branch: https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git next
branch HEAD: ffd0b25ca049a477cb757e5bcf2d5e1664d12e5d Revert "powerpc/pci: unmap legacy INTx interrupts when a PHB is removed"
elapsed time: 1663m
configs tested: 197
configs skipped: 2
The following configs have been built successfully.
More configs may be tested in the coming days.
gcc tested configs:
arm defconfig
arm64 allyesconfig
arm64 defconfig
arm allyesconfig
arm allmodconfig
arm h3600_defconfig
sh apsh4ad0a_defconfig
s390 alldefconfig
arm multi_v4t_defconfig
powerpc ppc44x_defconfig
mips tb0287_defconfig
sh sh7724_generic_defconfig
arm netwinder_defconfig
xtensa defconfig
mips e55_defconfig
xtensa audio_kc705_defconfig
m68k mvme147_defconfig
powerpc cell_defconfig
arm collie_defconfig
mips maltaaprp_defconfig
arm cm_x300_defconfig
arm zx_defconfig
powerpc mpc8560_ads_defconfig
mips jmr3927_defconfig
powerpc tqm8555_defconfig
arm alldefconfig
powerpc ps3_defconfig
xtensa generic_kc705_defconfig
arc vdk_hs38_defconfig
powerpc katmai_defconfig
sparc sparc32_defconfig
sh se7780_defconfig
xtensa virt_defconfig
arm lpc18xx_defconfig
arm u300_defconfig
arm colibri_pxa300_defconfig
arm xcep_defconfig
powerpc eiger_defconfig
mips ip32_defconfig
powerpc motionpro_defconfig
mips malta_defconfig
arm lpc32xx_defconfig
arm simpad_defconfig
arm at91_dt_defconfig
arm lart_defconfig
parisc generic-64bit_defconfig
x86_64 alldefconfig
riscv defconfig
riscv nommu_k210_defconfig
mips ip28_defconfig
i386 alldefconfig
powerpc pmac32_defconfig
arm tct_hammer_defconfig
powerpc kilauea_defconfig
mips nlm_xlp_defconfig
arm mps2_defconfig
mips decstation_defconfig
sh r7785rp_defconfig
arm lubbock_defconfig
powerpc ppc64_defconfig
arm mini2440_defconfig
sh rts7751r2dplus_defconfig
powerpc mgcoge_defconfig
arm vexpress_defconfig
powerpc tqm8540_defconfig
arm nhk8815_defconfig
arm davinci_all_defconfig
mips cavium_octeon_defconfig
riscv alldefconfig
powerpc mpc512x_defconfig
arm oxnas_v6_defconfig
arm pxa_defconfig
arm bcm2835_defconfig
m68k amcore_defconfig
sh se7206_defconfig
sh r7780mp_defconfig
ia64 bigsur_defconfig
arm aspeed_g5_defconfig
arm mvebu_v5_defconfig
powerpc stx_gp3_defconfig
s390 zfcpdump_defconfig
sh se7705_defconfig
powerpc mpc834x_itxgp_defconfig
arm ep93xx_defconfig
arm spear3xx_defconfig
riscv allyesconfig
mips maltaup_defconfig
powerpc sbc8548_defconfig
sh sh7710voipgw_defconfig
sh se7721_defconfig
h8300 h8s-sim_defconfig
arm stm32_defconfig
arm spitz_defconfig
sh sh7785lcr_32bit_defconfig
arc nsimosci_defconfig
powerpc mpc885_ads_defconfig
sh polaris_defconfig
powerpc powernv_defconfig
sh ecovec24-romimage_defconfig
powerpc ppc6xx_defconfig
arm omap2plus_defconfig
powerpc mpc5200_defconfig
m68k sun3x_defconfig
sh shmin_defconfig
arm shannon_defconfig
powerpc sam440ep_defconfig
m68k m5307c3_defconfig
sh sh03_defconfig
sh edosk7705_defconfig
arm sama5_defconfig
arm magician_defconfig
sh migor_defconfig
arm viper_defconfig
ia64 allmodconfig
ia64 defconfig
ia64 allyesconfig
m68k allmodconfig
m68k defconfig
m68k allyesconfig
nios2 defconfig
arc allyesconfig
nds32 allnoconfig
c6x allyesconfig
nds32 defconfig
nios2 allyesconfig
csky defconfig
alpha defconfig
alpha allyesconfig
xtensa allyesconfig
h8300 allyesconfig
arc defconfig
sh allmodconfig
parisc defconfig
s390 allyesconfig
parisc allyesconfig
s390 defconfig
i386 allyesconfig
sparc allyesconfig
sparc defconfig
i386 defconfig
mips allyesconfig
mips allmodconfig
powerpc allyesconfig
powerpc allmodconfig
powerpc allnoconfig
x86_64 randconfig-a004-20201015
x86_64 randconfig-a002-20201015
x86_64 randconfig-a006-20201015
x86_64 randconfig-a001-20201015
x86_64 randconfig-a005-20201015
x86_64 randconfig-a003-20201015
i386 randconfig-a005-20201014
i386 randconfig-a006-20201014
i386 randconfig-a001-20201014
i386 randconfig-a003-20201014
i386 randconfig-a004-20201014
i386 randconfig-a002-20201014
i386 randconfig-a005-20201016
i386 randconfig-a006-20201016
i386 randconfig-a001-20201016
i386 randconfig-a003-20201016
i386 randconfig-a004-20201016
i386 randconfig-a002-20201016
x86_64 randconfig-a016-20201014
x86_64 randconfig-a012-20201014
x86_64 randconfig-a015-20201014
x86_64 randconfig-a013-20201014
x86_64 randconfig-a014-20201014
x86_64 randconfig-a011-20201014
i386 randconfig-a016-20201015
i386 randconfig-a013-20201015
i386 randconfig-a015-20201015
i386 randconfig-a011-20201015
i386 randconfig-a012-20201015
i386 randconfig-a014-20201015
i386 randconfig-a016-20201014
i386 randconfig-a013-20201014
i386 randconfig-a015-20201014
i386 randconfig-a011-20201014
i386 randconfig-a012-20201014
i386 randconfig-a014-20201014
riscv nommu_virt_defconfig
riscv allnoconfig
riscv rv32_defconfig
riscv allmodconfig
x86_64 rhel
x86_64 allyesconfig
x86_64 rhel-7.6-kselftests
x86_64 defconfig
x86_64 rhel-8.3
x86_64 kexec
clang tested configs:
x86_64 randconfig-a004-20201014
x86_64 randconfig-a002-20201014
x86_64 randconfig-a006-20201014
x86_64 randconfig-a001-20201014
x86_64 randconfig-a005-20201014
x86_64 randconfig-a003-20201014
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
^ permalink raw reply
* [powerpc:merge] BUILD SUCCESS 4fa6f5d55f64e974784cfc8f38312d48479a4323
From: kernel test robot @ 2020-10-16 15:08 UTC (permalink / raw)
To: Michael Ellerman; +Cc: linuxppc-dev
tree/branch: https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git merge
branch HEAD: 4fa6f5d55f64e974784cfc8f38312d48479a4323 Automatic merge of 'next' into merge (2020-10-15 22:13)
elapsed time: 1664m
configs tested: 130
configs skipped: 3
The following configs have been built successfully.
More configs may be tested in the coming days.
gcc tested configs:
arm defconfig
arm64 allyesconfig
arm64 defconfig
arm allyesconfig
arm allmodconfig
arm cm_x300_defconfig
arm zx_defconfig
powerpc mpc8560_ads_defconfig
mips jmr3927_defconfig
powerpc tqm8555_defconfig
arm alldefconfig
powerpc ps3_defconfig
xtensa generic_kc705_defconfig
powerpc katmai_defconfig
sparc sparc32_defconfig
sh se7780_defconfig
arm colibri_pxa300_defconfig
arm xcep_defconfig
powerpc eiger_defconfig
mips ip32_defconfig
powerpc motionpro_defconfig
mips malta_defconfig
arm lpc32xx_defconfig
arm simpad_defconfig
arm at91_dt_defconfig
arm lart_defconfig
parisc generic-64bit_defconfig
x86_64 alldefconfig
riscv defconfig
riscv nommu_k210_defconfig
mips ip28_defconfig
i386 alldefconfig
arc vdk_hs38_defconfig
powerpc pmac32_defconfig
mips tb0287_defconfig
powerpc mgcoge_defconfig
arm tct_hammer_defconfig
arm vexpress_defconfig
powerpc tqm8540_defconfig
arm nhk8815_defconfig
sh ap325rxa_defconfig
powerpc ppc64e_defconfig
mips ath79_defconfig
arm jornada720_defconfig
arm aspeed_g5_defconfig
arm mvebu_v5_defconfig
powerpc stx_gp3_defconfig
s390 zfcpdump_defconfig
sh se7705_defconfig
powerpc mpc834x_itxgp_defconfig
arm ep93xx_defconfig
arm spear3xx_defconfig
powerpc mpc885_ads_defconfig
sh polaris_defconfig
powerpc powernv_defconfig
sh ecovec24-romimage_defconfig
powerpc ppc6xx_defconfig
ia64 allmodconfig
ia64 defconfig
ia64 allyesconfig
m68k allmodconfig
m68k defconfig
m68k allyesconfig
nios2 defconfig
arc allyesconfig
nds32 allnoconfig
c6x allyesconfig
nds32 defconfig
nios2 allyesconfig
csky defconfig
alpha defconfig
alpha allyesconfig
xtensa allyesconfig
h8300 allyesconfig
arc defconfig
sh allmodconfig
parisc defconfig
s390 allyesconfig
parisc allyesconfig
s390 defconfig
i386 allyesconfig
sparc allyesconfig
sparc defconfig
i386 defconfig
mips allyesconfig
mips allmodconfig
powerpc allyesconfig
powerpc allmodconfig
powerpc allnoconfig
i386 randconfig-a005-20201014
i386 randconfig-a006-20201014
i386 randconfig-a001-20201014
i386 randconfig-a003-20201014
i386 randconfig-a004-20201014
i386 randconfig-a002-20201014
i386 randconfig-a005-20201016
i386 randconfig-a006-20201016
i386 randconfig-a001-20201016
i386 randconfig-a003-20201016
i386 randconfig-a004-20201016
i386 randconfig-a002-20201016
x86_64 randconfig-a016-20201014
x86_64 randconfig-a012-20201014
x86_64 randconfig-a015-20201014
x86_64 randconfig-a013-20201014
x86_64 randconfig-a014-20201014
x86_64 randconfig-a011-20201014
i386 randconfig-a016-20201014
i386 randconfig-a013-20201014
i386 randconfig-a015-20201014
i386 randconfig-a011-20201014
i386 randconfig-a012-20201014
i386 randconfig-a014-20201014
riscv allyesconfig
riscv nommu_virt_defconfig
riscv allnoconfig
riscv rv32_defconfig
riscv allmodconfig
x86_64 rhel
x86_64 allyesconfig
x86_64 rhel-7.6-kselftests
x86_64 defconfig
x86_64 rhel-8.3
x86_64 kexec
clang tested configs:
x86_64 randconfig-a004-20201014
x86_64 randconfig-a002-20201014
x86_64 randconfig-a006-20201014
x86_64 randconfig-a001-20201014
x86_64 randconfig-a005-20201014
x86_64 randconfig-a003-20201014
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
^ permalink raw reply
* Re: [PATCH 8/8] powerpc/signal64: Rewrite rt_sigreturn() to minimise uaccess switches
From: Christophe Leroy @ 2020-10-16 14:07 UTC (permalink / raw)
To: linuxppc-dev, Christopher M. Riedl
In-Reply-To: <20201015150159.28933-9-cmr@codefail.de>
Le 15/10/2020 à 17:01, Christopher M. Riedl a écrit :
> From: Daniel Axtens <dja@axtens.net>
>
> Add uaccess blocks and use the 'unsafe' versions of functions doing user
> access where possible to reduce the number of times uaccess has to be
> opened/closed.
>
> Signed-off-by: Daniel Axtens <dja@axtens.net>
> Signed-off-by: Christopher M. Riedl <cmr@codefail.de>
> ---
> arch/powerpc/kernel/signal_64.c | 23 +++++++++++++++--------
> 1 file changed, 15 insertions(+), 8 deletions(-)
>
> diff --git a/arch/powerpc/kernel/signal_64.c b/arch/powerpc/kernel/signal_64.c
> index 3b97e3681a8f..0f4ff7a5bfc1 100644
> --- a/arch/powerpc/kernel/signal_64.c
> +++ b/arch/powerpc/kernel/signal_64.c
> @@ -779,18 +779,22 @@ SYSCALL_DEFINE0(rt_sigreturn)
> */
> regs->msr &= ~MSR_TS_MASK;
>
> - if (__get_user(msr, &uc->uc_mcontext.gp_regs[PT_MSR]))
> + if (!user_read_access_begin(uc, sizeof(*uc)))
> goto badframe;
> +
> + unsafe_get_user(msr, &uc->uc_mcontext.gp_regs[PT_MSR], badframe_block);
> +
> if (MSR_TM_ACTIVE(msr)) {
> /* We recheckpoint on return. */
> struct ucontext __user *uc_transact;
>
> /* Trying to start TM on non TM system */
> if (!cpu_has_feature(CPU_FTR_TM))
> - goto badframe;
> + goto badframe_block;
> +
> + unsafe_get_user(uc_transact, &uc->uc_link, badframe_block);
> + user_read_access_end();
user_access_end() only in the if branch ?
>
> - if (__get_user(uc_transact, &uc->uc_link))
> - goto badframe;
> if (restore_tm_sigcontexts(current, &uc->uc_mcontext,
> &uc_transact->uc_mcontext))
> goto badframe;
> @@ -810,12 +814,13 @@ SYSCALL_DEFINE0(rt_sigreturn)
> * causing a TM bad thing.
> */
> current->thread.regs->msr &= ~MSR_TS_MASK;
> +
> +#ifndef CONFIG_PPC_TRANSACTIONAL_MEM
> if (!user_read_access_begin(uc, sizeof(*uc)))
The matching user_read_access_end() is not in the same #ifndef ? That's dirty and hard to follow.
Can you re-organise the code to avoid all those nesting ?
> - return -EFAULT;
> - if (__unsafe_restore_sigcontext(current, NULL, 1, &uc->uc_mcontext)) {
> - user_read_access_end();
> goto badframe;
> - }
> +#endif
> + unsafe_restore_sigcontext(current, NULL, 1, &uc->uc_mcontext,
> + badframe_block);
> user_read_access_end();
> }
>
> @@ -825,6 +830,8 @@ SYSCALL_DEFINE0(rt_sigreturn)
> set_thread_flag(TIF_RESTOREALL);
> return 0;
>
> +badframe_block:
> + user_read_access_end();
> badframe:
> signal_fault(current, regs, "rt_sigreturn", uc);
>
>
Christophe
^ permalink raw reply
* Re: [PATCH 7/8] powerpc/signal64: Rewrite handle_rt_signal64() to minimise uaccess switches
From: Christophe Leroy @ 2020-10-16 14:00 UTC (permalink / raw)
To: Christopher M. Riedl, linuxppc-dev; +Cc: Daniel Axtens
In-Reply-To: <20201015150159.28933-8-cmr@codefail.de>
Le 15/10/2020 à 17:01, Christopher M. Riedl a écrit :
> From: Daniel Axtens <dja@axtens.net>
>
> Add uaccess blocks and use the 'unsafe' versions of functions doing user
> access where possible to reduce the number of times uaccess has to be
> opened/closed.
>
> There is no 'unsafe' version of copy_siginfo_to_user, so move it
> slightly to allow for a "longer" uaccess block.
>
> Signed-off-by: Daniel Axtens <dja@axtens.net>
> Signed-off-by: Christopher M. Riedl <cmr@codefail.de>
> ---
> arch/powerpc/kernel/signal_64.c | 54 ++++++++++++++++-----------------
> 1 file changed, 27 insertions(+), 27 deletions(-)
>
> diff --git a/arch/powerpc/kernel/signal_64.c b/arch/powerpc/kernel/signal_64.c
> index 6d4f7a5c4fbf..3b97e3681a8f 100644
> --- a/arch/powerpc/kernel/signal_64.c
> +++ b/arch/powerpc/kernel/signal_64.c
> @@ -843,46 +843,42 @@ int handle_rt_signal64(struct ksignal *ksig, sigset_t *set,
> /* Save the thread's msr before get_tm_stackpointer() changes it */
> unsigned long msr = regs->msr;
> #endif
> -
> frame = get_sigframe(ksig, tsk, sizeof(*frame), 0);
> - if (!access_ok(frame, sizeof(*frame)))
> + if (!user_write_access_begin(frame, sizeof(*frame)))
> goto badframe;
>
> - err |= __put_user(&frame->info, &frame->pinfo);
> - err |= __put_user(&frame->uc, &frame->puc);
> - err |= copy_siginfo_to_user(&frame->info, &ksig->info);
> - if (err)
> - goto badframe;
> + unsafe_put_user(&frame->info, &frame->pinfo, badframe_block);
> + unsafe_put_user(&frame->uc, &frame->puc, badframe_block);
>
> /* Create the ucontext. */
> - err |= __put_user(0, &frame->uc.uc_flags);
> - err |= __save_altstack(&frame->uc.uc_stack, regs->gpr[1]);
> + unsafe_put_user(0, &frame->uc.uc_flags, badframe_block);
> + unsafe_save_altstack(&frame->uc.uc_stack, regs->gpr[1], badframe_block);
> +
> #ifdef CONFIG_PPC_TRANSACTIONAL_MEM
> if (MSR_TM_ACTIVE(msr)) {
> /* The ucontext_t passed to userland points to the second
> * ucontext_t (for transactional state) with its uc_link ptr.
> */
> - err |= __put_user(&frame->uc_transact, &frame->uc.uc_link);
> + unsafe_put_user(&frame->uc_transact, &frame->uc.uc_link, badframe_block);
> + user_write_access_end();
Whaou. Doing this inside an #ifdef sequence is dirty.
Can you reorganise code to avoid that and to avoid nesting #ifdef/#endif and the if/else as I did in
signal32 ?
> err |= setup_tm_sigcontexts(&frame->uc.uc_mcontext,
> &frame->uc_transact.uc_mcontext,
> tsk, ksig->sig, NULL,
> (unsigned long)ksig->ka.sa.sa_handler,
> msr);
> + if (!user_write_access_begin(frame, sizeof(struct rt_sigframe)))
> + goto badframe;
> +
> } else
> #endif
> {
> - err |= __put_user(0, &frame->uc.uc_link);
> -
> - if (!user_write_access_begin(frame, sizeof(struct rt_sigframe)))
> - return -EFAULT;
> - err |= __unsafe_setup_sigcontext(&frame->uc.uc_mcontext, tsk,
> - ksig->sig, NULL,
> - (unsigned long)ksig->ka.sa.sa_handler, 1);
> - user_write_access_end();
> + unsafe_put_user(0, &frame->uc.uc_link, badframe_block);
> + unsafe_setup_sigcontext(&frame->uc.uc_mcontext, tsk, ksig->sig,
> + NULL, (unsigned long)ksig->ka.sa.sa_handler,
> + 1, badframe_block);
> }
> - err |= __copy_to_user(&frame->uc.uc_sigmask, set, sizeof(*set));
> - if (err)
> - goto badframe;
> +
> + unsafe_copy_to_user(&frame->uc.uc_sigmask, set, sizeof(*set), badframe_block);
>
> /* Make sure signal handler doesn't get spurious FP exceptions */
> tsk->thread.fp_state.fpscr = 0;
> @@ -891,15 +887,17 @@ int handle_rt_signal64(struct ksignal *ksig, sigset_t *set,
> if (vdso64_rt_sigtramp && tsk->mm->context.vdso_base) {
> regs->nip = tsk->mm->context.vdso_base + vdso64_rt_sigtramp;
> } else {
> - if (!user_write_access_begin(frame, sizeof(struct rt_sigframe)))
> - return -EFAULT;
> - err |= __unsafe_setup_trampoline(__NR_rt_sigreturn, &frame->tramp[0]);
> - user_write_access_end();
> - if (err)
> - goto badframe;
> + unsafe_setup_trampoline(__NR_rt_sigreturn, &frame->tramp[0],
> + badframe_block);
> regs->nip = (unsigned long) &frame->tramp[0];
> }
>
> + user_write_access_end();
> +
> + /* Save the siginfo outside of the unsafe block. */
> + if (copy_siginfo_to_user(&frame->info, &ksig->info))
> + goto badframe;
> +
> /* Allocate a dummy caller frame for the signal handler. */
> newsp = ((unsigned long)frame) - __SIGNAL_FRAMESIZE;
> err |= put_user(regs->gpr[1], (unsigned long __user *)newsp);
> @@ -939,6 +937,8 @@ int handle_rt_signal64(struct ksignal *ksig, sigset_t *set,
>
> return 0;
>
> +badframe_block:
> + user_write_access_end();
> badframe:
> signal_fault(current, regs, "handle_rt_signal64", frame);
>
>
Christophe
^ permalink raw reply
* Re: [PATCH 6/8] powerpc/signal64: Replace setup_trampoline() w/ unsafe_setup_trampoline()
From: Christophe Leroy @ 2020-10-16 13:56 UTC (permalink / raw)
To: Christopher M. Riedl, linuxppc-dev; +Cc: Daniel Axtens
In-Reply-To: <20201015150159.28933-7-cmr@codefail.de>
Le 15/10/2020 à 17:01, Christopher M. Riedl a écrit :
> From: Daniel Axtens <dja@axtens.net>
>
> Previously setup_trampoline() performed a costly KUAP switch on every
> uaccess operation. These repeated uaccess switches cause a significant
> drop in signal handling performance.
>
> Rewrite setup_trampoline() to assume that a userspace write access
> window is open. Replace all uaccess functions with their 'unsafe'
> versions to avoid the repeated uaccess switches.
>
> Signed-off-by: Daniel Axtens <dja@axtens.net>
> Signed-off-by: Christopher M. Riedl <cmr@codefail.de>
> ---
> arch/powerpc/kernel/signal_64.c | 32 +++++++++++++++++++-------------
> 1 file changed, 19 insertions(+), 13 deletions(-)
>
> diff --git a/arch/powerpc/kernel/signal_64.c b/arch/powerpc/kernel/signal_64.c
> index bd92064e5576..6d4f7a5c4fbf 100644
> --- a/arch/powerpc/kernel/signal_64.c
> +++ b/arch/powerpc/kernel/signal_64.c
> @@ -600,30 +600,33 @@ static long restore_tm_sigcontexts(struct task_struct *tsk,
> /*
> * Setup the trampoline code on the stack
> */
> -static long setup_trampoline(unsigned int syscall, unsigned int __user *tramp)
> +#define unsafe_setup_trampoline(syscall, tramp, e) \
> + unsafe_op_wrap(__unsafe_setup_trampoline(syscall, tramp), e)
> +static long notrace __unsafe_setup_trampoline(unsigned int syscall,
> + unsigned int __user *tramp)
> {
> int i;
> - long err = 0;
>
> /* bctrl # call the handler */
> - err |= __put_user(PPC_INST_BCTRL, &tramp[0]);
> + unsafe_put_user(PPC_INST_BCTRL, &tramp[0], err);
> /* addi r1, r1, __SIGNAL_FRAMESIZE # Pop the dummy stackframe */
> - err |= __put_user(PPC_INST_ADDI | __PPC_RT(R1) | __PPC_RA(R1) |
> - (__SIGNAL_FRAMESIZE & 0xffff), &tramp[1]);
> + unsafe_put_user(PPC_INST_ADDI | __PPC_RT(R1) | __PPC_RA(R1) |
> + (__SIGNAL_FRAMESIZE & 0xffff), &tramp[1], err);
> /* li r0, __NR_[rt_]sigreturn| */
> - err |= __put_user(PPC_INST_ADDI | (syscall & 0xffff), &tramp[2]);
> + unsafe_put_user(PPC_INST_ADDI | (syscall & 0xffff), &tramp[2], err);
> /* sc */
> - err |= __put_user(PPC_INST_SC, &tramp[3]);
> + unsafe_put_user(PPC_INST_SC, &tramp[3], err);
>
> /* Minimal traceback info */
> for (i=TRAMP_TRACEBACK; i < TRAMP_SIZE ;i++)
> - err |= __put_user(0, &tramp[i]);
> + unsafe_put_user(0, &tramp[i], err);
>
> - if (!err)
> - flush_icache_range((unsigned long) &tramp[0],
> - (unsigned long) &tramp[TRAMP_SIZE]);
> + flush_icache_range((unsigned long)&tramp[0],
> + (unsigned long)&tramp[TRAMP_SIZE]);
This flush should be done outside the user_write_access block.
>
> - return err;
> + return 0;
> +err:
> + return 1;
> }
>
> /*
> @@ -888,7 +891,10 @@ int handle_rt_signal64(struct ksignal *ksig, sigset_t *set,
> if (vdso64_rt_sigtramp && tsk->mm->context.vdso_base) {
> regs->nip = tsk->mm->context.vdso_base + vdso64_rt_sigtramp;
> } else {
> - err |= setup_trampoline(__NR_rt_sigreturn, &frame->tramp[0]);
> + if (!user_write_access_begin(frame, sizeof(struct rt_sigframe)))
> + return -EFAULT;
> + err |= __unsafe_setup_trampoline(__NR_rt_sigreturn, &frame->tramp[0]);
> + user_write_access_end();
> if (err)
> goto badframe;
> regs->nip = (unsigned long) &frame->tramp[0];
>
Christophe
^ permalink raw reply
* Re: [PATCH 2/8] powerpc/signal: Add unsafe_copy_{vsx, fpr}_from_user()
From: Christophe Leroy @ 2020-10-16 13:48 UTC (permalink / raw)
To: Christopher M. Riedl, linuxppc-dev
In-Reply-To: <20201015150159.28933-3-cmr@codefail.de>
Le 15/10/2020 à 17:01, Christopher M. Riedl a écrit :
> Reuse the "safe" implementation from signal.c except for calling
> unsafe_copy_from_user() to copy into a local buffer. Unlike the
> unsafe_copy_{vsx,fpr}_to_user() functions the "copy from" functions
> cannot use unsafe_get_user() directly to bypass the local buffer since
> doing so significantly reduces signal handling performance.
Why can't the functions use unsafe_get_user(), why does it significantly reduces signal handling
performance ? How much significant ? I would expect that not going through an intermediate memory
area would be more efficient
Christophe
>
> Signed-off-by: Christopher M. Riedl <cmr@codefail.de>
> ---
> arch/powerpc/kernel/signal.h | 33 +++++++++++++++++++++++++++++++++
> 1 file changed, 33 insertions(+)
>
> diff --git a/arch/powerpc/kernel/signal.h b/arch/powerpc/kernel/signal.h
> index 2559a681536e..e9aaeac0da37 100644
> --- a/arch/powerpc/kernel/signal.h
> +++ b/arch/powerpc/kernel/signal.h
> @@ -53,6 +53,33 @@ unsigned long copy_ckfpr_from_user(struct task_struct *task, void __user *from);
> &buf[i], label);\
> } while (0)
>
> +#define unsafe_copy_fpr_from_user(task, from, label) do { \
> + struct task_struct *__t = task; \
> + u64 __user *__f = (u64 __user *)from; \
> + u64 buf[ELF_NFPREG]; \
> + int i; \
> + \
> + unsafe_copy_from_user(buf, __f, ELF_NFPREG * sizeof(double), \
> + label); \
> + for (i = 0; i < ELF_NFPREG - 1; i++) \
> + __t->thread.TS_FPR(i) = buf[i]; \
> + __t->thread.fp_state.fpscr = buf[i]; \
> +} while (0)
> +
> +#define unsafe_copy_vsx_from_user(task, from, label) do { \
> + struct task_struct *__t = task; \
> + u64 __user *__f = (u64 __user *)from; \
> + u64 buf[ELF_NVSRHALFREG]; \
> + int i; \
> + \
> + unsafe_copy_from_user(buf, __f, \
> + ELF_NVSRHALFREG * sizeof(double), \
> + label); \
> + for (i = 0; i < ELF_NVSRHALFREG ; i++) \
> + __t->thread.fp_state.fpr[i][TS_VSRLOWOFFSET] = buf[i]; \
> +} while (0)
> +
> +
> #ifdef CONFIG_PPC_TRANSACTIONAL_MEM
> #define unsafe_copy_ckfpr_to_user(to, task, label) do { \
> struct task_struct *__t = task; \
> @@ -80,6 +107,10 @@ unsigned long copy_ckfpr_from_user(struct task_struct *task, void __user *from);
> unsafe_copy_to_user(to, (task)->thread.fp_state.fpr, \
> ELF_NFPREG * sizeof(double), label)
>
> +#define unsafe_copy_fpr_from_user(task, from, label) \
> + unsafe_copy_from_user((task)->thread.fp_state.fpr, from \
> + ELF_NFPREG * sizeof(double), label)
> +
> static inline unsigned long
> copy_fpr_to_user(void __user *to, struct task_struct *task)
> {
> @@ -115,6 +146,8 @@ copy_ckfpr_from_user(struct task_struct *task, void __user *from)
> #else
> #define unsafe_copy_fpr_to_user(to, task, label) do { } while (0)
>
> +#define unsafe_copy_fpr_from_user(task, from, label) do { } while (0)
> +
> static inline unsigned long
> copy_fpr_to_user(void __user *to, struct task_struct *task)
> {
>
^ permalink raw reply
* Re: [PATCH 1/8] powerpc/uaccess: Add unsafe_copy_from_user
From: Christophe Leroy @ 2020-10-16 13:18 UTC (permalink / raw)
To: Christoph Hellwig, Christopher M. Riedl; +Cc: linuxppc-dev, linux-kernel, viro
In-Reply-To: <20201016065403.GA9343@infradead.org>
Le 16/10/2020 à 08:54, Christoph Hellwig a écrit :
> On Thu, Oct 15, 2020 at 10:01:52AM -0500, Christopher M. Riedl wrote:
>> Implement raw_copy_from_user_allowed() which assumes that userspace read
>> access is open. Use this new function to implement raw_copy_from_user().
>> Finally, wrap the new function to follow the usual "unsafe_" convention
>> of taking a label argument. The new raw_copy_from_user_allowed() calls
>> __copy_tofrom_user() internally, but this is still safe to call in user
>> access blocks formed with user_*_access_begin()/user_*_access_end()
>> since asm functions are not instrumented for tracing.
>
> Please also add a fallback unsafe_copy_from_user to linux/uaccess.h
> so this can be used as a generic API.
>
I guess this can be done in a separate patch independant of that series ?
Christophe
^ permalink raw reply
* Re: [PATCH 1/8] powerpc/uaccess: Add unsafe_copy_from_user
From: Christophe Leroy @ 2020-10-16 13:17 UTC (permalink / raw)
To: Christopher M. Riedl, linuxppc-dev
In-Reply-To: <20201015150159.28933-2-cmr@codefail.de>
Le 15/10/2020 à 17:01, Christopher M. Riedl a écrit :
> Implement raw_copy_from_user_allowed() which assumes that userspace read
> access is open. Use this new function to implement raw_copy_from_user().
> Finally, wrap the new function to follow the usual "unsafe_" convention
> of taking a label argument. The new raw_copy_from_user_allowed() calls
> __copy_tofrom_user() internally, but this is still safe to call in user
> access blocks formed with user_*_access_begin()/user_*_access_end()
> since asm functions are not instrumented for tracing.
Would objtool accept that if it was implemented on powerpc ?
__copy_tofrom_user() is a function which is optimised for larger memory copies (using dcbz, etc ...)
Do we need such an optimisation for unsafe_copy_from_user() ? Or can we do a simple loop as done for
unsafe_copy_to_user() instead ?
Christophe
>
> Signed-off-by: Christopher M. Riedl <cmr@codefail.de>
> ---
> arch/powerpc/include/asm/uaccess.h | 28 +++++++++++++++++++---------
> 1 file changed, 19 insertions(+), 9 deletions(-)
>
> diff --git a/arch/powerpc/include/asm/uaccess.h b/arch/powerpc/include/asm/uaccess.h
> index 26781b044932..66940b4eb692 100644
> --- a/arch/powerpc/include/asm/uaccess.h
> +++ b/arch/powerpc/include/asm/uaccess.h
> @@ -418,38 +418,45 @@ raw_copy_in_user(void __user *to, const void __user *from, unsigned long n)
> }
> #endif /* __powerpc64__ */
>
> -static inline unsigned long raw_copy_from_user(void *to,
> - const void __user *from, unsigned long n)
> +static inline unsigned long
> +raw_copy_from_user_allowed(void *to, const void __user *from, unsigned long n)
> {
> - unsigned long ret;
> if (__builtin_constant_p(n) && (n <= 8)) {
> - ret = 1;
> + unsigned long ret = 1;
>
> switch (n) {
> case 1:
> barrier_nospec();
> - __get_user_size(*(u8 *)to, from, 1, ret);
> + __get_user_size_allowed(*(u8 *)to, from, 1, ret);
> break;
> case 2:
> barrier_nospec();
> - __get_user_size(*(u16 *)to, from, 2, ret);
> + __get_user_size_allowed(*(u16 *)to, from, 2, ret);
> break;
> case 4:
> barrier_nospec();
> - __get_user_size(*(u32 *)to, from, 4, ret);
> + __get_user_size_allowed(*(u32 *)to, from, 4, ret);
> break;
> case 8:
> barrier_nospec();
> - __get_user_size(*(u64 *)to, from, 8, ret);
> + __get_user_size_allowed(*(u64 *)to, from, 8, ret);
> break;
> }
> if (ret == 0)
> return 0;
> }
>
> + return __copy_tofrom_user((__force void __user *)to, from, n);
> +}
> +
> +static inline unsigned long
> +raw_copy_from_user(void *to, const void __user *from, unsigned long n)
> +{
> + unsigned long ret;
> +
> barrier_nospec();
> allow_read_from_user(from, n);
> - ret = __copy_tofrom_user((__force void __user *)to, from, n);
> + ret = raw_copy_from_user_allowed(to, from, n);
> prevent_read_from_user(from, n);
> return ret;
> }
> @@ -571,6 +578,9 @@ user_write_access_begin(const void __user *ptr, size_t len)
> #define unsafe_get_user(x, p, e) unsafe_op_wrap(__get_user_allowed(x, p), e)
> #define unsafe_put_user(x, p, e) __put_user_goto(x, p, e)
>
> +#define unsafe_copy_from_user(d, s, l, e) \
> + unsafe_op_wrap(raw_copy_from_user_allowed(d, s, l), e)
> +
> #define unsafe_copy_to_user(d, s, l, e) \
> do { \
> u8 __user *_dst = (u8 __user *)(d); \
>
^ permalink raw reply
* Re: [PATCH v4 0/2] powerpc/mce: Fix mce handler and add selftest
From: Michael Ellerman @ 2020-10-16 11:32 UTC (permalink / raw)
To: mpe, Ganesh Goudar, linuxppc-dev; +Cc: msuchanek, mahesh, npiggin, keescook
In-Reply-To: <20201009064005.19777-1-ganeshgr@linux.ibm.com>
On Fri, 9 Oct 2020 12:10:03 +0530, Ganesh Goudar wrote:
> This patch series fixes mce handling for pseries, Adds LKDTM test
> for SLB multihit recovery and enables selftest for the same,
> basically to test MCE handling on pseries/powernv machines running
> in hash mmu mode.
>
> v4:
> * Use radix_enabled() to check if its in Hash or Radix mode.
> * Use FW_FEATURE_LPAR instead of machine_is_pseries().
>
> [...]
Patch 1 applied to powerpc/fixes.
[1/2] powerpc/mce: Avoid nmi_enter/exit in real mode on pseries hash
https://git.kernel.org/powerpc/c/8d0e2101274358d9b6b1f27232b40253ca48bab5
cheers
^ permalink raw reply
page: next (older) | prev (newer) | latest
- recent:[subjects (threaded)|topics (new)|topics (active)]
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox