* Re: [PATCH] powerpc/pseries/vas: Include irqdomain.h
From: Michael Ellerman @ 2021-06-26 10:46 UTC (permalink / raw)
To: Michael Ellerman, linuxppc-dev; +Cc: sfr
In-Reply-To: <20210625045337.3197833-1-mpe@ellerman.id.au>
On Fri, 25 Jun 2021 14:53:37 +1000, Michael Ellerman wrote:
> There are patches in flight to break the dependency between asm/irq.h
> and linux/irqdomain.h, which would break compilation of vas.c because it
> needs the declaration of irq_create_mapping() etc.
>
> So add an explicit include of irqdomain.h to avoid that becoming a
> problem in future.
Applied to powerpc/next.
[1/1] powerpc/pseries/vas: Include irqdomain.h
https://git.kernel.org/powerpc/c/c736fb97051c39c74bf5d4684bdac1766d43e175
cheers
^ permalink raw reply
* Re: [PATCH] powerpc/perf: Fix crash with 'perf_instruction_pointer' when pmu is not set
From: Michael Ellerman @ 2021-06-26 10:40 UTC (permalink / raw)
To: mpe, Athira Rajeev; +Cc: maddy, linuxppc-dev
In-Reply-To: <1623952506-1431-1-git-send-email-atrajeev@linux.vnet.ibm.com>
On Thu, 17 Jun 2021 13:55:06 -0400, Athira Rajeev wrote:
> On systems without any specific PMU driver support registered, running
> perf record causes Oops.
>
> The relevant portion from call trace:
>
> BUG: Kernel NULL pointer dereference on read at 0x00000040
> Faulting instruction address: 0xc0021f0c
> Oops: Kernel access of bad area, sig: 11 [#1]
> BE PAGE_SIZE=4K PREEMPT CMPCPRO
> SAF3000 DIE NOTIFICATION
> CPU: 0 PID: 442 Comm: null_syscall Not tainted 5.13.0-rc6-s3k-dev-01645-g7649ee3d2957 #5164
> NIP: c0021f0c LR: c00e8ad8 CTR: c00d8a5c
> NIP [c0021f0c] perf_instruction_pointer+0x10/0x60
> LR [c00e8ad8] perf_prepare_sample+0x344/0x674
> Call Trace:
> [e6775880] [c00e8810] perf_prepare_sample+0x7c/0x674 (unreliable)
> [e67758c0] [c00e8e44] perf_event_output_forward+0x3c/0x94
> [e6775910] [c00dea8c] __perf_event_overflow+0x74/0x14c
> [e6775930] [c00dec5c] perf_swevent_hrtimer+0xf8/0x170
> [e6775a40] [c008c8d0] __hrtimer_run_queues.constprop.0+0x160/0x318
> [e6775a90] [c008d94c] hrtimer_interrupt+0x148/0x3b0
> [e6775ae0] [c000c0c0] timer_interrupt+0xc4/0x22c
> [e6775b10] [c00046f0] Decrementer_virt+0xb8/0xbc
>
> [...]
Applied to powerpc/fixes.
[1/1] powerpc/perf: Fix crash with 'perf_instruction_pointer' when pmu is not set
https://git.kernel.org/powerpc/c/60b7ed54a41b550d50caf7f2418db4a7e75b5bdc
cheers
^ permalink raw reply
* Re: [PATCH] powerpc/sysfs: Replace sizeof(arr)/sizeof(arr[0]) with ARRAY_SIZE
From: Michael Ellerman @ 2021-06-26 10:37 UTC (permalink / raw)
To: Jason Wang, mpe; +Cc: christophe.leroy, maddy, paulus, clg, linuxppc-dev, joel
In-Reply-To: <20210624063632.25632-1-wangborong@cdjrlc.com>
On Thu, 24 Jun 2021 14:36:32 +0800, Jason Wang wrote:
> The ARRAY_SIZE macro is more compact and more formal in linux source.
Applied to powerpc/next.
[1/1] powerpc/sysfs: Replace sizeof(arr)/sizeof(arr[0]) with ARRAY_SIZE
https://git.kernel.org/powerpc/c/590e1e4254458455477e4e857cd00733280a3d73
cheers
^ permalink raw reply
* Re: [RESEND-PATCH v2] powerpc/papr_scm: Add support for reporting dirty-shutdown-count
From: Michael Ellerman @ 2021-06-26 10:37 UTC (permalink / raw)
To: Vaibhav Jain, linux-nvdimm, linuxppc-dev, nvdimm
Cc: Aneesh Kumar K . V, Santosh Sivaraj, Ira Weiny, Dan Williams
In-Reply-To: <20210624080621.252038-1-vaibhav@linux.ibm.com>
On Thu, 24 Jun 2021 13:36:21 +0530, Vaibhav Jain wrote:
> Persistent memory devices like NVDIMMs can loose cached writes in case
> something prevents flush on power-fail. Such situations are termed as
> dirty shutdown and are exposed to applications as
> last-shutdown-state (LSS) flag and a dirty-shutdown-counter(DSC) as
> described at [1]. The latter being useful in conditions where multiple
> applications want to detect a dirty shutdown event without racing with
> one another.
>
> [...]
Applied to powerpc/next.
[1/1] powerpc/papr_scm: Add support for reporting dirty-shutdown-count
https://git.kernel.org/powerpc/c/de21e1377c4fe65bfd8d31e446482c1bc2232997
cheers
^ permalink raw reply
* Re: [PATCH v3] powerpc/papr_scm: Make 'perf_stats' invisible if perf-stats unavailable
From: Michael Ellerman @ 2021-06-26 10:37 UTC (permalink / raw)
To: Vaibhav Jain, linux-nvdimm, linuxppc-dev; +Cc: Aneesh Kumar K . V
In-Reply-To: <20210513092349.285021-1-vaibhav@linux.ibm.com>
On Thu, 13 May 2021 14:53:49 +0530, Vaibhav Jain wrote:
> In case performance stats for an nvdimm are not available, reading the
> 'perf_stats' sysfs file returns an -ENOENT error. A better approach is
> to make the 'perf_stats' file entirely invisible to indicate that
> performance stats for an nvdimm are unavailable.
>
> So this patch updates 'papr_nd_attribute_group' to add a 'is_visible'
> callback implemented as newly introduced 'papr_nd_attribute_visible()'
> that returns an appropriate mode in case performance stats aren't
> supported in a given nvdimm.
>
> [...]
Applied to powerpc/next.
[1/1] powerpc/papr_scm: Make 'perf_stats' invisible if perf-stats unavailable
https://git.kernel.org/powerpc/c/ed78f56e1271f108e8af61baeba383dcd77adbec
cheers
^ permalink raw reply
* Re: [PATCH] powerpc/pmu: Make the generic compat PMU use the architected events
From: Michael Ellerman @ 2021-06-26 10:37 UTC (permalink / raw)
To: Madhavan Srinivasan, linuxppc-dev, Paul Mackerras; +Cc: Michael Ellerman
In-Reply-To: <YJD7L9yeoxvxqeYi@thinks.paulus.ozlabs.org>
On Tue, 4 May 2021 17:43:43 +1000, Paul Mackerras wrote:
> This changes generic-compat-pmu.c so that it only uses architected
> events defined in Power ISA v3.0B, rather than event encodings which,
> while common to all the IBM Power Systems implementations, are
> nevertheless implementation-specific rather than architected. The
> intention is that any CPU implementation designed to conform to Power
> ISA v3.0B or later can use generic-compat-pmu.c.
>
> [...]
Applied to powerpc/next.
[1/1] powerpc/pmu: Make the generic compat PMU use the architected events
https://git.kernel.org/powerpc/c/d40a82be2f79d16cc18c28c14d267da240659949
cheers
^ permalink raw reply
* Re: [PATCH] powerpc/64s: Fix copy-paste data exposure into newly created tasks
From: Michael Ellerman @ 2021-06-26 10:37 UTC (permalink / raw)
To: Nicholas Piggin, linuxppc-dev; +Cc: Sukadev Bhattiprolu, Haren Myneni
In-Reply-To: <20210622053036.474678-1-npiggin@gmail.com>
On Tue, 22 Jun 2021 15:30:36 +1000, Nicholas Piggin wrote:
> copy-paste contains implicit "copy buffer" state that can contain
> arbitrary user data (if the user process executes a copy instruction).
> This could be snooped by another process if a context switch hits while
> the state is live. So cp_abort is executed on context switch to clear
> out possible sensitive data and prevent the leak.
>
> cp_abort is done after the low level _switch(), which means it is never
> reached by newly created tasks, so they could snoop on this buffer
> between their first and second context switch.
>
> [...]
Applied to powerpc/next.
[1/1] powerpc/64s: Fix copy-paste data exposure into newly created tasks
https://git.kernel.org/powerpc/c/f35d2f249ef05b9671e7898f09ad89aa78f99122
cheers
^ permalink raw reply
* Re: [PATCH] powerpc/xmon: Add support for running a command on all cpus in xmon
From: Michael Ellerman @ 2021-06-26 10:37 UTC (permalink / raw)
To: Michael Ellerman, Nicholas Piggin, Naveen N. Rao; +Cc: linuxppc-dev
In-Reply-To: <20210601074801.617363-1-naveen.n.rao@linux.vnet.ibm.com>
On Tue, 1 Jun 2021 13:18:01 +0530, Naveen N. Rao wrote:
> It is sometimes desirable to run a command on all cpus in xmon. A
> typical scenario is to obtain the backtrace from all cpus in xmon if
> there is a soft lockup. Add rudimentary support for the same. The
> command to be run on all cpus should be prefixed with 'c#'. As an
> example, 'c#t' will run 't' command and produce a backtrace on all cpus
> in xmon.
>
> [...]
Applied to powerpc/next.
[1/1] powerpc/xmon: Add support for running a command on all cpus in xmon
https://git.kernel.org/powerpc/c/b8ee3e6d6c5eec7e66de82449382f1a206db2046
cheers
^ permalink raw reply
* Re: [PATCH] powerpc/configs: Enable STACK_TRACER and FTRACE_SYSCALLS in some of the configs
From: Michael Ellerman @ 2021-06-26 10:37 UTC (permalink / raw)
To: Michael Ellerman, Naveen N. Rao; +Cc: linuxppc-dev
In-Reply-To: <20210524120227.3333208-1-naveen.n.rao@linux.vnet.ibm.com>
On Mon, 24 May 2021 17:32:27 +0530, Naveen N. Rao wrote:
> Both these config options are generally enabled in distro kernels.
> Enable the same in a few powerpc64 configs to get better coverage and
> testing.
Applied to powerpc/next.
[1/1] powerpc/configs: Enable STACK_TRACER and FTRACE_SYSCALLS in some of the configs
https://git.kernel.org/powerpc/c/dcf57af201eb2ba401e62df374afb7543c81b523
cheers
^ permalink raw reply
* Re: [PATCH] powerpc/bpf: Use bctrl for making function calls
From: Michael Ellerman @ 2021-06-26 10:37 UTC (permalink / raw)
To: linuxppc-dev, bpf, Naveen N. Rao
In-Reply-To: <20210609090024.1446800-1-naveen.n.rao@linux.vnet.ibm.com>
On Wed, 9 Jun 2021 14:30:24 +0530, Naveen N. Rao wrote:
> blrl corrupts the link stack. Instead use bctrl when making function
> calls from BPF programs.
Applied to powerpc/next.
[1/1] powerpc/bpf: Use bctrl for making function calls
https://git.kernel.org/powerpc/c/20ccb004bad659c186f9091015a956da220d615d
cheers
^ permalink raw reply
* Re: (subset) [PATCH 0/5] powerpc/kprobes: fixes and cleanups
From: Michael Ellerman @ 2021-06-26 10:37 UTC (permalink / raw)
To: Michael Ellerman, Jordan Niethe, Naveen N. Rao, Christophe Leroy
Cc: linuxppc-dev
In-Reply-To: <cover.1621416666.git.naveen.n.rao@linux.vnet.ibm.com>
On Wed, 19 May 2021 16:17:16 +0530, Naveen N. Rao wrote:
> Various fixes and some code refactoring for kprobes on powerpc. The
> first patch fixes an invalid access if probing the first instruction in
> a kernel module. The rest are small cleanups. More details in the
> individual patches.
>
> - Naveen
>
> [...]
Applied to powerpc/next.
[5/5] powerpc/kprobes: Warn if instruction patching failed
https://git.kernel.org/powerpc/c/12b58492e60bf5a31d7f41e8a6f8ceb6f87e710e
cheers
^ permalink raw reply
* Re: [PATCH] powerpc/rtas-rtc: remove unused constant
From: Michael Ellerman @ 2021-06-26 10:37 UTC (permalink / raw)
To: linuxppc-dev, Nathan Lynch
In-Reply-To: <20210503175811.1528208-1-nathanl@linux.ibm.com>
On Mon, 3 May 2021 12:58:11 -0500, Nathan Lynch wrote:
> RTAS_CLOCK_BUSY is unused, remove it.
Applied to powerpc/next.
[1/1] powerpc/rtas-rtc: remove unused constant
https://git.kernel.org/powerpc/c/4bfa5ddff924c2d5b2427f752515ca594dade19f
cheers
^ permalink raw reply
* Re: [PATCH] powerpc/pseries/dlpar: use rtas_get_sensor()
From: Michael Ellerman @ 2021-06-26 10:37 UTC (permalink / raw)
To: linuxppc-dev, Nathan Lynch; +Cc: tyreld, ldufour
In-Reply-To: <20210504025329.1713878-1-nathanl@linux.ibm.com>
On Mon, 3 May 2021 21:53:29 -0500, Nathan Lynch wrote:
> Instead of making bare calls to get-sensor-state, use
> rtas_get_sensor(), which correctly handles busy and extended delay
> statuses.
Applied to powerpc/next.
[1/1] powerpc/pseries/dlpar: use rtas_get_sensor()
https://git.kernel.org/powerpc/c/bfb0c9fcf5870036e54081b28cae2af5f9ee7088
cheers
^ permalink raw reply
* Re: [PATCH] powerpc: Fix is_kvm_guest() / kvm_para_available()
From: Michael Ellerman @ 2021-06-26 10:37 UTC (permalink / raw)
To: Michael Ellerman, linuxppc-dev
In-Reply-To: <20210623130514.2543232-1-mpe@ellerman.id.au>
On Wed, 23 Jun 2021 23:05:14 +1000, Michael Ellerman wrote:
> Commit a21d1becaa3f ("powerpc: Reintroduce is_kvm_guest() as a fast-path
> check") added is_kvm_guest() and changed kvm_para_available() to use it.
>
> is_kvm_guest() checks a static key, kvm_guest, and that static key is
> set in check_kvm_guest().
>
> The problem is check_kvm_guest() is only called on pseries, and even
> then only in some configurations. That means is_kvm_guest() always
> returns false on all non-pseries and some pseries depending on
> configuration. That's a bug.
>
> [...]
Applied to powerpc/next.
[1/1] powerpc: Fix is_kvm_guest() / kvm_para_available()
https://git.kernel.org/powerpc/c/95839225639ba7c3d8d7231b542728dcf222bf2d
cheers
^ permalink raw reply
* Re: [PATCH] powerpc/64s: Make prom_init require RELOCATABLE
From: Michael Ellerman @ 2021-06-26 10:37 UTC (permalink / raw)
To: Michael Ellerman, linuxppc-dev; +Cc: jniethe5
In-Reply-To: <20210623130454.2542945-1-mpe@ellerman.id.au>
On Wed, 23 Jun 2021 23:04:54 +1000, Michael Ellerman wrote:
> When we boot from open firmware (OF) using PPC_OF_BOOT_TRAMPOLINE, aka.
> prom_init, we run parts of the kernel at an address other than the link
> address. That happens because OF loads the kernel above zero (OF is at
> zero) and we run prom_init before copying the kernel down to zero.
>
> Currently that works even for non-relocatable kernels, because we do
> various fixups to the prom_init code to make it run where it's loaded.
>
> [...]
Applied to powerpc/next.
[1/1] powerpc/64s: Make prom_init require RELOCATABLE
https://git.kernel.org/powerpc/c/24d33ac5b8ffb7a0e697344fea8591376162548f
cheers
^ permalink raw reply
* Re: [PATCH] powerpc/papr_scm: trivial: fix typo in a comment
From: Michael Ellerman @ 2021-06-26 10:37 UTC (permalink / raw)
To: Kajol Jain, mpe; +Cc: trivial, maddy, linuxppc-dev, linux-kernel, vaibhav
In-Reply-To: <20210418074003.6651-1-kjain@linux.ibm.com>
On Sun, 18 Apr 2021 13:10:03 +0530, Kajol Jain wrote:
> There is a spelling mistake "byes" -> "bytes" in a comment of
> function drc_pmem_query_stats(). Fix that typo.
Applied to powerpc/next.
[1/1] powerpc/papr_scm: trivial: fix typo in a comment
https://git.kernel.org/powerpc/c/d2827e5e2e0f0941a651f4b1ca5e9b778c4b5293
cheers
^ permalink raw reply
* Re: [PATCH] selftests/powerpc: Use req_max_processed_len from sysfs NX capabilities
From: Michael Ellerman @ 2021-06-26 10:37 UTC (permalink / raw)
To: linuxppc-dev, mpe, npiggin, rzinsly, Haren Myneni
In-Reply-To: <ed908341b1eb7ca0183c028a4ed4a0cf48bfe0f6.camel@linux.ibm.com>
On Tue, 22 Jun 2021 22:17:46 -0700, Haren Myneni wrote:
> On PowerVM, the hypervisor defines the maximum buffer length for
> each NX request and the kernel exported this value via sysfs.
>
> This patch reads this value if the sysfs entry is available and
> is used to limit the request length.
Applied to powerpc/next.
[1/1] selftests/powerpc: Use req_max_processed_len from sysfs NX capabilities
https://git.kernel.org/powerpc/c/c6c27e3d84648e6188fba314ae21a005e60bdcd4
cheers
^ permalink raw reply
* Re: [PATCH v2] powerpc/kprobes: Fix Oops by passing ppc_inst as a pointer to emulate_step() on ppc32
From: Michael Ellerman @ 2021-06-26 10:37 UTC (permalink / raw)
To: Benjamin Herrenschmidt, Michael Ellerman, Paul Mackerras,
Christophe Leroy
Cc: linuxppc-dev, linux-kernel
In-Reply-To: <5bdc8cbc9a95d0779e27c9ddbf42b40f51f883c0.1624425798.git.christophe.leroy@csgroup.eu>
On Wed, 23 Jun 2021 05:23:30 +0000 (UTC), Christophe Leroy wrote:
> Trying to use a kprobe on ppc32 results in the below splat:
> BUG: Unable to handle kernel data access on read at 0x7c0802a6
> Faulting instruction address: 0xc002e9f0
> Oops: Kernel access of bad area, sig: 11 [#1]
> BE PAGE_SIZE=4K PowerPC 44x Platform
> Modules linked in:
> CPU: 0 PID: 89 Comm: sh Not tainted 5.13.0-rc1-01824-g3a81c0495fdb #7
> NIP: c002e9f0 LR: c0011858 CTR: 00008a47
> REGS: c292fd50 TRAP: 0300 Not tainted (5.13.0-rc1-01824-g3a81c0495fdb)
> MSR: 00009000 <EE,ME> CR: 24002002 XER: 20000000
> DEAR: 7c0802a6 ESR: 00000000
> <snip>
> NIP [c002e9f0] emulate_step+0x28/0x324
> LR [c0011858] optinsn_slot+0x128/0x10000
> Call Trace:
> opt_pre_handler+0x7c/0xb4 (unreliable)
> optinsn_slot+0x128/0x10000
> ret_from_syscall+0x0/0x28
>
> [...]
Applied to powerpc/next.
[1/1] powerpc/kprobes: Fix Oops by passing ppc_inst as a pointer to emulate_step() on ppc32
https://git.kernel.org/powerpc/c/511eea5e2ccdfdbf3d626bde0314e551f247dd18
cheers
^ permalink raw reply
* Re: [PATCH v2 0/4] Convert powerpc to GENERIC_PTDUMP
From: Michael Ellerman @ 2021-06-26 10:37 UTC (permalink / raw)
To: Paul Mackerras, Steven Price, akpm, Michael Ellerman,
Benjamin Herrenschmidt, Christophe Leroy, dja
Cc: linux-arch, linux-mm, Oliver O'Halloran, linuxppc-dev,
linux-kernel
In-Reply-To: <cover.1618828806.git.christophe.leroy@csgroup.eu>
On Mon, 19 Apr 2021 10:47:24 +0000 (UTC), Christophe Leroy wrote:
> This series converts powerpc to generic PTDUMP.
>
> For that, we first need to add missing hugepd support
> to pagewalk and ptdump.
>
> v2:
> - Reworked the pagewalk modification to add locking and check ops->pte_entry
> - Modified powerpc early IO mapping to have gaps between mappings
> - Removed the logic that checked for contiguous physical memory
> - Removed the articial level calculation in ptdump_pte_entry(), level 4 is ok for all.
> - Removed page_size argument to note_page()
>
> [...]
Patches 2 and 4 pplied to powerpc/next.
[2/4] powerpc/mm: Leave a gap between early allocated IO areas
https://git.kernel.org/powerpc/c/57307f1b6edd781fba2bf9f7ec5f4d17a881ea54
[3/4] powerpc/mm: Properly coalesce pages in ptdump
https://git.kernel.org/powerpc/c/6ca6512c716afd6e37281372c4c35aa6afd71d10
cheers
^ permalink raw reply
* Re: [PATCH] powerpc: Remove klimit
From: Michael Ellerman @ 2021-06-26 10:37 UTC (permalink / raw)
To: Paul Mackerras, Michael Ellerman, Benjamin Herrenschmidt,
wangkefeng.wang, Christophe Leroy
Cc: linuxppc-dev, linux-kernel
In-Reply-To: <9fa9ba6807c17f93f35a582c199c646c4a8bfd9c.1622800638.git.christophe.leroy@csgroup.eu>
On Fri, 4 Jun 2021 09:57:36 +0000 (UTC), Christophe Leroy wrote:
> klimit is a global variable initialised at build time with the
> value of _end.
>
> This variable is never modified, so _end symbol can be used directly.
>
> Remove klimit.
Applied to powerpc/next.
[1/1] powerpc: Remove klimit
https://git.kernel.org/powerpc/c/56afad885228902d090558a0b1cf75e9809e831d
cheers
^ permalink raw reply
* Re: [PATCH] powerpc/interrupt: Use names in check_return_regs_valid()
From: Michael Ellerman @ 2021-06-26 10:37 UTC (permalink / raw)
To: Paul Mackerras, Michael Ellerman, npiggin, Benjamin Herrenschmidt,
Christophe Leroy
Cc: linuxppc-dev, linux-kernel
In-Reply-To: <d48bf0184a1de185eb0ed3282247f8a294710674.1624632537.git.christophe.leroy@csgroup.eu>
On Fri, 25 Jun 2021 14:49:09 +0000 (UTC), Christophe Leroy wrote:
> trap->regs == 0x3000 is trap_is_scv()
>
> trap 0x500 is INTERRUPT_EXTERNAL
Applied to powerpc/next.
[1/1] powerpc/interrupt: Use names in check_return_regs_valid()
https://git.kernel.org/powerpc/c/b064037ea4104120418ccbf39951a6d529a9d6d5
cheers
^ permalink raw reply
* Re: [PATCH] powerpc/interrupt: Also use exit_must_hard_disable() on PPC32
From: Michael Ellerman @ 2021-06-26 10:37 UTC (permalink / raw)
To: Paul Mackerras, Michael Ellerman, npiggin, Benjamin Herrenschmidt,
Christophe Leroy
Cc: linuxppc-dev, linux-kernel
In-Reply-To: <52531029563c1fc823b790058e799d0ca71b028c.1624631463.git.christophe.leroy@csgroup.eu>
On Fri, 25 Jun 2021 14:31:46 +0000 (UTC), Christophe Leroy wrote:
> Reduce #ifdefs a bit by making exit_must_hard_disable() return
> true on PPC32.
Applied to powerpc/next.
[1/1] powerpc/interrupt: Also use exit_must_hard_disable() on PPC32
https://git.kernel.org/powerpc/c/767e6e7130b288d856e4f2be365554dc6147a80a
cheers
^ permalink raw reply
* Re: [PATCH 1/4] powerpc/32: Interchange r10 and r12 in SYSCALL_ENTRY on non booke
From: Michael Ellerman @ 2021-06-26 10:37 UTC (permalink / raw)
To: Benjamin Herrenschmidt, Michael Ellerman, Paul Mackerras,
Christophe Leroy
Cc: linuxppc-dev, linux-kernel
In-Reply-To: <5ab3a517bc883a2fc905fb2cb5ee9344f37b2cfa.1622818435.git.christophe.leroy@csgroup.eu>
On Fri, 4 Jun 2021 14:54:12 +0000 (UTC), Christophe Leroy wrote:
> To better match booke version of SYSCALL_ENTRY macro, interchange
> r10 and r12 in the non booke version.
Applied to powerpc/next.
[1/4] powerpc/32: Interchange r10 and r12 in SYSCALL_ENTRY on non booke
https://git.kernel.org/powerpc/c/10e9252f043ecda0dad7cde6ef87db5d10dff2c7
[2/4] powerpc/32: Interchange r1 and r11 in SYSCALL_ENTRY on booke
https://git.kernel.org/powerpc/c/275dcf24e253f4f5b200bc8cca5eac32a23b08c8
[3/4] powerpc/32: Reduce code duplication of system call entry
https://git.kernel.org/powerpc/c/4bd9e05ac7b8b1f7d0c28702cb684417501a5e39
[4/4] powerpc/32: Avoid #ifdef nested with FTR_SECTION on booke syscall entry
https://git.kernel.org/powerpc/c/a27755d57e0b8c1109a6b1485e52a5f9d51bd4eb
cheers
^ permalink raw reply
* Re: [PATCH 1/2] powerpc/ptrace: Move set_return_regs_changed() before regs_set_return_{msr/ip}
From: Michael Ellerman @ 2021-06-26 10:37 UTC (permalink / raw)
To: Benjamin Herrenschmidt, Michael Ellerman, Paul Mackerras,
Christophe Leroy
Cc: linuxppc-dev, linux-kernel
In-Reply-To: <49f4fb051a3e1cb69f7305d5b6768aec14727c32.1624619582.git.christophe.leroy@csgroup.eu>
On Fri, 25 Jun 2021 11:13:16 +0000 (UTC), Christophe Leroy wrote:
> regs_set_return_msr() and regs_set_return_ip() have a copy
> of the code of set_return_regs_changed().
>
> Move up set_return_regs_changed() so it can be reused by
> regs_set_return_{msr/ip}
Applied to powerpc/next.
[1/2] powerpc/ptrace: Move set_return_regs_changed() before regs_set_return_{msr/ip}
https://git.kernel.org/powerpc/c/5f0f95f1e1b64fe55679059837dafb3439b57012
[2/2] powerpc/ptrace: Refactor regs_set_return_{msr/ip}
https://git.kernel.org/powerpc/c/cae4644673ec5f54c77deab67a57c41395a1539f
cheers
^ permalink raw reply
* Re: [PATCH] powerpc: mark local variables around longjmp as volatile
From: Michael Ellerman @ 2021-06-26 10:37 UTC (permalink / raw)
To: Michael Ellerman, Arnd Bergmann
Cc: Ravi Bangoria, Arnd Bergmann, linux-kernel, Paul Mackerras,
Nicholas Piggin, linuxppc-dev
In-Reply-To: <20210429080708.1520360-1-arnd@kernel.org>
On Thu, 29 Apr 2021 10:06:38 +0200, Arnd Bergmann wrote:
> gcc-11 points out that modifying local variables next to a
> longjmp/setjmp may cause undefined behavior:
>
> arch/powerpc/kexec/crash.c: In function 'crash_kexec_prepare_cpus.constprop':
> arch/powerpc/kexec/crash.c:108:22: error: variable 'ncpus' might be clobbered by 'longjmp' or 'vfork' [-Werror=clobbere
> d]
> arch/powerpc/kexec/crash.c:109:13: error: variable 'tries' might be clobbered by 'longjmp' or 'vfork' [-Werror=clobbere
> d]
> arch/powerpc/xmon/xmon.c: In function 'xmon_print_symbol':
> arch/powerpc/xmon/xmon.c:3625:21: error: variable 'name' might be clobbered by 'longjmp' or 'vfork' [-Werror=clobbered]
> arch/powerpc/xmon/xmon.c: In function 'stop_spus':
> arch/powerpc/xmon/xmon.c:4057:13: error: variable 'i' might be clobbered by 'longjmp' or 'vfork' [-Werror=clobbered]
> arch/powerpc/xmon/xmon.c: In function 'restart_spus':
> arch/powerpc/xmon/xmon.c:4098:13: error: variable 'i' might be clobbered by 'longjmp' or 'vfork' [-Werror=clobbered]
> arch/powerpc/xmon/xmon.c: In function 'dump_opal_msglog':
> arch/powerpc/xmon/xmon.c:3008:16: error: variable 'pos' might be clobbered by 'longjmp' or 'vfork' [-Werror=clobbered]
> arch/powerpc/xmon/xmon.c: In function 'show_pte':
> arch/powerpc/xmon/xmon.c:3207:29: error: variable 'tsk' might be clobbered by 'longjmp' or 'vfork' [-Werror=clobbered]
> arch/powerpc/xmon/xmon.c: In function 'show_tasks':
> arch/powerpc/xmon/xmon.c:3302:29: error: variable 'tsk' might be clobbered by 'longjmp' or 'vfork' [-Werror=clobbered]
> arch/powerpc/xmon/xmon.c: In function 'xmon_core':
> arch/powerpc/xmon/xmon.c:494:13: error: variable 'cmd' might be clobbered by 'longjmp' or 'vfork' [-Werror=clobbered]
> arch/powerpc/xmon/xmon.c:860:21: error: variable 'bp' might be clobbered by 'longjmp' or 'vfork' [-Werror=clobbered]
> arch/powerpc/xmon/xmon.c:860:21: error: variable 'bp' might be clobbered by 'longjmp' or 'vfork' [-Werror=clobbered]
> arch/powerpc/xmon/xmon.c:492:48: error: argument 'fromipi' might be clobbered by 'longjmp' or 'vfork' [-Werror=clobbered]
>
> [...]
Applied to powerpc/next.
[1/1] powerpc: mark local variables around longjmp as volatile
https://git.kernel.org/powerpc/c/a2305e3de819394a7adf68078964a92d06f9db33
cheers
^ permalink raw reply
page: next (older) | prev (newer) | latest
- recent:[subjects (threaded)|topics (new)|topics (active)]
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox