From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from AM1EHSOBE004.bigfish.com (am1ehsobe004.messaging.microsoft.com [213.199.154.207]) (using TLSv1 with cipher AES128-SHA (128/128 bits)) (Client CN "mail.global.frontbridge.com", Issuer "Microsoft Secure Server Authority" (verified OK)) by ozlabs.org (Postfix) with ESMTPS id 8ACF4B6F00 for ; Mon, 22 Aug 2011 20:01:48 +1000 (EST) Content-Type: text/plain; charset="utf-8"; format=flowed; delsp=yes To: Scott Wood , Chunhe Lan Subject: Re: [PATCH] mtd/nand: Don't add disabled nand flash devices References: <1313486855-15233-1-git-send-email-Chunhe.Lan@freescale.com> <4E4AE535.4070400@freescale.com> Date: Mon, 22 Aug 2011 18:04:35 +0800 MIME-Version: 1.0 From: Lan Chunhe Message-ID: In-Reply-To: <4E4AE535.4070400@freescale.com> Cc: dwmw2@infradead.org, kumar.gala@freescale.com, linux-mtd@lists.infradead.org, akpm@linux-foundation.org, linuxppc-dev@ozlabs.org List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Wed, 17 Aug 2011 05:46:29 +0800, Scott Wood = = wrote: > On 08/16/2011 04:27 AM, Chunhe Lan wrote: >> Nand flash nodes with the property status=3D"disabled" are not >> usable and so avoid adding "disabled" nand flash devices with >> the system. >> >> Signed-off-by: Chunhe Lan >> --- >> drivers/mtd/nand/fsl_elbc_nand.c | 5 ++++- >> 1 files changed, 4 insertions(+), 1 deletions(-) >> >> diff --git a/drivers/mtd/nand/fsl_elbc_nand.c = >> b/drivers/mtd/nand/fsl_elbc_nand.c >> index 33d8aad..8212c12 100644 >> --- a/drivers/mtd/nand/fsl_elbc_nand.c >> +++ b/drivers/mtd/nand/fsl_elbc_nand.c >> @@ -1,6 +1,6 @@ >> /* Freescale Enhanced Local Bus Controller NAND driver >> * >> - * Copyright =C2=A9 2006-2007, 2010 Freescale Semiconductor >> + * Copyright =C2=A9 2006-2007, 2010-2011 Freescale Semiconductor >> * >> * Authors: Nick Spence , >> * Scott Wood >> @@ -849,6 +849,9 @@ static int __devinit fsl_elbc_nand_probe(struct = >> platform_device *pdev) >> struct device *dev; >> struct device_node *node =3D pdev->dev.of_node; >> >> + if (!of_device_is_available(node)) >> + return -ENODEV; >> + >> if (!fsl_lbc_ctrl_dev || !fsl_lbc_ctrl_dev->regs) >> return -ENODEV; >> lbc =3D fsl_lbc_ctrl_dev->regs; > > Same comment as the other patch -- unavailable devices should already > not be getting probed. Also, this subject line makes it sound like th= is > is a NAND subsystem change rather than a change in one specific driver= . You are right. The upper layers have prevented unavailable devices. So, this patch is no need. Thanks. -Jack Lan > -Scott