From: Chunhe Lan <b25806@freescale.com>
To: Kumar Gala <kumar.gala@freescale.com>,
Chunhe Lan <Chunhe.Lan@freescale.com>,
Chris Ball <cjb@laptop.org>
Cc: Shengzhou Liu <b36685@freescale.com>,
linux-mmc@vger.kernel.org,
PPC list <linuxppc-dev@lists.ozlabs.org>
Subject: Re: [PATCH 3/3 v2] mmc: Use mmc_delay() instead of mdelay() for time delay
Date: Tue, 6 Sep 2011 14:52:18 +0800 [thread overview]
Message-ID: <op.v1dj1g1mrxq6oa@localhost.localdomain> (raw)
In-Reply-To: <CBED532F-6456-46FE-A96A-D91264E95966@freescale.com>
On Thu, 01 Sep 2011 12:42:08 +0800, Kumar Gala <kumar.gala@freescale.com>
wrote:
>
> On Aug 26, 2011, at 2:55 AM, Chunhe Lan wrote:
>
>> The mmc_delay() is a wrapper function for mdelay() and msleep().
>>
>> o mdelay() -- block the system when busy-waiting.
>> o msleep() -- suspend the currently running task to enable CPU
>> to process other tasks, so it is non-blocking
>> regarding the whole system.
>>
>> When the desired delay time is more than a period of timer interrupt,
>> just use msleep(). Change mdelay() to mmc_delay() to avoid chewing
>> CPU when busy wait.
>>
>> Signed-off-by: Shengzhou Liu <b36685@freescale.com>
>> Signed-off-by: Chunhe Lan <Chunhe.Lan@freescale.com>
>> Cc: Chris Ball <cjb@laptop.org>
>> ---
>> drivers/mmc/host/sdhci.c | 10 +++++-----
>> 1 files changed, 5 insertions(+), 5 deletions(-)
>
> It might be good to either merge patch 2/3 & 3/3 or rename them since
> they have same commit message.
>
> Chris,
>
> Any comments on closing on these patches?
>
Hello Chris,
Do you any comments on these patches ?
If not, can you apply these patches to mmc-next ?
Thanks.
-Jack
> - k
prev parent reply other threads:[~2011-09-06 6:50 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-26 7:55 [PATCH 3/3 v2] mmc: Use mmc_delay() instead of mdelay() for time delay Chunhe Lan
2011-09-01 4:42 ` Kumar Gala
2011-09-06 6:52 ` Chunhe Lan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=op.v1dj1g1mrxq6oa@localhost.localdomain \
--to=b25806@freescale.com \
--cc=Chunhe.Lan@freescale.com \
--cc=b36685@freescale.com \
--cc=cjb@laptop.org \
--cc=kumar.gala@freescale.com \
--cc=linux-mmc@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).