From: "Michal Nazarewicz" <mina86@mina86.com>
To: "Alexandre Pereira da Silva" <aletes.xgr@gmail.com>,
"Rob Herring" <robherring2@gmail.com>
Cc: Roland Stigge <stigge@antcom.de>,
linux-doc@vger.kernel.org,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
devicetree-discuss@lists.ozlabs.org, linux-usb@vger.kernel.org,
linux-kernel@vger.kernel.org, Felipe Balbi <balbi@ti.com>,
Rob Landley <rob@landley.net>,
linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH 5/5] usb: gadget: composite: parse dt overrides
Date: Tue, 26 Jun 2012 21:18:48 +0200 [thread overview]
Message-ID: <op.wgiylmt83l0zgt@mpn-glaptop> (raw)
In-Reply-To: <4FEA02B7.3030801@gmail.com>
> On 06/26/2012 09:27 AM, Alexandre Pereira da Silva wrote:
>> Grab the devicetree node properties to override VendorId, ProductId,
>> bcdDevice, Manucacturer, Product and SerialNumber
Like before, the code looks good to me:
Acked-by: Michal Nazarewicz <mina86@mina86.com>
Not commenting on the other aspects of the business logic though.
On Tue, 26 Jun 2012 20:43:03 +0200, Rob Herring <robherring2@gmail.com> =
wrote:
> I'm still confused about what is the order of priority for the 2
> possible sources of these values. The way it is written, the DT value =
is
> a default, not an override.
They are overwritten by module parameter but they are overwriting anythi=
ng that
composite gadget might be providing.
-- =
Best regards, _ _
.o. | Liege of Serenely Enlightened Majesty of o' \,=3D./ `o
..o | Computer Science, Micha=C5=82 =E2=80=9Cmina86=E2=80=9D Nazarewicz=
(o o)
ooo +----<email/xmpp: mpn@google.com>--------------ooO--(_)--Ooo--
next prev parent reply other threads:[~2012-06-26 19:18 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-26 14:27 [PATCH 0/5] Usb gadget devicetree bindings Alexandre Pereira da Silva
2012-06-26 14:27 ` [PATCH 1/5] usb: gadget: lpc32xx_udc: Propagate devicetree to gadget drivers Alexandre Pereira da Silva
2012-06-26 14:27 ` [PATCH 2/5] usb: gadget: s3c-hsotg: " Alexandre Pereira da Silva
2012-06-26 14:27 ` [PATCH 3/5] usb: gadget: fsl_udc: " Alexandre Pereira da Silva
2012-06-26 14:27 ` [PATCH 4/5] usb: gadget: at91_udc: " Alexandre Pereira da Silva
2012-06-26 14:27 ` [PATCH 5/5] usb: gadget: composite: parse dt overrides Alexandre Pereira da Silva
2012-06-26 18:43 ` Rob Herring
2012-06-26 19:18 ` Michal Nazarewicz [this message]
2012-07-02 7:35 ` Felipe Balbi
2012-07-02 22:46 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=op.wgiylmt83l0zgt@mpn-glaptop \
--to=mina86@mina86.com \
--cc=aletes.xgr@gmail.com \
--cc=balbi@ti.com \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=rob@landley.net \
--cc=robherring2@gmail.com \
--cc=stigge@antcom.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox