From: Grant Likely <grant.likely@secretlab.ca>
To: John Linn <John.Linn@xilinx.com>
Cc: Eric Dumazet <eric.dumazet@gmail.com>,
linuxppc-dev@ozlabs.org, netdev@vger.kernel.org,
John Tyner <jtyner@cs.ucr.edu>,
michal.simek@petalogix.com, john.williams@petalogix.com
Subject: Re: [PATCH] [V3] Add non-Virtex5 support for LL TEMAC driver
Date: Tue, 6 Apr 2010 11:54:42 -0600 [thread overview]
Message-ID: <p2vfa686aa41004061054qad1495bbxdf6deb5d5d9dd4bf@mail.gmail.com> (raw)
In-Reply-To: <7a42d507-bf50-40f3-a2a0-8de682b314d7@SG2EHSMHS017.ehs.local>
On Mon, Apr 5, 2010 at 3:33 PM, John Linn <John.Linn@xilinx.com> wrote:
> From: Eric Dumazet [mailto:eric.dumazet@gmail.com]
>> > +/* Align the IP data in the packet on word boundaries as MicroBlaze
>> > + * needs it.
>> > + */
>> > +
>> > =A0#define XTE_ALIGN =A0 =A0 =A0 32
>> > -#define BUFFER_ALIGN(adr) ((XTE_ALIGN - ((u32) adr)) % XTE_ALIGN)
>> > +#define BUFFER_ALIGN(adr) ((34 - ((u32) adr)) % XTE_ALIGN)
>> >
>>
>> Very interesting way of doing this, but why such convoluted thing ?
>
> Grant might have insight into why this started this way, I just updated t=
o help with MicroBlaze alignment.
It was that way in the code I received from Yoshio Kashiwagi and David
H. Lynch. I have no problem with it being changed.
Personally I would probably write a followup patch to change this to
netdev_alloc_skb_ip_align(), just to keep changes logically separated.
But I'm okay with it rolled into this patch also.
g.
next prev parent reply other threads:[~2010-04-06 17:55 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-05 21:11 [PATCH] [V3] Add non-Virtex5 support for LL TEMAC driver John Linn
2010-04-05 21:29 ` Eric Dumazet
2010-04-05 21:33 ` John Linn
2010-04-06 15:08 ` Steven J. Magnani
2010-04-06 17:54 ` Grant Likely [this message]
2010-04-06 16:12 ` John Linn
2010-04-06 17:00 ` Eric Dumazet
2010-04-06 17:11 ` John Linn
2010-04-06 17:47 ` Eric Dumazet
2010-04-06 18:53 ` Grant Likely
2010-04-06 20:03 ` John Linn
2010-04-06 20:03 ` Steven J. Magnani
2010-04-06 20:12 ` John Linn
2010-04-06 20:24 ` Eric Dumazet
2010-04-06 20:32 ` John Linn
2010-04-07 2:52 ` David Miller
2010-04-07 13:25 ` John Linn
2010-04-07 13:31 ` Eric Dumazet
2010-04-06 0:08 ` Grant Likely
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=p2vfa686aa41004061054qad1495bbxdf6deb5d5d9dd4bf@mail.gmail.com \
--to=grant.likely@secretlab.ca \
--cc=John.Linn@xilinx.com \
--cc=eric.dumazet@gmail.com \
--cc=john.williams@petalogix.com \
--cc=jtyner@cs.ucr.edu \
--cc=linuxppc-dev@ozlabs.org \
--cc=michal.simek@petalogix.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).