From: Andi Kleen <andi@firstfloor.org>
To: David Miller <davem@davemloft.net>
Cc: Geert.Uytterhoeven@sonycom.com, linuxppc-dev@ozlabs.org,
linux-kernel@vger.kernel.org, arnd@arndb.de,
jens.axboe@oracle.com
Subject: Re: ioctl32: Unknown cmd
Date: 17 Oct 2007 02:25:20 +0200 [thread overview]
Message-ID: <p73wstmy4cv.fsf@crumb.suse.de> (raw)
In-Reply-To: <20071016.152404.35664335.davem@davemloft.net>
David Miller <davem@davemloft.net> writes:
> From: Arnd Bergmann <arnd@arndb.de>
> Date: Tue, 16 Oct 2007 21:50:35 +0200
>
> > The one point where it is expected to have changed now is when you
> > try to do these ioctls on something that is not a block device. Are
> > you sure that the files you tried them on were created correctly?
>
> Many many many programs do this exact sort of thing.
>
> It is one of the bad aspects of moving the compat handling
> down into the file ops for a specific device.
When this happens one should add respective IGNORE_IOCTL()s to
compat_ioctl.c
-Andi
next prev parent reply other threads:[~2007-10-17 0:25 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-16 14:45 ioctl32: Unknown cmd Geert Uytterhoeven
2007-10-16 16:58 ` Jens Axboe
2007-10-16 19:50 ` Arnd Bergmann
2007-10-16 22:24 ` David Miller
2007-10-17 0:25 ` Andi Kleen [this message]
2007-10-17 6:38 ` Geert Uytterhoeven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=p73wstmy4cv.fsf@crumb.suse.de \
--to=andi@firstfloor.org \
--cc=Geert.Uytterhoeven@sonycom.com \
--cc=arnd@arndb.de \
--cc=davem@davemloft.net \
--cc=jens.axboe@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).