* [PATCH] powerpc: remove non-dependent load fsl_booke PTE_64BIT
@ 2008-10-10 11:56 Milton Miller
2008-10-10 13:05 ` Kumar Gala
2008-10-10 13:07 ` Kumar Gala
0 siblings, 2 replies; 3+ messages in thread
From: Milton Miller @ 2008-10-10 11:56 UTC (permalink / raw)
To: linuxppc-dev, Kumar Gala
b38fd42ff46a4a31dced8533e8a6e549693500b6 added false dependencys
to order the load of upper and lower halfs of the pte, but only
adjusted whitespace instead of deleting the old load in the iside
handler, letting the hardware see the non-dependent load.
This patch removes the extra load.
Signed-off-by: Milton Miller <miltonm@bga.com>
---
Kumar, I think this is right from my inspection, please review.
Index: next.git/arch/powerpc/kernel/head_fsl_booke.S
===================================================================
--- next.git.orig/arch/powerpc/kernel/head_fsl_booke.S 2008-10-05 02:40:38.000000000 -0500
+++ next.git/arch/powerpc/kernel/head_fsl_booke.S 2008-10-05 02:40:58.000000000 -0500
@@ -658,10 +658,6 @@ interrupt_base:
bne 2f /* Bail if permission mismach */
-#ifdef CONFIG_PTE_64BIT
- lwz r13,0(r12)
-#endif
-
/* Jump to common TLB load point */
b finish_tlb_load
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] powerpc: remove non-dependent load fsl_booke PTE_64BIT
2008-10-10 11:56 [PATCH] powerpc: remove non-dependent load fsl_booke PTE_64BIT Milton Miller
@ 2008-10-10 13:05 ` Kumar Gala
2008-10-10 13:07 ` Kumar Gala
1 sibling, 0 replies; 3+ messages in thread
From: Kumar Gala @ 2008-10-10 13:05 UTC (permalink / raw)
To: Milton Miller; +Cc: linuxppc-dev
On Oct 10, 2008, at 6:56 AM, Milton Miller wrote:
> b38fd42ff46a4a31dced8533e8a6e549693500b6 added false dependencys
> to order the load of upper and lower halfs of the pte, but only
> adjusted whitespace instead of deleting the old load in the iside
> handler, letting the hardware see the non-dependent load.
>
> This patch removes the extra load.
>
> Signed-off-by: Milton Miller <miltonm@bga.com>
> ---
> Kumar, I think this is right from my inspection, please review.
good catch, thanks.
- k
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] powerpc: remove non-dependent load fsl_booke PTE_64BIT
2008-10-10 11:56 [PATCH] powerpc: remove non-dependent load fsl_booke PTE_64BIT Milton Miller
2008-10-10 13:05 ` Kumar Gala
@ 2008-10-10 13:07 ` Kumar Gala
1 sibling, 0 replies; 3+ messages in thread
From: Kumar Gala @ 2008-10-10 13:07 UTC (permalink / raw)
To: Milton Miller; +Cc: linuxppc-dev
On Oct 10, 2008, at 6:56 AM, Milton Miller wrote:
> b38fd42ff46a4a31dced8533e8a6e549693500b6 added false dependencys
> to order the load of upper and lower halfs of the pte, but only
> adjusted whitespace instead of deleting the old load in the iside
> handler, letting the hardware see the non-dependent load.
>
> This patch removes the extra load.
>
> Signed-off-by: Milton Miller <miltonm@bga.com>
> ---
> Kumar, I think this is right from my inspection, please review.
applied
- k
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2008-10-10 13:07 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-10-10 11:56 [PATCH] powerpc: remove non-dependent load fsl_booke PTE_64BIT Milton Miller
2008-10-10 13:05 ` Kumar Gala
2008-10-10 13:07 ` Kumar Gala
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).