From: Grant Likely <grant.likely@secretlab.ca>
To: Ben Dooks <ben-linux@fluff.org>
Cc: alsa-devel@alsa-project.org, sfr@canb.auug.org.au,
monstr@monstr.eu, broonie@opensource.wolfsonmicro.com,
linux-scsi@vger.kernel.org, linux-ide@vger.kernel.org,
devicetree-discuss@lists.ozlabs.org, gregkh@suse.de,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
jeremy.kerr@canonical.com, linuxppc-dev@ozlabs.org,
James.Bottomley@suse.de, linux-i2c@vger.kernel.org,
microblaze-uclinux@itee.uq.edu.au, sparclinux@vger.kernel.org,
akpm@linux-foundation.org, dwmw2@infradead.org,
jgarzik@pobox.com, davem@davemloft.net
Subject: Re: [PATCH 33/37] sound/soc: use .dev.of_node instead of .node in struct of_device
Date: Mon, 5 Apr 2010 17:47:48 -0600 [thread overview]
Message-ID: <q2tfa686aa41004051647p4c8182d0h807583d09714761a@mail.gmail.com> (raw)
In-Reply-To: <20100405230301.GF32401@fluff.org.uk>
Hi Ben, thanks for the comment. Reply below...
On Mon, Apr 5, 2010 at 5:03 PM, Ben Dooks <ben-linux@fluff.org> wrote:
> On Thu, Mar 11, 2010 at 11:06:50AM -0700, Grant Likely wrote:
>> .node is being removed
[...]
>> --- a/sound/soc/fsl/mpc8610_hpcd.c
>> +++ b/sound/soc/fsl/mpc8610_hpcd.c
>> @@ -202,7 +202,7 @@ static struct snd_soc_ops mpc8610_hpcd_ops =3D {
>> =A0static int mpc8610_hpcd_probe(struct of_device *ofdev,
>> =A0 =A0 =A0 const struct of_device_id *match)
>> =A0{
>> - =A0 =A0 struct device_node *np =3D ofdev->node;
>> + =A0 =A0 struct device_node *np =3D ofdev->dev.of_node;
>> =A0 =A0 =A0 struct device_node *codec_np =3D NULL;
>> =A0 =A0 =A0 struct device_node *guts_np =3D NULL;
>> =A0 =A0 =A0 struct device_node *dma_np =3D NULL;
>
> This looks like one case where an inline function would have been a
> help.
In what regard (how would you like it to look)? The node pointer
location is very unlikely to move again, and I prefer the clarity of
direct dereferencing.
g.
next prev parent reply other threads:[~2010-04-05 23:48 UTC|newest]
Thread overview: 53+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-11 18:03 [PATCH 00/37] OF: move device node pointer into struct device Grant Likely
2010-03-11 18:03 ` [PATCH 01/37] i2c/of: Allow device node to be passed via i2c_board_info Grant Likely
2010-03-11 18:03 ` [PATCH 02/37] of: Eliminate dev_archdata_get_node() Grant Likely
2010-03-11 18:04 ` [PATCH 03/37] of/sparc: use dev->of_node instead of dev->archdata.prom_node Grant Likely
2010-03-11 18:04 ` [PATCH 04/37] arch/sparc: use .dev.of_node instead of .node in struct of_device Grant Likely
2010-03-11 18:04 ` [PATCH 05/37] arch/powerpc: " Grant Likely
2010-03-11 18:04 ` [PATCH 06/37] arch/microblaze: " Grant Likely
2010-03-11 18:04 ` [PATCH 07/37] drivers/serial: " Grant Likely
2010-03-11 18:04 ` [PATCH 08/37] drivers/watchdog: " Grant Likely
2010-03-11 18:04 ` [PATCH 09/37] drivers/atm: " Grant Likely
2010-03-11 18:04 ` [PATCH 10/37] drivers/video: " Grant Likely
2010-03-11 18:04 ` [PATCH 11/37] drivers/scsi: " Grant Likely
2010-03-11 18:04 ` [PATCH 12/37] drivers/usb: " Grant Likely
2010-03-11 18:28 ` Greg KH
2010-03-11 18:04 ` [PATCH 13/37] drivers/macintosh: " Grant Likely
2010-03-11 18:05 ` [PATCH 14/37] drivers/spi: " Grant Likely
2010-03-11 18:05 ` [PATCH 15/37] drivers/mmc: " Grant Likely
2010-03-11 18:05 ` [PATCH 16/37] drivers/sbus: " Grant Likely
2010-03-11 18:05 ` [PATCH 17/37] drivers/net: " Grant Likely
2010-03-11 18:05 ` [PATCH 18/37] drivers/pcmcia: " Grant Likely
2010-03-11 18:05 ` [PATCH 19/37] drivers/serial: " Grant Likely
2010-03-11 18:05 ` [PATCH 20/37] drivers/input: " Grant Likely
2010-03-11 18:05 ` [PATCH 21/37] drivers/ata: " Grant Likely
2010-03-11 18:31 ` Sergei Shtylyov
2010-03-11 18:36 ` Jeff Garzik
2010-03-11 18:38 ` David Miller
2010-03-11 18:05 ` [PATCH 22/37] drivers/leds: " Grant Likely
2010-03-11 18:05 ` [PATCH 23/37] drivers/i2c: " Grant Likely
2010-03-11 18:06 ` [PATCH 24/37] drivers/char: " Grant Likely
2010-03-11 18:06 ` [PATCH 25/37] drivers/infiniband: " Grant Likely
2010-03-11 19:57 ` Roland Dreier
2010-03-12 13:30 ` Alexander Schmidt
2010-03-11 18:06 ` [PATCH 26/37] drivers/mtd: " Grant Likely
2010-03-11 18:06 ` [PATCH 27/37] drivers/of: " Grant Likely
2010-03-11 18:06 ` [PATCH 28/37] drivers/scsi: use .of_node instead of .archdata.of_node in struct device Grant Likely
2010-03-11 18:06 ` [PATCH 29/37] drivers/char: " Grant Likely
2010-03-11 18:06 ` [PATCH 30/37] drivers/cdrom: " Grant Likely
2010-03-11 18:06 ` [PATCH 31/37] drivers/of: " Grant Likely
2010-03-11 18:06 ` [PATCH 32/37] sound/aoa: use .dev.of_node instead of .node in struct of_device Grant Likely
2010-03-11 18:06 ` [PATCH 33/37] sound/soc: " Grant Likely
2010-03-11 19:34 ` Mark Brown
2010-03-11 21:22 ` Grant Likely
2010-03-12 8:26 ` Jean Delvare
2010-04-05 23:03 ` Ben Dooks
2010-04-05 23:47 ` Grant Likely [this message]
2010-03-11 18:06 ` [PATCH 34/37] sound/sparc: " Grant Likely
2010-03-11 18:07 ` [PATCH 35/37] arch/powerpc: Remove .archdata.of_node and use .of_node in struct device Grant Likely
2010-03-11 18:07 ` [PATCH 36/37] arch/microblaze: " Grant Likely
2010-03-11 18:07 ` [PATCH 37/37] arch/sparc: " Grant Likely
2010-03-11 18:20 ` [PATCH 00/37] OF: move device node pointer into " David Miller
2010-03-11 18:23 ` David Miller
2010-03-11 18:25 ` Grant Likely
2010-03-11 18:27 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=q2tfa686aa41004051647p4c8182d0h807583d09714761a@mail.gmail.com \
--to=grant.likely@secretlab.ca \
--cc=James.Bottomley@suse.de \
--cc=akpm@linux-foundation.org \
--cc=alsa-devel@alsa-project.org \
--cc=ben-linux@fluff.org \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=davem@davemloft.net \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=dwmw2@infradead.org \
--cc=gregkh@suse.de \
--cc=jeremy.kerr@canonical.com \
--cc=jgarzik@pobox.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=microblaze-uclinux@itee.uq.edu.au \
--cc=monstr@monstr.eu \
--cc=netdev@vger.kernel.org \
--cc=sfr@canb.auug.org.au \
--cc=sparclinux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).