From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <tiwai@suse.de>
Received: from mx1.suse.de (cantor.suse.de [195.135.220.2])
	(using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))
	(Client CN "mx1.suse.de",
	Issuer "Thawte Premium Server CA" (verified OK))
	by ozlabs.org (Postfix) with ESMTP id 56C4767BF5
	for <linuxppc-dev@ozlabs.org>; Wed,  9 Aug 2006 22:52:57 +1000 (EST)
Date: Wed, 09 Aug 2006 14:52:52 +0200
Message-ID: <s5h1wrqdqaj.wl%tiwai@suse.de>
From: Takashi Iwai <tiwai@suse.de>
To: Johannes Berg <johannes@sipsolutions.net>
Subject: Re: [Alsa-devel] Linux v2.6.18-rc4, snd-aoa link error
In-Reply-To: <44D9D74E.6010009@sipsolutions.net>
References: <Pine.LNX.4.64.0608061127070.5167@g5.osdl.org>
	<20060808194651.GA29482@aepfle.de>
	<1155067429.26338.96.camel@mindpipe> <s5hoduudypc.wl%tiwai@suse.de>
	<44D9B1BE.9070600@sipsolutions.net> <s5hk65idwia.wl%tiwai@suse.de>
	<44D9C8E5.10109@sipsolutions.net> <s5h7j1idrvf.wl%tiwai@suse.de>
	<44D9D532.9010200@sipsolutions.net> <s5h4pwmdr9o.wl%tiwai@suse.de>
	<44D9D74E.6010009@sipsolutions.net>
MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka")
Content-Type: text/plain; charset=US-ASCII
Cc: linuxppc-dev@ozlabs.org, Lee Revell <rlrevell@joe-job.com>,
	alsa-devel@alsa-project.org
List-Id: Linux on PowerPC Developers Mail List <linuxppc-dev.ozlabs.org>
List-Unsubscribe: <https://ozlabs.org/mailman/listinfo/linuxppc-dev>,
	<mailto:linuxppc-dev-request@ozlabs.org?subject=unsubscribe>
List-Archive: <http://ozlabs.org/pipermail/linuxppc-dev>
List-Post: <mailto:linuxppc-dev@ozlabs.org>
List-Help: <mailto:linuxppc-dev-request@ozlabs.org?subject=help>
List-Subscribe: <https://ozlabs.org/mailman/listinfo/linuxppc-dev>,
	<mailto:linuxppc-dev-request@ozlabs.org?subject=subscribe>

At Wed, 09 Aug 2006 14:38:38 +0200,
Johannes Berg wrote:
> 
> Takashi Iwai wrote:
> > A relevant question: do we need I2C_POWERMAC for both onyx and tas?
> >   
> Yes, there are PowerBooks and G5s with either. Actually, a bit more 
> thinking about this I'm pretty sure that it is used on all G5s by way of 
> how things are hooked up. There are SMU I2C busses too but they surely 
> don't connect any sound i2c stuff.

OK, now I added both I2C and I2C_POWERMAC and committed to ALSA tree.


Takashi

diff -r 67e0e0ca5f65 -r f72c2a462f76 aoa/codecs/Kconfig
--- a/aoa/codecs/Kconfig	Wed Aug 09 14:33:27 2006 +0200
+++ b/aoa/codecs/Kconfig	Wed Aug 09 14:51:14 2006 +0200
@@ -1,6 +1,8 @@ config SND_AOA_ONYX
 config SND_AOA_ONYX
 	tristate "support Onyx chip"
 	depends on SND_AOA
+	select I2C
+	select I2C_POWERMAC
 	---help---
 	This option enables support for the Onyx (pcm3052)
 	codec chip found in the latest Apple machines
@@ -18,6 +20,8 @@ config SND_AOA_TAS
 config SND_AOA_TAS
 	tristate "support TAS chips"
 	depends on SND_AOA
+	select I2C
+	select I2C_POWERMAC
 	---help---
 	This option enables support for the tas chips
 	found in a lot of Apple Machines, especially