From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.suse.de (mx2.suse.de [195.135.220.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 41HQPJ3LVtzF1Qp for ; Sat, 30 Jun 2018 04:37:33 +1000 (AEST) Date: Fri, 29 Jun 2018 20:37:28 +0200 Message-ID: From: Takashi Iwai To: "Nicholas Mc Guire" Cc: "Johannes Berg" , , , "Jaroslav Kysela" , Subject: Re: [PATCH] ALSA: snd-aoa: add of_node_put() in error path In-Reply-To: <1530292062-31567-1-git-send-email-hofrat@osadl.org> References: <1530292062-31567-1-git-send-email-hofrat@osadl.org> MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Fri, 29 Jun 2018 19:07:42 +0200, Nicholas Mc Guire wrote: > > Both calls to of_find_node_by_name() and of_get_next_child() return a > node pointer with refcount incremented thus it must be explicidly > decremented here after the last usage. As we are assured to have a > refcounted np either from the initial > of_find_node_by_name(NULL, name); or from the of_get_next_child(gpio, np) > in the while loop if we reached the error code path below, an > x of_node_put(np) is needed. > > Signed-off-by: Nicholas Mc Guire > Fixes: commit f3d9478b2ce4 ("[ALSA] snd-aoa: add snd-aoa") > --- > > Problem located by an experimental coccinelle script > > Patch was compiletested with: ppc64_defconfig (implies CONFIG_SND_AOA=m) > > Patch is against 4.18-rc2 (localversion-next is next-20180629) Applied, thanks. Takashi