linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: Hirokazu Takata <takata@linux-m32r.org>
To: linux-ia64@vger.kernel.org, linux-mips@linux-mips.org,
	linuxppc-embedded@ozlabs.org, paulkf@microgate.com,
	takata@linux-m32r.org, linux-kernel@vger.kernel.org
Subject: Re: [CFT:PATCH] Removing possible wrong asm/serial.h inclusions
Date: Wed, 30 Aug 2006 22:03:40 +0900	[thread overview]
Message-ID: <swf8xl61ikz.wl%takata.hirokazu@renesas.com> (raw)
In-Reply-To: <20060828085244.GA13544@flint.arm.linux.org.uk>

From: Russell King <rmk+lkml@arm.linux.org.uk>
Subject: [CFT:PATCH] Removing possible wrong asm/serial.h inclusions
Date: Mon, 28 Aug 2006 09:52:44 +0100
> diff --git a/drivers/serial/m32r_sio.c b/drivers/serial/m32r_sio.c
> --- a/drivers/serial/m32r_sio.c
> +++ b/drivers/serial/m32r_sio.c
> @@ -76,17 +76,16 @@
>   */
>  #define is_real_interrupt(irq)	((irq) != 0)
>  
> -#include <asm/serial.h>
> +#define BASE_BAUD	115200
>  
>  /* Standard COM flags */
>  #define STD_COM_FLAGS (UPF_BOOT_AUTOCONF | UPF_SKIP_TEST)
>  
>  /*
>   * SERIAL_PORT_DFNS tells us about built-in ports that have no
>   * standard enumeration mechanism.   Platforms that can find all
>   * serial ports via mechanisms like ACPI or PCI need not supply it.
>   */
> -#undef SERIAL_PORT_DFNS
>  #if defined(CONFIG_PLAT_USRV)
>  
>  #define SERIAL_PORT_DFNS						\
> @@ -109,7 +108,7 @@
>  #endif /* !CONFIG_PLAT_USRV */
>  
>  static struct old_serial_port old_serial_port[] = {
> -	SERIAL_PORT_DFNS	/* defined in asm/serial.h */
> +	SERIAL_PORT_DFNS
>  };
>  
>  #define UART_NR	ARRAY_SIZE(old_serial_port)
> 

Acked-by: Hirokazu Takata <takata@linux-m32r.org>

Thank you.

-- Takata

  parent reply	other threads:[~2006-08-30 13:09 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-08-28  8:52 [CFT:PATCH] Removing possible wrong asm/serial.h inclusions Russell King
2006-08-29 16:17 ` Ralf Baechle
2006-08-30  9:09 ` David Howells
2006-08-30 13:03 ` Hirokazu Takata [this message]
  -- strict thread matches above, loose matches on Subject: below --
2006-08-28 16:28 Luck, Tony
2006-08-28 20:05 Mark A. Greer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=swf8xl61ikz.wl%takata.hirokazu@renesas.com \
    --to=takata@linux-m32r.org \
    --cc=linux-ia64@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mips@linux-mips.org \
    --cc=linuxppc-embedded@ozlabs.org \
    --cc=paulkf@microgate.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).