From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-gy0-f170.google.com (mail-gy0-f170.google.com [209.85.160.170]) by ozlabs.org (Postfix) with ESMTP id B953BB7CF8 for ; Tue, 6 Apr 2010 05:32:17 +1000 (EST) Received: by gyf2 with SMTP id 2so2101356gyf.15 for ; Mon, 05 Apr 2010 12:32:15 -0700 (PDT) MIME-Version: 1.0 Sender: glikely@secretlab.ca In-Reply-To: <20100405.121647.91426186.davem@davemloft.net> References: <20100405.121647.91426186.davem@davemloft.net> From: Grant Likely Date: Mon, 5 Apr 2010 13:31:55 -0600 Message-ID: Subject: Re: [PATCH] [V2] Add non-Virtex5 support for LL TEMAC driver To: David Miller Content-Type: text/plain; charset=ISO-8859-1 Cc: linuxppc-dev@ozlabs.org, netdev@vger.kernel.org, jtyner@cs.ucr.edu, michal.simek@petalogix.com, john.linn@xilinx.com, john.williams@petalogix.com List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Mon, Apr 5, 2010 at 1:16 PM, David Miller wrote: > From: Grant Likely > Date: Mon, 5 Apr 2010 12:10:51 -0600 > >> David, are you going to pick up this patch, or would you like me to? > > The submitter, when asked, stated that he couldn't even get > the driver to build on microblaze against mainline. > > So I marked the patch "changed requested" because being able > to build is... you know... sort of a requirement for integration. Heh, the current driver doesn't build on microblaze either. However, John, since you're removing the depends on PPC_DCR_NATIVE, can you please respin the patch to make it depend on CONFIG_PPC and CONFIG_OF. Looking at it now I see that as-is it will cause collateral damage to allmodconfig on every other architecture. g.