From: Stefan Richter <stefanr@s5r6.in-berlin.de>
To: linux1394-devel@lists.sourceforge.net
Cc: linuxppc-dev@ozlabs.org,
Gioele Barabucci <dev@gioelebarabucci.com>,
Olaf Hering <olaf@aepfle.de>
Subject: [PATCH update 3/3] ieee1394: ohci1394: call PMac code in shutdown only for proper machines
Date: Sat, 11 Nov 2006 00:26:24 +0100 (CET) [thread overview]
Message-ID: <tkrat.9fa7eb5af4b571c3@s5r6.in-berlin.de> (raw)
In-Reply-To: <tkrat.210c1fb372b68f41@s5r6.in-berlin.de>
There has been an if(...) missing, for ages.
Signed-off-by: Stefan Richter <stefanr@s5r6.in-berlin.de>
---
drivers/ieee1394/ohci1394.c | 2 +-
1 files changed, 1 insertion(+), 1 deletion(-)
Index: linux/drivers/ieee1394/ohci1394.c
===================================================================
--- linux.orig/drivers/ieee1394/ohci1394.c 2006-11-11 00:13:45.000000000 +0100
+++ linux/drivers/ieee1394/ohci1394.c 2006-11-11 00:16:37.000000000 +0100
@@ -3517,7 +3517,7 @@ static void ohci1394_pci_remove(struct p
#ifdef CONFIG_PPC_PMAC
/* On UniNorth, power down the cable and turn off the chip clock
* to save power on laptops */
- {
+ if (machine_is(powermac)) {
struct device_node* ofn = pci_device_to_OF_node(ohci->dev);
if (ofn) {
next prev parent reply other threads:[~2006-11-10 23:27 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-11-05 10:41 [Fwd: [Bug 7431] New: ohci1394 Oops after a rmmod/modprobe cycle] Stefan Richter
2006-11-05 10:54 ` Benjamin Herrenschmidt
2006-11-05 11:22 ` Stefan Richter
2006-11-05 11:37 ` Stefan Richter
2006-11-05 12:59 ` Benjamin Herrenschmidt
2006-11-10 22:43 ` [PATCH 1/2] ieee1394: ohci1394: add PPC_PMAC platform code to driver probe Stefan Richter
2006-11-10 22:44 ` [PATCH 2/2] ieee1394: ohci1394: reformat PPC_PMAC platform code Stefan Richter
2006-11-06 16:58 ` [Fwd: [Bug 7431] New: ohci1394 Oops after a rmmod/modprobe cycle] Olaf Hering
2006-11-06 22:19 ` Benjamin Herrenschmidt
2006-11-07 7:08 ` Olaf Hering
2006-11-07 7:17 ` Benjamin Herrenschmidt
2006-11-10 22:39 ` Stefan Richter
2006-11-10 23:07 ` Stefan Richter
2006-11-10 23:10 ` Benjamin Herrenschmidt
2006-11-10 23:22 ` [PATCH update 1/3] ieee1394: ohci1394: add PPC_PMAC platform code to driver probe Stefan Richter
2006-11-10 23:23 ` [PATCH update 2/3] ieee1394: ohci1394: reformat PPC_PMAC platform code Stefan Richter
2006-11-10 23:26 ` Stefan Richter [this message]
2006-11-10 23:55 ` [Fwd: [Bug 7431] New: ohci1394 Oops after a rmmod/modprobe cycle] Stefan Richter
2006-11-11 1:31 ` Benjamin Herrenschmidt
2006-11-13 17:58 ` Olaf Hering
2006-11-13 19:08 ` Stefan Richter
2006-11-14 2:09 ` Benjamin Herrenschmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=tkrat.9fa7eb5af4b571c3@s5r6.in-berlin.de \
--to=stefanr@s5r6.in-berlin.de \
--cc=dev@gioelebarabucci.com \
--cc=linux1394-devel@lists.sourceforge.net \
--cc=linuxppc-dev@ozlabs.org \
--cc=olaf@aepfle.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).