From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-we0-x230.google.com (mail-we0-x230.google.com [IPv6:2a00:1450:400c:c03::230]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id A5E691A0A1F for ; Wed, 11 Jun 2014 18:25:03 +1000 (EST) Received: by mail-we0-f176.google.com with SMTP id u56so4020089wes.7 for ; Wed, 11 Jun 2014 01:24:59 -0700 (PDT) Sender: Michal Nazarewicz From: Michal Nazarewicz To: Joonsoo Kim Subject: Re: [RFC PATCH 2/3] DMA, CMA: use general CMA reserved area management framework In-Reply-To: <20140610024910.GB19036@js1304-P5Q-DELUXE> References: <1401757919-30018-1-git-send-email-iamjoonsoo.kim@lge.com> <1401757919-30018-3-git-send-email-iamjoonsoo.kim@lge.com> <20140610024910.GB19036@js1304-P5Q-DELUXE> Date: Wed, 11 Jun 2014 10:24:55 +0200 Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Cc: Russell King - ARM Linux , kvm@vger.kernel.org, linux-mm@kvack.org, Gleb Natapov , Greg Kroah-Hartman , Alexander Graf , kvm-ppc@vger.kernel.org, linux-kernel@vger.kernel.org, Minchan Kim , Paul Mackerras , "Aneesh Kumar K.V" , Paolo Bonzini , Andrew Morton , linuxppc-dev@lists.ozlabs.org, linux-arm-kernel@lists.infradead.org, Marek Szyprowski List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Tue, Jun 10 2014, Joonsoo Kim wrote: > Without including device.h, build failure occurs. > In dma-contiguous.h, we try to access to dev->cma_area, so we need > device.h. In the past, we included it luckily by swap.h in > drivers/base/dma-contiguous.c. Swap.h includes node.h and then node.h > includes device.h, so we were happy. But, in this patch, I remove > 'include ' so we need to include device.h explicitly. Ack. --=20 Best regards, _ _ .o. | Liege of Serenely Enlightened Majesty of o' \,=3D./ `o ..o | Computer Science, Micha=C5=82 =E2=80=9Cmina86=E2=80=9D Nazarewicz = (o o) ooo +------ooO--(_)--Ooo--