From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 46867C433E0 for ; Sat, 18 Jul 2020 19:14:52 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [203.11.71.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A6A2B20657 for ; Sat, 18 Jul 2020 19:14:51 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=google.com header.i=@google.com header.b="VLkScLOa" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A6A2B20657 Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Received: from bilbo.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 4B8Hk10hVzzDrBy for ; Sun, 19 Jul 2020 05:14:49 +1000 (AEST) Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=flex--gthelen.bounces.google.com (client-ip=2607:f8b0:4864:20::549; helo=mail-pg1-x549.google.com; envelope-from=3vektxwckdjsboc9g9ibjjbg9.7jhgdipskk7-89qgdnon.jug56n.jmb@flex--gthelen.bounces.google.com; receiver=) Authentication-Results: lists.ozlabs.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=google.com header.i=@google.com header.a=rsa-sha256 header.s=20161025 header.b=VLkScLOa; dkim-atps=neutral Received: from mail-pg1-x549.google.com (mail-pg1-x549.google.com [IPv6:2607:f8b0:4864:20::549]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4B8Hh85sX8zDr96 for ; Sun, 19 Jul 2020 05:13:04 +1000 (AEST) Received: by mail-pg1-x549.google.com with SMTP id j9so10497452pgm.8 for ; Sat, 18 Jul 2020 12:13:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:in-reply-to:message-id:mime-version:references:subject:from:to :cc; bh=AF6WzDREys7pX44hC1bnRv06arMUHM4xLeS+gr1uXIw=; b=VLkScLOaoK0Ukpw/Jn1jBHjHkQPxv/NzGahgmzX8U0JLGmdRxN0Z5glvG35Ea0KlV7 ccFW0AMVog87wJnx3QDFvbdWRS0xpiBN08aN8hkGBDjLElpckhcF+BzFhrA9RLinRlTn JoSfoaKHdvQd+4YPF+ARFjvAg3itMssIOypqgKovoyzyLzpFwKh0P9bYtktiYQQtHZ8h hbyFmZ7P7/6XZPpIZfBUXfGwQCvF9WTKWroTOUKeZpN0AZcCD7IKBonS4zuRJ5VlI421 GBEH7UGDNbj4YOBi5woahrem9VtRZPXYggSIkdJIh+2+Uf0ypGfEAzyr2CV9hiTq3Nc8 lzPQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:in-reply-to:message-id:mime-version :references:subject:from:to:cc; bh=AF6WzDREys7pX44hC1bnRv06arMUHM4xLeS+gr1uXIw=; b=TUf+q/j8iK45m/HFf8NFyCeQQqwKkZIdnOIOSXttLjMNRWhbX0C5HYnzpauNcv7Uma I5qKCACP4roNaXPj0gIrSRLndLcQhZ9R2lpjmyiCIsePL8gw26+6c4t8JtLE9qJpynFH nZhFASLyj2cdPFrbdZVDszMQXsMGK+bJmL9fdt1IRuBJb17Ue1ao2mk+y056LJBCC8D0 0g0T70r5Cviimx0L9zdA7gIt3ebvUTTI7lLIaZ7b25pOSD6BjRrQXwC5K0nTiFqlYdtc 9a7HILBwyxFjIOw+kSXd0jPBonVE0Y5W3xmScr6qPTygAwi3T1190d6vTc+jE3q7mIYw 75Dw== X-Gm-Message-State: AOAM532FrBDXW43cWyDwl4NrYaBcVxOJ+WI43gLChE2hQ7y5JmJOQxl7 pA3lLiORG0zAdVozynOkxREZ+ghYWolb X-Google-Smtp-Source: ABdhPJx2fo6BNpvN/HcJneXKAp7Vtblyq6Xzc8545k3Dnwng76UGrnDP2f88KKuHDeAbqncqBVpbu0nztdy9 X-Received: by 2002:a62:be02:: with SMTP id l2mr12704136pff.163.1595099580890; Sat, 18 Jul 2020 12:13:00 -0700 (PDT) Date: Sat, 18 Jul 2020 12:12:58 -0700 In-Reply-To: Message-Id: Mime-Version: 1.0 References: <37af499e-2b8b-7e78-ed4b-0aaf711fcb38@csgroup.eu> <20200614233235.121432-1-gthelen@google.com> Subject: Re: [PATCH v2] powerpc/powernv/pci: use ifdef to avoid dead code From: Greg Thelen To: "Oliver O'Halloran" , Michael Ellerman Content-Type: text/plain; charset="UTF-8" X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Paul Mackerras , linuxppc-dev , Linux Kernel Mailing List Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" Oliver O'Halloran wrote: > On Mon, Jun 15, 2020 at 9:33 AM Greg Thelen wrote: >> >> Commit dc3d8f85bb57 ("powerpc/powernv/pci: Re-work bus PE >> configuration") removed a couple pnv_ioda_setup_bus_dma() calls. The >> only remaining calls are behind CONFIG_IOMMU_API. Thus builds without >> CONFIG_IOMMU_API see: >> arch/powerpc/platforms/powernv/pci-ioda.c:1888:13: error: 'pnv_ioda_setup_bus_dma' defined but not used >> >> Move pnv_ioda_setup_bus_dma() under CONFIG_IOMMU_API to avoid dead code. > > Doh! Thanks for the fix. > > Reviewed-by: Oliver O'Halloran Is there anything else needed from me on this patch? Given that it fixes a 5.8 commit I figured it'd be 5.8 material.