From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <tsutomu.owa@toshiba.co.jp>
Received: from imx11.toshiba.co.jp (imx11.toshiba.co.jp [61.202.160.20])
	(using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))
	(Client did not present a certificate)
	by ozlabs.org (Postfix) with ESMTP id C24F367B7E
	for <linuxppc-dev@ozlabs.org>; Mon, 21 Aug 2006 19:44:38 +1000 (EST)
Date: Mon, 21 Aug 2006 18:44:06 +0900
Message-ID: <yyihd068luh.wl@forest.swc.toshiba.co.jp>
From: Tsutomu OWA <tsutomu.owa@toshiba.co.jp>
To: Daniel Walker <dwalker@mvista.com>
Subject: [RFC PATCH 3/4] powerpc 2.6.16-rt17: to support CONFIG_MCOUNT
In-Reply-To: <1155305556.16579.49.camel@c-67-188-28-158.hsd1.ca.comcast.net>
References: <yyilkpwhvwh.wl@forest.swc.toshiba.co.jp>
	<1155305556.16579.49.camel@c-67-188-28-158.hsd1.ca.comcast.net>
MIME-Version: 1.0 (generated by SEMI 1.14.4 - "Hosorogi")
Content-Type: text/plain; charset=US-ASCII
Cc: mingo@elte.hu, tglx@linutronix.de, linux-kernel@vger.kernel.org,
	linuxppc-dev@ozlabs.org
List-Id: Linux on PowerPC Developers Mail List <linuxppc-dev.ozlabs.org>
List-Unsubscribe: <https://ozlabs.org/mailman/listinfo/linuxppc-dev>,
	<mailto:linuxppc-dev-request@ozlabs.org?subject=unsubscribe>
List-Archive: <http://ozlabs.org/pipermail/linuxppc-dev>
List-Post: <mailto:linuxppc-dev@ozlabs.org>
List-Help: <mailto:linuxppc-dev-request@ozlabs.org?subject=help>
List-Subscribe: <https://ozlabs.org/mailman/listinfo/linuxppc-dev>,
	<mailto:linuxppc-dev-request@ozlabs.org?subject=subscribe>


Sorry about the late response and thanks a lot for your comments.

> On Fri, 11 Aug 2006 07:12:35 -0700, Daniel Walker <dwalker@mvista.com> said:

>> On Fri, 2006-08-11 at 11:02 +0900, Tsutomu OWA wrote:

>> +
>> +#if defined(CONFIG_PREEMPT_TRACE) || defined(CONFIG_LATENCY_TRACE)
>> +        print_traces(current);
>> +#endif /* CONFIG_PREEMPT_TRACE || CONFIG_LATENCY_TRACE */

> You shouldn't need the ifdef's here.

  Right.  I'll remove them.

>> +#ifdef CONFIG_DEBUG_MUTEXES
>> +	show_held_locks(current);
>> +#endif /* CONFIG_DEBUG_MUTEXES */
>> +
>> }
>> EXPORT_SYMBOL(dump_stack);
>> 
>> diff -rup -x CVS 2.6.16-rt17/arch/powerpc/kernel/prom.c rt-powerpc/arch/powerpc/kernel/prom.c

> Your on an ancient version of the -rt patch. I see that your using CVS
> which explains that. If you want to keep better pace you should consider
> not using CVS. 

  Hmm... I'll think about that.

>> diff -rup -x CVS 2.6.16-rt17/lib/string.c rt-powerpc/lib/string.c
>> --- 2.6.16-rt17/lib/string.c	2006-03-20 14:53:29.000000000 +0900
>> +++ rt-powerpc/lib/string.c	2006-06-16 13:08:07.000000000 +0900
>> @@ -67,7 +67,7 @@ EXPORT_SYMBOL(strnicmp);
>> * @src: Where to copy the string from
>> */
>> #undef strcpy
>> -char *strcpy(char *dest, const char *src)
>> +char * notrace strcpy(char *dest, const char *src)
>> {
>> char *tmp = dest;

> Why are these notrace ?

  Because these are called from prom_init before the relocation.
I was a bit reluctant to calcurate the address of mcount_enabled,
every time _mcount is called and was not sure if it's ok to call
__trace() at this early stage.

thanks.
-- owa
Software Engineering Center, TOSHIBA.