From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f41.google.com (mail-wm1-f41.google.com [209.85.128.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 567CA4430 for ; Mon, 27 Jan 2025 12:50:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.41 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1737982238; cv=none; b=dCOIVWIMHkElXZbzoJnIpzj68sVGZ/HGinAUU0jIkHI31UOtASybXgX9Yn7fLEJ43ipCsV9jTVr50BFDsygRm+WDK2cGnZKfFnfOp2DQUxcPPgfD3b03DIuLZz2DeUTOHGtD1A2Pnnt0Br3ARUGgD7+ZwwHwh7vJ31Woh89vGu8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1737982238; c=relaxed/simple; bh=HR4noXGU7w13ZIhOM/ucls8vVM3bhmVGGYLoZmvVDTY=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=PKTk4g0QVC+qOpIQrL2qOV4tnzDNQ/lYTaA/EkFWcNWu+WXP9vPqPQPW+YASU6zDBllPF0M9rHR8JwbMxdY2fAn/hQiX2SenWYp9kOXh1SySRaNEIqBk2zSK2lSOi1jOeSgEm+YPSsGpLsEfqdqC9D12x4d6l1ZwLIZA78kLFSY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com; spf=pass smtp.mailfrom=suse.com; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b=PyQZLNMp; arc=none smtp.client-ip=209.85.128.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b="PyQZLNMp" Received: by mail-wm1-f41.google.com with SMTP id 5b1f17b1804b1-4361c705434so30718585e9.3 for ; Mon, 27 Jan 2025 04:50:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1737982234; x=1738587034; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=VG6M7E++/3Ce9GXj2tezC00IBdvh1kteyj5hzR0NwA8=; b=PyQZLNMpcVv/C7aBWa3i52KmbAcnYmUFq8gKJojCHwVh04N4W5Jf8S5K0rmEWApHqN X93gpvF1GQFkJ1DFtHAoBHJckiAP3RU9fie6Xbw0vXq7ylpjHiww6RoOzN89jXFRN32x Q+wQXO+1zwxrvukDu9Bpe0dMNdQwux3a+D9Z7MeiiQ/3C2bb2wSSvV6EJfsbBYFcj3Ng vm2o+LlIeCdP/lHC7e0qSOdAB7FLP/OdrT9oyujN4J2gy6UMr7LlRiG20LsWk3jw8mJa cgtGJGcT5IRkhwdT7jYeDvhrlJzGBedfWqUbeGG8pNOlegM2Y/dhITi/KOJhQS2RQczD RWBQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1737982234; x=1738587034; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=VG6M7E++/3Ce9GXj2tezC00IBdvh1kteyj5hzR0NwA8=; b=u4CnmEAOawFdpfVufMkMjVyY9L62RtzEnFVaeiXY5VJWvktGRatXr6gZymyqLsPhhp 356/Rw+7lTeJq28ZpoetxW4kDf8amti1aR68638sOkDwJLvp7WPY490Zo2jVkiFLJ2LO t6V0IeaEYS3ATgjcDsNZKNJ587zalU9cybEofNvBbpy42MTwkJ1NApCRdMxQQlCNskh2 2YnkZxAf8zotB6CVOQeHYAXIv5GS99uGu7r5RaCN0/CqfRSeQzGR8nxv+5rEie6EUK/n zvmMjfEXXCMcL0SVRbzMdxb1FoCXuAU+BhjJPAt4N6ZaS/I/cQ/EENpDDEcfe2j4CLH/ ELbg== X-Forwarded-Encrypted: i=1; AJvYcCX9iF1uc+Y04FdUn6rrXgEbgCHrBm6fsfCVrJ6IZPUDUP7KIqmZfgVPWO/ONdxsj0j92ldWsP2iHhcJRBZI@vger.kernel.org X-Gm-Message-State: AOJu0YxAYSo6MD6FzOm9joA7MoXlGO/XFmnb6zU27ZZCbp8FNkGhzIsg RA2HWbpfP5x+LKTJ+NNLeeKZw40xHYwaEsAGuCanGnlxoEZunWt/dOBYa1opleM= X-Gm-Gg: ASbGncvjW/Weo8IR5/++XDflwiU0BnxUsNwUYL4DEZxmA344pp0q5fxVD6i4WG7ereq OprFWfhohxMXW8b6+vZ8cd8UdhnTO3obdsyV3L6Jp79uQjAr6b6aiAFRQTvn0n6enGvt55RsRtY 0ZtYK35AfZBm4g7ON900aKg2WY9OimnokBgaGzablrj4j0QVY0Wajl7849ZzYnTu8/u4eJGVORv 8KwJu/sv0S97UOYji31VBxgCxeBvShsaILs1Zd0mrhjbxSVbO88GohrEp1Iu2OpejYXkmZClkNJ kjH5ZYPB X-Google-Smtp-Source: AGHT+IHGKx5XPAjKkuM8tLdY/iEmI+lFN9vw68MEGkVKzufCkr8AVUadSDTJkGDjd3qRPKQy8gyy+g== X-Received: by 2002:a05:600c:46ca:b0:434:a367:2bd9 with SMTP id 5b1f17b1804b1-438913dfd7fmr435221995e9.14.1737982233635; Mon, 27 Jan 2025 04:50:33 -0800 (PST) Received: from [10.100.51.161] ([193.86.92.181]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-438bd54bfb0sm128676475e9.32.2025.01.27.04.50.31 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 27 Jan 2025 04:50:33 -0800 (PST) Message-ID: <021665c5-b017-415f-ad2b-0131dcc81068@suse.com> Date: Mon, 27 Jan 2025 13:50:31 +0100 Precedence: bulk X-Mailing-List: live-patching@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 6/9] module: switch to execmem API for remapping as RW and restoring ROX To: Mike Rapoport Cc: x86@kernel.org, Andrew Morton , Andy Lutomirski , Anton Ivanov , Borislav Petkov , Brendan Higgins , Daniel Gomez , Daniel Thompson , Dave Hansen , David Gow , Douglas Anderson , Ingo Molnar , Jason Wessel , Jiri Kosina , Joe Lawrence , Johannes Berg , Josh Poimboeuf , "Kirill A. Shutemov" , Lorenzo Stoakes , Luis Chamberlain , Mark Rutland , Masami Hiramatsu , Miroslav Benes , "H. Peter Anvin" , Peter Zijlstra , Petr Mladek , Rae Moar , Richard Weinberger , Sami Tolvanen , Shuah Khan , Song Liu , Steven Rostedt , Thomas Gleixner , kgdb-bugreport@lists.sourceforge.net, kunit-dev@googlegroups.com, linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-mm@kvack.org, linux-modules@vger.kernel.org, linux-trace-kernel@vger.kernel.org, linux-um@lists.infradead.org, live-patching@vger.kernel.org References: <20250126074733.1384926-1-rppt@kernel.org> <20250126074733.1384926-7-rppt@kernel.org> Content-Language: en-US From: Petr Pavlu In-Reply-To: <20250126074733.1384926-7-rppt@kernel.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 1/26/25 08:47, Mike Rapoport wrote: > From: "Mike Rapoport (Microsoft)" > > Instead of using writable copy for module text sections, temporarily remap > the memory allocated from execmem's ROX cache as writable and restore its > ROX permissions after the module is formed. > > This will allow removing nasty games with writable copy in alternatives > patching on x86. > > Signed-off-by: Mike Rapoport (Microsoft) [...] > +static void module_memory_restore_rox(struct module *mod) > +{ > + for_class_mod_mem_type(type, text) { > + struct module_memory *mem = &mod->mem[type]; > + > + if (mem->is_rox) > + execmem_restore_rox(mem->base, mem->size); > + } > +} > + Can the execmem_restore_rox() call here fail? I realize that there isn't much that the module loader can do if that happens, but should it be perhaps logged as a warning? -- Thanks, Petr