From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1EB2BC433FE for ; Mon, 21 Nov 2022 15:34:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229935AbiKUPe1 (ORCPT ); Mon, 21 Nov 2022 10:34:27 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59480 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231929AbiKUPeD (ORCPT ); Mon, 21 Nov 2022 10:34:03 -0500 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A281AC9014 for ; Mon, 21 Nov 2022 07:32:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1669044736; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=aAnNSC79PB+nEOAdqHzoVvnCbPLv+tVDX8zsNeLu1uI=; b=JUbPKXdGEjFbP6+KokuAzUXDV5UbjtS1B2Ex6FpbVNWmZn7pNPf3xrV4ENWUG23ac+WrUp Dke/AFoNJXOljZg3lFy77WVCQYgwO6r6HapBJtiqHKEhhtKj9W8funxvR7ANkpC7+spo81 gjVT7JIqsp/6mH2dfTuBJ9JxbhbYjno= Received: from mail-qt1-f199.google.com (mail-qt1-f199.google.com [209.85.160.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-272-4mn3iIwXOaC2CFYAcOoj5w-1; Mon, 21 Nov 2022 10:32:13 -0500 X-MC-Unique: 4mn3iIwXOaC2CFYAcOoj5w-1 Received: by mail-qt1-f199.google.com with SMTP id bz20-20020a05622a1e9400b003a646e03748so2933268qtb.12 for ; Mon, 21 Nov 2022 07:32:13 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:content-language:in-reply-to:mime-version :user-agent:date:message-id:from:references:cc:to:subject :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=aAnNSC79PB+nEOAdqHzoVvnCbPLv+tVDX8zsNeLu1uI=; b=YWi/BLhuFRyTZrDzeRilFrrUZo29pHrXKztnnVZjtDBsSUsnVjzSrI64aL5NdgdLdB CEa1YULzKPdRvkr0sy4Z6AoqB6L+S9kZ+GlIaxrqIutsHEIRQ56WaAqob9ObxbR5sWxw x8bbES4bTxDckNbOsAkAf1gNelqIcH0H109iCTnClEKfH3he7iA9GubzhrrW9qLCGwTN s6JgoHkQ0NqYkLl7fYOF/VW6V0g0AgX2UVtJqiVJPAp5+Q8MbmLwsiS/s3G/D/CfPUyF QDuaLTVOI72Z0P6AUsry51bnOTrq9Q4AllnvCxCtADndbbL+92bSCGiOspwyDCdG6ogB o35w== X-Gm-Message-State: ANoB5pkdBiyfLjl8dKaiI2oO6IsXWPPLyp+tG6D8pR/2/JA4NvPoCY7E UIfN+YTqZ9pdIBVVnOi//aOUqdpz+njRLuW7TZZb2dsQ/6TR+UZZaU1xlaCg5w6fE+HSl8aYhzY fY5u8S+UgiEKjxUBydOU5HPRJpg== X-Received: by 2002:a05:620a:c02:b0:6ec:54d6:ea87 with SMTP id l2-20020a05620a0c0200b006ec54d6ea87mr16526653qki.245.1669044733169; Mon, 21 Nov 2022 07:32:13 -0800 (PST) X-Google-Smtp-Source: AA0mqf5QzcKpByoH5IFOBRZhUId/n1mZE/TJWamNTXtflc+eRaSTrKwX2lDdC7dfI+/Rue70ehtUbg== X-Received: by 2002:a05:620a:c02:b0:6ec:54d6:ea87 with SMTP id l2-20020a05620a0c0200b006ec54d6ea87mr16526622qki.245.1669044732744; Mon, 21 Nov 2022 07:32:12 -0800 (PST) Received: from [192.168.1.9] (pool-68-160-135-240.bstnma.fios.verizon.net. [68.160.135.240]) by smtp.gmail.com with ESMTPSA id k7-20020ac80747000000b003a4d5fed8c3sm6718285qth.85.2022.11.21.07.32.11 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 21 Nov 2022 07:32:11 -0800 (PST) Subject: Re: [PATCH v6] livepatch: Clear relocation targets on a module removal To: Song Liu Cc: live-patching@vger.kernel.org, linux-kernel@vger.kernel.org, jpoimboe@kernel.org, jikos@kernel.org, mbenes@suse.cz, x86@kernel.org, linuxppc-dev@lists.ozlabs.org, Josh Poimboeuf , Petr Mladek References: <20220901171252.2148348-1-song@kernel.org> From: Joe Lawrence Message-ID: <09ac46a0-45fe-e280-cabb-682e05c7fddc@redhat.com> Date: Mon, 21 Nov 2022 10:32:17 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.10.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: live-patching@vger.kernel.org On 11/18/22 12:14 PM, Song Liu wrote: > Hi Petr, > > On Fri, Nov 18, 2022 at 8:24 AM Petr Mladek wrote: >> >> On Thu 2022-09-01 10:12:52, Song Liu wrote: > [...] >>> >>> arch/powerpc/kernel/module_32.c | 10 ++++ >>> arch/powerpc/kernel/module_64.c | 49 +++++++++++++++ >>> arch/s390/kernel/module.c | 8 +++ >>> arch/x86/kernel/module.c | 102 +++++++++++++++++++++++--------- >>> include/linux/moduleloader.h | 7 +++ >>> kernel/livepatch/core.c | 41 ++++++++++++- >> >> First, thanks a lot for working on this. >> >> I can't check or test the powerpc and s390 code easily. >> >> I am going to comment only x86 and generic code. It looks good >> but it needs some changes to improve maintainability. > > Thanks for these comments and suggestions. I will work on them > and send v4. > Hi Song, I'll help with testing the arches (at least ppc64le and s390x, I can only cross-build ppc32). I can either pick up the patches from the list when you post, or if you want to run them through testing first, lmk. Thanks, -- Joe