From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 35F19EB64D7 for ; Tue, 20 Jun 2023 07:47:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229970AbjFTHrI (ORCPT ); Tue, 20 Jun 2023 03:47:08 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46298 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229597AbjFTHrH (ORCPT ); Tue, 20 Jun 2023 03:47:07 -0400 Received: from mail.loongson.cn (mail.loongson.cn [114.242.206.163]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 97BB0188; Tue, 20 Jun 2023 00:47:04 -0700 (PDT) Received: from loongson.cn (unknown [113.200.148.30]) by gateway (Coremail) with SMTP id _____8Dx_+t2WZFkcBoHAA--.14516S3; Tue, 20 Jun 2023 15:47:02 +0800 (CST) Received: from bogon.localdomain (unknown [113.200.148.30]) by localhost.localdomain (Coremail) with SMTP id AQAAf8DxK8pvWZFkJGYhAA--.19652S2; Tue, 20 Jun 2023 15:46:55 +0800 (CST) From: Youling Tang To: Josh Poimboeuf , Peter Zijlstra , Huacai Chen , madvenka@linux.microsoft.com Cc: chenzhongjin@huawei.com, WANG Xuerui , Xi Ruoyao , live-patching@vger.kernel.org, linux-kernel@vger.kernel.org, loongarch@lists.linux.dev, tangyouling00@gmail.com, youling.tang@outlook.com Subject: [RFC PATCH v1 00/23] LoongArch: Add objtool and ORC unwinder support Date: Tue, 20 Jun 2023 15:46:26 +0800 Message-Id: <1687247209-31676-1-git-send-email-tangyouling@loongson.cn> X-Mailer: git-send-email 2.1.0 X-CM-TRANSID: AQAAf8DxK8pvWZFkJGYhAA--.19652S2 X-CM-SenderInfo: 5wdqw5prxox03j6o00pqjv00gofq/ X-Coremail-Antispam: 1Uk129KBj93XoW3JF17Xw17XrWktr17AF1xXrc_yoW3Cw1UpF srCrZ3GF4UWr93Zw1Ut3WUurWDJan7Wr12g3ZrXry8CFW2qrnrJrsakr1DAF9Fqw4rKFy0 qFn5Wrn8WF4jvabCm3ZEXasCq-sJn29KB7ZKAUJUUUU3529EdanIXcx71UUUUU7KY7ZEXa sCq-sGcSsGvfJ3Ic02F40EFcxC0VAKzVAqx4xG6I80ebIjqfuFe4nvWSU5nxnvy29KBjDU 0xBIdaVrnRJUUUB2b4IE77IF4wAFF20E14v26r1j6r4UM7CY07I20VC2zVCF04k26cxKx2 IYs7xG6rWj6s0DM7CIcVAFz4kK6r1Y6r17M28lY4IEw2IIxxk0rwA2F7IY1VAKz4vEj48v e4kI8wA2z4x0Y4vE2Ix0cI8IcVAFwI0_Gr0_Xr1l84ACjcxK6xIIjxv20xvEc7CjxVAFwI 0_Gr0_Cr1l84ACjcxK6I8E87Iv67AKxVW8Jr0_Cr1UM28EF7xvwVC2z280aVCY1x0267AK xVW8Jr0_Cr1UM2kKe7AKxVWUAVWUtwAS0I0E0xvYzxvE52x082IY62kv0487Mc804VCY07 AIYIkI8VC2zVCFFI0UMc02F40EFcxC0VAKzVAqx4xG6I80ewAv7VC0I7IYx2IY67AKxVWU AVWUtwAv7VC2z280aVAFwI0_Gr0_Cr1lOx8S6xCaFVCjc4AY6r1j6r4UM4x0Y48IcxkI7V AKI48JMxkF7I0En4kS14v26r126r1DMxAIw28IcxkI7VAKI48JMxC20s026xCaFVCjc4AY 6r1j6r4UMxCIbckI1I0E14v26r126r1DMI8I3I0E5I8CrVAFwI0_Jr0_Jr4lx2IqxVCjr7 xvwVAFwI0_JrI_JrWlx4CE17CEb7AF67AKxVWUtVW8ZwCIc40Y0x0EwIxGrwCI42IY6xII jxv20xvE14v26r1I6r4UMIIF0xvE2Ix0cI8IcVCY1x0267AKxVWUJVW8JwCI42IY6xAIw2 0EY4v20xvaj40_Jr0_JF4lIxAIcVC2z280aVAFwI0_Jr0_Gr1lIxAIcVC2z280aVCY1x02 67AKxVWUJVW8JbIYCTnIWIevJa73UjIFyTuYvjxU4SoGDUUUU Precedence: bulk List-ID: X-Mailing-List: live-patching@vger.kernel.org This series of patches adds objtool and ORC unwinder support for LoongArch. Patch 01 - 07 are from "Madhavan T. Venkataraman" [1] with minor code tweaks. The "objtool: Reorganize ORC types" patch was not added, because LoongArch cannot share `strcut orc_entry`, it also needs to include ra_offset and ra_reg. Since the changes in Patch 01 - 08 in [1] are architecture-independent, it might be better if they could be separated separately from the series of patches. ORC unwinder can get a reliable stack trace, which provides a prerequisite for the subsequent addition of livepatch support. Instruction decoder =================== To do this, an instruction decoder needs to be implemented. I have implemented a simple, table-driven decoder for LoongArch. Only a subset of the instructions needs to be fully decoded for this purpose: - Load-Store instructions - Add instructions - Branch instructions - Call instructions - Return instructions - Stack pointer authentication instruction Unwind hints ============ Unwind hints are collected in a special section. Objtool converts unwind hints to ORC data. The unwinder processes unwind hints to handle special cases mentioned above. ORC unwinder ============ Before vmlinux created, we check all metadata, find the stack operation, note stack state and create orc data. Objtool insert two sections into vmlinux. '.orc_unwind_ip' and '.orc_unwind'. (For modules, insert '.rela.orc_unwind_ip' to relocate '.orc_unwind_ip'.) Each insn has only one stack state in .orc_unwind and orc_unwind_ip hint its pc address. Through unwinding orc data, we can get stack info both kernel and module. This is a series of RFC patches, which may require long-term discussions and revisions. It is not based on the latest code but based on 6.3-rc3. Any ideas or suggestions are welcome. base-commit: e8d018dd0257f744ca50a729e3d042cf2ec9da65 (Linux 6.3-rc3) Link: [1]: https://lore.kernel.org/lkml/20230202074036.507249-1-madvenka@linux.microsoft.com/#r Madhavan T. Venkataraman (7): objtool: Reorganize CFI code objtool: Reorganize instruction-related code objtool: Move decode_instructions() to a separate file objtool: Reorganize Unwind hint code objtool: Reorganize ORC code objtool: Reorganize ORC kernel code objtool: Introduce STATIC_CHECK Youling Tang (16): tools: LoongArch: Copy inst.h and asm.h to tools objtool: LoongArch: Add base definition for LoongArch objtool: LoongArch: Implement decoder objtool: Add annotate_reachable() for objtools LoongArch: bug: Add reachable annotation to warning macros objtool: Add next member in struct reloc objtool: Add orc_print_dump() package objtool: Add ORC support for LoongArch LoongArch: Add ORC unwinder support LoongArch: Support R_LARCH_32_PCREL relocation type in kernel module LoongArch: Fix fpu.S objtool warning LoongArch: Annotate unwind_hint LoongArch: Move some data definitions into the .data section objtool: Add arch-specific "noreturn" function handling objtool: Make update_cfi_state() arch-specific function LoongArch: objtool: Mark non-standard object files and directories arch/loongarch/Kconfig | 2 + arch/loongarch/Kconfig.debug | 11 + arch/loongarch/Makefile | 4 + arch/loongarch/include/asm/bug.h | 1 + arch/loongarch/include/asm/module.h | 7 + arch/loongarch/include/asm/orc_types.h | 58 ++ arch/loongarch/include/asm/stackframe.h | 3 + arch/loongarch/include/asm/unwind.h | 17 +- arch/loongarch/include/asm/unwind_hints.h | 110 +++ arch/loongarch/kernel/Makefile | 3 + arch/loongarch/kernel/entry.S | 2 + arch/loongarch/kernel/fpu.S | 11 +- arch/loongarch/kernel/genex.S | 2 + arch/loongarch/kernel/head.S | 1 + arch/loongarch/kernel/module.c | 21 +- arch/loongarch/kernel/relocate_kernel.S | 12 +- arch/loongarch/kernel/setup.c | 2 + arch/loongarch/kernel/stacktrace.c | 1 + arch/loongarch/kernel/unwind_orc.c | 301 +++++++++ arch/loongarch/kernel/vmlinux.lds.S | 3 + arch/loongarch/power/Makefile | 2 + arch/loongarch/vdso/Makefile | 2 + arch/x86/include/asm/unwind.h | 5 - arch/x86/include/asm/unwind_hints.h | 86 +++ arch/x86/kernel/module.c | 7 +- arch/x86/kernel/unwind_orc.c | 268 +------- arch/x86/kernel/vmlinux.lds.S | 2 +- .../asm => include/asm-generic}/orc_lookup.h | 43 ++ include/linux/compiler.h | 9 + include/linux/objtool.h | 70 -- kernel/Makefile | 2 + kernel/orc_lookup.c | 261 ++++++++ scripts/Makefile | 5 +- tools/arch/loongarch/include/asm/asm.h | 201 ++++++ tools/arch/loongarch/include/asm/inst.h | 629 ++++++++++++++++++ tools/arch/loongarch/include/asm/orc_types.h | 58 ++ .../arch/loongarch/include/asm/unwind_hints.h | 110 +++ tools/arch/x86/include/asm/unwind_hints.h | 160 +++++ tools/include/linux/bitops.h | 10 + tools/include/linux/objtool.h | 70 -- tools/objtool/Build | 8 +- tools/objtool/Makefile | 9 +- tools/objtool/arch/loongarch/Build | 3 + tools/objtool/arch/loongarch/decode.c | 352 ++++++++++ .../arch/loongarch/include/arch/cfi_regs.h | 14 + .../objtool/arch/loongarch/include/arch/elf.h | 15 + .../arch/loongarch/include/arch/special.h | 21 + tools/objtool/arch/loongarch/orc.c | 155 +++++ tools/objtool/arch/loongarch/special.c | 25 + tools/objtool/arch/powerpc/special.c | 3 + tools/objtool/arch/x86/Build | 1 + tools/objtool/arch/x86/include/arch/elf.h | 1 + tools/objtool/arch/x86/orc.c | 164 +++++ tools/objtool/arch/x86/special.c | 4 + tools/objtool/cfi.c | 108 +++ tools/objtool/check.c | 568 +--------------- tools/objtool/decode.c | 136 ++++ tools/objtool/elf.c | 11 +- tools/objtool/include/objtool/arch.h | 3 + tools/objtool/include/objtool/cfi.h | 12 + tools/objtool/include/objtool/check.h | 97 +-- tools/objtool/include/objtool/elf.h | 1 + tools/objtool/include/objtool/insn.h | 166 +++++ tools/objtool/include/objtool/objtool.h | 3 + tools/objtool/include/objtool/orc.h | 15 + tools/objtool/include/objtool/special.h | 3 + tools/objtool/insn.c | 195 ++++++ tools/objtool/orc_dump.c | 67 +- tools/objtool/orc_gen.c | 79 +-- tools/objtool/sync-check.sh | 9 + tools/objtool/unwind_hints.c | 107 +++ 71 files changed, 3721 insertions(+), 1206 deletions(-) create mode 100644 arch/loongarch/include/asm/orc_types.h create mode 100644 arch/loongarch/include/asm/unwind_hints.h create mode 100644 arch/loongarch/kernel/unwind_orc.c rename {arch/x86/include/asm => include/asm-generic}/orc_lookup.h (50%) create mode 100644 kernel/orc_lookup.c create mode 100644 tools/arch/loongarch/include/asm/asm.h create mode 100644 tools/arch/loongarch/include/asm/inst.h create mode 100644 tools/arch/loongarch/include/asm/orc_types.h create mode 100644 tools/arch/loongarch/include/asm/unwind_hints.h create mode 100644 tools/arch/x86/include/asm/unwind_hints.h create mode 100644 tools/objtool/arch/loongarch/Build create mode 100644 tools/objtool/arch/loongarch/decode.c create mode 100644 tools/objtool/arch/loongarch/include/arch/cfi_regs.h create mode 100644 tools/objtool/arch/loongarch/include/arch/elf.h create mode 100644 tools/objtool/arch/loongarch/include/arch/special.h create mode 100644 tools/objtool/arch/loongarch/orc.c create mode 100644 tools/objtool/arch/loongarch/special.c create mode 100644 tools/objtool/arch/x86/orc.c create mode 100644 tools/objtool/cfi.c create mode 100644 tools/objtool/decode.c create mode 100644 tools/objtool/include/objtool/insn.h create mode 100644 tools/objtool/include/objtool/orc.h create mode 100644 tools/objtool/insn.c create mode 100644 tools/objtool/unwind_hints.c -- 2.39.2