From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2CDD8C742D2 for ; Fri, 12 Jul 2019 17:58:16 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 066D32054F for ; Fri, 12 Jul 2019 17:58:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727186AbfGLR6P (ORCPT ); Fri, 12 Jul 2019 13:58:15 -0400 Received: from mx1.redhat.com ([209.132.183.28]:52264 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727118AbfGLR6P (ORCPT ); Fri, 12 Jul 2019 13:58:15 -0400 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 525413091D67; Fri, 12 Jul 2019 17:58:15 +0000 (UTC) Received: from redhat.com (ovpn-122-246.rdu2.redhat.com [10.10.122.246]) by smtp.corp.redhat.com (Postfix) with ESMTPS id C9E8660A9A; Fri, 12 Jul 2019 17:58:14 +0000 (UTC) Date: Fri, 12 Jul 2019 13:58:12 -0400 From: Joe Lawrence To: shuah Cc: live-patching@vger.kernel.org, linux-kselftest@vger.kernel.org Subject: Re: [RFC PATCH] selftests/livepatch: only consider supported arches Message-ID: <20190712175812.GB15872@redhat.com> References: <20190712171402.15930-1-joe.lawrence@redhat.com> <20190712172517.GA15872@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.12.0 (2019-05-25) X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.42]); Fri, 12 Jul 2019 17:58:15 +0000 (UTC) Sender: live-patching-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: live-patching@vger.kernel.org On Fri, Jul 12, 2019 at 11:43:02AM -0600, shuah wrote: > Hi Joe, > > [ ... snip ... ] > > The one thing I am not seeing is Skip handling. Without that users will > complain livepatch test is failing as opposed to that the test can't > run due to unmet dependencies and skipped. > > Maybe that is all you need? I would recommend going in that direction > instead of Arch check. > Okay, I see that kselftest/runner.sh compares test return code with skip_rc=4 to determine SKIP status... so perhaps our scripts could perform a simple "modinfo" on their test modules to determine if they have been built and installed? If not found, just SKIP to the next test. Thanks, -- Joe