From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7393BC83001 for ; Tue, 28 Apr 2020 16:42:00 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 46511208FE for ; Tue, 28 Apr 2020 16:42:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1588092120; bh=Vvggmw/f87wJwwqcO00zpB4XAFeguB9nPxLBdxzSiWU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=DvLyAa9bm1FZtVnF/tdllZuykb/AcvMGesFqZF4T3vp/JuDhOLDjOWMBm8C53AZlE z0zJfRfp1a3xci4JXTtEvLnM7xf9iDJlFIjq4JiulyGix4naecWb39XCt9IppZ8gHv yloQP9oITMxuO/dQGWVOxIDHnJP+RqYP/RfGlQNw= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728253AbgD1QmA (ORCPT ); Tue, 28 Apr 2020 12:42:00 -0400 Received: from mail.kernel.org ([198.145.29.99]:50928 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728084AbgD1Ql7 (ORCPT ); Tue, 28 Apr 2020 12:41:59 -0400 Received: from linux-8ccs.fritz.box (p3EE2CE96.dip0.t-ipconnect.de [62.226.206.150]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 5321C206D6; Tue, 28 Apr 2020 16:41:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1588092119; bh=Vvggmw/f87wJwwqcO00zpB4XAFeguB9nPxLBdxzSiWU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=LVSPZw3itszoxEpvAzvTZ+ytG/GUhHhiSMC0d7+aJsOoXi2kpWiu7Ww0mOyeo3jtH H6+jVbCP+YkPtisGCGzxelfBoG+J4e81A0vaX5iQ9NdMeXbQfeWRK1SLv1SHqxN2qN iCgdUMfvJkBBZLrpOSA0fNmJcwaEaZ/SEhvIdxoU= Date: Tue, 28 Apr 2020 18:41:55 +0200 From: Jessica Yu To: Josh Poimboeuf Cc: live-patching@vger.kernel.org, linux-kernel@vger.kernel.org, Peter Zijlstra , Joe Lawrence Subject: Re: [PATCH v3 09/10] module: Remove module_disable_ro() Message-ID: <20200428164155.GB12860@linux-8ccs.fritz.box> References: <33089a8ffb2e724cecfa51d72887ae9bf70354f9.1587812518.git.jpoimboe@redhat.com> <20200428162505.GA12860@linux-8ccs.fritz.box> <20200428163602.77t6s2qeh4xeacdq@treble> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: <20200428163602.77t6s2qeh4xeacdq@treble> X-OS: Linux linux-8ccs 4.12.14-lp150.12.61-default x86_64 User-Agent: Mutt/1.10.1 (2018-07-13) Sender: live-patching-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: live-patching@vger.kernel.org +++ Josh Poimboeuf [28/04/20 11:36 -0500]: >On Tue, Apr 28, 2020 at 06:25:05PM +0200, Jessica Yu wrote: >> +++ Josh Poimboeuf [25/04/20 06:07 -0500]: >> > module_disable_ro() has no more users. Remove it. >> > >> > Signed-off-by: Josh Poimboeuf >> > Acked-by: Peter Zijlstra (Intel) >> >> Hm, I guess this means we can also remove the module_enable_ro() stubs >> in module.h and make it a static function again (like the other >> module_enable_* functions) as there are no more outside users. I have to >> remind myself after this patchset is merged :-) > >Ah, true. I'm respinning the patch set anyway, I can just add this as a >another patch. That would be great. Thanks!