From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C62B1C00A89 for ; Mon, 2 Nov 2020 14:41:12 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6CF492072C for ; Mon, 2 Nov 2020 14:41:12 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=suse.com header.i=@suse.com header.b="MpevfN3G" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726009AbgKBOlM (ORCPT ); Mon, 2 Nov 2020 09:41:12 -0500 Received: from mx2.suse.de ([195.135.220.15]:33474 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725788AbgKBOlM (ORCPT ); Mon, 2 Nov 2020 09:41:12 -0500 X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1604328070; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=hmEKAQREm+jqesAwSXDRO+rQTKsVN1T127G+Uf+JVEQ=; b=MpevfN3GJJcLe+03477VH/DUNhpuduQOcbmSpPfgj+CRO57PsmBxOZi4kSkYQyNn+QwTEh XRLu0p4M/LIfHx2kASuQ8NauWXzKqW79XRPyxXpBwTuS/hMTbzcKn+LAFeeMFjqIN0Wzd2 Vc/jygrb8Kc1YkkysPh2Y9GFWXG9WhQ= Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 55D68AD6B; Mon, 2 Nov 2020 14:41:10 +0000 (UTC) Date: Mon, 2 Nov 2020 15:41:09 +0100 From: Petr Mladek To: Steven Rostedt Cc: linux-kernel@vger.kernel.org, Masami Hiramatsu , Andrew Morton , Peter Zijlstra , Ingo Molnar , Josh Poimboeuf , Jiri Kosina , Miroslav Benes , Joe Lawrence , live-patching@vger.kernel.org Subject: Re: [PATCH 07/11 v2] livepatch: Trigger WARNING if livepatch function fails due to recursion Message-ID: <20201102144109.GI20201@alley> References: <20201030213142.096102821@goodmis.org> <20201030214014.167613723@goodmis.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201030214014.167613723@goodmis.org> Precedence: bulk List-ID: X-Mailing-List: live-patching@vger.kernel.org On Fri 2020-10-30 17:31:49, Steven Rostedt wrote: > From: "Steven Rostedt (VMware)" > > If for some reason a function is called that triggers the recursion > detection of live patching, trigger a warning. By not executing the live > patch code, it is possible that the old unpatched function will be called > placing the system into an unknown state. > > Link: https://lore.kernel.org/r/20201029145709.GD16774@alley > > Cc: Josh Poimboeuf > Cc: Jiri Kosina > Cc: Miroslav Benes > Cc: Joe Lawrence > Cc: live-patching@vger.kernel.org > Suggested-by: Petr Mladek It has actually been first suggested by Miroslav. He might want to take the fame and eventual shame ;-) > Signed-off-by: Steven Rostedt (VMware) Reviewed-by: Petr Mladek Best Regards, Petr