From: David Vernet <void@manifault.com>
To: Joe Lawrence <joe.lawrence@redhat.com>
Cc: live-patching@vger.kernel.org, linux-kernel@vger.kernel.org,
jpoimboe@redhat.com, pmladek@suse.com, jikos@kernel.org,
mbenes@suse.cz, corbet@lwn.net, kernel-team@fb.com
Subject: Re: [PATCH] livepatch: Skip livepatch tests if ftrace cannot be configured
Date: Fri, 4 Feb 2022 12:43:03 -0800 [thread overview]
Message-ID: <20220204204303.scyxvt4yh2gjftce@dev0025.ash9.facebook.com> (raw)
In-Reply-To: <917650f7-4e8c-4643-77d3-45d1ebbb217f@redhat.com>
On Fri, Feb 04, 2022 at 03:30:02PM -0500, Joe Lawrence wrote:
Hi Joe,
Thanks for the review.
> sp: s/permament/permanent
>
Ack, thanks for catching that.
> > + if [[ "$result" == *"Device or resource busy"* ]]; then
> > + skip "failed to set kernel.ftrace_enabled=$1"
> > + fi
> > +
>
> style nit: move the blank line from here to just before the new # Skip
> comment
Ack.
> Can we be more paranoid and just look for the exact result that we expect:
>
> if [[ "$result" != "kernel.ftrace_enabled = 1" ]]; then
> skip "failed to set kernel.ftrace_enabled=$1"
> fi
Agreed, this is cleaner and less brittle.
I'll follow-up with a v2 patch shortly. Thanks!
- David
next prev parent reply other threads:[~2022-02-04 20:43 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-03 23:32 [PATCH] livepatch: Skip livepatch tests if ftrace cannot be configured David Vernet
2022-02-04 20:30 ` Joe Lawrence
2022-02-04 20:43 ` David Vernet [this message]
2022-02-04 20:56 ` [PATCH v2] " David Vernet
2022-02-08 15:45 ` Joe Lawrence
2022-02-09 13:02 ` Petr Mladek
2022-02-09 15:49 ` David Vernet
2022-02-10 15:23 ` Petr Mladek
2022-02-10 16:22 ` David Vernet
2022-02-10 20:58 ` Joe Lawrence
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220204204303.scyxvt4yh2gjftce@dev0025.ash9.facebook.com \
--to=void@manifault.com \
--cc=corbet@lwn.net \
--cc=jikos@kernel.org \
--cc=joe.lawrence@redhat.com \
--cc=jpoimboe@redhat.com \
--cc=kernel-team@fb.com \
--cc=linux-kernel@vger.kernel.org \
--cc=live-patching@vger.kernel.org \
--cc=mbenes@suse.cz \
--cc=pmladek@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox