From: Steven Rostedt <rostedt@goodmis.org>
To: Song Liu <song@kernel.org>
Cc: <netdev@vger.kernel.org>, <bpf@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, <ast@kernel.org>,
<daniel@iogearbox.net>, <andrii@kernel.org>, <kernel-team@fb.com>,
<jolsa@kernel.org>, <mhiramat@kernel.org>,
Josh Poimboeuf <jpoimboe@kernel.org>,
Jiri Kosina <jikos@kernel.org>, Miroslav Benes <mbenes@suse.cz>,
Petr Mladek <pmladek@suse.com>,
Joe Lawrence <joe.lawrence@redhat.com>,
live-patching@vger.kernel.org
Subject: Re: [PATCH v2 bpf-next 0/5] ftrace: host klp and bpf trampoline together
Date: Mon, 11 Jul 2022 19:55:52 -0400 [thread overview]
Message-ID: <20220711195552.22c3a4be@gandalf.local.home> (raw)
In-Reply-To: <20220602193706.2607681-1-song@kernel.org>
I just realized that none of the live kernel patching folks are Cc'd on
this thread. I think they will care much more about this than I do.
-- Steve
On Thu, 2 Jun 2022 12:37:01 -0700
Song Liu <song@kernel.org> wrote:
> Changes v1 => v2:
> 1. Fix build errors for different config. (kernel test robot)
>
> Kernel Live Patch (livepatch, or klp) and bpf trampoline are important
> features for modern systems. This set allows the two to work on the same
> kernel function as the same time.
>
> live patch uses ftrace with IPMODIFY, while bpf trampoline use direct
> ftrace. Existing policy does not allow the two to attach to the same kernel
> function. This is changed by fine tuning ftrace IPMODIFY policy, and allows
> one non-DIRECT IPMODIFY ftrace_ops and one non-IPMODIFY DIRECT ftrace_ops
> on the same kernel function at the same time. Please see 3/5 for more
> details on this.
>
> Note that, one of the constraint here is to let bpf trampoline use direct
> call when it is not working on the same function as live patch. This is
> achieved by allowing ftrace code to ask bpf trampoline to make changes.
>
> Jiri Olsa (1):
> bpf, x64: Allow to use caller address from stack
>
> Song Liu (4):
> ftrace: allow customized flags for ftrace_direct_multi ftrace_ops
> ftrace: add modify_ftrace_direct_multi_nolock
> ftrace: introduce FTRACE_OPS_FL_SHARE_IPMODIFY
> bpf: trampoline: support FTRACE_OPS_FL_SHARE_IPMODIFY
>
> arch/x86/net/bpf_jit_comp.c | 13 +-
> include/linux/bpf.h | 8 ++
> include/linux/ftrace.h | 79 +++++++++++
> kernel/bpf/trampoline.c | 109 +++++++++++++--
> kernel/trace/ftrace.c | 269 +++++++++++++++++++++++++++++++-----
> 5 files changed, 424 insertions(+), 54 deletions(-)
>
> --
> 2.30.2
next parent reply other threads:[~2022-07-11 23:56 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20220602193706.2607681-1-song@kernel.org>
2022-07-11 23:55 ` Steven Rostedt [this message]
2022-07-12 5:15 ` [PATCH v2 bpf-next 0/5] ftrace: host klp and bpf trampoline together Song Liu
2022-07-12 13:36 ` Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220711195552.22c3a4be@gandalf.local.home \
--to=rostedt@goodmis.org \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=jikos@kernel.org \
--cc=joe.lawrence@redhat.com \
--cc=jolsa@kernel.org \
--cc=jpoimboe@kernel.org \
--cc=kernel-team@fb.com \
--cc=linux-kernel@vger.kernel.org \
--cc=live-patching@vger.kernel.org \
--cc=mbenes@suse.cz \
--cc=mhiramat@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pmladek@suse.com \
--cc=song@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox