public inbox for live-patching@vger.kernel.org
 help / color / mirror / Atom feed
From: Zhen Lei <thunder.leizhen@huawei.com>
To: Josh Poimboeuf <jpoimboe@kernel.org>,
	Jiri Kosina <jikos@kernel.org>, Miroslav Benes <mbenes@suse.cz>,
	Petr Mladek <pmladek@suse.com>,
	Joe Lawrence <joe.lawrence@redhat.com>,
	<live-patching@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	Masahiro Yamada <masahiroy@kernel.org>,
	Alexei Starovoitov <ast@kernel.org>, Jiri Olsa <jolsa@kernel.org>,
	Kees Cook <keescook@chromium.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	"Luis Chamberlain" <mcgrof@kernel.org>,
	<linux-modules@vger.kernel.org>,
	"Steven Rostedt" <rostedt@goodmis.org>,
	Ingo Molnar <mingo@redhat.com>
Cc: Zhen Lei <thunder.leizhen@huawei.com>,
	David Laight <David.Laight@ACULAB.COM>
Subject: [PATCH v8 4/9] kallsyms: Reduce the memory occupied by kallsyms_seqs_of_names[]
Date: Wed, 2 Nov 2022 16:49:16 +0800	[thread overview]
Message-ID: <20221102084921.1615-5-thunder.leizhen@huawei.com> (raw)
In-Reply-To: <20221102084921.1615-1-thunder.leizhen@huawei.com>

kallsyms_seqs_of_names[] records the symbol index sorted by address, the
maximum value in kallsyms_seqs_of_names[] is the number of symbols. And
2^24 = 16777216, which means that three bytes are enough to store the
index. This can help us save (1 * kallsyms_num_syms) bytes of memory.

Signed-off-by: Zhen Lei <thunder.leizhen@huawei.com>
---
 kernel/kallsyms.c          | 18 ++++++++++++++----
 kernel/kallsyms_internal.h |  2 +-
 scripts/kallsyms.c         |  5 ++++-
 3 files changed, 19 insertions(+), 6 deletions(-)

diff --git a/kernel/kallsyms.c b/kernel/kallsyms.c
index ba351dfa109b6ac..48f36fd7e10b95e 100644
--- a/kernel/kallsyms.c
+++ b/kernel/kallsyms.c
@@ -201,6 +201,16 @@ static int compare_symbol_name(const char *name, char *namebuf)
 	return ret;
 }
 
+static unsigned int get_symbol_seq(int index)
+{
+	unsigned int i, seq = 0;
+
+	for (i = 0; i < 3; i++)
+		seq = (seq << 8) | kallsyms_seqs_of_names[3 * index + i];
+
+	return seq;
+}
+
 static int kallsyms_lookup_names(const char *name,
 				 unsigned int *start,
 				 unsigned int *end)
@@ -215,7 +225,7 @@ static int kallsyms_lookup_names(const char *name,
 
 	while (low <= high) {
 		mid = low + (high - low) / 2;
-		seq = kallsyms_seqs_of_names[mid];
+		seq = get_symbol_seq(mid);
 		off = get_symbol_offset(seq);
 		kallsyms_expand_symbol(off, namebuf, ARRAY_SIZE(namebuf));
 		ret = compare_symbol_name(name, namebuf);
@@ -232,7 +242,7 @@ static int kallsyms_lookup_names(const char *name,
 
 	low = mid;
 	while (low) {
-		seq = kallsyms_seqs_of_names[low - 1];
+		seq = get_symbol_seq(low - 1);
 		off = get_symbol_offset(seq);
 		kallsyms_expand_symbol(off, namebuf, ARRAY_SIZE(namebuf));
 		if (compare_symbol_name(name, namebuf))
@@ -244,7 +254,7 @@ static int kallsyms_lookup_names(const char *name,
 	if (end) {
 		high = mid;
 		while (high < kallsyms_num_syms - 1) {
-			seq = kallsyms_seqs_of_names[high + 1];
+			seq = get_symbol_seq(high + 1);
 			off = get_symbol_offset(seq);
 			kallsyms_expand_symbol(off, namebuf, ARRAY_SIZE(namebuf));
 			if (compare_symbol_name(name, namebuf))
@@ -269,7 +279,7 @@ unsigned long kallsyms_lookup_name(const char *name)
 
 	ret = kallsyms_lookup_names(name, &i, NULL);
 	if (!ret)
-		return kallsyms_sym_address(kallsyms_seqs_of_names[i]);
+		return kallsyms_sym_address(get_symbol_seq(i));
 
 	return module_kallsyms_lookup_name(name);
 }
diff --git a/kernel/kallsyms_internal.h b/kernel/kallsyms_internal.h
index a04b7a5cb1e3eaf..27fabdcc40f5793 100644
--- a/kernel/kallsyms_internal.h
+++ b/kernel/kallsyms_internal.h
@@ -26,6 +26,6 @@ extern const char kallsyms_token_table[] __weak;
 extern const u16 kallsyms_token_index[] __weak;
 
 extern const unsigned int kallsyms_markers[] __weak;
-extern const unsigned int kallsyms_seqs_of_names[] __weak;
+extern const u8 kallsyms_seqs_of_names[] __weak;
 
 #endif // LINUX_KALLSYMS_INTERNAL_H_
diff --git a/scripts/kallsyms.c b/scripts/kallsyms.c
index 07ecf7e5c49f616..04e04fbd9625caf 100644
--- a/scripts/kallsyms.c
+++ b/scripts/kallsyms.c
@@ -600,7 +600,10 @@ static void write_src(void)
 	sort_symbols_by_name();
 	output_label("kallsyms_seqs_of_names");
 	for (i = 0; i < table_cnt; i++)
-		printf("\t.long\t%u\n", table[i]->seq);
+		printf("\t.byte 0x%02x, 0x%02x, 0x%02x\n",
+			(unsigned char)(table[i]->seq >> 16),
+			(unsigned char)(table[i]->seq >> 8),
+			(unsigned char)(table[i]->seq >> 0));
 	printf("\n");
 
 	output_label("kallsyms_token_table");
-- 
2.25.1


  parent reply	other threads:[~2022-11-02  8:50 UTC|newest]

Thread overview: 35+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-02  8:49 [PATCH v8 0/9] kallsyms: Optimizes the performance of lookup symbols Zhen Lei
2022-11-02  8:49 ` [PATCH v8 1/9] scripts/kallsyms: rename build_initial_tok_table() Zhen Lei
2022-11-02  8:49 ` [PATCH v8 2/9] kallsyms: Improve the performance of kallsyms_lookup_name() Zhen Lei
2022-11-02  8:49 ` [PATCH v8 3/9] kallsyms: Correctly sequence symbols when CONFIG_LTO_CLANG=y Zhen Lei
2022-11-02  8:49 ` Zhen Lei [this message]
2022-11-02 12:00   ` [PATCH v8 4/9] kallsyms: Reduce the memory occupied by kallsyms_seqs_of_names[] David Laight
2022-11-07  8:01     ` Leizhen (ThunderTown)
2022-11-02  8:49 ` [PATCH v8 5/9] kallsyms: Add helper kallsyms_on_each_match_symbol() Zhen Lei
2022-11-02  8:49 ` [PATCH v8 6/9] livepatch: Use kallsyms_on_each_match_symbol() to improve performance Zhen Lei
2022-11-23 13:28   ` Petr Mladek
2022-11-24  2:36     ` Leizhen (ThunderTown)
2022-11-24  8:29       ` Petr Mladek
2022-12-06 22:08       ` Luis Chamberlain
2022-12-07  1:30         ` Leizhen (ThunderTown)
2022-11-02  8:49 ` [PATCH v8 7/9] livepatch: Improve the search performance of module_kallsyms_on_each_symbol() Zhen Lei
2022-11-14  7:47   ` Jiri Olsa
2022-11-14  8:50     ` Leizhen (ThunderTown)
2022-11-14  9:27       ` Jiri Olsa
2022-11-14 10:00         ` Leizhen (ThunderTown)
2022-11-14 10:31           ` Jiri Olsa
2022-11-14 11:30             ` Leizhen (ThunderTown)
2022-11-14 13:26               ` Jiri Olsa
2022-11-14 15:46                 ` Luis Chamberlain
2022-11-15  2:10                   ` Leizhen (ThunderTown)
2022-11-15  7:30                     ` Jiri Olsa
2022-11-15  7:54                       ` Luis Chamberlain
2022-11-15  8:14                         ` Leizhen (ThunderTown)
2022-11-15 20:11                         ` Stephen Rothwell
2022-11-23 13:57   ` Petr Mladek
2022-11-24  2:41     ` Leizhen (ThunderTown)
2022-11-02  8:49 ` [PATCH v8 8/9] kallsyms: Delete an unused parameter related to kallsyms_on_each_symbol() Zhen Lei
2022-11-02  8:49 ` [PATCH v8 9/9] kallsyms: Add self-test facility Zhen Lei
2022-11-13  2:44 ` [PATCH v8 0/9] kallsyms: Optimizes the performance of lookup symbols Luis Chamberlain
2022-11-13  2:55   ` Luis Chamberlain
2022-11-14  1:25     ` Leizhen (ThunderTown)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20221102084921.1615-5-thunder.leizhen@huawei.com \
    --to=thunder.leizhen@huawei.com \
    --cc=David.Laight@ACULAB.COM \
    --cc=akpm@linux-foundation.org \
    --cc=ast@kernel.org \
    --cc=jikos@kernel.org \
    --cc=joe.lawrence@redhat.com \
    --cc=jolsa@kernel.org \
    --cc=jpoimboe@kernel.org \
    --cc=keescook@chromium.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-modules@vger.kernel.org \
    --cc=live-patching@vger.kernel.org \
    --cc=masahiroy@kernel.org \
    --cc=mbenes@suse.cz \
    --cc=mcgrof@kernel.org \
    --cc=mingo@redhat.com \
    --cc=pmladek@suse.com \
    --cc=rostedt@goodmis.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox