From: Josh Poimboeuf <jpoimboe@kernel.org>
To: Song Liu <song@kernel.org>
Cc: linux-kernel@vger.kernel.org, linux-modules@vger.kernel.org,
live-patching@vger.kernel.org, x86@kernel.org, jikos@kernel.org,
pmladek@suse.com, joe.lawrence@redhat.com,
Miroslav Benes <mbenes@suse.cz>,
Josh Poimboeuf <jpoimboe@redhat.com>
Subject: Re: [PATCH v9] livepatch: Clear relocation targets on a module removal
Date: Fri, 20 Jan 2023 09:28:22 -0800 [thread overview]
Message-ID: <20230120172822.43lreggioj7hozke@treble> (raw)
In-Reply-To: <CAPhsuW75hr5kp85X3C45u071PyUHQ8NG0dnOajTc9O976wN0vg@mail.gmail.com>
On Fri, Jan 20, 2023 at 09:03:55AM -0800, Song Liu wrote:
> > > > Shouldn't there also be a fix for this powerpc issue?
> > >
> > > There was a working version, but it was not very clean. We couldn't agree
> > > on the path forward for powerpc, so we are hoping to ship the fix to x86 (and
> > > s390?) first [1].
> >
> > Sorry for coming in late, I was on leave so I missed a lot of the
> > discussions on previous versions. The decision to leave powerpc broken
> > wasn't clear from reading the commit message. The bug is mentioned, and
> > the fix is implied, but surprisingly there's no fix.
> >
> > I agree that the powerpc fix should be in a separate patch, but I still
> > don't feel comfortable merging the x86 fix without the corresponding
> > powerpc fix.
> >
> > powerpc is a major arch and not a second-class citizen. If we don't fix
> > it now then it'll probably never get fixed until it blows up in the real
> > world.
> >
> > For powerpc, instead of clearing, how about just "fixing" the warning
> > site, something like so (untested)?
>
> This version looks reasonable to me.
Ok, I'll run it through testing and work up a proper patch. I just
noticed the one I posted has a major bug thanks to restore_r2()'s
surprising return semantics.
--
Josh
next prev parent reply other threads:[~2023-01-20 17:28 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20230118204728.1876249-1-song@kernel.org>
2023-01-18 22:08 ` [PATCH v9] livepatch: Clear relocation targets on a module removal Josh Poimboeuf
2023-01-19 19:06 ` Song Liu
2023-01-20 6:42 ` Josh Poimboeuf
2023-01-20 17:03 ` Song Liu
2023-01-20 17:28 ` Josh Poimboeuf [this message]
2023-01-24 20:08 ` Joe Lawrence
2023-01-24 22:32 ` Josh Poimboeuf
2023-01-20 19:16 ` Josh Poimboeuf
2023-01-20 19:41 ` Song Liu
2023-01-20 20:32 ` Josh Poimboeuf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230120172822.43lreggioj7hozke@treble \
--to=jpoimboe@kernel.org \
--cc=jikos@kernel.org \
--cc=joe.lawrence@redhat.com \
--cc=jpoimboe@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-modules@vger.kernel.org \
--cc=live-patching@vger.kernel.org \
--cc=mbenes@suse.cz \
--cc=pmladek@suse.com \
--cc=song@kernel.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox