From: Josh Poimboeuf <jpoimboe@kernel.org>
To: Petr Mladek <pmladek@suse.com>
Cc: Nicolai Stange <nstange@suse.de>,
Marcos Paulo de Souza <mpdesouza@suse.com>,
linux-kernel@vger.kernel.org, live-patching@vger.kernel.org,
jpoimboe@redhat.com, joe.lawrence@redhat.com
Subject: Re: [PATCH v2 4/4] livepatch/shadow: Add garbage collection of shadow variables
Date: Wed, 25 Jan 2023 15:22:48 -0800 [thread overview]
Message-ID: <20230125232248.inewq5tlpwfk3rny@treble> (raw)
In-Reply-To: <Y8a4ZQ0sm5AOnY7R@alley>
On Tue, Jan 17, 2023 at 04:01:57PM +0100, Petr Mladek wrote:
> IMHO, this is the reason why we should make it per-object.
>
> If the shadow variable was used by a livepatched module and we remove
> this module then the shadow variables would get unmaintained. It would
> results in the problem described in this paragraph.
Yes, that makes sense. Ok, I'm convinced.
BTW, this is yet another unfortunate consequence of our decision many
years ago to break the module dependency between a livepatch module and
the modules it patches. We already have a lot of technical debt as a
result of that decision and it continues to pile up.
In that vein see also Song's and my recent patches to fix module
re-patching.
--
Josh
next prev parent reply other threads:[~2023-01-25 23:22 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-26 19:41 [PATCH v2 0/4] livepatch: Add garbage collection for shadow variables Marcos Paulo de Souza
2022-10-26 19:41 ` [PATCH v2 1/4] livepatch/shadow: Separate code to get or use pre-allocated shadow variable Marcos Paulo de Souza
2022-10-31 15:44 ` Petr Mladek
2022-10-26 19:41 ` [PATCH v2 2/4] livepatch/shadow: Separate code removing all shadow variables for a given id Marcos Paulo de Souza
2022-10-26 19:41 ` [PATCH v2 3/4] livepatch/shadow: Introduce klp_shadow_type structure Marcos Paulo de Souza
2022-10-31 16:02 ` Petr Mladek
2023-01-31 4:36 ` Josh Poimboeuf
2022-10-26 19:41 ` [PATCH v2 4/4] livepatch/shadow: Add garbage collection of shadow variables Marcos Paulo de Souza
2022-11-04 1:03 ` Josh Poimboeuf
2022-11-04 10:25 ` Petr Mladek
2022-11-08 1:32 ` Josh Poimboeuf
2022-11-08 9:14 ` Petr Mladek
2022-11-08 18:44 ` Josh Poimboeuf
2022-11-09 14:36 ` Petr Mladek
2023-02-04 23:59 ` Josh Poimboeuf
2023-02-17 16:22 ` Petr Mladek
2022-11-11 9:20 ` Nicolai Stange
2022-11-11 9:55 ` Petr Mladek
2022-11-13 18:51 ` Josh Poimboeuf
2023-01-17 15:01 ` Petr Mladek
2023-01-25 23:22 ` Josh Poimboeuf [this message]
2023-01-26 9:36 ` Petr Mladek
2023-02-04 19:34 ` Josh Poimboeuf
2023-01-31 4:40 ` Josh Poimboeuf
2023-01-31 14:23 ` Petr Mladek
2023-01-31 21:17 ` Josh Poimboeuf
2023-02-02 13:58 ` Petr Mladek
2023-02-01 0:18 ` Josh Poimboeuf
2023-02-02 10:14 ` Petr Mladek
2023-02-04 17:37 ` Josh Poimboeuf
2022-11-01 10:43 ` [PATCH v2 0/4] livepatch: Add garbage collection for " Petr Mladek
2023-01-23 17:33 ` Marcos Paulo de Souza
2023-01-24 15:51 ` Petr Mladek
2023-01-26 16:35 ` Petr Mladek
2023-01-26 17:05 ` Joe Lawrence
2023-01-26 18:30 ` Josh Poimboeuf
2023-01-27 10:51 ` Petr Mladek
2023-01-27 11:08 ` Marcos Paulo de Souza
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230125232248.inewq5tlpwfk3rny@treble \
--to=jpoimboe@kernel.org \
--cc=joe.lawrence@redhat.com \
--cc=jpoimboe@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=live-patching@vger.kernel.org \
--cc=mpdesouza@suse.com \
--cc=nstange@suse.de \
--cc=pmladek@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox