From: Josh Poimboeuf <jpoimboe@kernel.org>
To: zhang warden <zhangwarden@gmail.com>
Cc: mbenes@suse.cz, jikos@kernel.org, Petr Mladek <pmladek@suse.com>,
Joe Lawrence <joe.lawrence@redhat.com>,
live-patching@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/1] *** Replace KLP_* to KLP_TRANSITION_* ***
Date: Mon, 6 May 2024 19:41:51 -0700 [thread overview]
Message-ID: <20240507024151.6jto4zraqfbqxcw2@treble> (raw)
In-Reply-To: <0E399FCD-396E-448B-A974-6034F4CF2B53@gmail.com>
On Tue, May 07, 2024 at 10:21:40AM +0800, zhang warden wrote:
>
>
> >
> > transition state. With this marcos renamed, comments are not
> > necessary at this point.
> >
> Sorry for my careless, the comment still remains in the code. However,
> comment in the code do no harms here. Maybe it can be kept.
The comments aren't actually correct.
For example, KLP_TRANSITION_UNPATCHED doesn't always mean "transitioning
to unpatched state". Sometimes it means "transitioning *from* unpatched
state".
--
Josh
next prev parent reply other threads:[~2024-05-07 2:41 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-07 2:17 [PATCH 0/1] *** Replace KLP_* to KLP_TRANSITION_* *** zhangwarden
2024-05-07 2:17 ` [PATCH 1/1] livepatch: Rename KLP_* to KLP_TRANSITION_* zhangwarden
2024-05-07 2:21 ` [PATCH 0/1] *** Replace KLP_* to KLP_TRANSITION_* *** zhang warden
2024-05-07 2:41 ` Josh Poimboeuf [this message]
2024-05-07 2:56 ` zhang warden
2024-05-07 3:29 ` Josh Poimboeuf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240507024151.6jto4zraqfbqxcw2@treble \
--to=jpoimboe@kernel.org \
--cc=jikos@kernel.org \
--cc=joe.lawrence@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=live-patching@vger.kernel.org \
--cc=mbenes@suse.cz \
--cc=pmladek@suse.com \
--cc=zhangwarden@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox