From: Song Liu <song@kernel.org>
To: live-patching@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-trace-kernel@vger.kernel.org
Cc: jpoimboe@kernel.org, jikos@kernel.org, mbenes@suse.cz,
pmladek@suse.com, joe.lawrence@redhat.com, nathan@kernel.org,
morbo@google.com, justinstitt@google.com, mcgrof@kernel.org,
thunder.leizhen@huawei.com, kees@kernel.org,
kernel-team@meta.com, song@kernel.org, mmaurer@google.com,
samitolvanen@google.com, mhiramat@kernel.org,
rostedt@goodmis.org
Subject: [PATCH v2 3/3] tracing/kprobes: Use APIs that matches symbols without .XXX suffix
Date: Fri, 2 Aug 2024 14:08:35 -0700 [thread overview]
Message-ID: <20240802210836.2210140-4-song@kernel.org> (raw)
In-Reply-To: <20240802210836.2210140-1-song@kernel.org>
Use the new kallsyms APIs that matches symbols name with .XXX
suffix. This allows userspace tools to get kprobes on the expected
function name, while the actual symbol has a .llvm.<hash> suffix.
This only effects kernel compile with CONFIG_LTO_CLANG.
Signed-off-by: Song Liu <song@kernel.org>
---
kernel/kprobes.c | 6 +++++-
kernel/trace/trace_kprobe.c | 11 ++++++++++-
2 files changed, 15 insertions(+), 2 deletions(-)
diff --git a/kernel/kprobes.c b/kernel/kprobes.c
index e85de37d9e1e..99102283b076 100644
--- a/kernel/kprobes.c
+++ b/kernel/kprobes.c
@@ -70,7 +70,11 @@ static DEFINE_PER_CPU(struct kprobe *, kprobe_instance);
kprobe_opcode_t * __weak kprobe_lookup_name(const char *name,
unsigned int __unused)
{
- return ((kprobe_opcode_t *)(kallsyms_lookup_name(name)));
+ unsigned long addr = kallsyms_lookup_name(name);
+
+ if (IS_ENABLED(CONFIG_LTO_CLANG) && !addr)
+ addr = kallsyms_lookup_name_without_suffix(name);
+ return ((kprobe_opcode_t *)(addr));
}
/*
diff --git a/kernel/trace/trace_kprobe.c b/kernel/trace/trace_kprobe.c
index 61a6da808203..d2ad0c561c83 100644
--- a/kernel/trace/trace_kprobe.c
+++ b/kernel/trace/trace_kprobe.c
@@ -203,6 +203,10 @@ unsigned long trace_kprobe_address(struct trace_kprobe *tk)
if (tk->symbol) {
addr = (unsigned long)
kallsyms_lookup_name(trace_kprobe_symbol(tk));
+
+ if (IS_ENABLED(CONFIG_LTO_CLANG) && !addr)
+ addr = kallsyms_lookup_name_without_suffix(trace_kprobe_symbol(tk));
+
if (addr)
addr += tk->rp.kp.offset;
} else {
@@ -766,8 +770,13 @@ static unsigned int number_of_same_symbols(const char *mod, const char *func_nam
{
struct sym_count_ctx ctx = { .count = 0, .name = func_name };
- if (!mod)
+ if (!mod) {
kallsyms_on_each_match_symbol(count_symbols, func_name, &ctx.count);
+ if (IS_ENABLED(CONFIG_LTO_CLANG) && !ctx.count) {
+ kallsyms_on_each_match_symbol_without_suffix(
+ count_symbols, func_name, &ctx.count);
+ }
+ }
module_kallsyms_on_each_symbol(mod, count_mod_symbols, &ctx);
--
2.43.0
next prev parent reply other threads:[~2024-08-02 21:09 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-02 21:08 [PATCH v2 0/3] Fix kallsyms with CONFIG_LTO_CLANG Song Liu
2024-08-02 21:08 ` [PATCH v2 1/3] kallsyms: Do not cleanup .llvm.<hash> suffix before sorting symbols Song Liu
2024-08-02 21:08 ` [PATCH v2 2/3] kallsyms: Add APIs to match symbol without .XXXX suffix Song Liu
2024-08-05 13:45 ` Masami Hiramatsu
2024-08-05 17:46 ` Song Liu
2024-08-08 10:20 ` Petr Mladek
2024-08-08 15:13 ` Song Liu
2024-08-02 21:08 ` Song Liu [this message]
2024-08-06 18:44 ` [PATCH v2 3/3] tracing/kprobes: Use APIs that matches symbols without .XXX suffix Steven Rostedt
2024-08-06 19:35 ` Song Liu
2024-08-06 20:00 ` Steven Rostedt
2024-08-06 20:01 ` Steven Rostedt
2024-08-06 20:12 ` Song Liu
2024-08-07 0:01 ` Masami Hiramatsu
2024-08-07 0:19 ` Song Liu
2024-08-07 10:08 ` Masami Hiramatsu
2024-08-07 15:33 ` Sami Tolvanen
2024-08-07 20:48 ` Song Liu
2024-08-08 9:59 ` Petr Mladek
2024-08-08 15:20 ` Song Liu
2024-08-09 15:40 ` Petr Mladek
2024-08-09 16:33 ` Song Liu
2024-08-08 15:52 ` Masami Hiramatsu
2024-08-09 6:20 ` Alessandro Carminati
2024-08-09 16:40 ` Song Liu
2024-08-07 21:26 ` Masami Hiramatsu
2024-08-07 19:41 ` Song Liu
2024-08-07 20:08 ` Steven Rostedt
2024-08-07 20:40 ` Song Liu
2024-08-07 20:43 ` Song Liu
2024-08-07 20:55 ` Masami Hiramatsu
2024-08-07 21:07 ` Song Liu
2024-08-07 14:58 ` zhang warden
2024-08-07 19:46 ` Song Liu
2024-08-08 2:10 ` zhang warden
2024-08-08 9:48 ` Petr Mladek
2024-08-08 15:17 ` Song Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240802210836.2210140-4-song@kernel.org \
--to=song@kernel.org \
--cc=jikos@kernel.org \
--cc=joe.lawrence@redhat.com \
--cc=jpoimboe@kernel.org \
--cc=justinstitt@google.com \
--cc=kees@kernel.org \
--cc=kernel-team@meta.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=live-patching@vger.kernel.org \
--cc=mbenes@suse.cz \
--cc=mcgrof@kernel.org \
--cc=mhiramat@kernel.org \
--cc=mmaurer@google.com \
--cc=morbo@google.com \
--cc=nathan@kernel.org \
--cc=pmladek@suse.com \
--cc=rostedt@goodmis.org \
--cc=samitolvanen@google.com \
--cc=thunder.leizhen@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).