Re: [RFC 27/31] objtool: Fix weak symbol detection

Josh Poimboeuf
2024-09-04T16:03:15Z

On Wed, Sep 04, 2024 at 09:42:54AM +0200, Peter Zijlstra wrote:
> On Tue, Sep 03, 2024 at 08:55:13PM -0700, Josh Poimboeuf wrote:
> > On Tue, Sep 03, 2024 at 10:26:45AM +0200, Peter Zijlstra wrote:
> > > On Mon, Sep 02, 2024 at 09:00:10PM -0700, Josh Poimboeuf wrote:
> > > > @@ -433,9 +433,13 @@ static void elf_add_symbol(struct elf *elf, struct symbol *sym)
> > > > /*
> > > > * Don't store empty STT_NOTYPE symbols in the rbtree. They
> > > > * can exist within a function, confusing the sorting.
> > > > + *
> > > > + * TODO: is this still true?
> > >
> > > a2e38dffcd93 ("objtool: Don't add empty symbols to the rbtree")
> > >
> > > I don't think that changed.
> >
> > But see two patches back where I fixed a bug in the insertion of
> > zero-length symbols.
> >
> > I was thinking that might actually be the root cause of the above
> > commit.
>
> Aah, yeah, might be. If we can reproduce the original problem, it should
> be verifiable.

Indeed, I'll investigate.

--
Josh