Re: [RFC 31/31] objtool, livepatch: Livepatch module generation

Josh Poimboeuf
2024-09-05T04:15:56Z

On Wed, Sep 04, 2024 at 02:38:14PM -0700, Jeff Johnson wrote:
> On 9/2/24 21:00, Josh Poimboeuf wrote:
> ...
> > diff --git a/scripts/livepatch/module.c b/scripts/livepatch/module.c
> > new file mode 100644
> > index 000000000000..101cabf6b2f1
> > --- /dev/null
> > +++ b/scripts/livepatch/module.c
> > @@ -0,0 +1,120 @@
> > +// SPDX-License-Identifier: GPL-2.0-or-later
> > +/*
> > + * Base module code for a livepatch kernel module
> > + *
> > + * Copyright (C) 2024 Josh Poimboeuf <jpoimboe@kernel.org>
> > + */
> ...
> > +module_init(livepatch_mod_init);
> > +module_exit(livepatch_mod_exit);
> > +MODULE_LICENSE("GPL");
> > +MODULE_INFO(livepatch, "Y");
>
> Since commit 1fffe7a34c89 ("script: modpost: emit a warning when the
> description is missing"), a module without a MODULE_DESCRIPTION() will
> result in a warning when built with make W=1. Recently, multiple
> developers have been eradicating these warnings treewide, and very few
> are left. Not sure if this would introduce a new one, so just want to
> flag it so that you can check and fix if necessary.

I'll fix that, thanks!

--
Josh