From: Song Liu <song@kernel.org>
To: live-patching@vger.kernel.org
Cc: jpoimboe@kernel.org, kernel-team@meta.com, jikos@kernel.org,
mbenes@suse.cz, pmladek@suse.com, joe.lawrence@redhat.com,
Song Liu <song@kernel.org>
Subject: [PATCH] klp-build: Update demangle_name for LTO
Date: Tue, 3 Feb 2026 13:40:06 -0800 [thread overview]
Message-ID: <20260203214006.741364-1-song@kernel.org> (raw)
With CONFIG_LTO_CLANG_THIN, __UNIQUE_ID_* can be global. Therefore, it
is necessary to demangle global symbols.
Also, LTO may generate symbols like:
__UNIQUE_ID_addressable___UNIQUE_ID_pci_invalid_bar_694_695
Remove trailing '_' together with numbers and '.' so that both numbers
added to the end of the symbol are removed. For example, the above s
ymbol will be demangled as
__UNIQUE_ID_addressable___UNIQUE_ID_pci_invalid_bar
Signed-off-by: Song Liu <song@kernel.org>
---
tools/objtool/elf.c | 11 +++++++----
1 file changed, 7 insertions(+), 4 deletions(-)
diff --git a/tools/objtool/elf.c b/tools/objtool/elf.c
index 2c02c7b49265..b4a7ea4720e1 100644
--- a/tools/objtool/elf.c
+++ b/tools/objtool/elf.c
@@ -445,9 +445,6 @@ static const char *demangle_name(struct symbol *sym)
{
char *str;
- if (!is_local_sym(sym))
- return sym->name;
-
if (!is_func_sym(sym) && !is_object_sym(sym))
return sym->name;
@@ -463,7 +460,13 @@ static const char *demangle_name(struct symbol *sym)
for (int i = strlen(str) - 1; i >= 0; i--) {
char c = str[i];
- if (!isdigit(c) && c != '.') {
+ /*
+ * With CONFIG_LTO_CLANG_THIN, the UNIQUE_ID field could
+ * be like:
+ * __UNIQUE_ID_addressable___UNIQUE_ID_<name>_628_629
+ * Remove all the trailing number, '.', and '_'.
+ */
+ if (!isdigit(c) && c != '.' && c != '_') {
str[i + 1] = '\0';
break;
}
--
2.47.3
next reply other threads:[~2026-02-03 21:40 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-03 21:40 Song Liu [this message]
2026-02-03 23:52 ` [PATCH] klp-build: Update demangle_name for LTO Josh Poimboeuf
2026-02-04 0:24 ` Song Liu
2026-02-04 1:24 ` Josh Poimboeuf
2026-02-04 6:38 ` Song Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260203214006.741364-1-song@kernel.org \
--to=song@kernel.org \
--cc=jikos@kernel.org \
--cc=joe.lawrence@redhat.com \
--cc=jpoimboe@kernel.org \
--cc=kernel-team@meta.com \
--cc=live-patching@vger.kernel.org \
--cc=mbenes@suse.cz \
--cc=pmladek@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox