From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 50195364E9A; Thu, 23 Apr 2026 08:34:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=90.155.50.34 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776933261; cv=none; b=ojtsmePC+a/jWq39S++HMEjJEMzqrwkQ5RrwGQTlSkYRpMhLZP/MQ+6+oKyPSgdbFAomIJ1Mx18UVQGGEXe/M1xUfGsG11w5Ihwca/WKCwvlTDvsY1RzqRriilLKv0EbL8dyzH6nSlXW06khBo459PxD/PGkZaVNhUxq2uRJA+E= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776933261; c=relaxed/simple; bh=MFfB5dfXeyapl5sa4ZnHR8fZ9qSJ5XyTo7OD3q6mli4=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=ClvtRFh2r28PHeorkKhlcpK5Y4HzWGhS3VuZzun7c+1d1a5/LCVw7GCVL++bk/rAfENnJ3lFFB0uyZy2wHz8TL4daPqjPYLgw/x8HcljYZNZvX1YWLxdgFUWjs3SaWdQdKKd3KlX86o19MnLEauwXB5zu6Nprl+JEqpBClOQKCk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=infradead.org; spf=none smtp.mailfrom=infradead.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b=Iwdzkq3K; arc=none smtp.client-ip=90.155.50.34 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=infradead.org Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=infradead.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="Iwdzkq3K" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=lVHZkIDDu0IVHp7HkGNXOU4FONveGRjXJnyzyG4nRoU=; b=Iwdzkq3KftpvbycHHT5KEgHLKL lVxXkosYQB1WA+2BpNxEIpFZEfv5wo4qLm02G6XwOeBl6403vOq7EVuy7cOBBE5Iqpi0qeJZlgslW bviww+eb68PYJWfddX2RX9Jp0y8DK7wS6ynXyYdxyYok4/YgByavC0M2YTe9n7PnSUEOntdwPMXSf 5pCicekMb0Yyy4yPYUigw2nRDwMaHtssYuWqKYKV2iUMz1/feTt3+hA/t9C77VTyukuBwSNyovqy4 P21ugrxKYFKIIpj8BzRQ4ui/ZIsjIVZ7EofsSJvjuC3/Cgld8j2HA8DOAUXWuzjmI7i0XTjI4/4r+ YyNxkAhg==; Received: from 2001-1c00-8d85-4b00-266e-96ff-fe07-7dcc.cable.dynamic.v6.ziggo.nl ([2001:1c00:8d85:4b00:266e:96ff:fe07:7dcc] helo=noisy.programming.kicks-ass.net) by casper.infradead.org with esmtpsa (Exim 4.98.2 #2 (Red Hat Linux)) id 1wFpVp-0000000D7U2-1wDi; Thu, 23 Apr 2026 08:34:17 +0000 Received: by noisy.programming.kicks-ass.net (Postfix, from userid 1000) id 0499B3008E2; Thu, 23 Apr 2026 10:34:17 +0200 (CEST) Date: Thu, 23 Apr 2026 10:34:16 +0200 From: Peter Zijlstra To: Josh Poimboeuf Cc: x86@kernel.org, linux-kernel@vger.kernel.org, live-patching@vger.kernel.org, Joe Lawrence , Song Liu , Miroslav Benes , Petr Mladek Subject: Re: [PATCH 26/48] objtool/klp: Don't set sym->file for section symbols Message-ID: <20260423083416.GT3126523@noisy.programming.kicks-ass.net> References: Precedence: bulk X-Mailing-List: live-patching@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Wed, Apr 22, 2026 at 09:03:54PM -0700, Josh Poimboeuf wrote: > Section symbols aren't grouped after their corresponding FILE symbols. > Their sym->file should really be NULL rather than whatever random FILE > happened to be last. > > Signed-off-by: Josh Poimboeuf Acked-by: Peter Zijlstra (Intel) > --- > tools/objtool/elf.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tools/objtool/elf.c b/tools/objtool/elf.c > index c4cb371e72b2..00c2389f345f 100644 > --- a/tools/objtool/elf.c > +++ b/tools/objtool/elf.c > @@ -680,7 +680,7 @@ static int read_symbols(struct elf *elf) > > if (is_file_sym(sym)) > file = sym; > - else if (sym->bind == STB_LOCAL) > + else if (sym->bind == STB_LOCAL && !is_sec_sym(sym)) > sym->file = file; > } > > -- > 2.53.0 >