Re: [PATCH 31/48] objtool: Add is_alias_sym() helper

Peter Zijlstra
2026-04-23T08:35:03Z

On Wed, Apr 22, 2026 at 09:03:59PM -0700, Josh Poimboeuf wrote:
> Improve readability with a new is_alias_sym() helper.
>
> No functional changes intended.
>
> Signed-off-by: Josh Poimboeuf <jpoimboe@kernel.org>

Acked-by: Peter Zijlstra (Intel) <peterz@infradead.org>

> ---
> tools/objtool/check.c | 6 +++---
> tools/objtool/include/objtool/elf.h | 5 +++++
> 2 files changed, 8 insertions(+), 3 deletions(-)
>
> diff --git a/tools/objtool/check.c b/tools/objtool/check.c
> index 54ceac857979..4c18d6e7f6c3 100644
> --- a/tools/objtool/check.c
> +++ b/tools/objtool/check.c
> @@ -491,7 +491,7 @@ static int decode_instructions(struct objtool_file *file)
> return -1;
> }
>
> - if (func->embedded_insn || func->alias != func)
> + if (func->embedded_insn || is_alias_sym(func))
> continue;
>
> if (!find_insn(file, sec, func->offset)) {
> @@ -2229,7 +2229,7 @@ static int add_jump_table_alts(struct objtool_file *file)
> return 0;
>
> for_each_sym(file->elf, func) {
> - if (!is_func_sym(func) || func->alias != func)
> + if (!is_func_sym(func) || is_alias_sym(func))
> continue;
>
> mark_func_jump_tables(file, func);
> @@ -4527,7 +4527,7 @@ static int validate_symbol(struct objtool_file *file, struct section *sec,
> return 1;
> }
>
> - if (sym->pfunc != sym || sym->alias != sym)
> + if (sym->pfunc != sym || is_alias_sym(sym))
> return 0;
>
> insn = find_insn(file, sec, sym->offset);
> diff --git a/tools/objtool/include/objtool/elf.h b/tools/objtool/include/objtool/elf.h
> index cd5844c7b4e2..3abe4cbc584c 100644
> --- a/tools/objtool/include/objtool/elf.h
> +++ b/tools/objtool/include/objtool/elf.h
> @@ -279,6 +279,11 @@ static inline bool is_local_sym(struct symbol *sym)
> return sym->bind == STB_LOCAL;
> }
>
> +static inline bool is_alias_sym(struct symbol *sym)
> +{
> + return sym->alias != sym;
> +}
> +
> static inline bool is_prefix_func(struct symbol *sym)
> {
> return sym->prefix;
> --
> 2.53.0
>