Re: [PATCH 03/48] objtool/klp: Don't correlate __ADDRESSABLE() symbols

Josh Poimboeuf
2026-04-27T19:00:51Z

On Fri, Apr 24, 2026 at 11:34:33AM +0200, Miroslav Benes wrote:
> On Fri, 24 Apr 2026, Miroslav Benes wrote:
>
> > On Wed, 22 Apr 2026 21:03:31 -0700, Josh Poimboeuf <jpoimboe@kernel.org> wrote:
> > > Symbols created by __ADDRESSABLE() are only used to convince the
> > > toolchain not to optimize out the referenced symbol.
> >
> > Reviewed-by: Miroslav Benes <mbenes@suse.cz>
>
> Looking at it again... wouldn't it be better to address this in
> is_special_section() which is looking at .discard.addressable already
> (only the outcome is different)?

No, I don't think so. If .discard.addressable were classified as a
"special" section then klp-diff would try to extract its entries into
the livepatch module, which is completely unnecessary as these are
throwaway symbols.

--
Josh