Live Patching
 help / color / mirror / Atom feed
From: George Guo <dongtai.guo@linux.dev>
To: WangYuli <wangyuli@aosc.io>
Cc: ardb@kernel.org, chenhuacai@kernel.org, guodongtai@kylinos.cn,
	jiaxun.yang@flygoat.com, jikos@kernel.org,
	joe.lawrence@redhat.com, jpoimboe@kernel.org, kernel@xen0n.name,
	linux-kernel@vger.kernel.org, liukexin@kylinos.cn,
	live-patching@vger.kernel.org, llvm@lists.linux.dev,
	loongarch@lists.linux.dev, mbenes@suse.cz, nathan@kernel.org,
	nick.desaulniers+lkml@gmail.com, peterz@infradead.org,
	pmladek@suse.com, rostedt@goodmis.org, xry111@xry111.site,
	yangtiezhu@loongson.cn
Subject: Re: [PATCH 3/8] LoongArch: Add special section entry sizes for KLP support
Date: Mon,  8 Jun 2026 18:33:02 +0800	[thread overview]
Message-ID: <20260608103302.340456-1-dongtai.guo@linux.dev> (raw)
In-Reply-To: <20260605083839.67474-1-wangyuli@aosc.io>

Hi WangYuli,

Thanks for the review -- all three points are addressed in v2:
https://lore.kernel.org/all/20260608100406.322598-1-dongtai.guo@linux.dev/

> Have you actually tested your changes with LLVM?

Yes, now confirmed: the affected files build cleanly with
'make LLVM=1' (clang). You were right that this had not been properly
exercised before -- the writable special sections were the real problem.

> BTW, "awM" is dangerous, pls see how did x86 do.

Fixed. __bug_table and __jump_table are writable, and SHF_MERGE cannot be
combined with SHF_WRITE (Clang rejects it). v2 drops "awM"/entsize on
those two and marks each entry with ANNOTATE_DATA_SPECIAL instead, just
as x86 and arm64 do; SHF_MERGE is kept only for the read-only
.altinstructions/__ex_table.

> And head.S doesn't need to include asm-offsets.h, it seems
> stackframe.h has included it.

Correct, removed -- head.S already pulls it in via <asm/stackframe.h>.

Thanks,
George

  reply	other threads:[~2026-06-08 10:33 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-06-04  6:53 [PATCH 0/8] LoongArch: Add livepatch build (KLP) support George Guo
2026-06-04  6:53 ` [PATCH 1/8] " George Guo
2026-06-04  6:53 ` [PATCH 2/8] objtool/LoongArch: Add arch_adjusted_addend() for KLP support George Guo
2026-06-04  6:53 ` [PATCH 3/8] LoongArch: Add special section entry sizes " George Guo
2026-06-05  8:38   ` WangYuli
2026-06-08 10:33     ` George Guo [this message]
2026-06-04  6:53 ` [PATCH 4/8] livepatch/klp-build: disable direct-extern-access for LoongArch to fix kernel panic George Guo
2026-06-05  8:53   ` WangYuli
2026-06-04  6:53 ` [PATCH 5/8] LoongArch: fix kernel panic with -fPIC for same-compilation-unit symbol references George Guo
2026-06-05  8:10   ` Xi Ruoyao
2026-06-08 10:23     ` George Guo
2026-06-04  6:53 ` [PATCH 6/8] LoongArch: Fix EFI linking with -fdata-sections George Guo
2026-06-04  6:53 ` [PATCH 7/8] objtool/klp: Add LoongArch jump opcode bytes support George Guo
2026-06-04  6:53 ` [PATCH 8/8] klp-build: Add LoongArch syscall patching macro George Guo
2026-06-05  7:57 ` [PATCH 0/8] LoongArch: Add livepatch build (KLP) support WangYuli

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260608103302.340456-1-dongtai.guo@linux.dev \
    --to=dongtai.guo@linux.dev \
    --cc=ardb@kernel.org \
    --cc=chenhuacai@kernel.org \
    --cc=guodongtai@kylinos.cn \
    --cc=jiaxun.yang@flygoat.com \
    --cc=jikos@kernel.org \
    --cc=joe.lawrence@redhat.com \
    --cc=jpoimboe@kernel.org \
    --cc=kernel@xen0n.name \
    --cc=linux-kernel@vger.kernel.org \
    --cc=liukexin@kylinos.cn \
    --cc=live-patching@vger.kernel.org \
    --cc=llvm@lists.linux.dev \
    --cc=loongarch@lists.linux.dev \
    --cc=mbenes@suse.cz \
    --cc=nathan@kernel.org \
    --cc=nick.desaulniers+lkml@gmail.com \
    --cc=peterz@infradead.org \
    --cc=pmladek@suse.com \
    --cc=rostedt@goodmis.org \
    --cc=wangyuli@aosc.io \
    --cc=xry111@xry111.site \
    --cc=yangtiezhu@loongson.cn \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox