Re: [PATCH v2 31/58] objtool/klp: Add test for the contents of the klp_funcs list

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] Test script relies on non-portable `grep` features (`\b` and `-w` on non-word boundaries), causing false test failures on BSD/macOS environments.
--

commit 4a06859b140cc416baf636400fbe85d7c99ad01c
Author: Song Liu <song@kernel.org>

objtool/klp: Add test for the contents of the klp_funcs list

The patch list is what livepatch acts on, and asserting only that it exists
does not say it is right. The fixture changes two of three functions and
asserts on all three: the two by name, and the third by its absence.

> diff --git a/tools/objtool/tests/generic/test-klp-funcs-content.sh b/tools/objtool/tests/generic/test-klp-funcs-content.sh
> new file mode 100755
> index 0000000000000..c4ec7098d9482
> --- /dev/null
> +++ b/tools/objtool/tests/generic/test-klp-funcs-content.sh
> @@ -0,0 +1,44 @@
[ ... ]
> +# The names the kernel matches on are real strings, not just relocations.
> +out_strings .rodata.klp.str1.1 |
> +	grep -q '\bfirst\b' ||
> +	fail "no 'first' string in .rodata.klp.str1.1"

[Severity: Low]
Is it possible to use POSIX regex features instead of \b here? The \b
extension is a GNU/PCRE feature and is unsupported by BSD grep, which can
cause spurious test failures on non-GNU platforms such as macOS or FreeBSD.

> +out_strings .rodata.klp.str1.1 |
> +	grep -q '\bsecond\b' ||
> +	fail "no 'second' string in .rodata.klp.str1.1"

[Severity: Low]
Does this code also need to avoid the \b extension to prevent false test
failures on environments using BSD grep?

> +
> +# The object list has to reach the function list, or nothing is walked.
> +assert_reloc_sym .init.klp_objects .init.klp_funcs

[Severity: Low]
Will this assertion fail on BSD grep? This passes a section name starting
with '.' to a helper that uses grep -qw.

On BSD grep, the -w option requires a transition between word and non-word
characters, which always fails when the matched pattern begins with a
non-word character like a dot.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260914062514.926997-1-song@kernel.org?part=31