Re: [PATCH v4 15/58] objtool/klp: Add test for static local correlation

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] objtool/klp: test script grep matches file path instead of symbol name
--

commit 8279e7aebe31fad0b7cca275957a41207409ca61
Author: Puranjay Mohan <puranjay@kernel.org>

    objtool/klp: Add test for static local correlation

A static local must be correlated with its original rather than duplicated.
The replacement has to reach the existing variable through a klp
relocation; a fresh definition would discard whatever state the running
kernel accumulated.

> diff --git a/tools/objtool/tests/generic/test-static-local.sh b/tools/objtool/tests/generic/test-static-local.sh
> new file mode 100755
> index 0000000000000..d57efa64dfd92
> --- /dev/null
> +++ b/tools/objtool/tests/generic/test-static-local.sh
> @@ -0,0 +1,24 @@
[ ... ]
> +out_symbols | grep -q '\.klp\.sym\..*\.counter' ||
> +	fail "static local not referenced through a klp relocation"
> +
> +out_symbols | grep 'counter' | grep -qvE 'UND|\.klp\.(sym|tombstone)' &&
> +	fail "static local was given a fresh definition"

[Severity: Low]
Will this grep command inadvertently match the ELF file path symbol's string
instead of uniquely matching the static local variable symbol?

If a developer checks out the kernel source tree in a directory path
containing the string 'counter' (e.g., /home/user/my_counters/linux/),
GCC populates the ELF file symbol with this full path. The unfiltered
grep 'counter' command matches this path in the readelf output. Since the
file symbol uses the absolute index rather than the undefined index, and does
not match the .klp exclusions, it bypasses the negative filter, triggering a
false positive test failure.

> +
> +pass "static local correlated rather than duplicated"

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260915233454.2405019-1-song@kernel.org?part=15