Re: [PATCH v10 7/9] selftests/livepatch: Add provides/obsoletes test scenarios

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] selftests: comment mismatch in obsoletes test
--

commit b0b3364b7d14143d4a32c2c1ce9eaf4a8c23c322
Author: Yafang Shao <laoar.shao@gmail.com>

selftests/livepatch: Add provides/obsoletes test scenarios

This commit adds test scenarios for the new provides/obsoletes livepatch
mechanism, verifying various replacement semantics. The tests are skipped
on kernels that only support the legacy "replace" attribute.

> diff --git a/tools/testing/selftests/livepatch/test-provides-obsoletes.sh b/tools/testing/selftests/livepatch/test-provides-obsoletes.sh
> new file mode 100755
> index 0000000000000..a1c0ebb9ed44e
> --- /dev/null
> +++ b/tools/testing/selftests/livepatch/test-provides-obsoletes.sh

[ ... ]

> +# - load a livepatch with provides=2 and obsoletes=[1] (cmdline),
> +#   then another with provides=1 (meminfo). Although the second patch

[Severity: Low]
Does this block comment swap the module names?

The text says cmdline is loaded with obsoletes=[1] and meminfo is loaded
second. However, as noted later in this same comment block and in the test
implementation below, MOD_MEMINFO is loaded first with obsoletes=1 and
MOD_CMDLINE is loaded second. This is functionally necessary because
test_klp_cmdline_lp.c does not declare an obsoletes module parameter.

> +#   does not list provides=2 in its own obsoletes list, it still
> +#   replaces the first one, because the obsoletes relationship is
> +#   symmetric: the first patch's obsoletes list contains the second
> +#   patch's provides id.
> +# - verify the provides sysfs value of the replacing patch
> +# - unload the remaining livepatch
> +#
> +#   MOD_MEMINFO(provides=2, obsoletes=[1])  -- loaded first
> +#   MOD_CMDLINE(provides=1)              -- loaded second, replaces above
> +
> +start_test "symmetric obsoletes replaces"
> +
> +load_lp $MOD_MEMINFO provides=2 obsoletes=1
> +load_lp $MOD_CMDLINE provides=1

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260930030323.14396-1-laoar.shao@gmail.com?part=7