From: zhang warden <zhangwarden@gmail.com>
To: Josh Poimboeuf <jpoimboe@kernel.org>
Cc: mbenes@suse.cz, jikos@kernel.org, Petr Mladek <pmladek@suse.com>,
Joe Lawrence <joe.lawrence@redhat.com>,
live-patching@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/1] *** Replace KLP_* to KLP_TRANSITION_* ***
Date: Tue, 7 May 2024 10:56:09 +0800 [thread overview]
Message-ID: <4010C687-88C9-43FC-B8C9-80981B04807F@gmail.com> (raw)
In-Reply-To: <20240507024151.6jto4zraqfbqxcw2@treble>
> On May 7, 2024, at 10:41, Josh Poimboeuf <jpoimboe@kernel.org> wrote:
>
> On Tue, May 07, 2024 at 10:21:40AM +0800, zhang warden wrote:
>>
>>
>>>
>>> transition state. With this marcos renamed, comments are not
>>> necessary at this point.
>>>
>> Sorry for my careless, the comment still remains in the code. However,
>> comment in the code do no harms here. Maybe it can be kept.
>
> The comments aren't actually correct.
>
> For example, KLP_TRANSITION_UNPATCHED doesn't always mean "transitioning
> to unpatched state". Sometimes it means "transitioning *from* unpatched
> state".
>
> --
> Josh
OK, I got it. I will remove the comment later. After all, comment is not necessary at this point after we rename the macros.
next prev parent reply other threads:[~2024-05-07 2:56 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-07 2:17 [PATCH 0/1] *** Replace KLP_* to KLP_TRANSITION_* *** zhangwarden
2024-05-07 2:17 ` [PATCH 1/1] livepatch: Rename KLP_* to KLP_TRANSITION_* zhangwarden
2024-05-07 2:21 ` [PATCH 0/1] *** Replace KLP_* to KLP_TRANSITION_* *** zhang warden
2024-05-07 2:41 ` Josh Poimboeuf
2024-05-07 2:56 ` zhang warden [this message]
2024-05-07 3:29 ` Josh Poimboeuf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4010C687-88C9-43FC-B8C9-80981B04807F@gmail.com \
--to=zhangwarden@gmail.com \
--cc=jikos@kernel.org \
--cc=joe.lawrence@redhat.com \
--cc=jpoimboe@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=live-patching@vger.kernel.org \
--cc=mbenes@suse.cz \
--cc=pmladek@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox