From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx-relay18-hz2.antispameurope.com (mx-relay18-hz2.antispameurope.com [83.246.65.160]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 969862FB094 for ; Mon, 20 Oct 2025 12:22:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=pass smtp.client-ip=83.246.65.160 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760962926; cv=pass; b=ToMX8zOGXYqT6xX+oXsnhPTYogE39TB+2C5bCQAGNqHiWk/a5M76Qldc+RVw1xc4JIe/LpdS9NT4LYNd9gmQbuWR+UMT+fnAiWS5qaNoq5lBR/88MEEhJN9Xkj7MFX03ahzGDWrFMcTAia8gZIv7KVtA5g+x+SaG7yZfi06OEo8= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760962926; c=relaxed/simple; bh=XrS9PhrVy8J4MNVTtRttJ7PJLldirtTrN2dE9PctUhQ=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=rL4flaxurd59o3ezrSoIb2Z1Q+FN689WI5z+1Lu02F9txOp+Qr6q8Ow1++GYgkgnNXR3+xWYgpc3hxLpi4cQiRvqgspA3cempWnqmLuHxO1cIBExTBQ06GrEsWLAW4QlBiE0hkXbvad978gwhUNZMu9+1bhhTh+yDM1Hdq9napo= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=ew.tq-group.com; spf=pass smtp.mailfrom=ew.tq-group.com; dkim=pass (2048-bit key) header.d=ew.tq-group.com header.i=@ew.tq-group.com header.b=VN5VnZ+i; arc=pass smtp.client-ip=83.246.65.160 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=ew.tq-group.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ew.tq-group.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=ew.tq-group.com header.i=@ew.tq-group.com header.b="VN5VnZ+i" ARC-Authentication-Results: i=1; mx-gate18-hz2.hornetsecurity.com 1; spf=pass reason=mailfrom (ip=94.100.132.6, headerfrom=ew.tq-group.com) smtp.mailfrom=ew.tq-group.com smtp.helo=smtp-out01-hz1.hornetsecurity.com; dmarc=pass header.from=ew.tq-group.com orig.disposition=pass ARC-Message-Signature: a=rsa-sha256; bh=FEA4yVHPGp0l+38xITknJy4FTIA46F5K1JVqc30O/jg=; c=relaxed/relaxed; d=hornetsecurity.com; h=from:to:date:subject:mime-version:; i=1; s=hse1; t=1760962852; b=Iu4kWwvfZ8vfA+m3QhByJysJjQtAgJg5wyqCGf88hX59qLweTgJZpK+OcKQA0xk4NIpSZaI/ 9XKCajvLEEpgCy8QCudnmK6UZ07WmvQdU/NOT58+2jDPZ7xvtbyFXjfh93Ysze+PgtzgcUyR+dw 2UXhkU1zahiS1kalwdSOuyKMqP7rTnBxV9F9ibvaPVh64Hn1nAmwp3zE4bznAqqAbh6WZrgAA2l CqFElIQgTyuirA00HZsRGV5GT0WLDA4VLMO5E2VfvXCB5ZXQtjqyV9sCtkcbg7ek6BEUJZIChl8 SK66eJ7+0+bvKU4Ak+T61ePzh8olXpORcgEL5a4l6xgVA== ARC-Seal: a=rsa-sha256; cv=none; d=hornetsecurity.com; i=1; s=hse1; t=1760962852; b=N+DLPJpush6D/xBMH594tfjJjQ/OBOD0G/2QA1E2aoC4mjSXJjNkHdHFhpidfNNgrv/Q9bfg cXQtkYUBSaRTyZ4otJ6GcprxfbE76BGqIGkGKLsK4D/6dez0YbvrPtr+SixyJENPkZwbKaonQ8z 6gvUrSTwj2r6VQAP4goEcPmmHnk5zi0UrhrJowGiX4ULL17Nlc46C7grFexy1cqtX82QSbyukQQ 2YuzNTs3eqDqsMgshW7+2RJER8tS2mascFw03hMuUhn2++KJuVQTjj/MpyRmCU8mne5Yrv+ChS0 /toRxdqmr2oTywY4q2ntoCKIsvFOfdM9bmdw9mj14QIUA== Received: from he-nlb01-hz1.hornetsecurity.com ([94.100.132.6]) by mx-relay18-hz2.antispameurope.com; Mon, 20 Oct 2025 14:20:52 +0200 Received: from steina-w.localnet (host-82-135-125-110.customer.m-online.net [82.135.125.110]) (Authenticated sender: alexander.stein@ew.tq-group.com) by smtp-out01-hz1.hornetsecurity.com (Postfix) with ESMTPSA id 1FFB1A4118D; Mon, 20 Oct 2025 14:20:36 +0200 (CEST) From: Alexander Stein To: x86@kernel.org, Josh Poimboeuf Cc: linux-kernel@vger.kernel.org, Petr Mladek , Miroslav Benes , Joe Lawrence , live-patching@vger.kernel.org, Song Liu , laokz , Jiri Kosina , Marcos Paulo de Souza , Weinan Liu , Fazla Mehrab , Chen Zhongjin , Puranjay Mohan , Dylan Hatch , Peter Zijlstra , Masahiro Yamada Subject: Re: [PATCH v4 08/63] kbuild: Remove 'kmod_' prefix from __KBUILD_MODNAME Date: Mon, 20 Oct 2025 14:20:35 +0200 Message-ID: <5936475.DvuYhMxLoT@steina-w> Organization: TQ-Systems GmbH In-Reply-To: References: Precedence: bulk X-Mailing-List: live-patching@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="iso-8859-1" X-cloud-security-sender:alexander.stein@ew.tq-group.com X-cloud-security-recipient:live-patching@vger.kernel.org X-cloud-security-crypt: load encryption module X-cloud-security-Mailarchiv: E-Mail archived for: alexander.stein@ew.tq-group.com X-cloud-security-Mailarchivtype:outbound X-cloud-security-Virusscan:CLEAN X-cloud-security-disclaimer: This E-Mail was scanned by E-Mailservice on mx-relay18-hz2.antispameurope.com with 4cqvdx0wRjz2lHKX X-cloud-security-connect: he-nlb01-hz1.hornetsecurity.com[94.100.132.6], TLS=1, IP=94.100.132.6 X-cloud-security-Digest:e0529b78e306560c4cb6295130408c3b X-cloud-security:scantime:2.046 DKIM-Signature: a=rsa-sha256; bh=FEA4yVHPGp0l+38xITknJy4FTIA46F5K1JVqc30O/jg=; c=relaxed/relaxed; d=ew.tq-group.com; h=content-type:mime-version:subject:from:to:message-id:date; s=hse1; t=1760962852; v=1; b=VN5VnZ+iBPWEwp2BaITDGk1s/oIDZzMzMFajcCL/8EsNuZ0imaJVp4guNtkJh0c1X5J135Wv nAZ+uDr7/TEnxjgAIgROm7vsB7ewCtoJhhc9KcJuQmoCJeXZZKORbdmAt7C8Bjr3/6vpmQQWfrw osGJQr3BHxCwWGAo+5hFLe4xbkFeJZBipdt2hsslj0ClWNHVl752IMWciXw4KLtr09A8DU9394l L57bEhKe3odG6danUo3WCZEIwHYqykp0wfzXobQHdXUjYSm/KkAxPb24oVbP9Kk4NZSJgb0lvBq OMOybxP3c5MEhjtporV3TEHrsVdC7cCcs4dyIzHU+p1fA== Hi, Am Mittwoch, 17. September 2025, 18:03:16 CEST schrieb Josh Poimboeuf: > In preparation for the objtool klp diff subcommand, remove the arbitrary > 'kmod_' prefix from __KBUILD_MODNAME and instead add it explicitly in > the __initcall_id() macro. >=20 > This change supports the standardization of "unique" symbol naming by > ensuring the non-unique portion of the name comes before the unique > part. That will enable objtool to properly correlate symbols across > builds. >=20 > Cc: Masahiro Yamada > Signed-off-by: Josh Poimboeuf Starting with this commit 6717e8f91db71 ("kbuild: Remove 'kmod_' prefix from __KBUILD_MODNAME") in next-20251020 I don't get any module aliases anymore. modinfo spi-fsl-dspi.ko returns: > filename: /work/repo/linux/build_arm64/drivers/spi/spi-fsl-dspi.ko > alias: platform:fsl-dspi > license: GPL > description: Freescale DSPI Controller Driver > depends: =20 > intree: Y > name: spi_fsl_dspi > vermagic: 6.18.0-rc1+ SMP preempt mod_unload modversions aarch64 but it should be like this: > filename: /work/repo/linux/build_arm64/drivers/spi/spi-fsl-dspi.ko > alias: platform:fsl-dspi > license: GPL > description: Freescale DSPI Controller Driver > alias: of:N*T*Cnxp,s32g2-dspiC* > alias: of:N*T*Cnxp,s32g2-dspi > alias: of:N*T*Cfsl,lx2160a-dspiC* > alias: of:N*T*Cfsl,lx2160a-dspi > alias: of:N*T*Cfsl,ls2085a-dspiC* > alias: of:N*T*Cfsl,ls2085a-dspi > alias: of:N*T*Cfsl,ls2080a-dspiC* > alias: of:N*T*Cfsl,ls2080a-dspi > alias: of:N*T*Cfsl,ls1046a-dspiC* > alias: of:N*T*Cfsl,ls1046a-dspi > alias: of:N*T*Cfsl,ls1043a-dspiC* > alias: of:N*T*Cfsl,ls1043a-dspi > alias: of:N*T*Cfsl,ls1028a-dspiC* > alias: of:N*T*Cfsl,ls1028a-dspi > alias: of:N*T*Cfsl,ls1012a-dspiC* > alias: of:N*T*Cfsl,ls1012a-dspi > alias: of:N*T*Cfsl,ls1021a-v1.0-dspiC* > alias: of:N*T*Cfsl,ls1021a-v1.0-dspi > alias: of:N*T*Cfsl,vf610-dspiC* > alias: of:N*T*Cfsl,vf610-dspi > depends: > intree: Y > name: spi_fsl_dspi > vermagic: 6.18.0-rc1+ SMP preempt mod_unload modversions aarch64 Reverting does not work on all building platforms, it works on one but fails on another one. Best regards Alexander > --- > include/linux/init.h | 3 ++- > scripts/Makefile.lib | 2 +- > 2 files changed, 3 insertions(+), 2 deletions(-) >=20 > diff --git a/include/linux/init.h b/include/linux/init.h > index 17c1bc712e234..40331923b9f4a 100644 > --- a/include/linux/init.h > +++ b/include/linux/init.h > @@ -200,12 +200,13 @@ extern struct module __this_module; > =20 > /* Format: ____ */ > #define __initcall_id(fn) \ > + __PASTE(kmod_, \ > __PASTE(__KBUILD_MODNAME, \ > __PASTE(__, \ > __PASTE(__COUNTER__, \ > __PASTE(_, \ > __PASTE(__LINE__, \ > - __PASTE(_, fn)))))) > + __PASTE(_, fn))))))) > =20 > /* Format: ____ */ > #define __initcall_name(prefix, __iid, id) \ > diff --git a/scripts/Makefile.lib b/scripts/Makefile.lib > index 1d581ba5df66f..b955602661240 100644 > --- a/scripts/Makefile.lib > +++ b/scripts/Makefile.lib > @@ -20,7 +20,7 @@ name-fix-token =3D $(subst $(comma),_,$(subst -,_,$1)) > name-fix =3D $(call stringify,$(call name-fix-token,$1)) > basename_flags =3D -DKBUILD_BASENAME=3D$(call name-fix,$(basetarget)) > modname_flags =3D -DKBUILD_MODNAME=3D$(call name-fix,$(modname)) \ > - -D__KBUILD_MODNAME=3Dkmod_$(call name-fix-token,$(modname)) > + -D__KBUILD_MODNAME=3D$(call name-fix-token,$(modname)) > modfile_flags =3D -DKBUILD_MODFILE=3D$(call stringify,$(modfile)) > =20 > _c_flags =3D $(filter-out $(CFLAGS_REMOVE_$(target-stem).o), \ >=20 =2D-=20 TQ-Systems GmbH | M=FChlstra=DFe 2, Gut Delling | 82229 Seefeld, Germany Amtsgericht M=FCnchen, HRB 105018 Gesch=E4ftsf=FChrer: Detlef Schneider, R=FCdiger Stahl, Stefan Schneider http://www.tq-group.com/