Re: [PATCH v2 0/4] livepatch: Add garbage collection for shadow variables

Josh Poimboeuf
2023-01-26T18:30:12Z

On Thu, Jan 26, 2023 at 12:05:02PM -0500, Joe Lawrence wrote:
> On 1/26/23 11:35, Petr Mladek wrote:
> >
> > Josh accepted the idea in the end so we could actually push the entire
> > patchset. I am not sure if anyone else would like to review it
> > so I going to wait a bit longer.
> >
> > Resume:
> >
> > I am going to push the entire patchset the following week (Wednesday?)
> > unless anyone asks for more time or finds a problem.
> >
>
> Hi Petr,
>
> Re docs: patches (3) and (4) change the klp_shadow_* API. There should
> be updates (and possibly examples) to
> Documentation/livepatch/shadow-vars.rst.

Agreed, a documentation update is definitely needed.

Also, as I mentioned, we need to document the motivation behind the
change and the expected use cases. Either in the commit log or the
documentation, or even better, some combination. There was some very
useful background from Nicolai and some very helpful clarifications from
Petr. We should make sure all that doesn't get lost in depths of the
mailing list.

And, while I did finally accept the idea, I still need to do a more
in-depth review of the patches. Patches 1-2 look fine, but please give
me some time to properly review patches 3 & 4.

--
Josh