From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id F19ECC433F5 for ; Fri, 8 Apr 2022 14:44:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237055AbiDHOqt (ORCPT ); Fri, 8 Apr 2022 10:46:49 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44692 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237067AbiDHOqs (ORCPT ); Fri, 8 Apr 2022 10:46:48 -0400 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 272D1FC100; Fri, 8 Apr 2022 07:44:42 -0700 (PDT) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id E05B0113E; Fri, 8 Apr 2022 07:44:41 -0700 (PDT) Received: from lakrids (usa-sjc-imap-foss1.foss.arm.com [10.121.207.14]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 5C0C63F73B; Fri, 8 Apr 2022 07:44:40 -0700 (PDT) Date: Fri, 8 Apr 2022 15:44:34 +0100 From: Mark Rutland To: "Madhavan T. Venkataraman" Cc: broonie@kernel.org, jpoimboe@redhat.com, ardb@kernel.org, nobuta.keiya@fujitsu.com, sjitindarsingh@gmail.com, catalin.marinas@arm.com, will@kernel.org, jmorris@namei.org, linux-arm-kernel@lists.infradead.org, live-patching@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v13 06/11] arm64: Use stack_trace_consume_fn and rename args to unwind() Message-ID: References: <95691cae4f4504f33d0fc9075541b1e7deefe96f> <20220117145608.6781-1-madvenka@linux.microsoft.com> <20220117145608.6781-7-madvenka@linux.microsoft.com> <845e4589-97d9-5371-3a0e-f6e05919f32d@linux.microsoft.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <845e4589-97d9-5371-3a0e-f6e05919f32d@linux.microsoft.com> Precedence: bulk List-ID: X-Mailing-List: live-patching@vger.kernel.org On Mon, Mar 07, 2022 at 10:51:38AM -0600, Madhavan T. Venkataraman wrote: > Hey Mark Rutland, Mark Brown, > > Could you please review the rest of the patches in the series when you can? Sorry, I was expecting a new version with some of my comments addressed, in case that had effects on subsequent patches. > Also, many of the patches have received a Reviewed-By from you both. > So, after I send the next version out, can we upstream those ones? I would very much like to upstream the ones I have given a Reviewed-by. Given those were conditional on some adjustments (e.g. actually filling out comments), do you mind if I pick those into a series now? Then, once that's picked, you can rebase the rest atop, and we can review that. Thanks, Mark. > On 2/15/22 07:39, Mark Rutland wrote: > > On Mon, Jan 17, 2022 at 08:56:03AM -0600, madvenka@linux.microsoft.com wrote: > >> From: "Madhavan T. Venkataraman" > >> > >> Rename the arguments to unwind() for better consistency. Also, use the > >> typedef stack_trace_consume_fn for the consume_entry function as it is > >> already defined in linux/stacktrace.h. > >> > >> Signed-off-by: Madhavan T. Venkataraman > > > > How about: > > > > | arm64: align with common stracktrace naming > > | > > | For historical reasons, the naming of parameters and their types in the arm64 > > | stacktrace code differs from that used in generic code and other > > | architectures, even though the types are equivalent. > > | > > | For consistency and clarity, use the generic names. > > > > Either way: > > > > Reviewed-by: Mark Rutland > > > > Mark. > > > >> --- > >> arch/arm64/kernel/stacktrace.c | 4 ++-- > >> 1 file changed, 2 insertions(+), 2 deletions(-) > >> > >> diff --git a/arch/arm64/kernel/stacktrace.c b/arch/arm64/kernel/stacktrace.c > >> index 1b32e55735aa..f772dac78b11 100644 > >> --- a/arch/arm64/kernel/stacktrace.c > >> +++ b/arch/arm64/kernel/stacktrace.c > >> @@ -181,12 +181,12 @@ static int notrace unwind_next(struct unwind_state *state) > >> NOKPROBE_SYMBOL(unwind_next); > >> > >> static void notrace unwind(struct unwind_state *state, > >> - bool (*fn)(void *, unsigned long), void *data) > >> + stack_trace_consume_fn consume_entry, void *cookie) > >> { > >> while (1) { > >> int ret; > >> > >> - if (!fn(data, state->pc)) > >> + if (!consume_entry(cookie, state->pc)) > >> break; > >> ret = unwind_next(state); > >> if (ret < 0) > >> -- > >> 2.25.1 > >>