live-patching.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Joe Lawrence <joe.lawrence@redhat.com>
To: Song Liu <song@kernel.org>
Cc: live-patching@vger.kernel.org, jpoimboe@kernel.org,
	jikos@kernel.org, mbenes@suse.cz, pmladek@suse.com,
	kernel-team@fb.com
Subject: Re: [PATCH v2 0/2] add sysfs entry "patched" for each klp_object
Date: Tue, 2 Aug 2022 17:37:17 -0400	[thread overview]
Message-ID: <YumZDXVy+739tnps@redhat.com> (raw)
In-Reply-To: <20220802010857.3574103-1-song@kernel.org>

On Mon, Aug 01, 2022 at 06:08:55PM -0700, Song Liu wrote:
> I was debugging an issue that a livepatch appears to be attached, but
> actually not. It turns out that there is a mismatch in module name
> (abc-xyz vs. abc_xyz), klp_find_object_module failed to find the module.
> 
> Changes v1 => v2:
> 1. Add selftest. (Petr Mladek)
> 2. Update documentation. (Petr Mladek)
> 3. Use sysfs_emit. (Petr Mladek)
> 
> Song Liu (2):
>   livepatch: add sysfs entry "patched" for each klp_object
>   selftests/livepatch: add sysfs test
> 
>  .../ABI/testing/sysfs-kernel-livepatch        |  8 ++++
>  kernel/livepatch/core.c                       | 18 +++++++++
>  tools/testing/selftests/livepatch/Makefile    |  3 +-
>  .../testing/selftests/livepatch/test-sysfs.sh | 40 +++++++++++++++++++
>  4 files changed, 68 insertions(+), 1 deletion(-)
>  create mode 100644 tools/testing/selftests/livepatch/test-sysfs.sh
> 
> --
> 2.30.2
> 

For both,

Reviewed-by: Joe Lawrence <joe.lawrence@redhat.com>

--
Joe


  parent reply	other threads:[~2022-08-02 21:37 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-08-02  1:08 [PATCH v2 0/2] add sysfs entry "patched" for each klp_object Song Liu
2022-08-02  1:08 ` [PATCH v2 1/2] livepatch: " Song Liu
2022-09-02 11:49   ` Petr Mladek
2022-08-02  1:08 ` [PATCH v2 2/2] selftests/livepatch: add sysfs test Song Liu
2022-08-02 21:36   ` Joe Lawrence
2022-09-02 12:37   ` Petr Mladek
2022-09-02 15:42     ` Joe Lawrence
2022-08-02 21:37 ` Joe Lawrence [this message]
2022-08-30 19:09   ` [PATCH v2 0/2] add sysfs entry "patched" for each klp_object Song Liu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YumZDXVy+739tnps@redhat.com \
    --to=joe.lawrence@redhat.com \
    --cc=jikos@kernel.org \
    --cc=jpoimboe@kernel.org \
    --cc=kernel-team@fb.com \
    --cc=live-patching@vger.kernel.org \
    --cc=mbenes@suse.cz \
    --cc=pmladek@suse.com \
    --cc=song@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).